Robert Bohne [Fri, 13 Dec 2013 15:37:46 +0000]
Increase oracle xe user process limit from 40 (default) to 150
Peter Rabbitson [Tue, 10 Dec 2013 03:53:44 +0000]
Streamline connection codepath, fix $ENV{DBI_DSN} regression from
d87929a4
Break out _dbi_connect_info to always take into account $ENV{DBI_DSN} on
a case-by-case basis. This allows to centralize handling of "whose driver
is this anyway" and let more exotic configs still function properly. As a
side effect need to move the _dbi_connect_info() population earlier in the
connect_info() codepath
Also break out the DBI_DRIVER reader, and use it if possible in the
_describe_connection codepath
Additionaly refactor of _connect since there is no point passing the DSN when
we can grab it from $self (this also fixed ::Replicated's _connect() loop
never actually having worked)
Peter Rabbitson [Sat, 7 Dec 2013 07:39:14 +0000]
Make life bearable for windows users wrt EOL
Peter Rabbitson [Sat, 7 Dec 2013 05:53:00 +0000]
Augment
1363f0f5 for running in hell
SQLite produces extra warnings on Win32 even with an appropriate IV_SIZE
Peter Rabbitson [Wed, 4 Dec 2013 06:19:42 +0000]
Windows fork is not only slow - it plain breaks on multiple requires :(
Stop using pseudofork on the lesser platform altogether
Peter Rabbitson [Wed, 4 Dec 2013 06:19:42 +0000]
Separate DBIC::_ENV_::* setup from loading of the main DBIx::Class module
Peter Rabbitson [Wed, 4 Dec 2013 03:19:28 +0000]
Better specification of the JSON::* optdeps
Peter Rabbitson [Sat, 7 Dec 2013 07:23:37 +0000]
New Test::Kwalitee completely prevents install of Pod::POM
Just skip all tests until we get a new release
Peter Rabbitson [Thu, 28 Nov 2013 08:52:28 +0000]
Add OracleXE 10.2-based testing
Peter Rabbitson [Sat, 7 Dec 2013 07:03:12 +0000]
Memcached no longer autostarts on install on ubuntu - wtf...
Peter Rabbitson [Sat, 7 Dec 2013 06:44:39 +0000]
Latest cpanminus changed its --scandeps error output, bleh
Peter Rabbitson [Sun, 17 Nov 2013 12:31:37 +0000]
Stop correlated subqueries from affecting the aliastypes analysis
This should make mind-bending correlations like the ones frew likes to (ab)use
work even when combined with Getty-levels of prefetch extravaganza
Peter Rabbitson [Fri, 8 Nov 2013 12:01:28 +0000]
Rename imprecisely named variables in the load_namespaces codepath
Clarify some error messages while we are at it
Peter Rabbitson [Fri, 8 Nov 2013 09:12:09 +0000]
Fix nonsensical result class names introduced by a test in
45f8858e6
Peter Rabbitson [Tue, 5 Nov 2013 08:26:23 +0000]
This is an expensive author-only test, move to xt/
Also get xt tests first in line (won't matter much with -s)
Peter Rabbitson [Tue, 5 Nov 2013 08:17:52 +0000]
Make sure DBICTest is always loaded first (purely bookkeep)
Peter Rabbitson [Tue, 5 Nov 2013 00:44:23 +0000]
Work around TB1.5 hanging with 5.19 - use unreleased github patch
Peter Rabbitson [Tue, 5 Nov 2013 00:29:05 +0000]
Revert
2c300e45 - new backwards compatible SQLT got released
Work is being done to reintroduce the feature with a softer push:
https://github.com/dbsrgits/sql-translator/pull/26#issuecomment-
27644756
Peter Rabbitson [Mon, 15 Feb 2010 18:45:05 +0000]
Clarify what happens on distinct + get_column($aggregate_alias)
Peter Rabbitson [Thu, 29 Aug 2013 06:14:05 +0000]
Centralize and sanify generation of synthetic group_by criteria
This should solve multiple deficiencies when a limited prefetch is ordered
by non-local columns (especially pre-multiplied ones). Also intelligently
solves many problems combining distinct with various non-selecting external
order criteria.
Most current behaviors should remain unaffected except for cases of
blatantly incorrect query generation (fingercross)
Matt Phillips [Mon, 4 Nov 2013 21:53:47 +0000]
fix typo in FATAL ERROR message.
Peter Rabbitson [Wed, 30 Oct 2013 15:33:48 +0000]
Simplify DBIHacks signatures
The cross-polination of $attrs and various subparts is becoming a nightmare
to maintain. Straighten up most ::DBIHacks to pass stuff around as a single
$attrs bag (no functional changes, this is a temp-stage cleanup)
The idea is to prepare for an rsattrs object (later on all we will need to
do is replace the hash-grabs with methods, but this requires much more
thought and design, small steps)
Affected signatures in :DBIHacks:
_prune_unused_joins()
_resolve_aliastypes_from_select_args()
_adjust_select_args_for_complex_prefetch()
_extract_fixed_condition_columns()
Not touching to facilitate easier DQ merge (TODO in a sense):
_order_by_is_stable()
_main_source_order_by_portion_is_stable()
Peter Rabbitson [Thu, 31 Oct 2013 09:55:01 +0000]
Temporarily freeze travis SQLT on 0.11016, until the SQLT debacle is resolved
https://github.com/dbsrgits/sql-translator/pull/26#issuecomment-
27472588
Peter Rabbitson [Thu, 31 Oct 2013 10:28:49 +0000]
Test more JSON::Any backends, and reorder the selection in terms of desirability
DWIW is the most lax JSON parser and thus is always preferred for CLI work
Peter Rabbitson [Wed, 30 Oct 2013 08:16:39 +0000]
Work around JSON::Any not being future-proof
https://rt.cpan.org/Ticket/Display.html?id=89853
https://github.com/perigrin/json-any/pull/2
Dagfinn Ilmari Mannsåker [Tue, 29 Oct 2013 17:24:34 +0000]
Consistently use "eq ''" when checking for exception refness
Dagfinn Ilmari Mannsåker [Tue, 29 Oct 2013 17:00:53 +0000]
Explicitly stringify when checking for existing exception
This fixes errors with exception objects with incomplete
overloading (like Log::Report::Dispatcher::Try).
Peter Rabbitson [Fri, 25 Oct 2013 05:10:47 +0000]
Fix
a47f273b change to be in line with the Row->Result rename of fb13a49f
Karen Etheridge [Thu, 24 Oct 2013 21:11:12 +0000]
fix some pod links
Peter Rabbitson [Fri, 18 Oct 2013 16:00:31 +0000]
Better render of $POSTMORTEM
Peter Rabbitson [Fri, 18 Oct 2013 14:47:29 +0000]
Add a MAKEFLAGS parallel execution config on travis
Peter Rabbitson [Fri, 18 Oct 2013 13:15:06 +0000]
Get TAP::Harness to time tests travis-wide
Peter Rabbitson [Mon, 14 Oct 2013 12:12:06 +0000]
Remove anything preinstalled on the travis perls when CLEANTEST is true
This will give us yet another test point
Peter Rabbitson [Wed, 16 Oct 2013 03:56:39 +0000]
Smoother concurrent test-flow
The noop trick initializes the STDOUT, so that the TAP::Harness
issued IO::Select->can_read calls (which are blocking wtf wtf wtf)
keep spinning and scheduling jobs
This results in an overall much smoother job-queue drainage, since
the Harness blocks less
(ideally this needs to be addressed in T::H, but a quick patchjob
broke everything so tabling it for now)
Peter Rabbitson [Wed, 16 Oct 2013 04:08:09 +0000]
Build more recent perls concurrently
Peter Rabbitson [Mon, 14 Oct 2013 07:46:37 +0000]
Check that 64 bit in-SQLite math works regardless of ivsize
Expand on top of
04ab4eb1 and 579d1966, work inspired by charsbar's
https://github.com/charsbar/dbd-sqlite-authortests
Tested by passing the following on an old and recent DBI and a mix of ivsizes
for p in 5.8.1 5.8.2 5.8.3 5.8.5 5.18.0 5.18.1; do
perlbrew switch $p
for v in 1.29 1.31 1.33 1.35 1.37 1.39 1.40 ; do
PERL_CPANM_OPT= cpanm -qn DBD::SQLite@$v && echo -n "$p " && perl -V:ivsize && prove -l t/752sqlite.t || break
done
done
@mattp- now *that's* attention to detail :)
Peter Rabbitson [Sat, 12 Oct 2013 12:40:30 +0000]
Fix exceedingly sloppy SQLite warning workaround from
04ab4eb1
The previous version managed not only to *not* silence any warning but also
break the test checking for lack of said warnings. In addition the silencing
regex was unacceptably broad, possibly missing some important misbinds.
riba pull your shit together man
a.k.a. this is what happens when there are no code reviewers :(((
Peter Rabbitson [Mon, 14 Oct 2013 06:47:17 +0000]
Forgotten remnant of
655d80dd (void by f207111d)
Peter Rabbitson [Mon, 14 Oct 2013 08:07:28 +0000]
Really work around https://github.com/travis-ci/travis-ci/issues/1477
Just upgrade cpanm by hand with --dev
Peter Rabbitson [Mon, 14 Oct 2013 09:13:04 +0000]
Add more autogenerated test exceptions, in fact do a carpetbomb
This is necessary at least for a while until the war on the user passes
Peter Rabbitson [Mon, 14 Oct 2013 12:09:45 +0000]
Streamline postmortem analysis, and fix non-essential-test report being lost
It got eaten by lack of STDERR output after fixage from
a4c52abc, GAH!
Peter Rabbitson [Fri, 11 Oct 2013 10:12:53 +0000]
Add a 9m soft / 9.5m hard timeout option to bin/cpan runs
This makes sure we do not abort a travis run without meaningful output
Peter Rabbitson [Fri, 11 Oct 2013 06:52:25 +0000]
Reenable 5.10 travis smokes
https://rt.cpan.org/Ticket/Display.html?id=88903 got solved \o/
Peter Rabbitson [Thu, 10 Oct 2013 10:10:27 +0000]
Correct attribution of nonessential skipped tests origin
Peter Rabbitson [Fri, 11 Oct 2013 07:44:50 +0000]
MULTICREATE_DEBUG + TRACE_PROFILE=console_monochrome results in >4MB log
Karen Etheridge [Thu, 10 Oct 2013 19:23:29 +0000]
Pod/comment fixes
Peter Rabbitson [Mon, 29 Jul 2013 01:47:13 +0000]
Make the dbh error handler installer `Perl -d` friendly
GC in perl is a mess sometimes - a literal sub { ... } within a try { ... } goes
wonky, but the equivalent coderef stored in a scalar is fine >.<
Peter Rabbitson [Mon, 29 Jul 2013 04:45:50 +0000]
Move classdata handling to DBICTest::Util::LeakTracer
Peter Rabbitson [Fri, 11 Oct 2013 11:03:05 +0000]
Silence nonessential test warning (last outstanding \o/)
Peter Rabbitson [Tue, 8 Oct 2013 22:51:25 +0000]
Many improvements of bigint handling across various DBD::SQLite versions
This started as a patch by ilmari to bind all integers as SQL_BIGINT
as opposed to SQL_INTEGER. While this change itself worked fine, further
testing revealed we never actually bound 'bigint' column types in the
first place. When this was rectified all hell broke loose.
The current situation per DBD::SQLite version
1.29 ~ 1.33: everything works fine, for large values DBD::SQLite loses
precision on perl binaries with ivsize == 4 (just like integer
math within perl itself)
1.35: Nothing works *regardless* of ivsize. Binding a >32 bit value
as either SQL_INTEGER or as SQL_BIGINT is impossible (an
exception is thrown from within DBD::SQLite). DBIC simply strips
the bindtype altogether and issues an "UPGRADE!" warning.
1.37 ~ 1.40: Everything works, except for the annoying fact that DBD::SQLite
issues a spurious 'datatype mismatch' warning when one tries
to bind a >32 bit value with ivsize == 4. RT#76395
Warning is silenced for the time being within the guts of DBIC.
On the SQL_INTEGER => SQL_BIGINT change: according to
http://www.sqlite.org/datatype3.html#storageclasses all numeric types are
dynamically allocated up to 8 bytes per individual value. Thus it should be
safe and non-wasteful to bind everything as SQL_BIGINT and have SQLite deal
with storage/comparisons however it deems correct.
Peter Rabbitson [Tue, 8 Oct 2013 22:47:15 +0000]
Add explicit notes wrt DBI/DBD::SQLite dep versions
Peter Rabbitson [Tue, 8 Oct 2013 22:28:46 +0000]
Make $SIG{__WARN__} overrides more Carp::Always friendly
Dagfinn Ilmari Mannsåker [Tue, 8 Oct 2013 12:02:23 +0000]
Warn about non-integer values for all integer bind types, not just SQL_INTEGER
Dagfinn Ilmari Mannsåker [Tue, 8 Oct 2013 12:02:23 +0000]
Use explicit variable on loop
Peter Rabbitson [Sat, 5 Oct 2013 08:14:38 +0000]
Fix and guard against erroneous use of list context in internal DBIC code
This situation is dangerous in case the end-user employs something like
DBIx::Class::Helper::ResultSet::IgnoreWantarray
Besides the trivial fix in ::Row::copy, this commit introduces the
DBIC_ASSERT_NO_INTERNAL_WANTARRAY=1 mechanism (which will be
automatically picked up and engaged by our CI due to
eed5492f). As a
bonus the check is usable on DBIC dependencies as well.
Peter Rabbitson [Wed, 2 Oct 2013 23:15:30 +0000]
Fail early properly even in the presence of -jN
Without the reordering of prints and without the mysterious sleep() call it
seems that prove just loses the STDERR text entirely
Karen Etheridge [Wed, 2 Oct 2013 21:38:49 +0000]
fix pod formatting of this code snippet
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:41:55 +0000]
Stop using the deprecated Class::MOP::load_class()
Use MooseX::Types::LoadableClass instead, requiring the version that
fixes the constraints to not throw an exception on syntactically
invalid names, so that we can coerce a prefix onto ::Foo.
Arthur Axel 'fREW' Schmidt [Thu, 25 Jul 2013 15:03:58 +0000]
Further tradeoffs on relationship sanity checking (augments
9e7525a2)
It turns out what we did earlier is not enough - what is truly needed is
shutting off *all* checks on non-belongs_to rels. Otherwise industrious devs
will inevitable tie themselves into a circual loading order knot.
The problem (as in
9e7525a2) is not so much that we need to bend over
backwards to support circular loads, but that these problems could very
well be masked by stable hash ordering of perl < 5.18. In other words this
commit serves to prevent perfectly working code from suffering intermittent
and hard-to-debug issues when someone upgrades their perl in 2018.
Peter Rabbitson [Tue, 1 Oct 2013 06:03:05 +0000]
Fail early if full test is run in a stale checkout
Peter Rabbitson [Wed, 2 Oct 2013 06:42:48 +0000]
Proper fix for t/storage/replicated.t (augments
617474ab7e)
Instead of blindly changing the use_ok to use figured out and moved together
the pieces responsible for the dance in the 1st place
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:12:14 +0000]
Fix t/storage/replicated.t class loading problem
Do all the skip_all in BEGIN {}, and just 'use' the modules instead of
use_ok().
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:04:22 +0000]
Throw clearer exception on ->new_related() with a non-existent relationship
Peter Rabbitson [Tue, 24 Sep 2013 13:59:48 +0000]
Smoker-wide parallel testing of installed deps
Peter Rabbitson [Mon, 23 Sep 2013 19:36:03 +0000]
Better diagnostics of skipped non-essential tests
Peter Rabbitson [Mon, 23 Sep 2013 11:16:39 +0000]
Engage nuclear option of travis testing
For the record - I am not happy about having to make this commit. However the
reality is that for every basic toolchain module I fix, another two are broken
by dzil-addicted (though well meaning) folks. Since this essentially paralyzes
any useful work, resort to simply ignoring some of the meaningless tests that
are autopopulated by ill-designed dzil author bundles.
This allows to revert
655d80dd, 72cd4007, and generally streamline the set of
workarounds
A preemptive note for anyone who is concerned that I am wasting precious tuits
on a dubious goal. Please realize that one of the corner stones of my personal
desire to participate in OSS comes from disdain of forced obsolescence (i.e.
one shall upgrade each and every year because the author feels like it). If I
can not guarantee my software performs correctly on old but usable versions of
our beloved VM - a massive portion of the very reason I "keep playing" goes
away entirely. With that gone the world beyond OSS suddenly becomes
exceedingly more appealing, at least much more appealing as opposed to pushing
features into a library unusable by most real-world production environments.
Additionally whether I or anyone else has encountered users benefitting from
my efforts is not relevant - the DarkPan universe is vast.
In other words instead of seeing these activities as a mindless fetish, see
them for what they are: one of the main reasons I am a CPAN contributor to
begin with.
--ribasushi
Peter Rabbitson [Tue, 17 Sep 2013 08:42:58 +0000]
Delist Example and add QuickStart to the DocMap
Pending my review of PR#35
Scott R. Godin [Thu, 4 Apr 2013 19:41:17 +0000]
Update DocMap - include missing local Manual pages (PR#22)
some of the local Manual pages are not mentioned in the DocMap which should be,
as people will use the DocMap as a stepping point, and may thus overlook them
Peter Rabbitson [Tue, 17 Sep 2013 07:57:51 +0000]
A fixed DBD::Firebird went to CPAN as well
Peter Rabbitson [Tue, 17 Sep 2013 07:52:02 +0000]
These workarounds are thankfully no longer needed
Loading strictures will only complain about missing optdeps if used
within a t/, and dbic is (and will remain, sorry Matt) structures-free
deliberately, so there you have it
Peter Rabbitson [Tue, 17 Sep 2013 06:16:05 +0000]
This was fixed in March 2013
Karen Etheridge [Sun, 15 Sep 2013 21:12:15 +0000]
switch from Class::MOP::class_of to Moose::Util::find_meta
Peter Rabbitson [Sat, 7 Sep 2013 16:05:38 +0000]
Augment test suite with oddball relationship declarations
Among other things this tests for the issue described/solved in
9e7525a2
Peter Rabbitson [Mon, 16 Sep 2013 17:16:48 +0000]
Reorder relationship sanity checks, run them only on known loaded classes
This avoids load-order issues in contrived situations where column definitions are
split across class inheritance (which gets rather fun doe to the prorotypical
inheritance of resultsource instances themselves)
While not an immediate problem in code in the wild, the hash randomization in 5.18
now leads to random load order, and as a result more load-order combinations are
tried and can eventually fail. This should reduce these situations to a minimum,
and
79061be1 should keep us appraised of any problems while DBICT:Schema evolves
Ideally the checks will be lifted up to schema-composition time, but we are not
there yet, one yak at a time.
Peter Rabbitson [Fri, 13 Sep 2013 12:52:41 +0000]
Consolidate single-pk checks from relationship inferrence codepaths
Peter Rabbitson [Wed, 11 Sep 2013 09:31:30 +0000]
More unreachable code - we've already thrown on !defined $pri
David Steinbrunner [Fri, 13 Sep 2013 11:33:07 +0000]
typo fix
Peter Rabbitson [Fri, 13 Sep 2013 03:39:15 +0000]
MOAR workarounds - freeze CMM at a usable version
The dzil conversion introduced dependency on MBT which is extremely
hard to get going on older perls, left alone all dists made with it
Hopefully it will get fixed:
https://rt.cpan.org/Ticket/Display.html?id=88641
Peter Rabbitson [Wed, 11 Sep 2013 00:30:32 +0000]
Disable perl introduced in
ced296a8 until fixed Carp.pm is shipped
https://rt.cpan.org/Public/Bug/Display.html?id=88531
Peter Rabbitson [Sat, 7 Sep 2013 16:13:52 +0000]
Run travis-prove under taint mode
Peter Rabbitson [Sat, 7 Sep 2013 16:05:38 +0000]
Fix
79061be1 not working under -T
Peter Rabbitson [Thu, 8 Aug 2013 10:38:32 +0000]
Excise unreachable code
Peter Rabbitson [Thu, 8 Aug 2013 06:58:58 +0000]
Rename internal rsrc method to be more descriptive, stop proxying it
Peter Rabbitson [Wed, 7 Aug 2013 07:09:19 +0000]
Make sure we can load each DBICTest::Schema result individually
This will ensure tests always fail if some sort of circular load order
issue is encountered, and we won't have to wait for a particular random
loading sequence to blow up the tests
Peter Rabbitson [Mon, 9 Sep 2013 06:49:21 +0000]
Reorder travis tests by length, add 5.12.4
Peter Rabbitson [Sun, 8 Sep 2013 16:04:17 +0000]
Only run our own tests concurrently, not stuff in after_success
Peter Rabbitson [Sun, 8 Sep 2013 15:23:14 +0000]
Check that each preinstall on an old CPAN.pm completes
Peter Rabbitson [Sun, 8 Sep 2013 10:40:05 +0000]
EU::MM on < 5.8.9 got fixed
Peter Rabbitson [Sun, 8 Sep 2013 12:10:03 +0000]
Change CPAN mirror again - metacpan is a complete backpan-backed mirror
This way the deletion of the usable version of Tree::DAG_Node won't
affect testing
Peter Rabbitson [Fri, 6 Sep 2013 09:04:49 +0000]
Lock down Tree::DAG_Node version until new Test::Warn appears
This will make travis green again
https://github.com/chorny/test-warn/pull/4
(also https://rt.cpan.org/Public/Bug/Display.html?id=88435)
Peter Rabbitson [Mon, 2 Sep 2013 05:36:30 +0000]
Fix typoed variable (just remote the shorthand entirely) ^Simon^++
Olly Betts [Thu, 16 May 2013 22:00:00 +0000]
More typo fixes
Peter Rabbitson [Thu, 29 Aug 2013 01:57:12 +0000]
Changes for
113e8d16 and 64c50e81
Peter Rabbitson [Thu, 29 Aug 2013 01:40:52 +0000]
Prevent DBD::Firebird and DBD::InterBase from colliding on same DSN
Peter Rabbitson [Thu, 29 Aug 2013 02:41:00 +0000]
Manpages are of no use on travis
Peter Rabbitson [Thu, 29 Aug 2013 01:00:39 +0000]
Do one poisoned env testrun with a threaded perl
Peter Rabbitson [Thu, 29 Aug 2013 00:50:25 +0000]
Only smoke blead-pan on allowed-to-fail runs
Peter Rabbitson [Wed, 28 Aug 2013 12:01:00 +0000]
Move bleadperl to 'fail ok' submatrix - too much churn
Peter Rabbitson [Thu, 29 Aug 2013 00:09:01 +0000]
Work around https://rt.cpan.org/Ticket/Display.html?id=88222
Peter Rabbitson [Mon, 26 Aug 2013 07:53:21 +0000]
Temporary work around yet another cpanm issue