Centralize and sanify generation of synthetic group_by criteria
authorPeter Rabbitson <ribasushi@cpan.org>
Thu, 29 Aug 2013 06:14:05 +0000 (08:14 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Tue, 5 Nov 2013 00:21:54 +0000 (01:21 +0100)
commiteb58c082cf9c35760d8fc199483d38c1d926b2e4
tree39c13d9e59a738e553dd316a5b6fb57db016fad0
parent23b2c49b17262ecf84307c9ffba88ed38ecc90cb
Centralize and sanify generation of synthetic group_by criteria

This should solve multiple deficiencies when a limited prefetch is ordered
by non-local columns (especially pre-multiplied ones). Also intelligently
solves many problems combining distinct with various non-selecting external
order criteria.

Most current behaviors should remain unaffected except for cases of
blatantly incorrect query generation (fingercross)
Changes
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/Storage/DBI.pm
lib/DBIx/Class/Storage/DBIHacks.pm
t/88result_set_column.t
t/prefetch/grouped.t
t/prefetch/o2m_o2m_order_by_with_limit.t
t/prefetch/with_limit.t
t/resultset/update_delete.t
t/search/distinct.t