Simplify DBIHacks signatures
authorPeter Rabbitson <ribasushi@cpan.org>
Wed, 30 Oct 2013 15:33:48 +0000 (16:33 +0100)
committerPeter Rabbitson <ribasushi@cpan.org>
Thu, 31 Oct 2013 10:59:59 +0000 (11:59 +0100)
commite1861c2c86f301613be9aa74eb9989a5c9188310
treee7dcbe9ecfd27994a08ad688a6c3dba091cdf72f
parent2c300e45a01274614341255389e4787bd3a13ee8
Simplify DBIHacks signatures

The cross-polination of $attrs and various subparts is becoming a nightmare
to maintain. Straighten up most ::DBIHacks to pass stuff around as a single
$attrs bag (no functional changes, this is a temp-stage cleanup)

The idea is to prepare for an rsattrs object (later on all we will need to
do is replace the hash-grabs with methods, but this requires much more
thought and design, small steps)

Affected signatures in :DBIHacks:
_prune_unused_joins()
_resolve_aliastypes_from_select_args()
_adjust_select_args_for_complex_prefetch()
_extract_fixed_condition_columns()

Not touching to facilitate easier DQ merge (TODO in a sense):
_order_by_is_stable()
_main_source_order_by_portion_is_stable()
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/Storage/DBI.pm
lib/DBIx/Class/Storage/DBIHacks.pm