projects / dbsrgits/DBIx-Class.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7150ea4)
Fix another ::FilterColumn bug sigh...
authorPeter Rabbitson <ribasushi@cpan.org>
Sat, 2 Apr 2016 15:41:52 +0000 (17:41 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Fri, 17 Jun 2016 13:41:14 +0000 (15:41 +0200)
commit5da5cf269102bf6e74b53644ebc21a599f7f407d
treeadd4aa819b76479ef78ce2983cd58ba7d9e8735btree | snapshot
parent7150ea46e61ba90c9e8f5ef0f551bd552a1ae42fcommit | diff
Fix another ::FilterColumn bug sigh...

( cherry-pick of b482a0958 )

This one is technically a regression introduced by dc6dadae, which aimed to
solve multiple runs on already-dirty columns. Unfortunately this very same
change broke update(). Overload get_dirty_columns to fix that, and add a
bunch of tests validating nothing crazy is going on.

I should have seen all of these problems when FC was initially considered,
but alas I was too damn inexperienced :/
Changes diff | blob | blame | history
lib/DBIx/Class/FilterColumn.pm diff | blob | blame | history
t/row/filter_column.t diff | blob | blame | history
xt/podcoverage.t diff | blob | blame | history
The Perl ORM (dbsrgits@git.shadowcat.co.uk:DBIx-Class.git)