Refactor ::DBIHacks::_extract_fixed_condition_columns (sequel to 8d005ad9)
authorPeter Rabbitson <ribasushi@cpan.org>
Sat, 12 Jul 2014 10:32:20 +0000 (12:32 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Sat, 12 Jul 2014 18:58:34 +0000 (20:58 +0200)
commit8e40a627f9c94df8ae46c1c1abc6f7abdb3fdfdf
treebd23a3f713d7ec9d65d91916a8a63fa92ef3a52b
parentfacd0e8e687648e52f29df73d62d9c993b9b19d1
Refactor ::DBIHacks::_extract_fixed_condition_columns (sequel to 8d005ad9)

Instead of just returning an array of column names, switch to a hashref that
can double as an inferred-value bag. As a bonus deduplicates and folds-in
another codepath from ::ResultSet::_merge_with_rscond

In the process fixup _collapse_cond to be even more robust in some arrayref
corner-cases. Now it is guaranteed to return a hashref at all times
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/ResultSource.pm
lib/DBIx/Class/Storage/DBIHacks.pm
t/sqlmaker/dbihacks_internals.t