10 years agoCorrect comments about overload methods vs. ->can()
Dagfinn Ilmari Mannsåker [Fri, 18 Jul 2014 09:08:01 +0000]
Correct comments about overload methods vs. ->can()

10 years agoAha - this is why I didn't use ->can originally
Peter Rabbitson [Thu, 17 Jul 2014 17:05:49 +0000]
Aha - this is why I didn't use ->can originally

Punt for the time being, will investigate why later. The error looks like:

rabbit@Ahasver:~/devel/dbic$ git rev-parse HEAD
32497625ce5699576c8a63edd16401d4f741c282

rabbit@Ahasver:~/devel/dbic$ PERL5LIB=/home/rabbit/devel/sqla/lib prove -lT t/100populate.t
t/100populate.t .. 1/? Stub found while resolving method "???" overloading """" in package "Path::Class::File" at /home/rabbit/devel/sqla/lib/SQL/Abstract.pm line 118, <> line 1.
t/100populate.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
All 43 subtests passed

Test Summary Report
-------------------
t/100populate.t (Wstat: 65280 Tests: 43 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=1, Tests=43,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.90 cusr  0.03 csys =  0.97 CPU)
Result: FAIL

10 years agoNew exportable functions: is_literal_value($) and is_plain_value($)
Peter Rabbitson [Thu, 17 Jul 2014 09:23:53 +0000]
New exportable functions: is_literal_value($) and is_plain_value($)

Ported from DBIC with some corner case fixes added.

10 years agoFix -values not being handled properly with NULLs
Peter Rabbitson [Wed, 16 Jul 2014 11:50:55 +0000]
Fix -values not being handled properly with NULLs

10 years agoEscape closing quote character in table and column names
Dagfinn Ilmari Mannsåker [Thu, 29 May 2014 09:12:08 +0000]
Escape closing quote character in table and column names

10 years agoAfter 5f3fa0ac script/ is no more
Peter Rabbitson [Wed, 16 Jul 2014 11:47:43 +0000]
After 5f3fa0ac script/ is no more

10 years agoFixup descriptions a bit
Peter Rabbitson [Wed, 16 Jul 2014 10:00:47 +0000]
Fixup descriptions a bit

10 years agoAdd basic .dir-locals.el
Dagfinn Ilmari Mannsåker [Wed, 25 Jun 2014 17:07:37 +0000]
Add basic .dir-locals.el

10 years agorelease 1.78
Peter Rabbitson [Wed, 28 May 2014 10:13:30 +0000]
release 1.78

10 years agoDrop reqs - works on 5.6.1 just fine
Peter Rabbitson [Wed, 28 May 2014 10:07:54 +0000]
Drop reqs - works on 5.6.1 just fine

10 years agoRewrite sql formatter script and shove it into examples until more tested
Peter Rabbitson [Wed, 28 May 2014 10:06:10 +0000]
Rewrite sql formatter script and shove it into examples until more tested

Combined with the opportunistic parser this little tool has the promise of
actually being useful outside of the echo chamber. Someone with good UX
skillz ought to take this to the next level... or something ;)

10 years agoSwap CAG with Moo, lazify a lot of the profile selection
Peter Rabbitson [Wed, 21 May 2014 13:15:04 +0000]
Swap CAG with Moo, lazify a lot of the profile selection

There should be zero functional changes

10 years agoPort the \[] *_sql_bind unpacker from DBIC
Peter Rabbitson [Tue, 27 May 2014 18:06:03 +0000]
Port the \[] *_sql_bind unpacker from DBIC

10 years agoUse variables to simplify grocking the parenthesis unroller rules
Peter Rabbitson [Wed, 21 May 2014 10:08:26 +0000]
Use variables to simplify grocking the parenthesis unroller rules

Zero (hopefully) functional changes

10 years agoFix the reassembler to treat RNO as the precious special snowflake it is
Arthur Axel 'fREW' Schmidt [Fri, 14 Mar 2014 16:12:05 +0000]
Fix the reassembler to treat RNO as the precious special snowflake it is

Yes, the parser is accumulating a lot of cruft this way with special casing
and whatnot, and yes it is necessary for the future when we write a real
parser which will *HAVE* to deal with the corner cases. The accumulated set
of tests is the goal here (with the side effect of better UX) -- ribasushi

10 years agoTreat RNO as a unary op, and properly normalize it
Peter Rabbitson [Wed, 21 May 2014 09:22:24 +0000]
Treat RNO as a unary op, and properly normalize it

10 years agoOriginal (now passing) test for 08e163601
Arthur Axel 'fREW' Schmidt [Wed, 26 Feb 2014 17:56:12 +0000]
Original (now passing) test for 08e163601

10 years agoFix the binop leg of the parser to correctly consider only a single LHS node
Peter Rabbitson [Wed, 21 May 2014 08:46:16 +0000]
Fix the binop leg of the parser to correctly consider only a single LHS node

Work gracefully around malformed "no lhs" cases as well

10 years agorelease 1.77
Peter Rabbitson [Fri, 17 Jan 2014 01:03:15 +0000]
release 1.77

10 years agoPort scalarref in array of sources test from dq (7732c37a)
Peter Rabbitson [Thu, 16 Jan 2014 23:39:31 +0000]
Port scalarref in array of sources test from dq (7732c37a)

10 years agoFix regression in column level { not => undef } op
Peter Rabbitson [Thu, 16 Jan 2014 23:14:23 +0000]
Fix regression in column level { not => undef } op

In 3cdadcbe we stopped considering a bare 'not' being an inequality op.
However there is code in the wild relying on this, so add an extra
compat shim (cheap)

10 years agoCheck for extra warnings, and diag input and output
Dagfinn Ilmari Mannsåker [Fri, 3 Jan 2014 18:26:01 +0000]
Check for extra warnings, and diag input and output

We want to test the _lack_ of warnings as well, and having the input and
output is handy for figuring out what's wrong.

10 years agoDiag input and output for unexpected success
Dagfinn Ilmari Mannsåker [Fri, 3 Jan 2014 15:03:46 +0000]
Diag input and output for unexpected success

10 years agoEnsure that multi-nested parenthesis are never unrolled after IN
Peter Rabbitson [Fri, 3 Jan 2014 16:57:16 +0000]
Ensure that multi-nested parenthesis are never unrolled after IN

This lets us remove parenthesis_significant from many tests that do
not need it, including reversal of 1ba9d0f03

10 years agoParentheses are significant in IN tests
Dagfinn Ilmari Mannsåker [Fri, 27 Dec 2013 14:52:12 +0000]
Parentheses are significant in IN tests

10 years agorelease 1.75
Peter Rabbitson [Fri, 27 Dec 2013 04:49:24 +0000]
release 1.75

10 years agoMove simple IN/BETWEEN tests to t/05in_between.t
Dagfinn Ilmari Mannsåker [Thu, 26 Dec 2013 21:27:11 +0000]
Move simple IN/BETWEEN tests to t/05in_between.t

No changes in the actual tests except splitting the empty array and
scalar tests for IN into separate cases.

10 years agoActually use the descriptions in the test cases
Dagfinn Ilmari Mannsåker [Thu, 26 Dec 2013 21:28:27 +0000]
Actually use the descriptions in the test cases

10 years agoAn old (now passing) test for regression introduced in 6f2a5b6
Arthur Axel 'fREW' Schmidt [Fri, 20 Apr 2012 18:46:28 +0000]
An old (now passing) test for regression introduced in 6f2a5b6

10 years agoPort fce4b7a9 from the DQ branch (with warning expectation ammendments)
Dagfinn Ilmari Mannsåker [Fri, 6 Dec 2013 17:24:22 +0000]
Port fce4b7a9 from the DQ branch (with warning expectation ammendments)

10 years agoReintroduce handling of IS( NOT) ops
Peter Rabbitson [Thu, 26 Dec 2013 08:23:06 +0000]
Reintroduce handling of IS( NOT) ops

This is undocumented syntax, but it is very likely someone is using it in
the wild, and the previous inequality op handler rewrite broke this

10 years agoExtensive tests and deprecations of multivalue/no value inequality op calls
Peter Rabbitson [Thu, 26 Dec 2013 05:47:18 +0000]
Extensive tests and deprecations of multivalue/no value inequality op calls

All sql-generation tests match pre <= 1.74 behavior (except for the newly
added rlike operator, which now warns while it simply did not work with
undefs before)

10 years agoMove test to a better location (no changes)
Peter Rabbitson [Thu, 26 Dec 2013 05:28:02 +0000]
Move test to a better location (no changes)

10 years agoNormalize handling of expected warnings/exceptions in tests
Peter Rabbitson [Thu, 26 Dec 2013 05:26:51 +0000]
Normalize handling of expected warnings/exceptions in tests

10 years agoRemove many of the settled-by-time comments, modernize a bit
Peter Rabbitson [Thu, 26 Dec 2013 05:07:25 +0000]
Remove many of the settled-by-time comments, modernize a bit

10 years agoCentralize handling of in-test dumpering
Peter Rabbitson [Thu, 26 Dec 2013 04:29:17 +0000]
Centralize handling of in-test dumpering

10 years agoExtra stopword (we need to find a way to introduce dialects...)
Peter Rabbitson [Sun, 22 Dec 2013 11:36:59 +0000]
Extra stopword (we need to find a way to introduce dialects...)

10 years agoNo tabs, no trailers
Peter Rabbitson [Wed, 18 Dec 2013 13:50:36 +0000]
No tabs, no trailers

10 years agoMake it clearer in examples that bool takes expressions
Peter Rabbitson [Wed, 18 Dec 2013 13:25:05 +0000]
Make it clearer in examples that bool takes expressions

timbunce++

10 years agoTest BETWEEN after the IN debacle (luckily it throws in all expected cases)
Peter Rabbitson [Wed, 18 Dec 2013 10:15:20 +0000]
Test BETWEEN after the IN debacle (luckily it throws in all expected cases)

Generalize the emitted exception text

10 years agoWe already have Storable as a dep, this is pointless
Peter Rabbitson [Wed, 18 Dec 2013 10:20:23 +0000]
We already have Storable as a dep, this is pointless

10 years agoAnd yet more improvements in the parsing engine
Peter Rabbitson [Tue, 17 Dec 2013 23:33:31 +0000]
And yet more improvements in the parsing engine

Streamline the construction of -MISC (gah I hate that name) nodes, and make
sure we do not treat placeholders as list element node terminator

10 years agoDo not yell loudly on TODOified is_same_* tests
Peter Rabbitson [Wed, 18 Dec 2013 08:15:50 +0000]
Do not yell loudly on TODOified is_same_* tests

10 years agoClarify in => undef exception (based on 90c87778)
Dagfinn Ilmari Mannsåker [Sun, 8 Dec 2013 17:01:03 +0000]
Clarify in => undef exception (based on 90c87778)

10 years agoBackport undef-with-in tests from DQ, add "roadwork ahead" exceptions
Peter Rabbitson [Wed, 18 Dec 2013 08:48:36 +0000]
Backport undef-with-in tests from DQ, add "roadwork ahead" exceptions

This is an amalgamation of test changes from 5b67050, 39221d2 and 038b0a7
ilmari++

10 years agoExtra test from the DQ branch (passes in 1.5)
Dagfinn Ilmari Mannsåker [Tue, 3 Dec 2013 17:17:29 +0000]
Extra test from the DQ branch (passes in 1.5)

10 years agoDocument and test non-reference { -in => ... }
Dagfinn Ilmari Mannsåker [Wed, 4 Dec 2013 15:16:13 +0000]
Document and test non-reference { -in => ... }

Also test the documented but untested { -in => [] } optimisation.

11 years agoFix typos in POD and comments (RT#87776)
Dagfinn Ilmari Mannsåker [Mon, 12 Aug 2013 20:03:16 +0000]
Fix typos in POD and comments (RT#87776)

11 years agoKill the plan
Peter Rabbitson [Sun, 9 Jun 2013 11:36:46 +0000]
Kill the plan

11 years agoFinish a RHS branch before applying ASC/DESC mods
Peter Rabbitson [Sun, 9 Jun 2013 11:28:35 +0000]
Finish a RHS branch before applying ASC/DESC mods

11 years agorelease 1.74
Peter Rabbitson [Tue, 4 Jun 2013 21:06:24 +0000]
release 1.74

11 years agoNo dynamic deps
Peter Rabbitson [Tue, 4 Jun 2013 21:05:40 +0000]
No dynamic deps

11 years agoMake tests pass without Storable
Peter Rabbitson [Tue, 4 Jun 2013 21:02:23 +0000]
Make tests pass without Storable

11 years agoAdded (now passing) test for @@ full text search
Mark A. Stratman [Mon, 3 Dec 2012 18:46:13 +0000]
Added (now passing) test for @@ full text search

11 years agoStop unknown token processing early in case a potential unknown function lies ahead
Peter Rabbitson [Tue, 4 Jun 2013 17:11:20 +0000]
Stop unknown token processing early in case a potential unknown function lies ahead

11 years agoAdd (now passing) reassembly test
Arthur Axel 'fREW' Schmidt [Wed, 17 Oct 2012 14:01:23 +0000]
Add (now passing) reassembly test

11 years agoChange parser to not eagerly slurp RHS expressions it doesn't recognize
Peter Rabbitson [Tue, 4 Jun 2013 16:08:25 +0000]
Change parser to not eagerly slurp RHS expressions it doesn't recognize

11 years agoThe ORDER BY parsing fix in 73835ff0 only worked by accident
Peter Rabbitson [Tue, 4 Jun 2013 15:11:13 +0000]
The ORDER BY parsing fix in 73835ff0 only worked by accident

Remove a number of workarounds introduced before the parser rewrite - none of
them help, and one of them was in fact the reason multi-member ORDER BY
did not function correctly

11 years agoAll roundtrip tests now look for the exact string
Peter Rabbitson [Sun, 2 Jun 2013 15:17:06 +0000]
All roundtrip tests now look for the exact string

Merge test files while at it

11 years agoStop differentiating between ORDER BY foo and ORDER BY foo ASC by default
Peter Rabbitson [Sun, 2 Jun 2013 13:38:35 +0000]
Stop differentiating between ORDER BY foo and ORDER BY foo ASC by default

11 years agoDrop the silly Dumpered bind comparison
Peter Rabbitson [Sun, 2 Jun 2013 12:16:36 +0000]
Drop the silly Dumpered bind comparison

11 years agoPave the road to more global state
Peter Rabbitson [Sat, 1 Jun 2013 20:02:17 +0000]
Pave the road to more global state

(Yes, yes an object is saner, but it means a thought out interface and
all that, and then it means optimization of when and how do we do the
modification passes, and really I am not after this stuff at the moment)

11 years agoRevert "Add support for NULLS FIRST/LAST in ORDER BY"
Dagfinn Ilmari Mannsåker [Sun, 14 Apr 2013 10:53:32 +0000]
Revert "Add support for NULLS FIRST/LAST in ORDER BY"

Despite being an ISO/ANSI SQL feature, it's apparently not supported by
enough databses to have by default.

This reverts commits 2266ca5c0bf34c24ba7fbf6448ad1c34a082f240 and
b137b0744a3aaea3df1ba497345378e9d3f8da40.

11 years agoNormalize the select docs s/$table/$source/
Olaf Alders [Wed, 6 Feb 2013 20:34:35 +0000]
Normalize the select docs s/$table/$source/

11 years agoFix false-negative function comparisons
Peter Rabbitson [Fri, 11 May 2012 04:47:09 +0000]
Fix false-negative function comparisons

11 years agoFix -nulls value case-insensitivity
Dagfinn Ilmari Mannsåker [Tue, 5 Feb 2013 19:12:46 +0000]
Fix -nulls value case-insensitivity

11 years agoAdd support for NULLS FIRST/LAST in ORDER BY
Dagfinn Ilmari Mannsåker [Sat, 26 Jan 2013 18:32:09 +0000]
Add support for NULLS FIRST/LAST in ORDER BY

12 years agorelease 1.73
Arthur Axel 'fREW' Schmidt [Tue, 10 Jul 2012 21:22:41 +0000]
release 1.73

12 years agorelease 1.73_01
Arthur Axel 'fREW' Schmidt [Wed, 30 May 2012 02:05:22 +0000]
release 1.73_01

12 years agofix regression introduced in 6f2a5b6
Arthur Axel 'fREW' Schmidt [Fri, 20 Apr 2012 18:46:28 +0000]
fix regression introduced in 6f2a5b6

12 years agoStop filling in placeholders in `format-sql`
Arthur Axel 'fREW' Schmidt [Fri, 20 Apr 2012 18:24:11 +0000]
Stop filling in placeholders in `format-sql`

12 years agoPull in some dependency bugfixes
Peter Rabbitson [Wed, 11 Apr 2012 05:12:57 +0000]
Pull in some dependency bugfixes

12 years agoUpgrade M::I
Peter Rabbitson [Tue, 29 Nov 2011 04:55:59 +0000]
Upgrade M::I

12 years agoMigrate -ident and -value from dbic, reorganize docs
Peter Rabbitson [Sun, 20 Mar 2011 09:30:17 +0000]
Migrate -ident and -value from dbic, reorganize docs

13 years agoDocument with the right name
Ryan P. Kelly [Wed, 29 Jun 2011 03:54:51 +0000]
Document with the right name

13 years agoCleaning up docs as ribasushi suggested. Made it clear that literal sql
Naveed Massjouni [Fri, 22 Apr 2011 22:08:21 +0000]
Cleaning up docs as ribasushi suggested. Made it clear that literal sql
should be used as a last resort.  Provided an example for testing IS NOT NULL.

13 years agoCleanup parser a bit more, anchor everything correctly, etc
Peter Rabbitson [Sun, 7 Aug 2011 03:54:03 +0000]
Cleanup parser a bit more, anchor everything correctly, etc

13 years agoAdd test for SQL statement that used to fail before the refactor
Alexander Hartmaier [Fri, 29 Jul 2011 13:14:35 +0000]
Add test for SQL statement that used to fail before the refactor

13 years agoMassively refactor arbitrary sql parser code
Peter Rabbitson [Sat, 6 Aug 2011 20:22:28 +0000]
Massively refactor arbitrary sql parser code

Now it deals much better with malformedness, does not recurse to insanely
deep evels, and reports much much better errors on test mismatches

13 years agoFix over-eager parenthesis unrolling (only legal in AND/OR)
Peter Rabbitson [Mon, 1 Aug 2011 10:14:49 +0000]
Fix over-eager parenthesis unrolling (only legal in AND/OR)

13 years agoPromote AS to a binop of sorts
Peter Rabbitson [Mon, 1 Aug 2011 10:03:29 +0000]
Promote AS to a binop of sorts

13 years agoDo not import Carp functions into the namespace
Peter Rabbitson [Sat, 19 Mar 2011 23:30:26 +0000]
Do not import Carp functions into the namespace

13 years ago_debug not debug, RT#67179
Justin Hunter [Fri, 8 Apr 2011 00:38:54 +0000]
_debug not debug, RT#67179

13 years agofix some pod per RT65556
Justin Hunter [Fri, 1 Apr 2011 14:47:29 +0000]
fix some pod per RT65556

13 years agofix git url, RT67137
Justin Hunter [Fri, 1 Apr 2011 14:12:45 +0000]
fix git url, RT67137

13 years agotake out useless _table option
Arthur Axel 'fREW' Schmidt [Tue, 29 Mar 2011 14:37:50 +0000]
take out useless _table option

13 years agoAdd some crazy malformed SQL to make sure things do not throw
Peter Rabbitson [Fri, 7 Jan 2011 09:40:14 +0000]
Add some crazy malformed SQL to make sure things do not throw

It looks like the empty-not-undef fix in 7cc47319 also fixes the general
issue of throwing on unknown operators (e.g. reverting af75bd59 would
still yield passing code, though the AST will still be incorrect).

Add a currently passing test as a reminder of what stuff to look for

13 years agoFix incorrect comparison of malformed lists
Peter Rabbitson [Fri, 7 Jan 2011 09:18:32 +0000]
Fix incorrect comparison of malformed lists

AND OR and , must have both a lhs and a rhs, if neither is
present add a [], which will properly trip the comparison
later on.

13 years agoFix recursion warnings while parsing extremely long lists
Peter Rabbitson [Fri, 7 Jan 2011 09:05:06 +0000]
Fix recursion warnings while parsing extremely long lists

13 years agoFix stupid not exists omission
Peter Rabbitson [Wed, 22 Dec 2010 15:45:39 +0000]
Fix stupid not exists omission

13 years agoRelease 1.72
Arthur Axel 'fREW' Schmidt [Tue, 21 Dec 2010 17:53:00 +0000]
Release 1.72

13 years agoConsolidate the injection_guard checks, fix bobby's name
Peter Rabbitson [Tue, 21 Dec 2010 16:24:29 +0000]
Consolidate the injection_guard checks, fix bobby's name

13 years agoinjection_guard implementation
Peter Rabbitson [Tue, 21 Dec 2010 12:56:07 +0000]
injection_guard implementation

13 years agoRequire bugfixed CAG
Peter Rabbitson [Tue, 21 Dec 2010 11:01:43 +0000]
Require bugfixed CAG

13 years agoUndocument -nest with extreme prejudice
Peter Rabbitson [Tue, 21 Dec 2010 10:26:09 +0000]
Undocument -nest with extreme prejudice

-nest is a wart that never served any reasonable purpose. While
DBIC is outright deprecating it, SQLA is simply undocumenting it,
committing to keep all tests intact (but not committing to
reimplement -nest in the Data::Query adapter).

13 years agoRemoved excess parentheses in generated SQL
Wes Malone [Tue, 30 Nov 2010 03:41:49 +0000]
Removed excess parentheses in generated SQL

13 years agoFix stupid assumption in parenthesis unroller
Peter Rabbitson [Sun, 5 Dec 2010 20:02:29 +0000]
Fix stupid assumption in parenthesis unroller

13 years agoPass options to _insert_returning and allow bind rvs
Peter Rabbitson [Sun, 5 Dec 2010 18:21:51 +0000]
Pass options to _insert_returning and allow bind rvs

13 years agoadd handling for NULL when using -in
Justin Hunter [Wed, 1 Dec 2010 00:03:50 +0000]
add handling for NULL when using -in

14 years agoBetter diagnostics (unparse the parent of the failed chunk)
Peter Rabbitson [Sun, 28 Nov 2010 01:31:25 +0000]
Better diagnostics (unparse the parent of the failed chunk)