11 years agoReduce amount of calls to $rsrc->columns_info where possible
Peter Rabbitson [Mon, 7 Jan 2013 13:14:34 +0000]
Reduce amount of calls to $rsrc->columns_info where possible

11 years ago_resolve_bindattrs already expects colinfo - just pass it in where we forgot
Peter Rabbitson [Mon, 7 Jan 2013 13:09:29 +0000]
_resolve_bindattrs already expects colinfo - just pass it in where we forgot

11 years agoFix some pessimizations spotted here and there (no functional changes)
Peter Rabbitson [Thu, 13 Dec 2012 06:40:13 +0000]
Fix some pessimizations spotted here and there (no functional changes)

Mainly remove a number of unused @_ unpackings, and remove the hideous
_resolved_attrs_copy pessimizer

11 years agoRemove apparent pessimization introduced in 6a588797
Peter Rabbitson [Thu, 10 Jan 2013 13:13:21 +0000]
Remove apparent pessimization introduced in 6a588797

There is no conceivable reason why the attrs need to be recalculated on cursor
reset. All tests seem to pass as well. Removing it as the calculation is quite
expensive - if problems arise bisection will hopefully lead us here

11 years agoOptimize populate(), especially bind handling in complex populate cases
Peter Rabbitson [Sun, 23 Dec 2012 11:45:16 +0000]
Optimize populate(), especially bind handling in complex populate cases

Instead of recalculating the data slice positions on every loop, we
do it only once during the "proto bind" generation. This is because
even though all bind values can and will change (even ones supplied
via \[ ... ]), their number will always remain constant.

11 years agoSimplify/cleanup parsing of search() arguments
Peter Rabbitson [Fri, 21 Dec 2012 11:41:54 +0000]
Simplify/cleanup parsing of search() arguments

11 years agoEnsure _dbi_attrs_for_bind/bind_attribute_by_data_type are called after connecting
Peter Rabbitson [Thu, 27 Dec 2012 05:43:53 +0000]
Ensure _dbi_attrs_for_bind/bind_attribute_by_data_type are called after connecting

This way a user does not have to worry about the particular DBI/DBD being
loaded before accessing its constants

11 years agoRemove support for source_bind_attributes() as promised in 0e773352a
Peter Rabbitson [Wed, 26 Dec 2012 19:50:57 +0000]
Remove support for source_bind_attributes() as promised in 0e773352a

Original deprecation was put in place almost 2 years ago

11 years agoDeprecate emulate_limit() - can not be sanely supported by DQ
Peter Rabbitson [Thu, 10 Jan 2013 13:39:08 +0000]
Deprecate emulate_limit() - can not be sanely supported by DQ

11 years agoReorganize travis test script, I *think* no functional changes
Peter Rabbitson [Thu, 27 Dec 2012 09:43:08 +0000]
Reorganize travis test script, I *think* no functional changes

11 years agoList::Util got fixed and is again installable on 5.8
Peter Rabbitson [Sat, 5 Jan 2013 22:18:17 +0000]
List::Util got fixed and is again installable on 5.8

11 years agoMove Travis Data::Dumper installation earlier, before its dependents
Peter Rabbitson [Wed, 26 Dec 2012 10:36:23 +0000]
Move Travis Data::Dumper installation earlier, before its dependents

11 years agoInstall Carp.pm separately on Travis
Peter Rabbitson [Wed, 26 Dec 2012 10:34:01 +0000]
Install Carp.pm separately on Travis

Otherwise when the timing is right it trips up installation of the parallel job

11 years agoReorganize MSSQL/DBD::Sybase TODOs on MAS+txn tests
Peter Rabbitson [Wed, 26 Dec 2012 09:50:33 +0000]
Reorganize MSSQL/DBD::Sybase TODOs on MAS+txn tests

11 years agoFix TODO tests to only mark exactly the failing tests as TODO
Brendan Byrd [Thu, 22 Mar 2012 01:10:08 +0000]
Fix TODO tests to only mark exactly the failing tests as TODO
and run the passing tests as real tests.

11 years agoNo reason to run this test at all until MC is rewritten
Peter Rabbitson [Wed, 26 Dec 2012 09:06:54 +0000]
No reason to run this test at all until MC is rewritten

11 years agoPromote leaky rscond todo to a smoke-fail - try to establish a pattern
Peter Rabbitson [Wed, 26 Dec 2012 09:02:20 +0000]
Promote leaky rscond todo to a smoke-fail - try to establish a pattern

11 years agoFix broken DBICTest::RunMode::is_smoker() (riba got pwned by precedence)
Peter Rabbitson [Wed, 19 Dec 2012 13:04:55 +0000]
Fix broken DBICTest::RunMode::is_smoker() (riba got pwned by precedence)

11 years agoAttempt to build a dist on travis if all tests pass
Peter Rabbitson [Wed, 19 Dec 2012 11:22:45 +0000]
Attempt to build a dist on travis if all tests pass

11 years agoFixup possible crlf in generated files
Peter Rabbitson [Mon, 17 Dec 2012 08:19:00 +0000]
Fixup possible crlf in generated files

11 years agoTighten notab/eol checks even more
Peter Rabbitson [Wed, 19 Dec 2012 10:36:33 +0000]
Tighten notab/eol checks even more

11 years agoSwitch rm to rm -f - we do not care about failure
Peter Rabbitson [Tue, 18 Dec 2012 12:08:08 +0000]
Switch rm to rm -f - we do not care about failure

11 years agoMove generated README to maint/.Generated_Pod as well - simplifies cleanup
Peter Rabbitson [Mon, 17 Dec 2012 08:07:02 +0000]
Move generated README to maint/.Generated_Pod as well - simplifies cleanup

11 years agoUse plain old file concat for the dbicadmin pod-injection
Peter Rabbitson [Mon, 17 Dec 2012 07:52:13 +0000]
Use plain old file concat for the dbicadmin pod-injection

Lose the oneliner for more sanity and better cross-platform support

11 years agoCreate distinct lib/ subdir in maint/.Generated_Pod (no functional changes)
Peter Rabbitson [Sun, 16 Dec 2012 11:53:20 +0000]
Create distinct lib/ subdir in maint/.Generated_Pod (no functional changes)

11 years agoRewrite all Makefile oneliners in terms of EU::MM::oneliner
Peter Rabbitson [Sun, 16 Dec 2012 07:39:42 +0000]
Rewrite all Makefile oneliners in terms of EU::MM::oneliner

11 years agoImprove the populate docs in ::Schema and ::ResultSet
Alexander Hartmaier [Wed, 7 Nov 2012 16:17:55 +0000]
Improve the populate docs in ::Schema and ::ResultSet

11 years agoExpand notabs/eol testing to .pod and some files at the root
Peter Rabbitson [Sun, 16 Dec 2012 21:07:06 +0000]
Expand notabs/eol testing to .pod and some files at the root

11 years agoExplicitly specify Scalar::Util dep, and work around RT#80646 on travis
Peter Rabbitson [Mon, 17 Dec 2012 12:50:27 +0000]
Explicitly specify Scalar::Util dep, and work around RT#80646 on travis

The inability to install Scalar::Util did not abort the cpan runs, and
therefore revealed a nasty bug in first() that is present on all perl-bundled
List::Utils until 5.8.8

11 years agoFix silly thinko in travis_prepare_env's extract_prereqs()
Peter Rabbitson [Mon, 17 Dec 2012 12:48:41 +0000]
Fix silly thinko in travis_prepare_env's extract_prereqs()

11 years agoNew Pod::Inherit now works on 5.8 (still needs Pod::Tree, RT#81896)
Peter Rabbitson [Fri, 14 Dec 2012 08:28:44 +0000]
New Pod::Inherit now works on 5.8 (still needs Pod::Tree, RT#81896)

11 years agoI was wrong about 2d12a809 - the crash is real
Peter Rabbitson [Sat, 15 Dec 2012 08:29:18 +0000]
I was wrong about 2d12a809 - the crash is real

Switch remaining problematic tests to skip away in is_plain (enduser
installation) mode, keep failing for the time being for authors until
a cause is found.

Please *DO NOT* quietly skip inconvenient tests

11 years agoRun t/storage/global_destruction.t using SQLite as well
Peter Rabbitson [Sat, 15 Dec 2012 06:55:23 +0000]
Run t/storage/global_destruction.t using SQLite as well

11 years agoAdd JSON::DWIW to authordeps, so more tests run
Peter Rabbitson [Sat, 15 Dec 2012 04:32:46 +0000]
Add JSON::DWIW to authordeps, so more tests run

11 years agoRevert skip from a0361822 and fix tests to work correctly
Peter Rabbitson [Sat, 15 Dec 2012 04:32:46 +0000]
Revert skip from a0361822 and fix tests to work correctly

Hand-assembling JSON is prone to error - the $dsn would end up containing
a backslash on Win32 which the simple catenation would not escape.

11 years agoForce xt/ tests to run on anything involving a create_distdir
Peter Rabbitson [Fri, 14 Dec 2012 13:33:22 +0000]
Force xt/ tests to run on anything involving a create_distdir

11 years agoSince .generated_pod is no longer shipped in-dist, move it to maint/
Peter Rabbitson [Fri, 14 Dec 2012 09:10:14 +0000]
Since .generated_pod is no longer shipped in-dist, move it to maint/

11 years agoMake pod generation more palatable to the existing toolchain
Peter Rabbitson [Thu, 13 Dec 2012 10:37:37 +0000]
Make pod generation more palatable to the existing toolchain

While the installation toolchain seems to understand the concept of
PMLIBDIRS/PMLIBPARENTDIRS rather well, it turns out that both s.c.o.
and metacpan hav great troubles displaying the results. While there
is work underway to fix metacpan, the intermittency of the failures
prompted a rethink of how to handle all of this.

So instead we turn (ab)use of ExtUtils::MakeMaker to 11. The generation
scripts still dump their contents into .generated_pod/ as before.
However afterwards we hook the create_distdir EUMM target and split it
into several targets:

create_distdir : clonedir_generate_files clonedir_post_generate_files fresh_manifest create_distdir_copy_manifested clonedir_cleanup_generated_files

Then we use the pre-existing EUMM install facility to copy the generated
POD directly to lib/, create a manifest and a distdir, and then delete
everything we just copied from lib/, leaving the clone-dir as pristine
as it was before we started.

11 years agoMerge all pod generation into one inc snippet, cleanup the poddir beforehand
Peter Rabbitson [Thu, 13 Dec 2012 08:48:52 +0000]
Merge all pod generation into one inc snippet, cleanup the poddir beforehand

11 years agoDo not mask Makefile.PL errors in END block
Peter Rabbitson [Thu, 13 Dec 2012 09:54:20 +0000]
Do not mask Makefile.PL errors in END block

11 years agoMinor clarifications to POD
Rafael Kitover [Tue, 27 Mar 2012 04:08:37 +0000]
Minor clarifications to POD

11 years agoMore documentation improvements in the spirit of fb13a49f
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
More documentation improvements in the spirit of fb13a49f

Clarify new/new_result/search relations
Clarify return of update/delete
Some trivial readability fixes

11 years agoBoy that's a lot of emails ;)
Peter Rabbitson [Wed, 12 Dec 2012 15:50:34 +0000]
Boy that's a lot of emails ;)

11 years agoAdd linkback to ResultSource::resultset_attributes
Brendan Byrd [Mon, 10 Dec 2012 22:43:06 +0000]
Add linkback to ResultSource::resultset_attributes

Also clarify problems related to its use

11 years agoRelationship::Base documentation fixes in the spirit of fb13a49f
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Relationship::Base documentation fixes in the spirit of fb13a49f

11 years agoSome dependency bumps
Peter Rabbitson [Fri, 30 Nov 2012 14:44:26 +0000]
Some dependency bumps

- CAG 0.10008 causes DBIC test fails
- D::GD before 0.09 is broken on threads in pure-perl mode
- Latest MRO::Compat will upgrade Class::C3 and Class::C3::XS automatically
- Older Module::Find will not go follow symlinks, upgrade to avoid deployment differences
- Older namespace::clean is too complex - use one where complexity lives in B::Hooks::EndOfScope
- Bump Try::Tiny API

11 years agoFix incorrect handling of $? in travis preconf script
Peter Rabbitson [Tue, 11 Dec 2012 11:47:42 +0000]
Fix incorrect handling of $? in travis preconf script

11 years agoTemporarily stop requiring podinherit on < 5.10.1, until we fix it
Peter Rabbitson [Tue, 11 Dec 2012 11:33:35 +0000]
Temporarily stop requiring podinherit on < 5.10.1, until we fix it

11 years agoFix RT#78436 - a replicated storage does not have a conninfo as such
Peter Rabbitson [Sat, 3 Nov 2012 17:50:18 +0000]
Fix RT#78436 - a replicated storage does not have a conninfo as such

11 years agoSmoke bleadperl as well
Peter Rabbitson [Mon, 3 Dec 2012 11:46:24 +0000]
Smoke bleadperl as well

11 years agoStop using deprecated regex syntax
Peter Rabbitson [Tue, 11 Dec 2012 11:01:25 +0000]
Stop using deprecated regex syntax

11 years agoPartial fix for the hash randomization issues in 5.17.6+
Peter Rabbitson [Tue, 11 Dec 2012 11:00:18 +0000]
Partial fix for the hash randomization issues in 5.17.6+

NOTE: this is *not* a complete fix. There are at least two other places
which do not manifest themselves due to lack of tests. Work underway...

11 years agoRevert 50e6c52e0 - the crash was most likely due to old Moo (same as dfd722ef)
Peter Rabbitson [Tue, 11 Dec 2012 10:51:20 +0000]
Revert 50e6c52e0 - the crash was most likely due to old Moo (same as dfd722ef)

11 years agoDBIC::Carp not primetime ready - hide
Peter Rabbitson [Tue, 11 Dec 2012 10:47:38 +0000]
DBIC::Carp not primetime ready - hide

11 years agoDo not grab a global lock if test won't run
Peter Rabbitson [Tue, 11 Dec 2012 10:28:52 +0000]
Do not grab a global lock if test won't run

11 years agoFill gaps in documentation: alias ($rs attr), table_alias, result_class
Brendan Byrd [Mon, 10 Dec 2012 22:10:26 +0000]
Fill gaps in documentation: alias ($rs attr), table_alias, result_class

11 years agoFINALLY document DBIC @bind_vals
Brendan Byrd [Mon, 10 Dec 2012 17:41:23 +0000]
FINALLY document DBIC @bind_vals

11 years agoClarify purpose and deprecation of search_literal
Peter Rabbitson [Tue, 11 Dec 2012 10:11:40 +0000]
Clarify purpose and deprecation of search_literal

11 years agoVarious other POD fixes
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Various other POD fixes

Change docs to reflect new Manual::ResultClass
Stop using "moniker"
There is no Row; there is only Zuul.
Arguments, Return Values, and Linking -will- be enforced!

11 years agoUtilize Pod::Inherit to add an INHERITED METHODS section to docs
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Utilize Pod::Inherit to add an INHERITED METHODS section to docs

11 years agoVarious method POD changes
Brendan Byrd [Fri, 23 Mar 2012 15:09:04 +0000]
Various method POD changes

Apply very small doc correction to search_related
Add "official" method entries for $rel and $col
Add more doc clarification changes to ::Row
Fix incorrect last_modified / update comparison in ::Row/update

11 years agoTurn the CLEANTEST smokes into full blown CPAN-based installs with testing
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Turn the CLEANTEST smokes into full blown CPAN-based installs with testing

Not considering doing cpanreporting because the reporter installation itself
would violate the CLEANTEST idea

11 years agoMore information about the test env we are about to use
Peter Rabbitson [Wed, 5 Dec 2012 10:30:23 +0000]
More information about the test env we are about to use

11 years agoFirebird apt configuration can't be made to cooperate - skip when it fails
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Firebird apt configuration can't be made to cooperate - skip when it fails

11 years agoReorganize travis preconfig script - better tracing and handling of failures
Peter Rabbitson [Sun, 9 Dec 2012 05:25:04 +0000]
Reorganize travis preconfig script - better tracing and handling of failures

11 years agoMove generated POD to its own dir
Peter Rabbitson [Sun, 9 Dec 2012 13:38:26 +0000]
Move generated POD to its own dir

11 years agoUse legacy File::Path API - avoid a dependency (see next commit)
Peter Rabbitson [Sun, 9 Dec 2012 16:51:35 +0000]
Use legacy File::Path API - avoid a dependency (see next commit)

11 years agoWhile permanentising meta/ 62628242 did not properly noindex it
Peter Rabbitson [Mon, 10 Dec 2012 08:05:32 +0000]
While permanentising meta/ 62628242 did not properly noindex it

11 years agoForgotten no-longer-needed dependency after d6b39e46
Peter Rabbitson [Sun, 9 Dec 2012 12:45:57 +0000]
Forgotten no-longer-needed dependency after d6b39e46

11 years agoAUTHORS mass update; mst doesn't have to take credit for -everything- :)
Brendan Byrd [Thu, 9 Aug 2012 14:45:54 +0000]
AUTHORS mass update; mst doesn't have to take credit for -everything- :)

11 years agoRelax FB reconfig timings even more
Peter Rabbitson [Mon, 3 Dec 2012 10:30:35 +0000]
Relax FB reconfig timings even more

11 years agoTruly clean CLEANTEST
Peter Rabbitson [Mon, 3 Dec 2012 10:29:58 +0000]
Truly clean CLEANTEST

11 years agoDisable travis list notifications until things stabilize
Peter Rabbitson [Mon, 3 Dec 2012 10:23:40 +0000]
Disable travis list notifications until things stabilize

11 years agoAdd comprehensive Firebird smoking to travis
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Add comprehensive Firebird smoking to travis

11 years agoExpand comments, move core dep install before RDBMS setup (no func. changes)
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Expand comments, move core dep install before RDBMS setup (no func. changes)

11 years agoDo not spam the mailing lists - only notify once per branchfail
Peter Rabbitson [Sun, 2 Dec 2012 08:13:54 +0000]
Do not spam the mailing lists - only notify once per branchfail

11 years agoAdd MOAR meta
Peter Rabbitson [Fri, 30 Nov 2012 18:34:30 +0000]
Add MOAR meta

11 years agoThrow away suboptimal travis CPANM env-option and tighten plans more
Peter Rabbitson [Fri, 30 Nov 2012 15:45:07 +0000]
Throw away suboptimal travis CPANM env-option and tighten plans more

11 years agoMore extensive travis testing plan
Peter Rabbitson [Thu, 29 Nov 2012 13:57:30 +0000]
More extensive travis testing plan

11 years agoFix the leaktracer rewrite in 218b7c12 which broke under 5.10
Peter Rabbitson [Fri, 30 Nov 2012 14:44:26 +0000]
Fix the leaktracer rewrite in 218b7c12 which broke under 5.10

Reduce the amount of shuffling happening in CLONE - use a fresh hashref
instead

11 years agoSome podlator stacks do not like multi-word =begin
Peter Rabbitson [Thu, 29 Nov 2012 13:50:36 +0000]
Some podlator stacks do not like multi-word =begin

11 years agoUpdate .travis.yml with faster deps and DBICTESTs
Brendan Byrd [Mon, 12 Nov 2012 21:06:28 +0000]
Update .travis.yml with faster deps and DBICTESTs

12 years agoStop stripping table name qualifier on complex $rs->update/delete
Peter Rabbitson [Mon, 19 Nov 2012 07:49:45 +0000]
Stop stripping table name qualifier on complex $rs->update/delete

RT#80015, RT#78844

12 years agoBack out frivolous loading of threads.pm
Peter Rabbitson [Sun, 18 Nov 2012 20:17:09 +0000]
Back out frivolous loading of threads.pm

Not only was this an unsuccesful attempt to mask out a bug introduced
in Moo's inlining of Devel::GlobalDestruction (since fixed), but it
broke a test under older win32 perls.
Revert 8bab2062, bump Moo dep

12 years agoRewrite 461c7168 solving Oracle silent connection failures
Peter Rabbitson [Sun, 18 Nov 2012 22:32:57 +0000]
Rewrite 461c7168 solving Oracle silent connection failures

The patch incorrectly masks the underlying issue - during the refactor
of 584ea6e4 a bunch of exception traps were introduced which were never
there in the first place. _dbh_get_info() should always be throwing an
error if one takes place (the only place before 584ea6e4 was in the
FreeTDS version determination, and that one made no sense anyway).
_server_info() OTOH is indeed an opportunistic routine - leave the
"rethrow if determining driver" escape as-is

12 years agoRename and expand false-value prefetch test
Peter Rabbitson [Sun, 18 Nov 2012 20:08:58 +0000]
Rename and expand false-value prefetch test

12 years agoWhile the TODO was solved in b11221ff the source of confusion was not
Peter Rabbitson [Sun, 18 Nov 2012 19:59:44 +0000]
While the TODO was solved in b11221ff the source of confusion was not

12 years agoList of what needs undoing since 0.08196
Peter Rabbitson [Sat, 25 Aug 2012 22:45:30 +0000]
List of what needs undoing since 0.08196

12 years agoExtended mailmap (name match only)
Peter Rabbitson [Sun, 18 Nov 2012 18:35:37 +0000]
Extended mailmap (name match only)

12 years agoFix test skips just like was done in 49b3a264
Peter Rabbitson [Wed, 14 Nov 2012 08:54:53 +0000]
Fix test skips just like was done in 49b3a264

12 years agoMore robust behavior under heavily threaded environments
Peter Rabbitson [Wed, 14 Nov 2012 08:54:18 +0000]
More robust behavior under heavily threaded environments

12 years agoReorganize metadata, add github addresses
Peter Rabbitson [Wed, 14 Nov 2012 07:16:50 +0000]
Reorganize metadata, add github addresses
Make the meta repository read github, so that metacpan shows cool
buttons for the cool kids. Note - the official repo still does and will
continue to reside on sc

12 years agodoc fix for Resultset find_or_new and update_or_new methods
Michael Jemmeson [Thu, 8 Nov 2012 14:01:27 +0000]
doc fix for Resultset find_or_new and update_or_new methods

12 years agoRelease 0.08204 v0.08204
Torsten Raudssus [Thu, 8 Nov 2012 19:56:08 +0000]
Release 0.08204

12 years agoBump CAG to a bugfixed version
Peter Rabbitson [Thu, 8 Nov 2012 12:00:10 +0000]
Bump CAG to a bugfixed version

12 years agoAsk for newer CAG which asks for bugfixed CXSA
Peter Rabbitson [Mon, 5 Nov 2012 08:31:44 +0000]
Ask for newer CAG which asks for bugfixed CXSA

12 years agoSquash NaN warnings on older perls
Peter Rabbitson [Mon, 5 Nov 2012 08:15:28 +0000]
Squash NaN warnings on older perls

12 years agoSwitch vestigial warn() calls to carp()
Peter Rabbitson [Mon, 5 Nov 2012 08:11:19 +0000]
Switch vestigial warn() calls to carp()

12 years agoBetter diagnostics in the case of missing drivers, slight ADO/ODBC refactor
Peter Rabbitson [Mon, 5 Nov 2012 02:35:45 +0000]
Better diagnostics in the case of missing drivers, slight ADO/ODBC refactor

12 years agoMore 5.8 nested-cref test leaks
Peter Rabbitson [Mon, 5 Nov 2012 05:18:16 +0000]
More 5.8 nested-cref test leaks