Fix Oracle _dbh_execute_for_fetch warning suppression
authorDagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Wed, 20 Apr 2016 16:20:26 +0000 (17:20 +0100)
committerPeter Rabbitson <ribasushi@cpan.org>
Thu, 21 Apr 2016 09:30:38 +0000 (11:30 +0200)
commit7b731f1eca0005daa869c61a96e48434af5635dc
tree61ebcc4897f2fbdc983cf58759baa5a6d69dca27
parent51ec03826afb5b20a686a7303bc55c42f4715945
Fix Oracle _dbh_execute_for_fetch warning suppression

Commit 52cef7e3 changed from using execute_array to execute_for_fetch,
but didn't update the signature of the override in
Storage::DBI::Oracle::Generic, so it was setting ->{PrintWarn} 0 on the
result source, not the statement handle.

The reason it was not detected since is that DBD::Oracle 1.28+ already
fixed the underlying warning.
lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm