take advantage of join_query_parts to clean up

[scpubgit/Q-Branch.git] / lib / SQL / Abstract / ExtraClauses.pm

diff --git a/lib/SQL/Abstract/ExtraClauses.pm b/lib/SQL/Abstract/ExtraClauses.pm
index ae1ded5..0ab5a9c 100644 (file)
--- a/lib/SQL/Abstract/ExtraClauses.pm
+++ b/lib/SQL/Abstract/ExtraClauses.pm
@@ -21,12 +21,12 @@ sub register_defaults {
     }
   }
   die "Huh?" unless @before_setop;
-  $self->clauses_of(select => @clauses);
+  $self->clauses_of(select => 'with', @clauses);
   $self->clause_expanders(
     'select.group_by', sub {
-      $_[0]->_expand_maybe_list_expr($_[1], -ident)
+      $_[0]->_expand_maybe_list_expr($_[2], -ident)
     },
-    'select.having', 'expand_expr',
+    'select.having', sub { $_[0]->expand_expr($_[2]) },
   );
   foreach my $thing (qw(join from_list)) {
     $self->expander($thing => "_expand_${thing}")
@@ -51,20 +51,20 @@ sub register_defaults {
   $self->clause_expanders(
     'update.from' => '_expand_select_clause_from',
     'delete.using' => sub {
-      +(using => $_[0]->_expand_from_list(undef, $_[1]));
+      +(using => $_[0]->_expand_from_list(undef, $_[2]));
     },
     'insert.rowvalues' => sub {
-      +(from => $_[0]->expand_expr({ -values => $_[1] }));
+      +(from => $_[0]->expand_expr({ -values => $_[2] }));
     },
     'insert.select' => sub {
-      +(from => $_[0]->expand_expr({ -select => $_[1] }));
+      +(from => $_[0]->expand_expr({ -select => $_[2] }));
     },
   );
 
   # set ops
-  {
-    my $orig = $self->expander('select');
-    $self->expander(select => sub {
+  $self->wrap_expander(select => sub {
+    my $orig = shift;
+    sub {
       my $self = shift;
       my $exp = $self->$orig(@_);
       return $exp unless my $setop = (my $sel = $exp->{-select})->{setop};
@@ -74,42 +74,85 @@ sub register_defaults {
           { -select => \%inner };
       }
       return $exp;
-    });
-  }
-
-  $self->clause_expander('select.union' => sub {
-    +(setop => $_[0]->expand_expr({
-                 -union => {
-                   queries => (ref($_[1]) eq 'ARRAY' ? $_[1] : [ $_[1] ]),
-                 }
-               }));
-  });
-  $self->clause_expander('select.union_all' => sub {
-    +(setop => $_[0]->expand_expr({
-                 -union => {
-                   type => 'all',
-                   queries => (ref($_[1]) eq 'ARRAY' ? $_[1] : [ $_[1] ]),
-                 }
-               }));
+    }
   });
-  $self->expander(union => sub {
-    my ($self, undef, $args) = @_;
-    +{ -union => {
+  my $expand_setop = sub {
+    my ($self, $setop, $args) = @_;
+    +{ "-${setop}" => {
          %$args,
          queries => [ map $self->expand_expr($_), @{$args->{queries}} ],
     } };
-  });
+  };
+  $self->expanders(map +($_ => $expand_setop), qw(union intersect except));
 
   $self->clause_renderer('select.setop' => sub {
-    my ($self, $setop) = @_;
+    my ($self, undef, $setop) = @_;
     $self->render_aqt($setop);
   });
 
-  $self->renderer(union => sub {
-    my ($self, $args) = @_;
-    $self->join_clauses(
-      ' '.$self->format_keyword(join '_', 'union', ($args->{type}||())).' ',
-      map [ $self->render_aqt($_) ], @{$args->{queries}}
+  $self->renderer($_ => sub {
+    my ($self, $setop, $args) = @_;
+    $self->join_query_parts(
+      ' '.$self->format_keyword(join '_', $setop, ($args->{type}||())).' ',
+      @{$args->{queries}}
+    );
+  }) for qw(union intersect except);
+
+  my $setop_expander = sub {
+    my ($self, $setop, $args) = @_;
+    my ($op, $type) = split '_', $setop;
+    +(setop => $self->expand_expr({
+      "-${op}" => {
+        ($type ? (type => $type) : ()),
+        queries => (ref($args) eq 'ARRAY' ? $args : [ $args ])
+      }
+    }));
+  };
+
+  $self->clause_expanders(
+    map +($_ => $setop_expander),
+      map "select.${_}",
+        map +($_, "${_}_all", "${_}_distinct"),
+          qw(union intersect except)
+  );
+
+  $self->clause_expander('select.with' => my $with_expander = sub {
+    my ($self, $name, $with) = @_;
+    my (undef, $type) = split '_', $name;
+    if (ref($with) eq 'HASH') {
+      return +{
+        %$with,
+        queries => [ map $self->expand_expr($_), @{$with->{queries}} ]
+      }
+    }
+    my @with = @$with;
+    my @exp;
+    while (my ($name, $query) = splice @with, 0, 2) {
+      my @n = map $self->expand_expr($_, -ident),
+                ref($name) eq 'ARRAY' ? @$name : $name;
+      push @exp, [
+        \@n,
+        $self->expand_expr($query)
+      ];
+    }
+    return +(with => { ($type ? (type => $type) : ()), queries => \@exp });
+  });
+  $self->clause_expander('select.with_recursive', $with_expander);
+  $self->clause_renderer('select.with' => sub {
+    my ($self, undef, $with) = @_;
+    my $q_part = [ $self->join_query_parts(', ',
+      map {
+        my ($alias, $query) = @$_;
+        [ $self->join_query_parts(' ',
+            [ $self->_render_alias($alias) ],
+            [ $self->format_keyword('as') ],
+            $query,
+        ) ]
+      } @{$with->{queries}}
+    ) ];
+    return $self->join_query_parts(' ',
+      [ $self->format_keyword(join '_', 'with', ($with->{type}||'')) ],
+      $q_part,
     );
   });
 
@@ -119,7 +162,7 @@ sub register_defaults {
 sub format_keyword { $_[0]->_sqlcase(join ' ', split '_', $_[1]) }
 
 sub _expand_select_clause_from {
-  my ($self, $from) = @_;
+  my ($self, undef, $from) = @_;
   +(from => $self->_expand_from_list(undef, $from));
 }
 
@@ -171,12 +214,12 @@ sub _expand_join {
 }
 
 sub _render_from_list {
-  my ($self, $list) = @_;
-  return $self->join_clauses(', ', map [ $self->render_aqt($_) ], @$list);
+  my ($self, undef, $list) = @_;
+  return $self->join_query_parts(', ', @$list);
 }
 
 sub _render_join {
-  my ($self, $args) = @_;
+  my ($self, undef, $args) = @_;
 
   my @parts = (
     [ $self->render_aqt($args->{from}) ],
@@ -193,7 +236,7 @@ sub _render_join {
       [ $self->render_aqt($args->{using}) ],
     ) : ()),
   );
-  return $self->join_clauses(' ', @parts);
+  return $self->join_query_parts(' ', @parts);
 }
 
 sub _expand_op_as {
@@ -204,25 +247,36 @@ sub _expand_op_as {
 }
 
 sub _render_as {
-  my ($self, $args) = @_;
-  my ($thing, $as, @cols) = @$args;
-  return $self->join_clauses(
+  my ($self, undef, $args) = @_;
+  my ($thing, @alias) = @$args;
+  return $self->join_query_parts(
     ' ',
     [ $self->render_aqt($thing) ],
     [ $self->format_keyword('as') ],
-    (@cols
-      ? [ $self->join_clauses('',
-            [ $self->render_aqt($as) ],
-            [ '(' ],
-            [ $self->join_clauses(
-                ', ',
-                map [ $self->render_aqt($_) ], @cols
-            ) ],
-            [ ')' ],
-        ) ]
-      : [ $self->render_aqt($as) ]
-    ),
+    [ $self->_render_alias(\@alias) ],
   );
 }
 
+sub _render_alias {
+  my ($self, $args) = @_;
+  my ($as, @cols) = @$args;
+  return (@cols
+    ? $self->join_query_parts('',
+         $as,
+         [ '(' ],
+         [ $self->join_query_parts(
+             ', ',
+             @cols
+         ) ],
+         [ ')' ],
+      )
+    : $self->render_aqt($as)
+  );
+}
+
+sub _expand_update_clause_target {
+  my ($self, undef, $target) = @_;
+  +(target => $self->_expand_from_list(undef, $target));
+}
+
 1;