use string eval for testing hints to avoid compile vs runtime complexity

[p5sagit/strictures.git] / t / strictures.t

diff --git a/t/strictures.t b/t/strictures.t
index de4b5c8..cf09a9d 100644 (file)
--- a/t/strictures.t
+++ b/t/strictures.t
@@ -1,55 +1,60 @@
-# -e is sufficient here.
--e 't/smells-of-vcs/.git'
-  or mkdir('t/smells-of-vcs/.git')
-  or die "Couldn't create fake .git: $!";
+BEGIN { $ENV{PERL_STRICTURES_EXTRA} = 0 }
+
+sub capture_hints {
+  my $code = shift;
+  my ($hints, $warning_bits);
+  $code .= q{
+    ;
+    BEGIN {
+      # ignore lexicalized hints
+      $hints = $^H & ~ 0x20000;
+      $warning_bits = defined ${^WARNING_BITS} ? (unpack "H*", ${^WARNING_BITS}) : undef;
+    };
+    1;
+  };
+  eval $code or die $@;
+  return ($hints, $warning_bits);
+}
 
+use strict;
+use warnings;
 use Test::More qw(no_plan);
 
-our (@us, @expect);
-
-sub capture_stuff { [ $^H, ${^WARNING_BITS} ] }
-
-sub capture_us { push @us, capture_stuff }
-sub capture_expect { push @expect, capture_stuff }
-
-{
-  use strictures 1;
-  BEGIN { capture_us }
+sub compare_hints {
+  my ($code_want, $code_got, $name) = @_;
+  my ($want_hints, $want_warnings) = capture_hints $code_want;
+  my ($hints, $warnings) = capture_hints $code_got;
+  is($hints,    $want_hints, "Hints correct for $name");
+  is($warnings, $want_warnings,  "Warnings correct for $name");
 }
 
-{
+compare_hints q{
   use strict;
   use warnings FATAL => 'all';
-  BEGIN { capture_expect }
-}
-
-# I'm assuming here we'll have more cases later. maybe not. eh.
-
-foreach my $idx (0 .. $#us) {
-  is($us[$idx][0], $expect[$idx][0], 'Hints ok for case '.($idx+1));
-  is($us[$idx][1], $expect[$idx][1], 'Warnings ok for case '.($idx+1));
-}
-
-SKIP: {
-  skip 'Extra tests disabled on perls <= 5.008003', 1
-    if $] < 5.008004;
-  skip 'Not got all the modules to do this', 1
-    unless eval {
-      require indirect;
-      require multidimensional;
-      require bareword::filehandles;
-      1;
-    };
-  local $0 = 't/00load.t';
-  sub Foo::new { 1 }
-  chdir("t/smells-of-vcs");
-  my $r = eval q{
-    use strictures 1;
-    new Foo 1, 2, 3;
-  };
-  # I don't test $@ here since if indirect isn't installed we hit one
-  # error and if it is we hit another; it's enough the code path's hit.
-  ok(!$r, 'strictures blows up for t/00load.t');
-}
+},
+q{
+  use strictures 1;
+},
+  'version 1';
 
-ok(!eval q{use strictures 2; 1; }, "Can't use strictures 2 (this is version 1)");
+compare_hints q{
+  use strict;
+  use warnings 'all';
+  use warnings FATAL => @strictures::WARNING_CATEGORIES;
+  no warnings FATAL => @strictures::V2_NONFATAL;
+  use warnings @strictures::V2_NONFATAL;
+  no warnings @strictures::V2_DISABLE;
+},
+q{
+  use strictures 2;
+},
+  'version 2';
+
+my $v;
+eval { $v = strictures->VERSION; 1 } or diag $@;
+is $v, $strictures::VERSION, '->VERSION returns version correctly';
+
+eval q{ use strictures 3; };
+
+like $@, qr/strictures version 3 required/,
+  "Can't use strictures 3 (this is version 2)";