*_PERL_LT_5_8_4 = ($] < 5.008004) ? sub(){1} : sub(){0};
}
-our $VERSION = '1.005006';
+our $VERSION = '2.000000';
$VERSION = eval $VERSION;
+our @WARNING_CATEGORIES = grep { exists $warnings::Offsets{$_} } qw(
+ closure
+ deprecated
+ exiting
+ experimental
+ experimental::lexical_subs
+ experimental::lexical_topic
+ experimental::regex_sets
+ experimental::smartmatch
+ glob
+ imprecision
+ io
+ closed
+ exec
+ layer
+ newline
+ pipe
+ unopened
+ misc
+ numeric
+ once
+ overflow
+ pack
+ portable
+ recursion
+ redefine
+ regexp
+ severe
+ debugging
+ inplace
+ internal
+ malloc
+ signal
+ substr
+ syntax
+ ambiguous
+ bareword
+ digit
+ illegalproto
+ parenthesis
+ precedence
+ printf
+ prototype
+ qw
+ reserved
+ semicolon
+ taint
+ threads
+ uninitialized
+ unpack
+ untie
+ utf8
+ non_unicode
+ nonchar
+ surrogate
+ void
+ y2k
+);
+
sub VERSION {
no warnings;
local $@;
goto &UNIVERSAL::VERSION;
}
-our $extra_load_states;
+our %extra_load_states;
our $Smells_Like_VCS;
= exists $^H{strictures_enable} ? delete $^H{strictures_enable}
: int $VERSION;
}
+ $opts{file} = (caller)[1];
$class->_enable(\%opts);
}
if !defined $version;
my $method = "_enable_$version";
if (!$class->can($method)) {
- die "Major version specified as $version - not supported!";
+ require Carp;
+ Carp::croak("Major version specified as $version - not supported!");
}
$class->$method($opts);
}
sub _enable_1 {
+ my ($class, $opts) = @_;
strict->import;
warnings->import(FATAL => 'all');
- my $extra_tests = do {
- if (exists $ENV{PERL_STRICTURES_EXTRA}) {
- if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) {
- die 'PERL_STRICTURES_EXTRA checks are not available on perls older than 5.8.4: '
- . "please unset \$ENV{PERL_STRICTURES_EXTRA}\n";
- }
- $ENV{PERL_STRICTURES_EXTRA};
- } elsif (! _PERL_LT_5_8_4) {
- (caller(3))[1] =~ /^(?:t|xt|lib|blib)[\\\/]/
- and defined $Smells_Like_VCS ? $Smells_Like_VCS
- : ( $Smells_Like_VCS = !!(
- -e '.git' || -e '.svn' || -e '.hg'
- || (-e '../../dist.ini'
- && (-e '../../.git' || -e '../../.svn' || -e '../../.hg' ))
- ))
+ if (_want_extra($opts->{file})) {
+ _load_extras(qw(indirect multidimensional bareword::filehandles));
+ indirect->unimport(':fatal')
+ if $extra_load_states{indirect};
+ multidimensional->unimport
+ if $extra_load_states{multidimensional};
+ bareword::filehandles->unimport
+ if $extra_load_states{'bareword::filehandles'};
+ }
+}
+
+our @V2_NONFATAL = grep { exists $warnings::Offsets{$_} } qw(
+ exec
+ recursion
+ internal
+ malloc
+ newline
+ experimental
+ deprecated
+ portable
+);
+our @V2_DISABLE = grep { exists $warnings::Offsets{$_} } qw(
+ once
+);
+
+sub _enable_2 {
+ my ($class, $opts) = @_;
+ strict->import;
+ warnings->import;
+ warnings->import(FATAL => @WARNING_CATEGORIES);
+ warnings->import(NONFATAL => @V2_NONFATAL);
+ warnings->unimport(@V2_DISABLE);
+
+ if (_want_extra($opts->{file})) {
+ _load_extras(qw(indirect multidimensional bareword::filehandles));
+ indirect->unimport(':fatal')
+ if $extra_load_states{indirect};
+ multidimensional->unimport
+ if $extra_load_states{multidimensional};
+ bareword::filehandles->unimport
+ if $extra_load_states{'bareword::filehandles'};
+ }
+}
+
+sub _want_extra_env {
+ if (exists $ENV{PERL_STRICTURES_EXTRA}) {
+ if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) {
+ die 'PERL_STRICTURES_EXTRA checks are not available on perls older'
+ . "than 5.8.4: please unset \$ENV{PERL_STRICTURES_EXTRA}\n";
}
- };
- if ($extra_tests) {
- $extra_load_states ||= do {
-
- my (%rv, @failed);
- foreach my $mod (qw(indirect multidimensional bareword::filehandles)) {
- eval "require $mod; \$rv{'$mod'} = 1;" or do {
- push @failed, $mod;
-
- # courtesy of the 5.8 require bug
- # (we do a copy because 5.16.2 at least uses the same read-only
- # scalars for the qw() list and it doesn't seem worth a $^V check)
-
- (my $file = $mod) =~ s|::|/|g;
- delete $INC{"${file}.pm"};
- };
- }
-
- if (@failed) {
- my $failed = join ' ', @failed;
- print STDERR <<EOE;
+ return $ENV{PERL_STRICTURES_EXTRA} ? 1 : 0;
+ }
+ return undef;
+}
+
+sub _want_extra {
+ my $file = shift;
+ my $want_env = _want_extra_env();
+ return $want_env
+ if defined $want_env;
+ return (
+ !_PERL_LT_5_8_4
+ and $file =~ /^(?:t|xt|lib|blib)[\\\/]/
+ and defined $Smells_Like_VCS ? $Smells_Like_VCS
+ : ( $Smells_Like_VCS = !!(
+ -e '.git' || -e '.svn' || -e '.hg'
+ || (-e '../../dist.ini'
+ && (-e '../../.git' || -e '../../.svn' || -e '../../.hg' ))
+ ))
+ );
+}
+
+sub _load_extras {
+ my @extras = @_;
+ my @failed;
+ foreach my $mod (@extras) {
+ next
+ if exists $extra_load_states{$mod};
+
+ $extra_load_states{$mod} = eval "require $mod; 1;" or do {
+ push @failed, $mod;
+
+ #work around 5.8 require bug
+ (my $file = $mod) =~ s|::|/|g;
+ delete $INC{"${file}.pm"};
+ };
+ }
+
+ if (@failed) {
+ my $failed = join ' ', @failed;
+ my $extras = join ' ', @extras;
+ print STDERR <<EOE;
strictures.pm extra testing active but couldn't load all modules. Missing were:
$failed
Extra testing is auto-enabled in checkouts only, so if you're the author
of a strictures-using module you need to run:
- cpan indirect multidimensional bareword::filehandles
+ cpan $extras
but these modules are not required by your users.
EOE
- }
-
- \%rv;
- };
-
- indirect->unimport(':fatal') if $extra_load_states->{indirect};
- multidimensional->unimport if $extra_load_states->{multidimensional};
- bareword::filehandles->unimport if $extra_load_states->{'bareword::filehandles'};
}
}
=head1 SYNOPSIS
- use strictures 1;
+ use strictures 2;
is equivalent to
use strict;
use warnings FATAL => 'all';
+ use warnings NONFATAL => qw(
+ exec
+ recursion
+ internal
+ malloc
+ newline
+ experimental
+ deprecated
+ portable
+ );
+ no warnings 'once';
except when called from a file which matches:
L<Dist::Zilla>) -- or when the C<PERL_STRICTURES_EXTRA> environment variable is
set, in which case
- use strictures 1;
+ use strictures 2;
is equivalent to
use strict;
use warnings FATAL => 'all';
+ use warnings NONFATAL => qw(
+ exec
+ recursion
+ internal
+ malloc
+ newline
+ experimental
+ deprecated
+ portable
+ );
+ no warnings 'once';
no indirect 'fatal';
no multidimensional;
no bareword::filehandles;
mechanism of this code will result in a sub-version increase (e.g. 1.000000 to
1.000001 (1.0.1)).
-If the behaviour of C<use strictures> in normal mode changes in any way, that
-will constitute a major version increase -- and the code already checks
-when its version is tested to ensure that
+=head1 VERSIONS
+
+Depending on the version of strictures requested, different warnings will be
+enabled. If no specific version is requested, the current version's behavior
+will be used. Versions can be requested using perl's standard mechanism:
+
+ use strictures 2;
+
+Or, by passing in a C<version> option:
+
+ use strictures version => 2;
+
+=head2 VERSION 2
+
+Equivalent to:
+
+ use strict;
+ use warnings FATAL => 'all';
+ use warnings NONFATAL => 'deprecated', 'experimental';
+ # and if in dev mode:
+ no indirect 'fatal';
+ no multidimensional;
+ no bareword::filehandles;
+
+=head2 VERSION 1
- use strictures 1;
+Equivalent to:
-will continue to only introduce the current set of strictures even if 2.0 is
-installed.
+ use strict;
+ use warnings FATAL => 'all';
+ # and if in dev mode:
+ no indirect 'fatal';
+ no multidimensional;
+ no bareword::filehandles;
=head1 METHODS
=head2 import
-This method does the setup work described above in L</DESCRIPTION>
+This method does the setup work described above in L</DESCRIPTION>. Optionally
+accepts a C<version> option to request a specific version's behavior.
=head2 VERSION
projects / p5sagit/strictures.git / blobdiff