RT#83929: fix memory leak in union types

[gitmo/Moose.git] / lib / Moose / Meta / TypeConstraint / Union.pm

diff --git a/lib/Moose/Meta/TypeConstraint/Union.pm b/lib/Moose/Meta/TypeConstraint/Union.pm
index 410c622..0ee8165 100644 (file)
--- a/lib/Moose/Meta/TypeConstraint/Union.pm
+++ b/lib/Moose/Meta/TypeConstraint/Union.pm
@@ -29,7 +29,7 @@ sub new {
         %options,
     );
 
-    $self->_set_constraint(sub { $self->check($_[0]) });
+    $self->_set_constraint( $self->_compiled_type_constraint );
 
     return $self;
 }
@@ -131,14 +131,13 @@ sub equals {
 sub parent {
     my $self = shift;
 
-    my @tcs = @{ $self->type_constraints };
+    my ($first, @rest) = @{ $self->type_constraints };
 
-    my $deepest
-        = ( sort { $a->_ancestor_count <=> $b->_ancestor_count } @tcs )[-1];
-
-    for my $parent ( $deepest->_collect_all_parents ) {
-        return $parent if all { $_->is_a_type_of($parent) } @tcs;
+    for my $parent ( $first->_collect_all_parents ) {
+        return $parent if all { $_->is_a_type_of($parent) } @rest;
     }
+
+    return;
 }
 
 sub validate {