use strict;
use warnings;
-our $VERSION = '0.15_02';
+our $VERSION = '0.19';
our $C3_IN_CORE;
our $C3_XS;
BEGIN {
- eval "require mro"; # XXX in the future, this should be a version check
- if($@) {
- die $@ if $@ !~ /locate/;
+ if($] > 5.009_004) {
+ $C3_IN_CORE = 1;
+ require mro;
+ }
+ else {
eval "require Class::C3::XS";
- if($@) {
- die $@ if $@ !~ /locate/;
- eval "require Algorithm::C3; require Class::C3::next";
- die $@ if $@;
+ my $error = $@;
+ if(!$error) {
+ $C3_XS = 1;
}
else {
- $C3_XS = 1;
+ die $error if $error !~ /\blocate\b/;
+ require Algorithm::C3;
+ require Class::C3::next;
}
}
- else {
- $C3_IN_CORE = 1;
- }
}
# this is our global stash of both
## initializers
+# This prevents silly warnings when Class::C3 is
+# used explicitly along with MRO::Compat under 5.9.5+
+
+{ no warnings 'redefine';
+
sub initialize {
%next::METHOD_CACHE = ();
# why bother if we don't have anything ...
sub reinitialize { goto &initialize }
+} # end of "no warnings 'redefine'"
+
## functions for applying C3 to classes
sub _calculate_method_dispatch_tables {
no strict 'refs';
my @MRO = calculateMRO($class, $merge_cache);
$MRO{$class} = { MRO => \@MRO };
- my $has_overload_fallback = 0;
+ my $has_overload_fallback;
my %methods;
# NOTE:
# we do @MRO[1 .. $#MRO] here because it
# have use "fallback", then we want to
# grab that value
$has_overload_fallback = ${"${local}::()"}
- if defined ${"${local}::()"};
+ if !defined $has_overload_fallback && defined ${"${local}::()"};
foreach my $method (grep { defined &{"${local}::$_"} } keys %{"${local}::"}) {
# skip if already overriden in local class
next unless !defined *{"${class}::$method"}{CODE};
my $class = shift;
no strict 'refs';
${"${class}::()"} = $MRO{$class}->{has_overload_fallback}
- if $MRO{$class}->{has_overload_fallback};
+ if !defined &{"${class}::()"}
+ && defined $MRO{$class}->{has_overload_fallback};
foreach my $method (keys %{$MRO{$class}->{methods}}) {
if ( $method =~ /^\(/ ) {
my $orig = $MRO{$class}->{methods}->{$method}->{orig};
return if $C3_IN_CORE;
foreach my $class (keys %MRO) {
_remove_method_dispatch_table($class);
- }
+ }
}
sub _remove_method_dispatch_table {
delete ${"${class}::"}{$method}
if defined *{"${class}::${method}"}{CODE} &&
(*{"${class}::${method}"}{CODE} eq $MRO{$class}->{methods}->{$method}->{code});
- }
+ }
}
sub calculateMRO {
}, $merge_cache);
}
-sub _core_calculateMRO { @{mro::get_linear_isa($_[0])} }
+# Method overrides to support 5.9.5+ or Class::C3::XS
+
+sub _core_calculateMRO { @{mro::get_linear_isa($_[0], 'c3')} }
if($C3_IN_CORE) {
no warnings 'redefine';
elsif($C3_XS) {
no warnings 'redefine';
*Class::C3::calculateMRO = \&Class::C3::XS::calculateMRO;
+ *Class::C3::_calculate_method_dispatch_table
+ = \&Class::C3::XS::_calculate_method_dispatch_table;
}
1;
D->can('hello')->(); # can() also works correctly
UNIVERSAL::can('D', 'hello'); # as does UNIVERSAL::can()
-=head1 SPECIAL NOTE FOR 0.15_01
-
-To try this with the experimental perl core c3 patch,
-download a recent copy perl-current:
-
-http://mirrors.develooper.com/perl/APC/perl-current-snap/perl-current@30943.tar.bz2
-
-apply the enclosed c3.patch, and install this perl:
-
-sh Configure -Dusedevel -Dprefix=/where/I/want/it -d -e && make && make test && make install
-
-then try your C3-using software against this perl + Class::C3 0.15_01.
-
=head1 DESCRIPTION
This is pragma to change Perl 5's standard method resolution order from depth-first left-to-right
=head1 COMPATIBILITY
-If your software requires Perl 5.9.5 or higher, you do not need L<Class::C3>, you can simple C<use mro 'c3'>, and not worry about C<initialize()>, avoid some of the above caveats, and get the best possible performance. See L<mro> for more details.
+If your software requires Perl 5.9.5 or higher, you do not need L<Class::C3>, you can simply C<use mro 'c3'>, and not worry about C<initialize()>, avoid some of the above caveats, and get the best possible performance. See L<mro> for more details.
If your software is meant to work on earlier Perls, use L<Class::C3> as documented here. L<Class::C3> will detect Perl 5.9.5+ and take advantage of the core support when available.
=head1 CODE COVERAGE
-I use B<Devel::Cover> to test the code coverage of my tests, below is the B<Devel::Cover> report on this
-module's test suite.
-
- ---------------------------- ------ ------ ------ ------ ------ ------ ------
- File stmt bran cond sub pod time total
- ---------------------------- ------ ------ ------ ------ ------ ------ ------
- Class/C3.pm 98.3 84.4 80.0 96.2 100.0 98.4 94.4
- ---------------------------- ------ ------ ------ ------ ------ ------ ------
- Total 98.3 84.4 80.0 96.2 100.0 98.4 94.4
- ---------------------------- ------ ------ ------ ------ ------ ------ ------
+L<Devel::Cover> was reporting 94.4% overall test coverage earlier in this module's life. Currently, the test suite does things that break under coverage testing, but it is fair to assume the coverage is still close to that value.
=head1 SEE ALSO
projects / gitmo/Class-C3.git / blobdiff