12 years agoimprovements for MSSQL driver via DBD::ADO
Rafael Kitover [Sun, 18 Mar 2012 06:33:54 +0000]
improvements for MSSQL driver via DBD::ADO

Various improvements and bug fixes:

 - Fix transaction support by changing CursorLocation on connection to
   adUseClient.

 - Support for VARCHAR(MAX)/VARBINARY(MAX)/NVARCHAR(MAX), add a catch
   for size => 'max' in _dbi_attrs_for_bind to set the ado_size workaround
   to LongReadLen, add a mapping to the data_type for literal
   'varchar(max)' entries as well. Tests for these types have been added
   as well.

 - Set $dbh->{LongReadLen} * 2 + 1 on connection, necessary for some LOB
   types.

 - Remove trailing null padding from BINARY/VARBINARY/IMAGE data via a
   custom Cursor class.

 - uniqueidentifier brace removal from data returned from ADO via Cursor
   class and re-addition via _dbi_attrs_for_bind and insert_bulk
   override for data sent to ADO.

 - Add type mappings for some missing MSSQL types and the types from other
   databases for cross-deployment.

 - Full set of tests, stolen from the MS Access tests, for savepoints,
   LOB support and GUIDs.

The trailing null padding and GUID brace removal is in utilities in
::DBI::ADO::CursorUtils which both ::DBI::ADO::MS_Jet (Access) and this
driver use, in their respective Cursor classes and in the drivers
themselves in select_single.

12 years agoThe cursor class is now autoloaded due to CAG component_class acc. group
Rafael Kitover [Sun, 18 Mar 2012 06:33:54 +0000]
The cursor class is now autoloaded due to CAG component_class acc. group

12 years agoFix auto-pk for Sybase ASE, broken by refactoring in fabbd5cc
Rafael Kitover [Thu, 29 Mar 2012 22:01:11 +0000]
Fix auto-pk for Sybase ASE, broken by refactoring in fabbd5cc

Was returning arrayref due to missing arrow, tests were passing because
arrayref numifies. Added a test that catches this.

12 years agoAdd all database connections via DBICTest::Schema to the leaktrace pool
Peter Rabbitson [Mon, 26 Mar 2012 03:11:24 +0000]
Add all database connections via DBICTest::Schema to the leaktrace pool

12 years agoFix thinkos from bfec318f and 3edfebff
Rafael Kitover [Sat, 24 Mar 2012 04:07:41 +0000]
Fix thinkos from bfec318f and 3edfebff

12 years agoDisable ODBC batch ops for Access, they are broken
Rafael Kitover [Sat, 24 Mar 2012 04:07:41 +0000]
Disable ODBC batch ops for Access, they are broken

12 years agoSome minor POD corrections
Brendan Byrd [Fri, 23 Mar 2012 15:09:04 +0000]
Some minor POD corrections

Apply very small doc correction to search_related
Fix incorrect last_modified / update comparison in ::Row/update
Add more direct documentation of grandparent methods in DBIC::Core

12 years agosupport FreeTDS 0.91 with Sybase ASE + DBD::Sybase
Rafael Kitover [Fri, 23 Mar 2012 13:04:53 +0000]
support FreeTDS 0.91 with Sybase ASE + DBD::Sybase

Requires disabling statement caching.

12 years agodisable batch ops for firebird ODBC driver
Rafael Kitover [Fri, 23 Mar 2012 18:27:10 +0000]
disable batch ops for firebird ODBC driver

12 years agomake carp_once register messages not just callsite
Rafael Kitover [Fri, 23 Mar 2012 17:37:27 +0000]
make carp_once register messages not just callsite

Add a test as well in t/106dbic_carp.t .

12 years agoAppease DBD::Sybase compiled with new freetds
Rafael Kitover [Thu, 22 Mar 2012 11:41:47 +0000]
Appease DBD::Sybase compiled with new freetds

12 years agoAs shitty as freetds is, it seems they at least got MARS right
Rafael Kitover [Thu, 22 Mar 2012 11:41:47 +0000]
As shitty as freetds is, it seems they at least got MARS right

12 years agoCentralize (and privatize) handling of freetds driver/version detection
Peter Rabbitson [Fri, 23 Mar 2012 09:38:18 +0000]
Centralize (and privatize) handling of freetds driver/version detection

12 years agoMultiple cleanups to accommodate broken FreeTDS driver
Peter Rabbitson [Tue, 20 Mar 2012 05:49:33 +0000]
Multiple cleanups to accommodate broken FreeTDS driver

- Disable batch operations entirely (can get as bad as silent insert failures)
- Disable SELECT SCOPE_IDENTITY generation when used with dynamic cursors
- Clean some warnings while we're at it

12 years agoFix pessimization of offset-less Oracle limits, introduced in 6a6394f1
Peter Rabbitson [Thu, 22 Mar 2012 07:44:33 +0000]
Fix pessimization of offset-less Oracle limits, introduced in 6a6394f1

When there is only one RowNum operator, stability of the order is not relevant

12 years agoRequire bugfixed Module::Install
Peter Rabbitson [Thu, 22 Mar 2012 08:48:33 +0000]
Require bugfixed Module::Install

12 years agoRemove all "magic number" DBI get_info calls from the codebase
Peter Rabbitson [Thu, 22 Mar 2012 08:42:24 +0000]
Remove all "magic number" DBI get_info calls from the codebase

12 years agoReplace all use of wantarray tri-calls with explicit return or preserve_context
Peter Rabbitson [Thu, 22 Mar 2012 08:06:04 +0000]
Replace all use of wantarray tri-calls with explicit return or preserve_context

12 years agoPassing test for mssql odbc bulk insert bug fixed by fabbd5cca9
Wes Malone [Tue, 29 Mar 2011 23:46:02 +0000]
Passing test for mssql odbc bulk insert bug fixed by fabbd5cca9

12 years agoFactor out IDENTITY_INSERT for Sybase ASE and MSSQL into a component
Rafael Kitover [Wed, 18 May 2011 09:45:47 +0000]
Factor out IDENTITY_INSERT for Sybase ASE and MSSQL into a component

This not only greatly simplifies the code of multiple storages, but the
reduction of identity retrieval calls fixes multiple issues with some
odd driver combinations.

12 years agoRun the sybase C subtest *after* the main test
Peter Rabbitson [Tue, 20 Mar 2012 03:14:53 +0000]
Run the sybase C subtest *after* the main test

12 years agoRemove todoified tests reflecting a conceptual brainfart
Peter Rabbitson [Tue, 20 Mar 2012 03:12:06 +0000]
Remove todoified tests reflecting a conceptual brainfart

12 years agoMake sure do_query retries on potentially disconnected $dbh
Peter Rabbitson [Sun, 18 Mar 2012 19:29:46 +0000]
Make sure do_query retries on potentially disconnected $dbh

12 years agoMove Oracle blob tests into separate file (no functional changes!)
Peter Rabbitson [Mon, 30 Jan 2012 11:08:54 +0000]
Move Oracle blob tests into separate file (no functional changes!)

12 years agoremove some Win32 workarounds in tests from cygwin
Rafael Kitover [Sat, 17 Mar 2012 00:24:36 +0000]
remove some Win32 workarounds in tests from cygwin

Cygwin can delete open files, so change some workarounds we had in tests
for closing open files before deleting them that were for both MSWin32
and cygwin to be for MSWin32 only.

12 years agobase.pm now repeatedly require()s modules, exposing missing Exporter exemption
Peter Rabbitson [Sat, 17 Mar 2012 10:28:11 +0000]
base.pm now repeatedly require()s modules, exposing missing Exporter exemption

12 years agoAdd all storage instances to the test suite leaktracing pool
Peter Rabbitson [Wed, 14 Mar 2012 12:40:44 +0000]
Add all storage instances to the test suite leaktracing pool

12 years agoFix leak of oracle storage objects in its _dbh_execute override
Peter Rabbitson [Wed, 14 Mar 2012 12:40:44 +0000]
Fix leak of oracle storage objects in its _dbh_execute override

Replace with a much cleaner (and leak free) blockrunner instance

12 years agoFix the pure-perl in_global_destruction() emulation under threads
Peter Rabbitson [Wed, 14 Mar 2012 12:40:44 +0000]
Fix the pure-perl in_global_destruction() emulation under threads

Also it seems that threads just don't work too well on < 5.8.5, ajust
the skip message to reflect this.

12 years agoMake sure we load threads.pm before Test::More
Peter Rabbitson [Wed, 14 Mar 2012 12:40:44 +0000]
Make sure we load threads.pm before Test::More

12 years agoremoved unnecessary use of Test::Exception
Alexander Hartmaier [Fri, 16 Mar 2012 12:08:14 +0000]
removed unnecessary use of Test::Exception

ack -l Test::Exception t/ | xargs egrep -L 'lives_ok|dies_ok|throws_ok|lives_and'

12 years agoAdjust tests to work correctly with the upcoming Test::Builder 1.005
Peter Rabbitson [Tue, 29 Nov 2011 06:31:21 +0000]
Adjust tests to work correctly with the upcoming Test::Builder 1.005

Also deduplicate code in the persistence runners of t/52leaks.t

12 years agofix Win32 file use error in t/storage/reconnect.t
Rafael Kitover [Tue, 13 Mar 2012 17:57:27 +0000]
fix Win32 file use error in t/storage/reconnect.t

Even though the fake SQLite db file is chmod 0000, for some reason
SQLite still opens it on Win32 and holds it open; this prevents deleting
it and replacing it with the original db file so that the rest of the
tests can run.

TODO: followup with the DBD::SQLite folks.

Disconnect the $dbh on Win32 so the unlink can succeed, and remove the
following SKIP: block (for if db is "encrypted") which is no longer
necessary.

12 years agoUpdate t/751msaccess.t broken by leak checker 65d35121
Rafael Kitover [Mon, 12 Mar 2012 21:00:04 +0000]
Update t/751msaccess.t broken by leak checker 65d35121

Can't have the cleanup sub close over $schema.

12 years agoadd SQLT dep if DBICTEST_SQLT_DEPLOY env is set
Rafael Kitover [Sun, 11 Mar 2012 20:56:53 +0000]
add SQLT dep if DBICTEST_SQLT_DEPLOY env is set

Add some code to Makefile.PL to check for $ENV{DBICTEST_SQLT_DEPLOY},
which if set requires SQL::Translator to be available or the tests
will fail. Add the dep as a test_requires directly, so that it is
scrubbed out of the META.yml in author mode due to not being in the
$test_requires hash.

12 years agomaking config flags actually recognize config files
Eden Cardim [Tue, 28 Feb 2012 12:23:57 +0000]
making config flags actually recognize config files

12 years agoFix t/inflate/datetime.t warning on older perls
Peter Rabbitson [Mon, 12 Mar 2012 06:48:29 +0000]
Fix t/inflate/datetime.t warning on older perls

12 years agoFix failures with DBICTEST_SQLITE_USE_FILE=1 introduced by 50261284
Peter Rabbitson [Mon, 12 Mar 2012 06:47:10 +0000]
Fix failures with DBICTEST_SQLITE_USE_FILE=1 introduced by 50261284

12 years agoTest suite wide leaktesting
Peter Rabbitson [Tue, 14 Feb 2012 22:05:04 +0000]
Test suite wide leaktesting

12 years agoRewrite txn_do and dbh_do to use a (hidden for now) blockrunner
Peter Rabbitson [Fri, 9 Dec 2011 16:35:53 +0000]
Rewrite txn_do and dbh_do to use a (hidden for now) blockrunner

12 years agoFix more $schema leaks in the SQLT DBIC Parser (AUGHHHHH!!!!)
Peter Rabbitson [Tue, 14 Feb 2012 22:05:04 +0000]
Fix more $schema leaks in the SQLT DBIC Parser (AUGHHHHH!!!!)

12 years agoAdd a TODO test for a very elaborate stack leak scenario
Peter Rabbitson [Tue, 14 Feb 2012 22:05:04 +0000]
Add a TODO test for a very elaborate stack leak scenario

12 years agoFix fallout from a807d012 (folks please run your podtests when hacking POD)
Peter Rabbitson [Fri, 9 Mar 2012 03:40:28 +0000]
Fix fallout from a807d012 (folks please run your podtests when hacking POD)

- Stray =end in DBIC/DB.pm
- Inadvertently hidden documentation of txn_scope_guard
  (the =for comment never applied to the POD-block previously)

12 years agoMinor messing with syntactically incorrect POD (no =headX blocks inside =begin, and...
Jess Robinson [Wed, 7 Mar 2012 17:10:18 +0000]
Minor messing with syntactically incorrect POD (no =headX blocks inside =begin, and =for is a one-paragraph block)

12 years agoSimplify code of GenericSubQ limit dialect
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Simplify code of GenericSubQ limit dialect

12 years agoSome cleanups and code dedup of Top and FetchFirst limit dialects
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Some cleanups and code dedup of Top and FetchFirst limit dialects

Relax requirement of having a primary key declared on table

12 years agoimplemented _collapse_result and _merge_result
Moritz Onken [Wed, 12 Jan 2011 16:56:48 +0000]
implemented _collapse_result and _merge_result

fixed inflate_result and some calling arguments

12 years agoFunctional row-parse generator - really works!!!
Peter Rabbitson [Wed, 4 Aug 2010 12:06:43 +0000]
Functional row-parse generator - really works!!!

12 years agoSimplify RowNumber Over limit dialect implementation
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Simplify RowNumber Over limit dialect implementation

12 years agoDeduplicate code in rownum limit emulation
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Deduplicate code in rownum limit emulation

Use the RSRC unique constraint traversal to determine if an order_by is stable

12 years agoDeduplicate code in RSC, use the RSRC unique constraint traversal instead
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Deduplicate code in RSC, use the RSRC unique constraint traversal instead

12 years agoAdd an internal unique colset finder and relax complex $rs update/delete code
Peter Rabbitson [Sat, 25 Feb 2012 14:36:43 +0000]
Add an internal unique colset finder and relax complex $rs update/delete code

As long as there is something to correlate the subquery by we are good

12 years agoRemove the "row-by-row shift" Ordered.pm pessimization
Peter Rabbitson [Fri, 2 Mar 2012 10:41:42 +0000]
Remove the "row-by-row shift" Ordered.pm pessimization

The idea this is necessary was born when working with buggy old 1.1x
SQLite versions back in 2008. This no longer seems to be necessary,
but if I am wrong we can always bring it back with an actual
storage capability flag

12 years agoFix embarrassing leak triggered on calling new_related on an uninserted object
Peter Rabbitson [Tue, 14 Feb 2012 22:05:04 +0000]
Fix embarrassing leak triggered on calling new_related on an uninserted object

Reason is a typo-ed hash element in a weaken() call back in 68f3b0dd. Add a
bunch of extra tests to catch this, and also better validate the new_related
behavior.

12 years agoFix rogue child disconnecting a parent $dbh - no idea how I even missed that
Peter Rabbitson [Fri, 17 Feb 2012 11:54:09 +0000]
Fix rogue child disconnecting a parent $dbh - no idea how I even missed that

12 years agoMajorly cleanup $rs->update/delete (no $rs-aware code should be in ::Storages)
Peter Rabbitson [Mon, 31 May 2010 22:26:39 +0000]
Majorly cleanup $rs->update/delete (no $rs-aware code should be in ::Storages)

12 years agoOverhaul of variable \[] handling in populate, and a lot of extra tests
Peter Rabbitson [Sat, 10 Dec 2011 23:51:12 +0000]
Overhaul of variable \[] handling in populate, and a lot of extra tests

Now things like multi-value \[ ' ? || ?', [...], [...] ] and populate
datasets where the values of the \[] change per row work correctly

12 years agoSwitch from using execute_array to execute_for_fetch directly
Peter Rabbitson [Sat, 10 Dec 2011 23:44:37 +0000]
Switch from using execute_array to execute_for_fetch directly

This saves us from pivoting our data into column slices, which execute_array
promptly turns back into our initial row-based format to feed to
execute_for_fetch. Apart from the obvious speed gain, this saves a lot of
memory since it avoids 2 copies of the (possibly rather large) dataset

12 years agoFix ASE bulk_insert for bind changes in 0e773352
Peter Rabbitson [Sun, 11 Dec 2011 20:15:05 +0000]
Fix ASE bulk_insert for bind changes in 0e773352

When using the bulk API, update the binds to the structure expected by
_execute_array. Also temporarily disable $sth->finish in the bulk API
codepath because for some reason it rolls everything back. Modify the
test to always exercise both codepaths from now on.

12 years agoFactor out bindattr resolver and tighten code a bit
Peter Rabbitson [Sat, 10 Dec 2011 22:50:36 +0000]
Factor out bindattr resolver and tighten code a bit

Zero functional changes

12 years agoAllow users to disable the "DT in search" warning introduced in e1038213
Peter Rabbitson [Fri, 3 Feb 2012 08:31:27 +0000]
Allow users to disable the "DT in search" warning introduced in e1038213

12 years agoShuffle things around, maint/ is now a proper toolchain tooldir
Peter Rabbitson [Sat, 4 Feb 2012 21:27:51 +0000]
Shuffle things around, maint/ is now a proper toolchain tooldir

12 years agoNormalize -'s and _'s in maint names and Makefile options
Peter Rabbitson [Sat, 4 Feb 2012 16:19:27 +0000]
Normalize -'s and _'s in maint names and Makefile options

12 years agoremove stale link and doc readonly pool queries
Caleb Cushing [Thu, 2 Feb 2012 21:25:44 +0000]
remove stale link and doc readonly pool queries

transactions cause an implicit force to master, this documents how you can
override this to force to pool

Signed-off-by: Caleb Cushing <xenoterracide@gmail.com>

12 years agoadd a link to SQL::Abstract for WHERE clauses
Caleb Cushing [Thu, 2 Feb 2012 20:50:43 +0000]
add a link to SQL::Abstract for WHERE clauses

Signed-off-by: Caleb Cushing <xenoterracide@gmail.com>

12 years agoFix forgotten whitespace - this is what I get for no prove xt
Peter Rabbitson [Mon, 30 Jan 2012 10:33:12 +0000]
Fix forgotten whitespace - this is what I get for no prove xt

12 years agoOnly invoke the author Makefile.PL includes if we are not part of a `make` run
Peter Rabbitson [Mon, 30 Jan 2012 08:45:55 +0000]
Only invoke the author Makefile.PL includes if we are not part of a `make` run

12 years agoComment typo
Matt Phillips [Mon, 30 Jan 2012 02:17:52 +0000]
Comment typo

12 years agoForgotten diag and some clarifications of fc4b0448
Peter Rabbitson [Sun, 29 Jan 2012 12:37:08 +0000]
Forgotten diag and some clarifications of fc4b0448

12 years agoFactor out the Makefile.PL into easily digestable snippets
Peter Rabbitson [Tue, 24 Jan 2012 11:47:44 +0000]
Factor out the Makefile.PL into easily digestable snippets

Also add explicit guard for attempts to `make dist` from within non-author mode.
The rationale is to disallow dist building on machines that do not have the optdeps
installed (this still does not giarantee `make test` will run, but is at least a
nudge in the right direction)

12 years agoAssert that complex bindtytyping passage works for the search() bind attribute
Peter Rabbitson [Thu, 26 Jan 2012 11:11:15 +0000]
Assert that complex bindtytyping passage works for the search() bind attribute

12 years agouse more correct subsection links in POD
Graham Knop [Tue, 17 Jan 2012 17:18:43 +0000]
use more correct subsection links in POD

12 years agoremove ::Storage::DBI::sth from POD as it should never have been public
Graham Knop [Tue, 17 Jan 2012 17:25:49 +0000]
remove ::Storage::DBI::sth from POD as it should never have been public

12 years agofix PrettyPrint package link in POD
Graham Knop [Tue, 17 Jan 2012 17:22:00 +0000]
fix PrettyPrint package link in POD

12 years agocorrect organization for SQLite POD
Graham Knop [Tue, 17 Jan 2012 17:20:34 +0000]
correct organization for SQLite POD

12 years agoissue warning for DateTimes passed to ->search
Rafael Kitover [Wed, 18 Jan 2012 14:56:18 +0000]
issue warning for DateTimes passed to ->search

Issue a carp_unique when DateTime objects are detected in binds in
::Storage::DBI with a pointer to the Cookbook recipe for formatting
DateTime objects for queries.

Add a test for the warning in t/inflate/datetime.t, which already has
TODO tests for DTs in ->search.

12 years agoadd POD on how to use Moose in custom ResultSets
Rafael Kitover [Tue, 10 Jan 2012 21:56:03 +0000]
add POD on how to use Moose in custom ResultSets

Thanks to mst for providing the relevant info.

12 years agoTrailing WS crusade - got to save them bits
Peter Rabbitson [Thu, 5 Jan 2012 02:59:41 +0000]
Trailing WS crusade - got to save them bits

12 years agoAdd link to SQLHackers documentation
Jess Robinson [Fri, 9 Dec 2011 17:00:45 +0000]
Add link to SQLHackers documentation

12 years ago- Fix typo (s/get_colum/get_column).
Brad Davis [Wed, 4 Jan 2012 04:52:02 +0000]
- Fix typo (s/get_colum/get_column).

12 years agouse Path::Class for finding subdirs of t and don't use global filehandle for slurping
Alexander Hartmaier [Tue, 3 Jan 2012 12:00:47 +0000]
use Path::Class for finding subdirs of t and don't use global filehandle for slurping

12 years agorefactored HashRefInflators internals
Alexander Hartmaier [Wed, 14 Dec 2011 10:15:44 +0000]
refactored HashRefInflators internals

12 years agoRewrite the HRI bench to produce consistent numbers with less handholding
Peter Rabbitson [Mon, 19 Dec 2011 05:55:18 +0000]
Rewrite the HRI bench to produce consistent numbers with less handholding

- Now we auto-pull from git what we want to benchmark (by default last
  2 commits + uncommitted changes if any)
- Run a very tight benchmarking loop, without requerying SQLite or have
  any other unrelated distractions
- use DumbBench (much saner implementation and results, though slower)

12 years agoAdd live Firebird test for paging fix 8b31f62e
Rafael Kitover [Thu, 1 Dec 2011 17:29:51 +0000]
Add live Firebird test for paging fix 8b31f62e

12 years agoFix and test first_skip/skip_first limit dialects
Peter Rabbitson [Thu, 1 Dec 2011 16:50:57 +0000]
Fix and test first_skip/skip_first limit dialects

Codebase didn't take in account the fact that limit bindvals for
SELECT FIRST x SKIP y and SELECT FIRST x SKIP y need to be inserted
at the head of the bind-assembly chain. Hence introducing a new
bind-chunk position 'pre_select'. While at it move the TOP dialect
to use it as well.

Extensive tests for both dialects, and also augment the test for
the Oracle RowNum dialect (no fixes necessary)

12 years agoStandardize hobbs' email address
Peter Rabbitson [Tue, 29 Nov 2011 06:00:23 +0000]
Standardize hobbs' email address

12 years agoRelease 0.08196 v0.08196
Andrew Rodland [Tue, 29 Nov 2011 05:34:15 +0000]
Release 0.08196

12 years agoMore test fixes following 4a425300 and new DBD::SQLite release
Peter Rabbitson [Tue, 29 Nov 2011 05:31:45 +0000]
More test fixes following 4a425300 and new DBD::SQLite release

12 years agoFix some logic pitfalls in the require tracer
Peter Rabbitson [Sat, 26 Nov 2011 10:00:53 +0000]
Fix some logic pitfalls in the require tracer

12 years agoFix the join/prefetch resolver when dealing with ''/undef/()
Peter Rabbitson [Sat, 26 Nov 2011 01:41:16 +0000]
Fix the join/prefetch resolver when dealing with ''/undef/()

12 years agoModifying links to /condition to point to DBIC::Relationship::Base
Peter Valdemar Mørch [Tue, 2 Aug 2011 18:18:17 +0000]
Modifying links to /condition to point to DBIC::Relationship::Base

Because that is where the condition description is to be found

12 years agoFix copyright... in November
Peter Rabbitson [Fri, 25 Nov 2011 23:22:17 +0000]
Fix copyright... in November

12 years agoMake both pg and mysql execute t/98savepoints.t if present
Peter Rabbitson [Fri, 25 Nov 2011 23:20:16 +0000]
Make both pg and mysql execute t/98savepoints.t if present

12 years agoMake tests pass with DBIC_TRACE and DBIC_TRACE_PROFILE set
Peter Rabbitson [Fri, 25 Nov 2011 23:01:46 +0000]
Make tests pass with DBIC_TRACE and DBIC_TRACE_PROFILE set

12 years agoFix TxnScopeGuard misbehaving on externally set $@ without inner exceptions
Peter Rabbitson [Fri, 25 Nov 2011 22:20:44 +0000]
Fix TxnScopeGuard misbehaving on externally set $@ without inner exceptions

The guard is supposed to warn when it goes out of scope without a commit.
However this doesn't work if $@ was already set before the guard was created
and there were no eval{}s to clear it between definition and destruction.

Fixing this by storing a weakref to the current exception (if any) and
disregarding the contents of $@ if they match the ref we started with.

12 years agoAbstract away the CORE::GLOBAL::require override code, foolproof tests
Peter Rabbitson [Thu, 24 Nov 2011 17:38:09 +0000]
Abstract away the CORE::GLOBAL::require override code, foolproof tests

Rewrite prompted by some weirdness in Package::Stash::XS and require overrides
on older perls < 5.8.7. Besides the cleaner code add a kick-ass require
tracer.

12 years agoMore robust test suite skip-checks, check ENV before loading modules
Peter Rabbitson [Fri, 25 Nov 2011 10:44:16 +0000]
More robust test suite skip-checks, check ENV before loading modules

12 years agoSwitch the nobindvars test from MySQL to the always available SQLite
Peter Rabbitson [Fri, 25 Nov 2011 10:35:00 +0000]
Switch the nobindvars test from MySQL to the always available SQLite

12 years agoSkip error/warn frames within CAG - saner callsite error messages this way
Peter Rabbitson [Tue, 23 Aug 2011 14:10:09 +0000]
Skip error/warn frames within CAG - saner callsite error messages this way

12 years agoDocumented $resultsource->name
Mark A. Stratman [Tue, 14 Jun 2011 17:48:34 +0000]
Documented $resultsource->name