14 years ago::DBI::Replicated - don't build pool/balancer from connect_info unless necessary
Rafael Kitover [Sat, 9 May 2009 12:21:44 +0000]
::DBI::Replicated - don't build pool/balancer from connect_info unless necessary

14 years agoupdated Changes
Rafael Kitover [Sat, 9 May 2009 11:52:52 +0000]
updated Changes

14 years agoMerge 'trunk' into 'storage-tweaks'
Peter Rabbitson [Sat, 9 May 2009 11:07:13 +0000]
Merge 'trunk' into 'storage-tweaks'

r6127@Thesaurus (orig r6126):  arcanez | 2009-05-05 09:27:56 +0200
 r6037@mullet (orig r6036):  arcanez | 2009-04-30 01:24:41 -0700
 branch to work on Sybase/MSSQL subtleties
 r6038@mullet (orig r6037):  arcanez | 2009-04-30 01:27:11 -0700
 jump to ::DBI::Sybase::MSSQL if we are using MSSQL through Sybase
 r6062@mullet (orig r6061):  arcanez | 2009-04-30 14:05:24 -0700
 fixes for MSSQL via Sybase
 r6126@mullet (orig r6125):  arcanez | 2009-05-05 00:27:13 -0700
 add a line to Changes and add a CAVEAT

r6164@Thesaurus (orig r6163):  ribasushi | 2009-05-07 19:09:01 +0200
 r6115@Thesaurus (orig r6114):  plu | 2009-05-03 10:39:16 +0200
 new branch to fix $rs->update and $rs->delete using the new as_query method

 r6116@Thesaurus (orig r6115):  plu | 2009-05-03 10:52:07 +0200
 Methods update/delete on resultset use now new as_query method to updated/delete properly on joined/prefetched resultset using a subquery. Therefore some tests have been added and some have been changed as well as the warnings around $rs->update/delete have been removed. Cheers!
 r6117@Thesaurus (orig r6116):  plu | 2009-05-03 11:13:48 +0200
 Using "is" instead of "cmp_ok"
 r6160@Thesaurus (orig r6159):  ribasushi | 2009-05-07 11:58:14 +0200
 Back out skip_parens support in as_query
 r6161@Thesaurus (orig r6160):  ribasushi | 2009-05-07 19:00:48 +0200
 This test is completely borked, needs a rewrite
 r6162@Thesaurus (orig r6161):  ribasushi | 2009-05-07 19:07:19 +0200
 Temporary fix or the IN ( ( ... ) ) problem until we get proper SQLA AST (needs SQLA released with commit 6158 to work)

r6165@Thesaurus (orig r6164):  ribasushi | 2009-05-07 19:11:46 +0200
Changes, remove merged branch
r6169@Thesaurus (orig r6168):  ribasushi | 2009-05-07 19:24:54 +0200
Bump SQLA dependency so -in/-between workarounds overload properly
r6172@Thesaurus (orig r6171):  ribasushi | 2009-05-07 20:49:26 +0200
Cookbook cleanup
r6174@Thesaurus (orig r6173):  ribasushi | 2009-05-08 10:13:30 +0200
Throw away some debugging code
r6175@Thesaurus (orig r6174):  ribasushi | 2009-05-08 10:21:53 +0200
Documentation patch by nniuq
r6176@Thesaurus (orig r6175):  plu | 2009-05-08 10:30:20 +0200
Set NLS_LANG so we  have a predictable date format when using MON
r6177@Thesaurus (orig r6176):  ribasushi | 2009-05-08 12:15:15 +0200
Fix POD
r6179@Thesaurus (orig r6178):  jgoulah | 2009-05-08 16:27:49 +0200
renaming rh performance test so it will show up at the end of test output

14 years ago::DBI::Replicated - fix fallback to master, test for the warning, other cleanups
Rafael Kitover [Sat, 9 May 2009 10:50:25 +0000]
::DBI::Replicated - fix fallback to master, test for the warning, other cleanups

14 years ago::DBI::Replicated - add master_read_weight to ::Random balancer_type
Rafael Kitover [Sat, 9 May 2009 03:31:15 +0000]
::DBI::Replicated - add master_read_weight to ::Random balancer_type

14 years agosupport ::DBI::Replicated opts in connect_info
Rafael Kitover [Fri, 8 May 2009 16:08:29 +0000]
support ::DBI::Replicated opts in connect_info

14 years agorenaming rh performance test so it will show up at the end of test output
John Goulah [Fri, 8 May 2009 14:27:49 +0000]
renaming rh performance test so it will show up at the end of test output

14 years agoFix POD
Peter Rabbitson [Fri, 8 May 2009 10:15:15 +0000]
Fix POD

14 years agoSet NLS_LANG so we have a predictable date format when using MON
Johannes Plunien [Fri, 8 May 2009 08:30:20 +0000]
Set NLS_LANG so we  have a predictable date format when using MON

14 years agoDocumentation patch by nniuq
Peter Rabbitson [Fri, 8 May 2009 08:21:53 +0000]
Documentation patch by nniuq

14 years agoThrow away some debugging code
Peter Rabbitson [Fri, 8 May 2009 08:13:30 +0000]
Throw away some debugging code

14 years agoCookbook cleanup
Peter Rabbitson [Thu, 7 May 2009 18:49:26 +0000]
Cookbook cleanup

14 years agoBump SQLA dependency so -in/-between workarounds overload properly
Peter Rabbitson [Thu, 7 May 2009 17:24:54 +0000]
Bump SQLA dependency so -in/-between workarounds overload properly

14 years agoChanges, remove merged branch
Peter Rabbitson [Thu, 7 May 2009 17:11:46 +0000]
Changes, remove merged branch

14 years agoMerge 'fix-update-and-delete-as_query' into 'trunk'
Peter Rabbitson [Thu, 7 May 2009 17:09:01 +0000]
Merge 'fix-update-and-delete-as_query' into 'trunk'

14 years agoTemporary fix or the IN ( ( ... ) ) problem until we get proper SQLA AST (needs SQLA...
Peter Rabbitson [Thu, 7 May 2009 17:07:19 +0000]
Temporary fix or the IN ( ( ... ) ) problem until we get proper SQLA AST (needs SQLA released with commit 6158 to work)

14 years agoThis test is completely borked, needs a rewrite
Peter Rabbitson [Thu, 7 May 2009 17:00:48 +0000]
This test is completely borked, needs a rewrite

14 years agoBack out skip_parens support in as_query
Peter Rabbitson [Thu, 7 May 2009 09:58:14 +0000]
Back out skip_parens support in as_query

14 years ago::DBI:Replicated - merge connect_info from master to replicants
Rafael Kitover [Wed, 6 May 2009 13:29:39 +0000]
::DBI:Replicated - merge connect_info from master to replicants

14 years agoReplicated - fixup types and namespace::clean
Rafael Kitover [Wed, 6 May 2009 03:25:04 +0000]
Replicated - fixup types and namespace::clean

14 years agofix ::DBI::Replicated::all_storages
Rafael Kitover [Wed, 6 May 2009 03:13:56 +0000]
fix ::DBI::Replicated::all_storages

14 years agoMerge 'sybase_mssql' into 'trunk'
Justin Hunter [Tue, 5 May 2009 07:27:56 +0000]
Merge 'sybase_mssql' into 'trunk'

r6037@mullet (orig r6036):  arcanez | 2009-04-30 01:24:41 -0700
branch to work on Sybase/MSSQL subtleties
r6038@mullet (orig r6037):  arcanez | 2009-04-30 01:27:11 -0700
jump to ::DBI::Sybase::MSSQL if we are using MSSQL through Sybase
r6062@mullet (orig r6061):  arcanez | 2009-04-30 14:05:24 -0700
fixes for MSSQL via Sybase
r6126@mullet (orig r6125):  arcanez | 2009-05-05 00:27:13 -0700
add a line to Changes and add a CAVEAT

14 years agoadd a line to Changes and add a CAVEAT
Justin Hunter [Tue, 5 May 2009 07:27:13 +0000]
add a line to Changes and add a CAVEAT

14 years agoMerge 'trunk' into 'sybase_mssql'
Justin Hunter [Tue, 5 May 2009 07:09:18 +0000]
Merge 'trunk' into 'sybase_mssql'

r6110@mullet (orig r6109):  plu | 2009-05-02 12:11:40 -0700
Failing testcase for using subselect (as_query)
r6111@mullet (orig r6110):  ribasushi | 2009-05-02 17:00:19 -0700
Failing test without immediate fixes go to branches, not to trunk
r6114@mullet (orig r6113):  ribasushi | 2009-05-03 01:23:28 -0700
Bump SQLA ependencies so parenthesis_significant is guaranteed to be there

14 years ago::Replicated - test hashref for connect_replicants and croak on coderef, switch to...
Rafael Kitover [Mon, 4 May 2009 21:07:43 +0000]
::Replicated - test hashref for connect_replicants and croak on coderef, switch to MX::Types, make test less noisy

14 years agosupport hashrefs for connect_replicants
Rafael Kitover [Mon, 4 May 2009 18:07:47 +0000]
support hashrefs for connect_replicants

14 years agoUsing "is" instead of "cmp_ok"
Johannes Plunien [Sun, 3 May 2009 09:13:48 +0000]
Using "is" instead of "cmp_ok"

14 years agoMethods update/delete on resultset use now new as_query method to updated/delete...
Johannes Plunien [Sun, 3 May 2009 08:52:07 +0000]
Methods update/delete on resultset use now new as_query method to updated/delete properly on joined/prefetched resultset using a subquery. Therefore some tests have been added and some have been changed as well as the warnings around $rs->update/delete have been removed. Cheers!

14 years agoBump SQLA ependencies so parenthesis_significant is guaranteed to be there
Peter Rabbitson [Sun, 3 May 2009 08:23:28 +0000]
Bump SQLA ependencies so parenthesis_significant is guaranteed to be there

15 years agoFailing test without immediate fixes go to branches, not to trunk
Peter Rabbitson [Sun, 3 May 2009 00:00:19 +0000]
Failing test without immediate fixes go to branches, not to trunk

15 years agoFailing testcase for using subselect (as_query)
Johannes Plunien [Sat, 2 May 2009 19:11:40 +0000]
Failing testcase for using subselect (as_query)

15 years agoMerge 'trunk' into 'sybase_mssql'
Peter Rabbitson [Thu, 30 Apr 2009 06:28:04 +0000]
Merge 'trunk' into 'sybase_mssql'

r6039@mullet (orig r6038):  ribasushi | 2009-04-30 01:28:04 -0700
Release 0.08102

15 years agofixes for MSSQL via Sybase
Justin Hunter [Thu, 30 Apr 2009 21:05:24 +0000]
fixes for MSSQL via Sybase

15 years agoRelease 0.08102 v0.08102
Peter Rabbitson [Thu, 30 Apr 2009 08:28:04 +0000]
Release 0.08102

15 years agojump to ::DBI::Sybase::MSSQL if we are using MSSQL through Sybase
Justin Hunter [Thu, 30 Apr 2009 08:27:11 +0000]
jump to ::DBI::Sybase::MSSQL if we are using MSSQL through Sybase

15 years agobranch to work on Sybase/MSSQL subtleties
Justin Hunter [Thu, 30 Apr 2009 08:24:41 +0000]
branch to work on Sybase/MSSQL subtleties

15 years agoRevert addition of superficial relationship in r5886
Peter Rabbitson [Thu, 30 Apr 2009 08:12:23 +0000]
Revert addition of superficial relationship in r5886

15 years agoAdd tests for r6002
Peter Rabbitson [Thu, 30 Apr 2009 06:53:51 +0000]
Add tests for r6002

15 years agoadd jasonmay to list of contributors
Jason May [Wed, 29 Apr 2009 16:47:26 +0000]
add jasonmay to list of contributors

15 years agoallow multiple classless sources to be registered without dying
Jason May [Wed, 29 Apr 2009 15:18:11 +0000]
allow multiple classless sources to be registered without dying

15 years agoChanges
Peter Rabbitson [Wed, 29 Apr 2009 13:47:23 +0000]
Changes

15 years agoFixes to massive breakage introduced by 5948 ribasushi--
Peter Rabbitson [Wed, 29 Apr 2009 13:41:37 +0000]
Fixes to massive breakage introduced by 5948  ribasushi--

15 years agoForgotten debugging
Peter Rabbitson [Wed, 29 Apr 2009 13:40:03 +0000]
Forgotten debugging

15 years agoStrip out inane todo
Peter Rabbitson [Wed, 29 Apr 2009 13:39:27 +0000]
Strip out inane todo

15 years agountodo/fix test
Justin Hunter [Wed, 29 Apr 2009 12:47:03 +0000]
untodo/fix test

15 years agoAdd TODOs illustrating a problem with as_query
Peter Rabbitson [Wed, 29 Apr 2009 08:24:20 +0000]
Add TODOs illustrating a problem with as_query

15 years agoAdd two TODOs by arcanez (not sure about those)
Peter Rabbitson [Wed, 29 Apr 2009 08:23:25 +0000]
Add two TODOs by arcanez (not sure about those)

15 years agotest and patch for failing mini-prefetch via columns (arcanez++)
Peter Rabbitson [Wed, 29 Apr 2009 08:22:16 +0000]
test and patch for failing mini-prefetch via columns (arcanez++)

15 years agotest for prefetch by columns
Justin Hunter [Tue, 28 Apr 2009 23:16:48 +0000]
test for prefetch by columns

15 years agofix for columns => [ ... ] issue
Justin Hunter [Tue, 28 Apr 2009 20:20:42 +0000]
fix for columns => [ ... ] issue

15 years agoBogus test dependency
Peter Rabbitson [Tue, 28 Apr 2009 09:35:31 +0000]
Bogus test dependency

15 years agoFix a todo and some minor test adjustments
Peter Rabbitson [Tue, 28 Apr 2009 09:12:33 +0000]
Fix a todo and some minor test adjustments

15 years agochange from DB::Schema to My::Schema
Justin Hunter [Tue, 28 Apr 2009 07:05:53 +0000]
change from DB::Schema to My::Schema
add ::Result:: as necessary (load_namespaces instead of load_classes)

15 years agoRelease 0.08101 v0.08101
Peter Rabbitson [Mon, 27 Apr 2009 09:11:15 +0000]
Release 0.08101

15 years agoMore AUTHOR dependencies pulled from Replicated.pm
Peter Rabbitson [Mon, 27 Apr 2009 08:14:38 +0000]
More AUTHOR dependencies pulled from Replicated.pm
Up MI version to 0.79 (not going further as auto_install is broken again, need a permanent solution)
Reorder configure_requires() as per Alias
Remove Meta_TupleKeys munging as per Alias

15 years agoWhops, we don't exit under win32
Peter Rabbitson [Mon, 27 Apr 2009 08:05:43 +0000]
Whops, we don't exit under win32

15 years agoRefactor the (almost obsolete) DBD::SQLite check not to fork() within win32
Peter Rabbitson [Mon, 27 Apr 2009 08:03:58 +0000]
Refactor the (almost obsolete) DBD::SQLite check not to fork() within win32

15 years agoDocs on using multiple db schemas (from abraxxa maybe, I forget)
Jess Robinson [Sat, 25 Apr 2009 09:59:28 +0000]
Docs on using multiple db schemas (from abraxxa maybe, I forget)
Docs on setting result_class from agaran

15 years agoCosmetic change
Peter Rabbitson [Fri, 24 Apr 2009 15:22:05 +0000]
Cosmetic change

15 years agocleanup 72pg.t
Moritz Onken [Fri, 24 Apr 2009 14:27:20 +0000]
cleanup 72pg.t

15 years agopatch for DBI.pm so store_column is called only once on create() and tests for that
Moritz Onken [Fri, 24 Apr 2009 14:24:26 +0000]
patch for DBI.pm so store_column is called only once on create() and tests for that

15 years agoWhops
Peter Rabbitson [Thu, 23 Apr 2009 23:47:04 +0000]
Whops

15 years agoupdate Changes for moving load_optional_class
Justin Hunter [Thu, 23 Apr 2009 20:58:59 +0000]
update Changes for moving load_optional_class

15 years agoFix busted get_column when using +select (and friends)
Cory G Watson [Thu, 23 Apr 2009 20:49:04 +0000]
Fix busted get_column when using +select (and friends)

15 years agoFix botched merge again - sorry r5959-5956 are actually a single commit
Peter Rabbitson [Wed, 22 Apr 2009 22:48:08 +0000]
Fix botched merge again - sorry r5959-5956 are actually a single commit

15 years agoMerge 'subclassed_rsset' into 'trunk'
Peter Rabbitson [Tue, 21 Apr 2009 18:06:25 +0000]
Merge 'subclassed_rsset' into 'trunk'

15 years agoThis code belongs in t/
Peter Rabbitson [Wed, 22 Apr 2009 22:25:32 +0000]
This code belongs in t/

15 years agoAnother indexer trick
Peter Rabbitson [Wed, 22 Apr 2009 08:18:14 +0000]
Another indexer trick

15 years agoRT45195 various indexer fixes
Peter Rabbitson [Wed, 22 Apr 2009 08:14:13 +0000]
RT45195 various indexer fixes

15 years agoun-todo these tests, load_optional_class is fixed
Justin Hunter [Wed, 22 Apr 2009 03:21:28 +0000]
un-todo these tests, load_optional_class is fixed

15 years agoadded IRC nick to contributor list
Peter Collingbourne [Tue, 21 Apr 2009 15:52:58 +0000]
added IRC nick to contributor list

15 years agoFix dumb omission in t/89dbicadmin.t
Peter Rabbitson [Tue, 21 Apr 2009 14:17:04 +0000]
Fix dumb omission in t/89dbicadmin.t
Adjust svn:ignore

15 years agoSloppy merge - adding imlari's fix from r5902
Peter Rabbitson [Tue, 21 Apr 2009 11:06:25 +0000]
Sloppy merge - adding imlari's fix from r5902

15 years agoMerge 'trunk' into 'subclassed_rsset'
Peter Rabbitson [Tue, 21 Apr 2009 10:57:35 +0000]
Merge 'trunk' into 'subclassed_rsset'

r5847@Thesaurus (orig r5846):  ribasushi | 2009-03-30 01:05:37 +0200
Take experimental off TxnScopeGuard
r5848@Thesaurus (orig r5847):  ribasushi | 2009-03-30 01:44:40 +0200
Dev-Release 0.08099_08
r5852@Thesaurus (orig r5851):  castaway | 2009-03-31 08:41:42 +0200
Fix my email address in AUTHOR

r5859@Thesaurus (orig r5858):  plu | 2009-04-07 16:15:32 +0200
Added caveat notes to dual trick in cookbook
r5875@Thesaurus (orig r5874):  arcanez | 2009-04-09 15:35:46 +0200
require DBD::SQLite 1.21+
r5885@Thesaurus (orig r5884):  caelum | 2009-04-13 14:47:47 +0200
add test for connect_info hashref
r5887@Thesaurus (orig r5886):  pcc | 2009-04-13 20:35:51 +0200
Correctly propagate forced left joins through arrayrefs and hashrefs
r5889@Thesaurus (orig r5888):  caelum | 2009-04-15 15:47:53 +0200
duplicate
r5891@Thesaurus (orig r5890):  plu | 2009-04-17 10:10:19 +0200
Added update_or_new to ResultSet.pm
r5903@Thesaurus (orig r5902):  ilmari | 2009-04-18 20:38:44 +0200
Don't warn when reregistering a source under the same name
r5913@Thesaurus (orig r5912):  matthewt | 2009-04-19 16:52:15 +0200
0.08100 release
r5916@Thesaurus (orig r5915):  arcanez | 2009-04-21 00:07:07 +0200
move load_optional_class into Class::C3::Componentised

r5923@Thesaurus (orig r5922):  ribasushi | 2009-04-21 10:37:11 +0200
New SQLite kicks ass - remove some warning silencers and reinstantiate tests
r5924@Thesaurus (orig r5923):  ribasushi | 2009-04-21 10:51:03 +0200
Multiple cdbi-compat test cleanups
Clarify search_like deprecation
r5925@Thesaurus (orig r5924):  ribasushi | 2009-04-21 10:51:59 +0200
More author test-requires
r5926@Thesaurus (orig r5925):  ribasushi | 2009-04-21 10:53:35 +0200
t/ janitorial work

15 years agoBack out my bogus test from r4902 - this warning was never supposed to be here in...
Peter Rabbitson [Tue, 21 Apr 2009 10:53:25 +0000]
Back out my bogus test from r4902 - this warning was never supposed to be here in the first place - we are essentially dynamically subclassing Artist (although in a very sloppy way)

15 years agoClarify _register_source code, no functional changes
Peter Rabbitson [Tue, 21 Apr 2009 10:42:14 +0000]
Clarify _register_source code, no functional changes

15 years agoFix number of tests
Peter Rabbitson [Tue, 21 Apr 2009 09:57:03 +0000]
Fix number of tests

15 years agot/ janitorial work
Peter Rabbitson [Tue, 21 Apr 2009 08:53:35 +0000]
t/ janitorial work

15 years agoMore author test-requires
Peter Rabbitson [Tue, 21 Apr 2009 08:51:59 +0000]
More author test-requires

15 years agoMultiple cdbi-compat test cleanups
Peter Rabbitson [Tue, 21 Apr 2009 08:51:03 +0000]
Multiple cdbi-compat test cleanups
Clarify search_like deprecation

15 years agoNew SQLite kicks ass - remove some warning silencers and reinstantiate tests
Peter Rabbitson [Tue, 21 Apr 2009 08:37:11 +0000]
New SQLite kicks ass - remove some warning silencers and reinstantiate tests

15 years agomove load_optional_class into Class::C3::Componentised
Justin Hunter [Mon, 20 Apr 2009 22:07:07 +0000]
move load_optional_class into Class::C3::Componentised

15 years ago0.08100 release v0.08100
Matt S Trout [Sun, 19 Apr 2009 14:52:15 +0000]
0.08100 release

15 years agoDon't warn when reregistering a source under the same name
Dagfinn Ilmari Mannsåker [Sat, 18 Apr 2009 18:38:44 +0000]
Don't warn when reregistering a source under the same name

15 years agoAdded update_or_new to ResultSet.pm
Johannes Plunien [Fri, 17 Apr 2009 08:10:19 +0000]
Added update_or_new to ResultSet.pm

15 years agoduplicate
Rafael Kitover [Wed, 15 Apr 2009 13:47:53 +0000]
duplicate

15 years agoCorrectly propagate forced left joins through arrayrefs and hashrefs
Peter Collingbourne [Mon, 13 Apr 2009 18:35:51 +0000]
Correctly propagate forced left joins through arrayrefs and hashrefs

15 years agoadd test for connect_info hashref
Rafael Kitover [Mon, 13 Apr 2009 12:47:47 +0000]
add test for connect_info hashref

15 years agorequire DBD::SQLite 1.21+
Justin Hunter [Thu, 9 Apr 2009 13:35:46 +0000]
require DBD::SQLite 1.21+

15 years agoMerge 'subclassed_rsset' into 'trunk'
Peter Rabbitson [Sun, 29 Mar 2009 08:30:21 +0000]
Merge 'subclassed_rsset' into 'trunk'

r81350@ofelia (orig r5840):  ribasushi | 2009-03-29 03:30:21 -0700
Re-add failing test

15 years agopatch for no-op, further testing required.
Jason M. Mills [Wed, 8 Apr 2009 19:26:57 +0000]
patch for no-op, further testing required.

15 years agoAdded caveat notes to dual trick in cookbook
Johannes Plunien [Tue, 7 Apr 2009 14:15:32 +0000]
Added caveat notes to dual trick in cookbook

15 years agoFix my email address in AUTHOR
Jess Robinson [Tue, 31 Mar 2009 06:41:42 +0000]
Fix my email address in AUTHOR

15 years agoDev-Release 0.08099_08
Peter Rabbitson [Sun, 29 Mar 2009 23:44:40 +0000]
Dev-Release 0.08099_08

15 years agoTake experimental off TxnScopeGuard
Peter Rabbitson [Sun, 29 Mar 2009 23:05:37 +0000]
Take experimental off TxnScopeGuard

15 years agoFix test - inane assumption on my part
Peter Rabbitson [Sun, 29 Mar 2009 14:55:03 +0000]
Fix test - inane assumption on my part

15 years agoRe-add failing test
Peter Rabbitson [Sun, 29 Mar 2009 10:30:21 +0000]
Re-add failing test

15 years agoRemove failing test before branching
Peter Rabbitson [Sun, 29 Mar 2009 10:22:49 +0000]
Remove failing test before branching

15 years agoAdjust parenthesis to pass with latest SQLA
Peter Rabbitson [Sun, 29 Mar 2009 10:18:19 +0000]
Adjust parenthesis to pass with latest SQLA

15 years agoRevert r5808 - this is NOT a bug, the warning IS correct
Peter Rabbitson [Sun, 29 Mar 2009 10:06:02 +0000]
Revert r5808 - this is NOT a bug, the warning IS correct