9 years agoNew namespace::clean to resolve the Package::Stash megafail
Peter Rabbitson [Sun, 9 Jan 2011 08:52:27 +0000]
New namespace::clean to resolve the Package::Stash megafail

9 years agoReduce to a warning the commit-without-apparent-begin exception from 7d216b10
Peter Rabbitson [Fri, 14 Jan 2011 12:07:50 +0000]
Reduce to a warning the commit-without-apparent-begin exception from 7d216b10

9 years agoReduce to a warning the find-with-NULL-key exception from b7743dab
Peter Rabbitson [Fri, 14 Jan 2011 11:41:42 +0000]
Reduce to a warning the find-with-NULL-key exception from b7743dab

9 years agoFix for => 'shared' on MySQL (RT#64590)
Peter Rabbitson [Thu, 13 Jan 2011 11:41:44 +0000]
Fix for => 'shared' on MySQL (RT#64590)

9 years agoFix RT#64500
Peter Rabbitson [Thu, 13 Jan 2011 11:35:36 +0000]
Fix RT#64500

9 years agoRemove some accumulated cruft
Peter Rabbitson [Thu, 13 Jan 2011 11:24:47 +0000]
Remove some accumulated cruft

9 years agoCleanup ResultSourceHandle handling after M.A.D. introduction
Peter Rabbitson [Thu, 13 Jan 2011 10:20:35 +0000]
Cleanup ResultSourceHandle handling after M.A.D. introduction

Since a source/schema combos no longer leak, it is safe to store
strong-refs to sources directly in Row/ResultSet objects. Reduce
ResultSourceHandle to a simple Source "meta-layer" to facilitate
serialization of ResultSources.

In the process improve behavior/error messages of objects which
were deserialized without $schema re-attachment

9 years agoIntroduce M.A.D. within the schema/source instance linkage
Peter Rabbitson [Tue, 11 Jan 2011 18:14:07 +0000]
Introduce M.A.D. within the schema/source instance linkage

When a source instance is registered with a schema instance, the code
in Schema::_register_source() adds a strong ref of the source to the
schema register, and a weak schema ref to the source itself. Install
DESTROY handlers both on Schema and ResultSource to flip this setup
any time the Schema instance goes out of scope (if we somehow
increment the refcount of $self in a DESTROY, then the garbage
collection is aborted). Tested all the way back to 5.8.1 with excellent

Promote the source links in both ResultSet and Row to real ResultSource
instance refs, as there's no longer any issue with memory leaks (before
a source handle would be instantiated lazily to sidestep the source
object entirely by keeping a schema ref instead).

Add freeze/thaw hooks for proper serialization of Source-containing
structures (be it Row's or ResultSet's). In another round of cleanup
ResultSourceHandle will be reduced to purely a "no schema yet"
placeholder after schema-less a freeze/thaw cycle.

9 years ago5.8.1 threads are wonky - tests no longer pass with recent DBD::Pg
Peter Rabbitson [Tue, 11 Jan 2011 17:25:39 +0000]
5.8.1 threads are wonky - tests no longer pass with recent DBD::Pg

9 years agoFasterize
Peter Rabbitson [Thu, 6 Jan 2011 08:59:12 +0000]

9 years agoFix losing order of columns provided in select/as
ostmann [Mon, 10 Jan 2011 10:56:49 +0000]
Fix losing order of columns provided in select/as

9 years agoMultiple optimizations of $rs->populate
Brian Phillips [Wed, 12 Jan 2011 19:21:02 +0000]
Multiple optimizations of $rs->populate

Remove unnecessary "find" while populating has_many, and reduce the overall
amount of method calls

9 years agoFix populate with an emply ([]) has_many
Brian Phillips [Wed, 12 Jan 2011 18:46:32 +0000]
Fix populate with an emply ([]) has_many

these are ignored if they're empty which makes them much more
compatible with HashRefInflator data sets

9 years agoremove warning about trying to delete open file in t/inflate/file_column.t
Rafael Kitover [Mon, 10 Jan 2011 19:55:20 +0000]
remove warning about trying to delete open file in t/inflate/file_column.t

9 years agoFix default selection resolution - make frew happy :)
Peter Rabbitson [Wed, 5 Jan 2011 23:27:05 +0000]
Fix default selection resolution - make frew happy :)

9 years agoMake sure unaliased selectors and prefetch coexist peacefully
Peter Rabbitson [Wed, 5 Jan 2011 14:52:09 +0000]
Make sure unaliased selectors and prefetch coexist peacefully

9 years agoFix bind transport for group_by (this code is so fucking ugly...)
Peter Rabbitson [Wed, 5 Jan 2011 14:43:15 +0000]
Fix bind transport for group_by (this code is so fucking ugly...)

9 years agoRelease 0.08126 v0.08126
Justin Hunter [Tue, 28 Dec 2010 18:17:18 +0000]
Release 0.08126

9 years agoStop running on smokers with a screwed up Package::Stash
Peter Rabbitson [Tue, 28 Dec 2010 17:03:56 +0000]
Stop running on smokers with a screwed up Package::Stash

9 years agoFix a deadlock-prone test
Peter Rabbitson [Tue, 28 Dec 2010 11:25:00 +0000]
Fix a deadlock-prone test

9 years agoStop t/storage/error from failing on memory-leaking smokers
Peter Rabbitson [Mon, 27 Dec 2010 09:38:31 +0000]
Stop t/storage/error from failing on memory-leaking smokers

(based on d5e5fb4b)

9 years agoFix Class::Accessor::Grouped and Hash::Merge dependencies
Peter Rabbitson [Mon, 27 Dec 2010 09:41:08 +0000]
Fix Class::Accessor::Grouped and Hash::Merge dependencies

Both were pulled in by SQLA but still :)

9 years agoAdd missed credit for 8592e2d1
Peter Rabbitson [Mon, 27 Dec 2010 09:52:18 +0000]
Add missed credit for 8592e2d1

9 years agoRelease 0.08125 v0.08125
Arthur Axel 'fREW' Schmidt [Mon, 27 Dec 2010 04:23:51 +0000]
Release 0.08125

9 years agoExtra test for Replicated debug (forgotten in 8592e2d1)
Peter Rabbitson [Mon, 27 Dec 2010 03:55:01 +0000]
Extra test for Replicated debug (forgotten in 8592e2d1)

9 years agoLatest blead (5.13.8) allows us to see $@ again
Peter Rabbitson [Mon, 27 Dec 2010 03:41:14 +0000]
Latest blead (5.13.8) allows us to see $@ again

... but does not allow us to change it still (it is set twice),
this is something that the SIG wrapper will take care of once

9 years agoFix missed mention of renamed module
Peter Rabbitson [Mon, 27 Dec 2010 03:28:15 +0000]
Fix missed mention of renamed module

9 years agoAnother revamp of the selector resolution - now supporting unbalanced select/as
Peter Rabbitson [Tue, 16 Nov 2010 17:02:45 +0000]
Another revamp of the selector resolution - now supporting unbalanced select/as

Builds on top of 37aafa2e

9 years agoDeprecate DBIx::Class::Serialize::Storable (all functionality is in ResultSourceHandle)
Peter Rabbitson [Sat, 25 Dec 2010 03:52:21 +0000]
Deprecate DBIx::Class::Serialize::Storable (all functionality is in ResultSourceHandle)

9 years agoFail early on literal-ordered complex prefetch without explicit group_by clause
Peter Rabbitson [Sat, 25 Dec 2010 03:38:41 +0000]
Fail early on literal-ordered complex prefetch without explicit group_by clause

9 years agoOnly add a group_by to a complex prefetch if a non-selecting multi-join is detected
Peter Rabbitson [Sat, 25 Dec 2010 03:10:45 +0000]
Only add a group_by to a complex prefetch if a non-selecting multi-join is detected

9 years agoFix check for blessedness and minor cleanup in many_to_many helper
Peter Rabbitson [Fri, 12 Mar 2010 00:22:19 +0000]
Fix check for blessedness and minor cleanup in many_to_many helper

9 years agoClean up from/select bind value handling (RT#61025)
Peter Rabbitson [Fri, 6 Aug 2010 22:01:46 +0000]
Clean up from/select bind value handling (RT#61025)

9 years agoReduce warnings introduced in 450e6dbf to one per callsite
Peter Rabbitson [Fri, 24 Dec 2010 12:57:30 +0000]
Reduce warnings introduced in 450e6dbf to one per callsite

9 years agoImprove fallback-to-master/return-to-slave reporting in ::Replicated::Balancer
Rafael Kitover [Sun, 26 Dec 2010 02:04:12 +0000]
Improve fallback-to-master/return-to-slave reporting in ::Replicated::Balancer

(patch from Bill Moseley)

9 years agoDeprecate -nest with strong prejudice
Peter Rabbitson [Thu, 23 Dec 2010 19:39:24 +0000]
Deprecate -nest with strong prejudice

9 years agoFix no-quoting assumptions in 'having' docs (RT#64129)
Peter Rabbitson [Thu, 23 Dec 2010 19:23:45 +0000]
Fix no-quoting assumptions in 'having' docs (RT#64129)

9 years agoadded RDBMS optional dependency groups for use by DBIC users + tests
Alexander Hartmaier [Fri, 17 Dec 2010 14:57:36 +0000]
added RDBMS optional dependency groups for use by DBIC users + tests

9 years agoRemoving perl -w usage in example code.
Squeeks [Fri, 17 Dec 2010 17:24:06 +0000]
Removing perl -w usage in example code.

9 years agoAdd missing attributes to Admin.pm (referenced in dbicadmin's POD)
Gordon Irving [Mon, 9 Aug 2010 22:50:02 +0000]
Add missing attributes to Admin.pm (referenced in dbicadmin's POD)

9 years agoSwitch the shortener (used only by oracle) reqs to an optional dependency
Peter Rabbitson [Fri, 17 Dec 2010 08:00:40 +0000]
Switch the shortener (used only by oracle) reqs to an optional dependency

9 years agoStop mangling sql on the way out of the limit dialects
Peter Rabbitson [Wed, 15 Dec 2010 15:58:46 +0000]
Stop mangling sql on the way out of the limit dialects

9 years agoMore oracle sequence detection woes RT#63493
Peter Rabbitson [Wed, 15 Dec 2010 11:27:24 +0000]
More oracle sequence detection woes RT#63493

9 years agoFix missed t/inflate/datetime_sqlanywhere.t migration to standalone small_dt
Rafael Kitover [Wed, 22 Dec 2010 14:22:56 +0000]
Fix missed t/inflate/datetime_sqlanywhere.t migration to standalone small_dt

9 years agoRemove small_datetime from the main schema - it is not a standard datatype
Rafael Kitover [Tue, 21 Dec 2010 20:01:32 +0000]
Remove small_datetime from the main schema - it is not a standard datatype

9 years agoforce NLS_{LANG,COMP,SORT} for improved predictability
Fabien Wernli [Thu, 16 Dec 2010 13:33:42 +0000]
force NLS_{LANG,COMP,SORT} for improved predictability

9 years agomerge and improve _is_lob_type from Sybase::ASE into Storage::DBI
Rafael Kitover [Tue, 7 Dec 2010 23:47:54 +0000]
merge and improve _is_lob_type from Sybase::ASE into Storage::DBI

9 years agosupport INSERT ... RETURNING in Oracle 8i and later
Alexander Hartmaier [Tue, 25 May 2010 15:55:26 +0000]
support INSERT ... RETURNING in Oracle 8i and later

9 years agorewrite Schema::Loader section in Manual::Intro
Rafael Kitover [Wed, 15 Dec 2010 09:12:55 +0000]
rewrite Schema::Loader section in Manual::Intro

9 years agorename sybase_asa tests and env vars to sqlanywhere
Rafael Kitover [Fri, 3 Dec 2010 09:16:56 +0000]
rename sybase_asa tests and env vars to sqlanywhere

9 years agoSupport for -value op in search (for pg arrays and stuff)
Peter Rabbitson [Thu, 2 Dec 2010 10:37:02 +0000]
Support for -value op in search (for pg arrays and stuff)

9 years agoOrder core dependencies, bump CAG to the rewritten fastiness
Peter Rabbitson [Wed, 1 Dec 2010 02:33:00 +0000]
Order core dependencies, bump CAG to the rewritten fastiness

9 years agoLimit the void context search exceptions to non-dbic code
Peter Rabbitson [Wed, 1 Dec 2010 02:21:50 +0000]
Limit the void context search exceptions to non-dbic code

<robkinyon> i can fully imagine someone doing it because of side-effects they've added
<robkinyon> to something they didn't realize called search

9 years agoMissing podcoverage skips
Peter Rabbitson [Wed, 1 Dec 2010 00:52:42 +0000]
Missing podcoverage skips

9 years agoMake the has-ident check in Row->update even lazier
Peter Rabbitson [Wed, 1 Dec 2010 00:42:19 +0000]
Make the has-ident check in Row->update even lazier

9 years agoIndulge in some microoptimization
Peter Rabbitson [Mon, 29 Nov 2010 06:22:51 +0000]
Indulge in some microoptimization

Per: http://lists.scsys.co.uk/pipermail/dbix-class/2010-November/009600.html
and http://lists.scsys.co.uk/pipermail/dbix-class/2010-November/009601.html

9 years agoGet Storage::Oracle to behave when quoting is enabled
Fabien Wernli [Fri, 23 Jul 2010 15:55:19 +0000]
Get Storage::Oracle to behave when quoting is enabled

Also fix Pg being unable to handle scalarref sequences

9 years agoQuieter Sybase tests
Peter Rabbitson [Mon, 29 Nov 2010 05:18:51 +0000]
Quieter Sybase tests

9 years agoSeparate the oracle core and hq tests
Peter Rabbitson [Sun, 28 Nov 2010 03:39:48 +0000]
Separate the oracle core and hq tests

9 years agoRename method, normalize rv to [$sql, @bind]
Peter Rabbitson [Sun, 28 Nov 2010 02:15:24 +0000]
Rename method, normalize rv to [$sql, @bind]

9 years agoKeep belongs_to related object / fk values in sync
Peter Rabbitson [Sun, 28 Nov 2010 00:49:41 +0000]
Keep belongs_to related object / fk values in sync

9 years agoFix count on rs with a having clause with an aliased condition
Peter Rabbitson [Sat, 27 Nov 2010 23:14:22 +0000]
Fix count on rs with a having clause with an aliased condition

9 years agoexplain how to use HashRefInflator with search
Al Newkirk [Sat, 6 Nov 2010 21:53:55 +0000]
explain how to use HashRefInflator with search

9 years agoFix the DBI-destroy-warning silencer
Peter Rabbitson [Fri, 26 Nov 2010 13:15:55 +0000]
Fix the DBI-destroy-warning silencer

10 years agoMicrooptimization of the IC::DT registration code
Peter Rabbitson [Thu, 25 Nov 2010 00:48:43 +0000]
Microoptimization of the IC::DT registration code

10 years agorefactor DBIx::Class::Storage::Statistics::debugfh() to be lazy
Arthur Axel 'fREW' Schmidt [Fri, 26 Nov 2010 23:11:20 +0000]
refactor DBIx::Class::Storage::Statistics::debugfh() to be lazy

10 years agoQuote table name when inserting DEFAULT VALUES
Rafael Kitover [Wed, 24 Nov 2010 09:42:52 +0000]
Quote table name when inserting DEFAULT VALUES

10 years agoFix multiple storage regressions from 52416317
Rafael Kitover [Mon, 22 Nov 2010 08:41:56 +0000]
Fix multiple storage regressions from 52416317

Factor out the pre-insert value fetching again, some storages need
to hook there. The rest is just riba being retarded, Caelum++

10 years agofix left-over from use_namespaces
Moritz Lenz [Tue, 23 Nov 2010 15:30:20 +0000]
fix left-over from use_namespaces

10 years agoadded website to community resources in main POD
Rafael Kitover [Tue, 23 Nov 2010 11:52:56 +0000]
added website to community resources in main POD

10 years agoAlways run the META.yml check
Peter Rabbitson [Thu, 18 Nov 2010 09:28:21 +0000]
Always run the META.yml check

10 years agoBackout inconsistent changes to +columns handling
Peter Rabbitson [Fri, 12 Nov 2010 14:58:24 +0000]
Backout inconsistent changes to +columns handling

introduced in 67ba664605de95b5130b55397c7351f53dae4c19 2 years ago

10 years agoOverhaul thread handling
Peter Rabbitson [Thu, 18 Nov 2010 07:56:14 +0000]
Overhaul thread handling

Throw away _verify_tid as it happens too late (when a request is fired).
Instead destroy the current $dbh as soon as possible in CLONE and hope for
the best. Also deactivate _verify_pid on Win32 as it silently spawns a
thread in the background (and thus invokes CLONE).

10 years agoSuppress replicated test warnings on win32 as well
Peter Rabbitson [Thu, 18 Nov 2010 07:10:48 +0000]
Suppress replicated test warnings on win32 as well

10 years agoFix 2 stupid omissions in tests
Peter Rabbitson [Mon, 15 Nov 2010 10:32:48 +0000]
Fix 2 stupid omissions in tests

10 years agoStop showing __BULK_INSERT__ during populate() without bindvals
Peter Rabbitson [Sun, 14 Nov 2010 12:43:00 +0000]
Stop showing __BULK_INSERT__  during populate() without bindvals

Also restructure the code a bit (e.g. avoid a useless list-copy)

10 years agoFix a forgotten nested try::tiny usage
Peter Rabbitson [Sun, 14 Nov 2010 12:37:28 +0000]
Fix a forgotten nested try::tiny usage

10 years agoAttach a storage debugobj lazily instead of at new() time
Peter Rabbitson [Sun, 14 Nov 2010 12:24:06 +0000]
Attach a storage debugobj lazily instead of at new() time

10 years agoUnqualify imported functions
Peter Rabbitson [Sun, 14 Nov 2010 12:23:19 +0000]
Unqualify imported functions

10 years agoCroak more intelligently when attrs->{page} is an unexpected value
Andrew Rodland [Tue, 9 Nov 2010 01:19:04 +0000]
Croak more intelligently when attrs->{page} is an unexpected value

10 years agoMajor overhaul of select/as resolution handling (fixes RT#61235)
Peter Rabbitson [Sat, 9 Oct 2010 09:01:35 +0000]
Major overhaul of select/as resolution handling (fixes RT#61235)

10 years agoAdd notes about handling of inflated objects in resultset conditions
Mike Baas [Fri, 29 Oct 2010 02:55:49 +0000]
Add notes about handling of inflated objects in resultset conditions

10 years agoStop spurious warnings in cdbi test
Peter Rabbitson [Fri, 12 Nov 2010 15:22:01 +0000]
Stop spurious warnings in cdbi test

10 years agoOverhaul serialization test, add optional Memcached testing
Peter Rabbitson [Tue, 9 Nov 2010 13:30:20 +0000]
Overhaul serialization test, add optional Memcached testing

10 years agoAdd Storable freeze/thaw hooks to ResultSet to detach active cursors
Peter Rabbitson [Sat, 30 Oct 2010 09:42:43 +0000]
Add Storable freeze/thaw hooks to ResultSet to detach active cursors

This allows serialization of resultsets "in-progress". Furthermore
testing revealed cached resultsets are serializable just fine \o/

10 years agoSwitch all Storable serialization calls from freeze() to nfreeze()
Peter Rabbitson [Sat, 30 Oct 2010 09:36:47 +0000]
Switch all Storable serialization calls from freeze() to nfreeze()

ovid++ for researching this:

10 years agoFix regressions in IC::DT registration logic
Peter Rabbitson [Mon, 8 Nov 2010 11:52:29 +0000]
Fix regressions in IC::DT registration logic

10 years agoFix datetime dependency in t/60core.t (RT62635)
Peter Rabbitson [Mon, 8 Nov 2010 02:03:36 +0000]
Fix datetime dependency in t/60core.t (RT62635)

10 years agoDeprecate rolled-out hash-condition in search()
Peter Rabbitson [Mon, 8 Nov 2010 01:54:09 +0000]
Deprecate rolled-out hash-condition in search()

10 years agoDie on search in void context
Peter Rabbitson [Mon, 8 Nov 2010 01:26:47 +0000]
Die on search in void context

10 years agoRefactor insert logic (Row should not handle SQLA options)
Peter Rabbitson [Mon, 8 Nov 2010 01:10:20 +0000]
Refactor insert logic (Row should not handle SQLA options)

10 years agoIntroduce columns_info, switch a large portion of the code over
Peter Rabbitson [Sun, 7 Nov 2010 23:20:11 +0000]
Introduce columns_info, switch a large portion of the code over

(saves on repeated method calls)

10 years agoCleanup Row::sequence()
Peter Rabbitson [Sun, 12 Sep 2010 18:52:49 +0000]
Cleanup Row::sequence()

While it seems like a rather useless method these days (we have excellent sequence
detection) keep it around nevertheless. However move it to ResultSource where
it logically belongs, and undocument its use from a couple of ::Storage driver
POD examples

10 years agoCleanup ::ResultSourceProxy, use a proxy-method generator
Peter Rabbitson [Sun, 12 Sep 2010 18:50:34 +0000]
Cleanup ::ResultSourceProxy, use a proxy-method generator

10 years agoMore robust Oracle autoinc pk sequence detection
Alexander Hartmaier [Fri, 29 Oct 2010 15:59:04 +0000]
More robust Oracle autoinc pk sequence detection

When only one trigger could possible match a specific column, the trigger
detection rules can be more lenient.

10 years agoHide package from PAUSE
Peter Rabbitson [Sat, 30 Oct 2010 08:40:11 +0000]
Hide package from PAUSE

10 years agoDon't quote NULL for debug output
Arthur Axel 'fREW' Schmidt [Tue, 9 Nov 2010 00:25:27 +0000]
Don't quote NULL for debug output

Also require new SQLA with more goodies (and which can take advantage
of an unquoted NULL)

10 years agofix and regression test for RT #62642
John Napiorkowski [Wed, 10 Nov 2010 02:22:58 +0000]
fix and regression test for RT #62642

10 years agoRemoved unintentionally doubled cd pk trigger from t/73oracle.t
Alexander Hartmaier [Fri, 29 Oct 2010 15:55:41 +0000]
Removed unintentionally doubled cd pk trigger from t/73oracle.t

10 years agofREWFail: Remove IRC topic from DBIx::Class
Arthur Axel 'fREW' Schmidt [Fri, 29 Oct 2010 15:10:24 +0000]
fREWFail: Remove IRC topic from DBIx::Class