15 years agoProper MSSQL last_insert_id() scoping patch by abraxxa
Peter Rabbitson [Fri, 16 Jan 2009 10:29:16 +0000]
Proper MSSQL last_insert_id() scoping patch by abraxxa
No tests as it is very hard to simulate the problematic behavior - it would only manifest if:
  1) An INSERT statement is issued from connection A
  2) An INSERT statement is issued from connection B
  3) last_insert_id is called from connection A

Without this patch the last id from the second INSERT will be returned in step 3
Tested with both DBICTEST_MSSQL_ODBC_DSN and DBICTEST_MSSQL_DSN against a MSSQL 2005

15 years agoauto_savepoint support for Oracle and a note on txn_do for with "AutoCommit => 0"
Rafael Kitover [Wed, 14 Jan 2009 01:25:28 +0000]
auto_savepoint support for Oracle and a note on txn_do for with "AutoCommit => 0"

15 years ago * Reworded $rs->current_source_alias POD (thanks to castaway).
Norbert Buchmuller [Mon, 12 Jan 2009 17:55:48 +0000]
 * Reworded $rs->current_source_alias POD (thanks to castaway).

15 years ago * Implemented $rs->current_source_alias.
Norbert Buchmuller [Mon, 12 Jan 2009 17:18:22 +0000]
 * Implemented $rs->current_source_alias.

15 years agonot necessary
Wallace Reis [Fri, 9 Jan 2009 12:14:49 +0000]
not necessary

15 years agofixup source registration bugs where schema-specific things were being set on class...
Matt S Trout [Fri, 9 Jan 2009 03:28:44 +0000]
fixup source registration bugs where schema-specific things were being set on class' result_source_instance objects

15 years agoby setting conn_?id first, we prevent $storage->dbh from recursing through on_connect...
Ricardo Signes [Fri, 9 Jan 2009 01:55:53 +0000]
by setting conn_?id first, we prevent $storage->dbh from recursing through on_connect_do actions

15 years agoreverting changes for versioning tests
Wallace Reis [Thu, 8 Jan 2009 23:11:50 +0000]
reverting changes for versioning tests

15 years ago>result_source_instance->source_name should return undef for any class
Wallace Reis [Thu, 8 Jan 2009 22:57:47 +0000]
>result_source_instance->source_name should return undef for any class

15 years agofailing test for load_namespace
Wallace Reis [Thu, 8 Jan 2009 22:45:35 +0000]
failing test for load_namespace

15 years agocredit where credit is due; namely: ME!
Ricardo Signes [Thu, 8 Jan 2009 20:51:39 +0000]
credit where credit is due; namely: ME!

15 years agofix the just-added test; pass the Storage object to pure-code on_connect callbacks
Ricardo Signes [Thu, 8 Jan 2009 20:50:57 +0000]
fix the just-added test; pass the Storage object to pure-code on_connect callbacks

15 years ago failing test for callback on_connect_do getting storage obejct
Ricardo Signes [Thu, 8 Jan 2009 20:49:29 +0000]
 failing test for callback on_connect_do getting storage obejct

15 years agoAdd definitions of relationship and relationship bridge, link to them from the rel...
Jess Robinson [Tue, 30 Dec 2008 10:58:19 +0000]
Add definitions of relationship and relationship bridge, link to them from the rel docs

15 years agoRe-ordered method docs to be in a more user-needs-it order.
Jess Robinson [Mon, 29 Dec 2008 22:17:37 +0000]
Re-ordered method docs to be in a more user-needs-it order.
Fixed some obj/table mentions in docs to be consistently $source.

15 years agoAdded standard arguments/return value to all docced methods.
Jess Robinson [Mon, 29 Dec 2008 21:51:54 +0000]
Added standard arguments/return value to all docced methods.
Upadted some method docs.

15 years agomake clear that search_like is only really there for Class::DBI users
Matt S Trout [Wed, 24 Dec 2008 17:26:35 +0000]
make clear that search_like is only really there for Class::DBI users

15 years agomap blob to PG_BYTEA on DBD::Pg
Yuval Kogman [Mon, 22 Dec 2008 16:43:50 +0000]
map blob to PG_BYTEA on DBD::Pg

15 years agodelete() POD patch from Michael Hendricks (slightly reworded)
Peter Rabbitson [Sun, 21 Dec 2008 11:24:39 +0000]
delete() POD patch from Michael Hendricks (slightly reworded)

15 years ago * Added myself to the contributors list.
Norbert Buchmuller [Sun, 21 Dec 2008 07:39:37 +0000]
 * Added myself to the contributors list.

15 years agoTodoify cdbi failing tests, waiting for schwern
Peter Rabbitson [Fri, 19 Dec 2008 21:09:17 +0000]
Todoify cdbi failing tests, waiting for schwern

15 years agoaltered schema->populate so that it is a very thin wrapper on top of resultset->popul...
John Napiorkowski [Fri, 19 Dec 2008 20:48:35 +0000]
altered schema->populate so that it is a very thin wrapper on top of resultset->populate and changed resultset_populate so that is accepted both the arrayref of hashes and the arrayref of arrayref style of args.  Documented this, updated the tests a bit to make sure it is all good.

15 years agomore noise debugging messages if debug is on, minor doc tweaks, changes so that the...
John Napiorkowski [Fri, 19 Dec 2008 19:52:44 +0000]
more noise debugging messages if debug is on, minor doc tweaks, changes so that the fake sqlite tests will work and laid the groundwork for replication without dbatabase native replication support.

15 years agoSome cleanups to the m2m warnings test
Peter Rabbitson [Thu, 18 Dec 2008 11:28:38 +0000]
Some cleanups to the m2m warnings test

15 years agoTry to fix test on 5.10
Ash Berlin [Tue, 16 Dec 2008 23:45:51 +0000]
Try to fix test on 5.10

15 years agosomehow i messed up the merge. this fixes it
Guillermo Roditi [Tue, 16 Dec 2008 23:27:57 +0000]
somehow i messed up the merge. this fixes it

15 years agoMerge 'belongs_to_null_col_fix' into 'trunk'
Guillermo Roditi [Tue, 16 Dec 2008 23:52:12 +0000]
Merge 'belongs_to_null_col_fix' into 'trunk'

15 years agoMerge 'belongs_to_null_col_fix' into 'trunk'
Guillermo Roditi [Wed, 10 Dec 2008 02:28:10 +0000]
Merge 'belongs_to_null_col_fix' into 'trunk'

r24740@martha (orig r5230):  groditi | 2008-12-09 20:28:10 -0500
fix for bug. all tests seem to pass, we still need a new test and more research

15 years agominor typo and style change
Guillermo Roditi [Tue, 16 Dec 2008 22:52:12 +0000]
minor typo and style change

15 years agorename option to undef_on_null_fk and make it default for belongs_to
Guillermo Roditi [Tue, 16 Dec 2008 22:42:10 +0000]
rename option to undef_on_null_fk and make it default for belongs_to

15 years agoIntroduce 'any_null_means_no_value' option to eliminate wasteful queries. The option...
Guillermo Roditi [Tue, 16 Dec 2008 21:27:06 +0000]
Introduce 'any_null_means_no_value' option to eliminate wasteful queries. The option is off by default and must be explicitly turned on. Tests, + docs included

15 years agoMerge 'trunk' into 'belongs_to_null_col_fix'
John Napiorkowski [Mon, 15 Dec 2008 23:02:19 +0000]
Merge 'trunk' into 'belongs_to_null_col_fix'

r24752@martha (orig r5239):  jnapiorkowski | 2008-12-15 17:02:19 -0500
changes to replication so that if a replicant is offline when we do the initial connection (or if we need to globally reconnect later) the connection does not die.  This is different from when a replicant is available just not listening, or if the replicant is too laggy.  Thanks David Steinbrunner for the patch suggestions.

15 years agochanges to replication so that if a replicant is offline when we do the initial conne...
John Napiorkowski [Mon, 15 Dec 2008 22:02:19 +0000]
changes to replication so that if a replicant is offline when we do the initial connection (or if we need to globally reconnect later) the connection does not die.  This is different from when a replicant is available just not listening, or if the replicant is too laggy.  Thanks David Steinbrunner for the patch suggestions.

15 years agofix for bug. all tests seem to pass, we still need a new test and more research
Guillermo Roditi [Wed, 10 Dec 2008 01:28:10 +0000]
fix for bug. all tests seem to pass, we still need a new test and more research

15 years agoMake the many-to-many warning use warnings::register;
Ash Berlin [Wed, 3 Dec 2008 17:23:00 +0000]
Make the many-to-many warning use warnings::register;

15 years agoFix pod errors so that some storage subclasses show up in cpan properly
Jess Robinson [Thu, 20 Nov 2008 13:49:39 +0000]
Fix pod errors so that some storage subclasses show up in cpan properly

15 years agoMinor doc patch by Caelum
Peter Rabbitson [Thu, 20 Nov 2008 11:09:11 +0000]
Minor doc patch by Caelum

15 years agoCDBI-compat tests by Dave Horwoth:
Peter Rabbitson [Thu, 20 Nov 2008 11:01:14 +0000]
CDBI-compat tests by Dave Horwoth:

    OK. I've attached a patch to t/cdbi-t/15-accessor.t that does several
    things:

    (1) Fixes the way the arguments are built so the sheep argument is
    correct in the tests.

    (2) Adds explicit tests for the number of sheep so we can be sure which
    database record is actually returned.

    (3) Adds tests for find_or_create() with modified accessor names.

    (4) Fixes the test for search() to report all errors

    I still don't fully understand what's going on in the output below but I
    think they are genuine test failures. I'd appreciate it if somebody else
    could run the tests to make sure the results are not some artefact of my
    test environment. I also attached a copy of the modified test script so
    you don't even have to apply the patch first :)

    I don't know what the DestroyWarning at the end is all about.

15 years agoTrunk passes tests again - todoify everything multicreate related to branch it out...
Peter Rabbitson [Thu, 20 Nov 2008 10:25:32 +0000]
Trunk passes tests again - todoify everything multicreate related to branch it out, as the task turned out to be more complex (no indentation to aid future merging)

15 years agoExtend might_have test with ideas from zby
Peter Rabbitson [Mon, 17 Nov 2008 11:04:54 +0000]
Extend might_have test with ideas from zby

15 years agoFailing tests by zby, showing that recursing insert() gets in the way of some exotic...
Peter Rabbitson [Mon, 17 Nov 2008 03:01:39 +0000]
Failing tests by zby, showing that recursing insert() gets in the way of some exotic insert scenarious - waiting for mst to decide course of action

15 years agoSilence cdbi tests like everything else
Peter Rabbitson [Mon, 17 Nov 2008 02:48:57 +0000]
Silence cdbi tests like everything else

15 years agoTwo failing multicreate tests (the root cause of castaway's problem)
Peter Rabbitson [Mon, 17 Nov 2008 02:09:18 +0000]
Two failing multicreate tests (the root cause of castaway's problem)

15 years agoTwo more sets of might_have - has_many relationships for extra tests
Peter Rabbitson [Mon, 17 Nov 2008 01:59:53 +0000]
Two more sets of might_have - has_many relationships for extra tests

15 years agoOne more (passing) multicreate test and a bit of cleanup
Peter Rabbitson [Mon, 17 Nov 2008 01:00:28 +0000]
One more (passing) multicreate test and a bit of cleanup

15 years agorip away a horribly wrong create_via_update test (will pass when multicreate is merged)
Peter Rabbitson [Mon, 17 Nov 2008 00:33:51 +0000]
rip away a horribly wrong create_via_update test (will pass when multicreate is merged)

15 years agomight_have test for castaway to break
Peter Rabbitson [Sun, 16 Nov 2008 22:23:38 +0000]
might_have test for castaway to break

15 years agoAdd new test relationship - a track can have a relates single_cd
Peter Rabbitson [Sun, 16 Nov 2008 22:16:31 +0000]
Add new test relationship - a track can have a relates single_cd

15 years agoRevert castaway's test - mildly bogus
Peter Rabbitson [Sun, 16 Nov 2008 22:14:13 +0000]
Revert castaway's test - mildly bogus

15 years agoMerge 'resultsetcolumn_custom_columns' into 'trunk'
Norbert Buchmuller [Mon, 17 Nov 2008 02:11:42 +0000]
Merge 'resultsetcolumn_custom_columns' into 'trunk'

r5165@vger:  mendel | 2008-11-16 20:11:42 +0100
 * Merged in changes from 'resultsetcolumn_custom_columns' branch,

15 years agowhops
Peter Rabbitson [Sun, 16 Nov 2008 09:53:07 +0000]
whops

15 years agoAdded failing create-multi test
Jess Robinson [Sat, 15 Nov 2008 21:08:30 +0000]
Added failing create-multi test

15 years ago * Rewrote fetching the 'select' and 'as' values from the parent resultset to somethi...
Norbert Buchmuller [Sun, 16 Nov 2008 02:18:11 +0000]
 * Rewrote fetching the 'select' and 'as' values from the parent resultset to something that's easier to read for everyone.

15 years ago * Fixed a bug: did not create the underlying resultset if neither ->next or ->reset...
Norbert Buchmuller [Sat, 15 Nov 2008 03:48:51 +0000]
 * Fixed a bug: did not create the underlying resultset if neither ->next or ->reset is called before ->first was called.

15 years ago * Added ->first and ->reset implementation to ResultSetColumn.
Norbert Buchmuller [Sat, 15 Nov 2008 03:18:53 +0000]
 * Added ->first and ->reset implementation to ResultSetColumn.
 * A bit of refactoring/cleanup of ResultSetColumn.

15 years agowe use register_extra_source() now
Peter Rabbitson [Fri, 14 Nov 2008 17:44:25 +0000]
we use register_extra_source() now

15 years agoDocument the new from usage
Peter Rabbitson [Fri, 14 Nov 2008 09:46:00 +0000]
Document the new from usage

15 years agoresultset attribute from can now take a scalarref and use it verbatim
Peter Rabbitson [Thu, 13 Nov 2008 18:34:29 +0000]
resultset attribute from can now take a scalarref and use it verbatim

15 years agoresult_class goodies by Caelum:
Peter Rabbitson [Thu, 13 Nov 2008 07:34:26 +0000]
result_class goodies by Caelum:
- result_class can now be specified as a search attribute, attaching it to the returned resultset
- the specified class is now autoloaded via ensure_loaded()

15 years agofixed 73oracle.t, added charfield
Johannes Plunien [Wed, 12 Nov 2008 16:42:44 +0000]
fixed 73oracle.t, added charfield

15 years ago * Fixed test cases of ResultSetColumn vs. +select/+as (they used to unconditionally...
Norbert Buchmuller [Tue, 11 Nov 2008 08:29:09 +0000]
 * Fixed test cases of ResultSetColumn vs. +select/+as (they used to unconditionally pass).
 * Added a test case of ResultSetColumn for a non-existent column (note: a valid SQL fragment still can be passed instead of a column).
 * Added a test case of ResultSetColumn that tests overriding a column using select/as.
 * ResultSetColumn now respects select/as/+select/+as.
 * Added missing throw_exception() to ResultSetColumn.

15 years agoClarify attributes argument of find()
Peter Rabbitson [Mon, 10 Nov 2008 23:18:01 +0000]
Clarify attributes argument of find()

15 years agobelongs_to relationships are explicitly flagged by default, to aid the DBIC SQLT...
Peter Rabbitson [Mon, 10 Nov 2008 23:09:23 +0000]
belongs_to relationships are explicitly flagged by default, to aid the DBIC SQLT parser (by abraxxa)

15 years agoSwitch out one more reliance on connect_info
Peter Rabbitson [Mon, 10 Nov 2008 22:46:45 +0000]
Switch out one more reliance on connect_info

15 years agochanged the way we get the DSN for debugging in replication
John Napiorkowski [Mon, 10 Nov 2008 16:12:28 +0000]
changed the way we get the DSN for debugging in replication

15 years agoSwitch schema management version calls from VERSION() to schema_version()
Peter Rabbitson [Sun, 9 Nov 2008 20:19:39 +0000]
Switch schema management version calls from VERSION() to schema_version()

15 years agoDon't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which...
Peter Rabbitson [Sun, 9 Nov 2008 16:02:05 +0000]
Don't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which is stable no matter which connect_info() flavor is used)
todo: ping jnpiorkowski about Replicated::Pool and Replicated::Replicant - it blindly assumes that connect_info->[0] contains the dsn, which might not be the case. Even when using _dbi_connect_info, the first element might be a coderef

15 years agoFix detection of multiple rows being returned for single(): calling fetchrow_array...
Peter Rabbitson [Sun, 9 Nov 2008 15:35:30 +0000]
Fix detection of multiple rows being returned for single(): calling fetchrow_array in scalar context leads to indefined results (search.cpan.org/~timb/DBI/DBI.pm#fetchrow_array)

15 years agoSome testdb changes and alignment, preparing for test refactor branch
Peter Rabbitson [Sun, 9 Nov 2008 15:29:34 +0000]
Some testdb changes and alignment, preparing for test refactor branch

15 years agoSQLT behaves sanely in scalar context, no need for stupid version detections (ribasus...
Peter Rabbitson [Sun, 9 Nov 2008 15:27:40 +0000]
SQLT behaves sanely in scalar context, no need for stupid version detections (ribasushi--)

15 years agoMore TODO items
Peter Rabbitson [Sun, 9 Nov 2008 13:35:57 +0000]
More TODO items

15 years agoOne extra multicreate test and some cleanup
Peter Rabbitson [Fri, 7 Nov 2008 09:42:48 +0000]
One extra multicreate test and some cleanup

15 years agoFix loss of objects on multicreate over several 1:M relations
Peter Rabbitson [Fri, 7 Nov 2008 07:30:49 +0000]
Fix loss of objects on multicreate over several 1:M relations

15 years agoFinal insanification of the multicreate test
Peter Rabbitson [Fri, 7 Nov 2008 07:29:21 +0000]
Final insanification of the multicreate test

15 years agounhide SQL::Translator::Parser::DBIx::Class from pause indexer
Steffen Schwigon [Thu, 6 Nov 2008 21:59:42 +0000]
unhide SQL::Translator::Parser::DBIx::Class from pause indexer

15 years agopod documentation for SQL::Translator::Parser::DBIx::Class
Steffen Schwigon [Thu, 6 Nov 2008 20:23:22 +0000]
pod documentation for SQL::Translator::Parser::DBIx::Class

15 years agoA little indentation clean up
Michael G Schwern [Thu, 6 Nov 2008 12:44:36 +0000]
A little indentation clean up

Test the result of an eval directly.

discard the changes to $sandl to quiet an "object destroyed with changes"
warning.

15 years agomk_group_accessor() is sometimes called internally when inflating a column
Michael G Schwern [Thu, 6 Nov 2008 12:44:27 +0000]
mk_group_accessor() is sometimes called internally when inflating a column
and with an array ref field spec, but the accessor and column names are
the same.  Special case that to go through the usual accessor_name_for stuff.

15 years ago[rt.cpan.org 36863]
Michael G Schwern [Tue, 4 Nov 2008 18:26:41 +0000]
[rt.cpan.org 36863]
Fix mk_group_accessors() to handle [$field, $name].  It ignores
accessor/mutator_name_for() because if you pass in your own accessor
name you probably mean it.

15 years agoNormalize indentation
Michael G Schwern [Tue, 4 Nov 2008 18:26:29 +0000]
Normalize indentation

15 years agoAnd now really untabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:19 +0000]
And now really untabify

15 years agonormalize the indentation and detabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:09 +0000]
normalize the indentation and detabify

15 years agofixed 73oracle.t
Johannes Plunien [Tue, 4 Nov 2008 16:22:51 +0000]
fixed 73oracle.t

15 years agoTest prompted by discussion about tasty stuff
Peter Rabbitson [Sun, 2 Nov 2008 16:55:31 +0000]
Test prompted by discussion about tasty stuff

15 years agoBetter linking in Relatiomship POD
Peter Rabbitson [Sun, 2 Nov 2008 16:54:46 +0000]
Better linking in Relatiomship POD

15 years agoMore svn:ignore
Peter Rabbitson [Sun, 2 Nov 2008 13:32:26 +0000]
More svn:ignore

15 years agoClarify Relationship POD
Peter Rabbitson [Sun, 2 Nov 2008 13:30:49 +0000]
Clarify Relationship POD

15 years agorefactor of t/96multi_create.t:
Peter Rabbitson [Sun, 2 Nov 2008 12:28:02 +0000]
refactor of t/96multi_create.t:
- simplify test case submitted by wreis
- incorporate it into the large multicreate at the end
- eval{} independent sections of the test so more output can be gathered

15 years agoAugment commit r5037 - the column_info feature on SQLite is not buggy but partially...
Peter Rabbitson [Sat, 1 Nov 2008 20:58:07 +0000]
Augment commit r5037 - the column_info feature on SQLite is not buggy but partially unimplemented

15 years agorolling back my last change, waiting until new sqlt is on cpan
Johannes Plunien [Sun, 2 Nov 2008 01:59:49 +0000]
rolling back my last change, waiting until new sqlt is on cpan

15 years agofixed next warnings
Johannes Plunien [Sun, 2 Nov 2008 01:37:21 +0000]
fixed next warnings

15 years agoupdated Changes
Johannes Plunien [Sun, 2 Nov 2008 01:22:09 +0000]
updated Changes

15 years agosplit sql statements for deploy only if SQLT::Producer returned a scalar
Johannes Plunien [Sun, 2 Nov 2008 01:19:09 +0000]
split sql statements for deploy only if SQLT::Producer returned a scalar

15 years agoTODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite...
Peter Rabbitson [Sat, 1 Nov 2008 14:23:15 +0000]
TODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite versions

15 years agoadded failing test case for multi create
Wallace Reis [Sat, 1 Nov 2008 00:42:56 +0000]
added failing test case for multi create

15 years agoKill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected
Peter Rabbitson [Fri, 31 Oct 2008 23:36:02 +0000]
Kill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected

15 years ago68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
Peter Rabbitson [Fri, 31 Oct 2008 20:34:27 +0000]
68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
bumped up the version of DBD::SQLite required for testing

15 years agoAdjust MANIFEST.SKIP
Peter Rabbitson [Fri, 31 Oct 2008 11:22:38 +0000]
Adjust MANIFEST.SKIP

15 years agoCleanup TODO, delete implemented VERSIONING.SKETCH
Peter Rabbitson [Fri, 31 Oct 2008 11:21:41 +0000]
Cleanup TODO, delete implemented VERSIONING.SKETCH

15 years agoIt seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which...
Peter Rabbitson [Fri, 31 Oct 2008 00:26:58 +0000]
It seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which return unexpected column info - fixing. Should take care of:
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525124.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525137.html