Remove use of Try::Tiny entirely (the missing part of ddcc02d1)
authorPeter Rabbitson <ribasushi@cpan.org>
Mon, 5 Sep 2016 12:27:24 +0000 (14:27 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Tue, 13 Sep 2016 15:34:19 +0000 (17:34 +0200)
commite2741c7fd695dca054614f297b01d351a45bbf38
treea5d810888e5886fe26187521cf0dd71c43a6988c
parent82c5f9168e30bc9dc7b681058298bb342582c5ec
Remove use of Try::Tiny entirely (the missing part of ddcc02d1)

While at the time it seemed expedient to keep relying on Try::Tiny::catch and
only replace Try::Tiny::try internally, it turns out that the current naming
behavior of T::T [1] means we can not get DBIC::Carp to report a friendly
callsite, as finding which catch{} frames are skippable becomes problematic.

Additionally this drops a flurry of runtime Sub::Name calls which in turn
is likely to take less time ( note - this has not been explicitly timed, but
seems to pop up often in profiles: https://youtu.be/PYCbumw0Fis?t=1919 )

In any case - one less dep that we do not really use is always a win

Despite the large changeset there should be zero functional changes

This essentially reverts the entirety of 9b58d129

Read under -w

[1] https://metacpan.org/diff/file?source=DOY/Try-Tiny-0.14&target=DOY/Try-Tiny-0.15#lib/Try/Tiny.pm
39 files changed:
Makefile.PL
lib/DBIx/Class/InflateColumn/DateTime.pm
lib/DBIx/Class/Relationship/Base.pm
lib/DBIx/Class/Relationship/BelongsTo.pm
lib/DBIx/Class/Relationship/HasOne.pm
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/ResultSource/RowParser.pm
lib/DBIx/Class/Schema.pm
lib/DBIx/Class/Storage.pm
lib/DBIx/Class/Storage/BlockRunner.pm
lib/DBIx/Class/Storage/DBI.pm
lib/DBIx/Class/Storage/DBI/MSSQL.pm
lib/DBIx/Class/Storage/DBI/ODBC/Firebird.pm
lib/DBIx/Class/Storage/DBI/ODBC/Microsoft_SQL_Server.pm
lib/DBIx/Class/Storage/DBI/Replicated.pm
lib/DBIx/Class/Storage/DBI/Replicated/Pool.pm
lib/DBIx/Class/Storage/DBI/SQLAnywhere.pm
lib/DBIx/Class/Storage/DBI/SQLite.pm
lib/DBIx/Class/Storage/DBI/Sybase.pm
lib/DBIx/Class/Storage/DBI/Sybase/ASE.pm
lib/DBIx/Class/_Util.pm
lib/SQL/Translator/Parser/DBIx/Class.pm
t/52leaks.t
t/73oracle.t
t/73oracle_blob.t
t/745db2.t
t/746mssql.t
t/747mssql_ado.t
t/749sqlanywhere.t
t/750firebird.t
t/751msaccess.t
t/icdt/engine_specific/msaccess.t
t/icdt/engine_specific/mssql.t
t/icdt/engine_specific/sqlite.t
t/lib/ANFANG.pm
t/storage/debug.t
t/storage/quote_names.t
xt/extra/internals/namespaces_cleaned.t
xt/extra/lean_startup.t