Fix incorrect cond construction in _minimal_valueset_satisfying_constraint
authorPeter Rabbitson <ribasushi@cpan.org>
Tue, 9 Sep 2014 23:38:43 +0000 (01:38 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Wed, 10 Sep 2014 06:58:53 +0000 (08:58 +0200)
commit76cc4546dfc51e7d83add9a90af1eb2d5a7d156c
treeef8588a9ca28868216d26f34944d80af2a6cd7c5
parent81023d83ad94dc8e6601d7c8aad598673f90ad18
Fix incorrect cond construction in _minimal_valueset_satisfying_constraint

The function in question introduced in d681f1bb (which builds upon work in
8e40a627) correctly uses _extract_fixed_condition_columns, but then fails to
account for all literals having their leading { '=' => ... } being stripped,
nor does it consider UNRESOLVABLE_CONDITION as a valid return value.

Tests and fixes to get this rolling, thanks go to Lianna Eeftinck for testing
and reporting \o/
lib/DBIx/Class/ResultSource.pm
t/60core.t
t/resultset/find_on_subquery_cond.t [new file with mode: 0644]