Consider unselected order_by during complex subqueried prefetch
authorPeter Rabbitson <ribasushi@cpan.org>
Sat, 9 Mar 2013 10:57:39 +0000 (11:57 +0100)
committerPeter Rabbitson <ribasushi@cpan.org>
Sun, 10 Mar 2013 11:10:45 +0000 (12:10 +0100)
commit97e130fa48aca5a1255b7014b4cbcb0c30c95328
treea0411625ee40236e501ed196bed87149b614e2b5
parent69e99ee63239ebcdd53f4aaa05c5cea5a54ed624
Consider unselected order_by during complex subqueried prefetch

Augment _resolve_aliastypes_from_select_args to collect the column names
it sees, allowing it to replace _extract_condition_columns() entirely.

In the process fix a number of *incorrect* limit_dialect tests
Changes
lib/DBIx/Class/SQLMaker.pm
lib/DBIx/Class/Storage/DBIHacks.pm
t/prefetch/incomplete.t
t/sqlmaker/limit_dialects/fetch_first.t
t/sqlmaker/limit_dialects/toplimit.t