Audit and minimize use of last major indirect method: search()
authorPeter Rabbitson <ribasushi@cpan.org>
Thu, 22 Sep 2016 09:46:18 +0000 (11:46 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Fri, 30 Sep 2016 15:45:56 +0000 (17:45 +0200)
commit367eaf50970dd3fd223ce5e1f0337703f2a6c70e
tree154e480bcba690ad7d72c5cda2a45a08905bd8cd
parenta580a22749565b3b07f583bc04412e6dc0c84ab2
Audit and minimize use of last major indirect method: search()

I am not entirely sure how I missed it during 1b822bd3, but oh well. This
should be the last highly volatile part ( as far as downstream is concerned ).

As previously - zero functional changes apart from no longer calling search()
at several spots (the SanityChecker ensures none of this results in silent
breakage)

All spots that *do* require wantarray()-specific behavior remained explicit
wrappers for search(), instead of doing the wantarray() check themselves: this
is a deliberate choice to allow DBIC::Helpers::ResultSet::IgnoreWantarray or
similar libraries to continue operating by simply hooking the search() method
lib/DBIx/Class/Admin.pm
lib/DBIx/Class/CDBICompat/LazyLoading.pm
lib/DBIx/Class/Ordered.pm
lib/DBIx/Class/Relationship/Base.pm
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/ResultSetColumn.pm
lib/DBIx/Class/Row.pm
lib/DBIx/Class/Schema/Versioned.pm
lib/DBIx/Class/_Util.pm