Add strict/warnings test, adjust all offenders (wow, that was a lot)

[dbsrgits/DBIx-Class.git] / t / cdbi / 14-might_have.t

diff --git a/t/cdbi/14-might_have.t b/t/cdbi/14-might_have.t
index b309edc..73318ac 100644 (file)
--- a/t/cdbi/14-might_have.t
+++ b/t/cdbi/14-might_have.t
@@ -1,16 +1,7 @@
 use strict;
+use warnings;
 use Test::More;
 
-BEGIN {
-  eval "use DBIx::Class::CDBICompat;";
-  if ($@) {
-    plan (skip_all => 'Class::Trigger and DBIx::ContextualFetch required');
-    next;
-  }
-  eval "use DBD::SQLite";
-  plan $@ ? (skip_all => 'needs DBD::SQLite for testing') : (tests => 22);
-}
-
 use lib 't/cdbi/testlib';
 use Film;
 use Blurb;
@@ -26,45 +17,45 @@ Film->might_have(info => Blurb => qw/blurb/);
 Film->create_test_film;
 
 {
-       ok my $bt = Film->retrieve('Bad Taste'), "Get Film";
-       isa_ok $bt, "Film";
-       is $bt->info, undef, "No blurb yet";
-       # bug where we couldn't write a class with a might_have that didn't_have
-       $bt->rating(16);
-       eval { $bt->update };
-       is $@, '', "No problems updating when don't have";
-       is $bt->rating, 16, "Updated OK";
-
-       is $bt->blurb, undef, "Bad taste has no blurb";
-       $bt->blurb("Wibble bar");
-       $bt->update;
-       is $bt->blurb, "Wibble bar", "And we can write the info";
+  ok my $bt = Film->retrieve('Bad Taste'), "Get Film";
+  isa_ok $bt, "Film";
+  is $bt->info, undef, "No blurb yet";
+  # bug where we couldn't write a class with a might_have that didn't_have
+  $bt->rating(16);
+  eval { $bt->update };
+  is $@, '', "No problems updating when don't have";
+  is $bt->rating, 16, "Updated OK";
+
+  is $bt->blurb, undef, "Bad taste has no blurb";
+  $bt->blurb("Wibble bar");
+  $bt->update;
+  is $bt->blurb, "Wibble bar", "And we can write the info";
 }
 
 {
-       my $bt   = Film->retrieve('Bad Taste');
-       my $info = $bt->info;
-       isa_ok $info, 'Blurb';
-
-       is $bt->blurb, $info->blurb, "Blurb is the same as fetching the long way";
-       ok $bt->blurb("New blurb"), "We can set the blurb";
-       $bt->update;
-       is $bt->blurb, $info->blurb, "Blurb has been set";
-
-       $bt->rating(18);
-       eval { $bt->update };
-       is $@, '', "No problems updating when do have";
-       is $bt->rating, 18, "Updated OK";
-
-       # cascade delete?
-       {
-               my $blurb = Blurb->retrieve('Bad Taste');
-               isa_ok $blurb => "Blurb";
-               $bt->delete;
-               $blurb = Blurb->retrieve('Bad Taste');
-               is $blurb, undef, "Blurb has gone";
-       }
-               
+  my $bt   = Film->retrieve('Bad Taste');
+  my $info = $bt->info;
+  isa_ok $info, 'Blurb';
+
+  is $bt->blurb, $info->blurb, "Blurb is the same as fetching the long way";
+  ok $bt->blurb("New blurb"), "We can set the blurb";
+  $bt->update;
+  is $bt->blurb, $info->blurb, "Blurb has been set";
+
+  $bt->rating(18);
+  eval { $bt->update };
+  is $@, '', "No problems updating when do have";
+  is $bt->rating, 18, "Updated OK";
+
+  # cascade delete?
+  {
+    my $blurb = Blurb->retrieve('Bad Taste');
+    isa_ok $blurb => "Blurb";
+    $bt->delete;
+    $blurb = Blurb->retrieve('Bad Taste');
+    is $blurb, undef, "Blurb has gone";
+  }
+
 }
 
 {
@@ -80,4 +71,6 @@ Film->create_test_film;
     ok $host->info->delete;
     $host->discard_changes;
     ok !$host->info, 'relationships rechecked after discard_changes';
-}
\ No newline at end of file
+}
+
+done_testing;