Fix RT#58554 (make sure FOR X is always the last part of a select)

[dbsrgits/DBIx-Class.git] / t / 745db2.t

diff --git a/t/745db2.t b/t/745db2.t
index 5822f35..c323529 100644 (file)
--- a/t/745db2.t
+++ b/t/745db2.t
@@ -1,5 +1,5 @@
 use strict;
-use warnings;  
+use warnings;
 
 use Test::More;
 use Test::Exception;
@@ -24,17 +24,17 @@ $dbh->do("CREATE TABLE artist (artistid INTEGER GENERATED BY DEFAULT AS IDENTITY
 my $ars = $schema->resultset('Artist');
 is ( $ars->count, 0, 'No rows at first' );
 
-# test primary key handling 
+# test primary key handling
 my $new = $ars->create({ name => 'foo' });
 ok($new->artistid, "Auto-PK worked");
 
-# test explicit key spec 
+# test explicit key spec
 $new = $ars->create ({ name => 'bar', artistid => 66 });
 is($new->artistid, 66, 'Explicit PK worked');
 $new->discard_changes;
 is($new->artistid, 66, 'Explicit PK assigned');
 
-# test populate 
+# test populate
 lives_ok (sub {
   my @pop;
   for (1..2) {
@@ -43,7 +43,7 @@ lives_ok (sub {
   $ars->populate (\@pop);
 });
 
-# test populate with explicit key 
+# test populate with explicit key
 lives_ok (sub {
   my @pop;
   for (1..2) {
@@ -51,11 +51,11 @@ lives_ok (sub {
   }
   $ars->populate (\@pop);
 });
-  
-# count what we did so far 
+
+# count what we did so far
 is ($ars->count, 6, 'Simple count works');
 
-# test LIMIT support 
+# test LIMIT support
 my $lim = $ars->search( {},
   {
     rows => 3,
@@ -63,10 +63,23 @@ my $lim = $ars->search( {},
     order_by => 'artistid'
   }
 );
-is( $lim->count, 2, 'LIMIT+OFFSET count ok' );
+is( $lim->count, 2, 'ROWS+OFFSET count ok' );
 is( $lim->all, 2, 'Number of ->all objects matches count' );
 
-# test iterator 
+# Limit with select-lock
+TODO: {
+  local $TODO = "Seems we can't SELECT ... FOR ... on subqueries";
+  lives_ok {
+    $schema->txn_do (sub {
+      isa_ok (
+        $schema->resultset('Artist')->find({artistid => 1}, {for => 'update', rows => 1}),
+        'DBICTest::Schema::Artist',
+      );
+    });
+  } 'Limited FOR UPDATE select works';
+}
+
+# test iterator
 $lim->reset;
 is( $lim->next->artistid, 101, "iterator->next ok" );
 is( $lim->next->artistid, 102, "iterator->next ok" );
@@ -87,12 +100,12 @@ my $test_type_info = {
     'charfield' => {
         'data_type' => 'CHAR',
         'is_nullable' => 1,
-        'size' => 10 
+        'size' => 10
     },
     'rank' => {
         'data_type' => 'INTEGER',
         'is_nullable' => 1,
-        'size' => 10 
+        'size' => 10
     },
 };