size => 100,
is_nullable => 1,
},
+ 'autoinc_col' => {
+ data_type => 'integer',
+ is_auto_increment => 1,
+ },
);
__PACKAGE__->set_primary_key('artistid');
DBICTest::Schema->load_classes('ArtistFQN');
my $schema = DBICTest::Schema->connect($dsn, $user, $pass);
+note "Oracle Version: " . $schema->storage->_server_info->{dbms_version};
+
my $dbh = $schema->storage->dbh;
do_creates($dbh);
$schema->class('CD')->load_components('PK::Auto::Oracle');
$schema->class('Track')->load_components('PK::Auto::Oracle');
-# test primary key handling
+
+# test primary key handling with multiple triggers
my $new = $schema->resultset('Artist')->create({ name => 'foo' });
is($new->artistid, 1, "Oracle Auto-PK worked");
-my $cd = $schema->resultset('CD')->create({ artist => 1, title => 'EP C', year => '2003' });
-is($cd->cdid, 1, "Oracle Auto-PK worked - using scalar ref as table name");
+like ($new->result_source->column_info('artistid')->{sequence}, qr/\.artist_pk_seq$/, 'Correct PK sequence selected');
# test again with fully-qualified table name
-$new = $schema->resultset('ArtistFQN')->create( { name => 'bar' } );
+my $artistfqn_rs = $schema->resultset('ArtistFQN');
+my $artist_rsrc = $artistfqn_rs->result_source;
+
+delete $artist_rsrc->column_info('artistid')->{sequence};
+
+$new = $artistfqn_rs->create( { name => 'bar' } );
is( $new->artistid, 2, "Oracle Auto-PK worked with fully-qualified tablename" );
+delete $artist_rsrc->column_info('artistid')->{sequence};
+
+$new = $artistfqn_rs->create( { name => 'bar', autoinc_col => 1000 } );
+is( $new->artistid, 3, "Oracle Auto-PK worked with fully-qualified tablename" );
+is( $new->autoinc_col, 1000, "Oracle Auto-Inc overruled with fully-qualified tablename");
+
+like ($artist_rsrc->column_info('artistid')->{sequence}, qr/\.artist_pk_seq$/, 'Still correct PK sequence');
+
+# test LIMIT support
+for (1..6) {
+ $schema->resultset('Artist')->create({ name => 'Artist ' . $_ });
+}
+my $it = $schema->resultset('Artist')->search( { name => { -like => 'Artist %' }},
+ { rows => 3,
+ offset => 4,
+ order_by => 'artistid' }
+);
+is( $it->count, 2, "LIMIT count past end of RS ok" );
+is( $it->next->name, "Artist 5", "iterator->next ok" );
+is( $it->next->name, "Artist 6", "iterator->next ok" );
+is( $it->next, undef, "next past end of resultset ok" );
+
+my $cd = $schema->resultset('CD')->create({ artist => 1, title => 'EP C', year => '2003' });
+is($cd->cdid, 1, "Oracle Auto-PK worked - using scalar ref as table name");
+
# test rel names over the 30 char limit
-my $query = $schema->resultset('Artist')->search({
- artistid => 1
-}, {
- prefetch => 'cds_very_very_very_long_relationship_name'
-});
-
-lives_and {
- is $query->first->cds_very_very_very_long_relationship_name->first->cdid, 1
-} 'query with rel name over 30 chars survived and worked';
-
-# rel name over 30 char limit with user condition
-# This requires walking the SQLA data structure.
{
- local $TODO = 'user condition on rel longer than 30 chars';
-
- $query = $schema->resultset('Artist')->search({
- 'cds_very_very_very_long_relationship_name.title' => 'EP C'
+ my $query = $schema->resultset('Artist')->search({
+ artistid => 1
}, {
prefetch => 'cds_very_very_very_long_relationship_name'
});
lives_and {
is $query->first->cds_very_very_very_long_relationship_name->first->cdid, 1
- } 'query with rel name over 30 chars and user condition survived and worked';
+ } 'query with rel name over 30 chars survived and worked';
+
+ # rel name over 30 char limit with user condition
+ # This requires walking the SQLA data structure.
+ {
+ local $TODO = 'user condition on rel longer than 30 chars';
+
+ $query = $schema->resultset('Artist')->search({
+ 'cds_very_very_very_long_relationship_name.title' => 'EP C'
+ }, {
+ prefetch => 'cds_very_very_very_long_relationship_name'
+ });
+
+ lives_and {
+ is $query->first->cds_very_very_very_long_relationship_name->first->cdid, 1
+ } 'query with rel name over 30 chars and user condition survived and worked';
+ }
}
# test join with row count ambiguity
);
is($tcount->count, 2, 'multiple column COUNT DISTINCT using column syntax ok');
-# test LIMIT support
-for (1..6) {
- $schema->resultset('Artist')->create({ name => 'Artist ' . $_ });
-}
-my $it = $schema->resultset('Artist')->search( {},
- { rows => 3,
- offset => 3,
- order_by => 'artistid' }
-);
-is( $it->count, 3, "LIMIT count ok" );
-is( $it->next->name, "Artist 2", "iterator->next ok" );
-$it->next;
-$it->next;
-is( $it->next, undef, "next past end of resultset ok" );
-
{
my $rs = $schema->resultset('Track')->search( undef, { columns=>[qw/trackid position/], group_by=> [ qw/trackid position/ ] , rows => 2, offset=>1 });
my @results = $rs->all;
);
$schema->resultset('Artist')->find({ name => 'cycle-root' })
- ->update({ parentid => \'artistid' });
+ ->update({ parentid => { -ident => 'artistid' } });
# select the whole tree
{
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
});
is_same_sql_bind (
}
# use order siblings by statement
- {
+ SKIP: {
+ # http://download.oracle.com/docs/cd/A87860_01/doc/server.817/a85397/state21b.htm#2066123
+ skip q{Oracle8i doesn't support ORDER SIBLINGS BY}, 1
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
order_siblings_by => { -desc => 'name' },
});
{
my $rs = $schema->resultset('Artist')->search({ parentid => undef }, {
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
});
is_same_sql_bind (
}
# combine a connect by with a join
- {
+ SKIP: {
+ # http://download.oracle.com/docs/cd/A87860_01/doc/server.817/a85397/state21b.htm#2066123
+ skip q{Oracle8i doesn't support connect by with join}, 1
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+
my $rs = $schema->resultset('Artist')->search(
{'cds.title' => { -like => '%cd'} },
{
join => 'cds',
start_with => { 'me.name' => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
}
);
{
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
order_by => { -asc => [ 'LEVEL', 'name' ] },
});
$rs->as_query,
'(
SELECT me.artistid, me.name, me.rank, me.charfield, me.parentid
- FROM artist me
+ FROM artist me
START WITH name = ?
CONNECT BY parentid = PRIOR artistid
ORDER BY LEVEL ASC, name ASC
[ [ name => 'root' ] ],
);
+
+ # Don't use "$rs->get_column ('name')->all" they build a query arround the $rs.
+ # If $rs has a order by, the order by is in the subquery and this doesn't work with Oracle 8i.
+ # TODO: write extra test and fix order by handling on Oracle 8i
is_deeply (
- [ $rs->get_column ('name')->all ],
+ [ map { $_->[1] } $rs->cursor->all ],
[ qw/root child1 child2 grandchild greatgrandchild/ ],
- 'Connect By with a order_by - result name ok'
+ 'Connect By with a order_by - result name ok (without get_column)'
);
+
+ SKIP: {
+ skip q{Connect By with a order_by - result name ok (with get_column), Oracle8i doesn't support order by in a subquery},1
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+ is_deeply (
+ [ $rs->get_column ('name')->all ],
+ [ qw/root child1 child2 grandchild greatgrandchild/ ],
+ 'Connect By with a order_by - result name ok (with get_column)'
+ );
+ }
}
# limit a connect by
- {
+ SKIP: {
+ skip q{Oracle8i doesn't support order by in a subquery}, 1
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
order_by => { -asc => 'name' },
rows => 2,
});
is_same_sql_bind (
$rs->as_query,
- '(
+ '(
SELECT artistid, name, rank, charfield, parentid FROM (
- SELECT artistid, name, rank, charfield, parentid, ROWNUM rownum__index FROM (
- SELECT
- me.artistid,
- me.name,
- me.rank,
- me.charfield,
- me.parentid
- FROM artist me
- START WITH name = ?
- CONNECT BY parentid = PRIOR artistid
- ORDER BY name ASC
- ) me
+ SELECT
+ me.artistid,
+ me.name,
+ me.rank,
+ me.charfield,
+ me.parentid
+ FROM artist me
+ START WITH name = ?
+ CONNECT BY parentid = PRIOR artistid
+ ORDER BY name ASC
) me
- WHERE rownum__index BETWEEN 1 AND 2
+ WHERE ROWNUM <= 2
)',
[ [ name => 'root' ] ],
);
'LIMIT a Connect By query - correct names'
);
- # TODO:
- # prints "START WITH name = ?
- # CONNECT BY artistid = PRIOR parentid "
- # after count_subq,
- # I will fix this later...
- #
is_same_sql_bind (
$rs->count_rs->as_query,
- '(
- SELECT COUNT( * ) FROM (
- SELECT artistid FROM (
- SELECT artistid, ROWNUM rownum__index FROM (
- SELECT
- me.artistid
- FROM artist me
- START WITH name = ?
- CONNECT BY parentid = PRIOR artistid
- ) me
- ) me
- WHERE rownum__index BETWEEN 1 AND 2
- ) me
+ '(
+ SELECT COUNT( * ) FROM (
+ SELECT artistid
+ FROM (
+ SELECT
+ me.artistid
+ FROM artist me
+ START WITH name = ?
+ CONNECT BY parentid = PRIOR artistid
+ ) me
+ WHERE ROWNUM <= 2
+ ) me
)',
[ [ name => 'root' ] ],
);
my $rs = $schema->resultset('Artist')->search({}, {
select => ['count(rank)'],
start_with => { name => 'root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
group_by => ['rank'],
having => { 'count(rank)' => { '<', 2 } },
});
{
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'cycle-root' },
- connect_by => { parentid => { -prior => \ 'artistid' } },
+ connect_by => { parentid => { -prior => { -ident => 'artistid' } } },
});
eval { $rs->get_column ('name')->all };
if ( $@ =~ /ORA-01436/ ){ # ORA-01436: CONNECT BY loop in user data
}
# select the whole cycle tree with nocylce
- {
+ SKIP: {
+ # http://download.oracle.com/docs/cd/A87860_01/doc/server.817/a85397/expressi.htm#1023748
+ skip q{Oracle8i doesn't support connect by nocycle}, 1
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+
my $rs = $schema->resultset('Artist')->search({}, {
start_with => { name => 'cycle-root' },
'+select' => [ \ 'CONNECT_BY_ISCYCLE' ],
- connect_by_nocycle => { parentid => { -prior => \ 'artistid' } },
+ connect_by_nocycle => { parentid => { -prior => { -ident => 'artistid' } } },
});
is_same_sql_bind (
# test sequence detection from a different schema
SKIP: {
+TODO: {
skip ((join '',
'Set DBICTEST_ORA_EXTRAUSER_DSN, _USER and _PASS to a *DIFFERENT* Oracle user',
' to run the cross-schema autoincrement test.'),
1) unless $dsn2 && $user2 && $user2 ne $user;
+ # Oracle8i Reference Release 2 (8.1.6)
+ # http://download.oracle.com/docs/cd/A87860_01/doc/server.817/a76961/ch294.htm#993
+ # Oracle Database Reference 10g Release 2 (10.2)
+ # http://download.oracle.com/docs/cd/B19306_01/server.102/b14237/statviews_2107.htm#sthref1297
+ local $TODO = "On Oracle8i all_triggers view is empty, i don't yet know why..."
+ if $schema->storage->_server_info->{normalized_dbms_version} < 9;
+
$schema2 = DBICTest::Schema->connect($dsn2, $user2, $pass2);
my $schema1_dbh = $schema->storage->dbh;
$schema1_dbh->do("GRANT INSERT ON artist TO $user2");
- $schema1_dbh->do("GRANT SELECT ON artist_seq TO $user2");
+ $schema1_dbh->do("GRANT SELECT ON artist_pk_seq TO $user2");
my $rs = $schema2->resultset('ArtistFQN');
} 'used autoinc sequence across schemas';
# now quote the sequence name
-
$schema1_dbh->do(qq{
- CREATE OR REPLACE TRIGGER artist_insert_trg
+ CREATE OR REPLACE TRIGGER artist_insert_trg_pk
BEFORE INSERT ON artist
FOR EACH ROW
BEGIN
IF :new.artistid IS NULL THEN
- SELECT "ARTIST_SEQ".nextval
+ SELECT "ARTIST_PK_SEQ".nextval
INTO :new.artistid
FROM DUAL;
END IF;
my $schema_name = uc $user;
is $rs->result_source->column_info('artistid')->{sequence},
- qq[${schema_name}."ARTIST_SEQ"],
+ qq[${schema_name}."ARTIST_PK_SEQ"],
'quoted sequence name correctly extracted';
-}
+} }
done_testing;
my $dbh = shift;
eval {
- $dbh->do("DROP SEQUENCE artist_seq");
+ $dbh->do("DROP SEQUENCE artist_autoinc_seq");
+ $dbh->do("DROP SEQUENCE artist_pk_seq");
$dbh->do("DROP SEQUENCE cd_seq");
$dbh->do("DROP SEQUENCE track_seq");
$dbh->do("DROP SEQUENCE pkid1_seq");
$dbh->do("DROP TABLE track");
$dbh->do("DROP TABLE cd");
};
- $dbh->do("CREATE SEQUENCE artist_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
+ $dbh->do("CREATE SEQUENCE artist_autoinc_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
+ $dbh->do("CREATE SEQUENCE artist_pk_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
$dbh->do("CREATE SEQUENCE cd_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
$dbh->do("CREATE SEQUENCE track_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
$dbh->do("CREATE SEQUENCE pkid1_seq START WITH 1 MAXVALUE 999999 MINVALUE 0");
$dbh->do("CREATE SEQUENCE pkid2_seq START WITH 10 MAXVALUE 999999 MINVALUE 0");
$dbh->do("CREATE SEQUENCE nonpkid_seq START WITH 20 MAXVALUE 999999 MINVALUE 0");
- $dbh->do("CREATE TABLE artist (artistid NUMBER(12), parentid NUMBER(12), name VARCHAR(255), rank NUMBER(38), charfield VARCHAR2(10))");
+ $dbh->do("CREATE TABLE artist (artistid NUMBER(12), parentid NUMBER(12), name VARCHAR(255), autoinc_col NUMBER(12), rank NUMBER(38), charfield VARCHAR2(10))");
$dbh->do("ALTER TABLE artist ADD (CONSTRAINT artist_pk PRIMARY KEY (artistid))");
$dbh->do("CREATE TABLE sequence_test (pkid1 NUMBER(12), pkid2 NUMBER(12), nonpkid NUMBER(12), name VARCHAR(255))");
$dbh->do("ALTER TABLE track ADD (CONSTRAINT track_pk PRIMARY KEY (trackid))");
$dbh->do(qq{
- CREATE OR REPLACE TRIGGER artist_insert_trg
+ CREATE OR REPLACE TRIGGER artist_insert_trg_auto
BEFORE INSERT ON artist
FOR EACH ROW
BEGIN
- IF :new.artistid IS NULL THEN
- SELECT artist_seq.nextval
- INTO :new.artistid
+ IF :new.autoinc_col IS NULL THEN
+ SELECT artist_autoinc_seq.nextval
+ INTO :new.autoinc_col
FROM DUAL;
END IF;
END;
});
$dbh->do(qq{
- CREATE OR REPLACE TRIGGER cd_insert_trg
- BEFORE INSERT OR UPDATE ON cd
+ CREATE OR REPLACE TRIGGER artist_insert_trg_pk
+ BEFORE INSERT ON artist
FOR EACH ROW
BEGIN
- IF :new.cdid IS NULL THEN
- SELECT cd_seq.nextval
- INTO :new.cdid
+ IF :new.artistid IS NULL THEN
+ SELECT artist_pk_seq.nextval
+ INTO :new.artistid
FROM DUAL;
END IF;
END;
});
$dbh->do(qq{
CREATE OR REPLACE TRIGGER cd_insert_trg
- BEFORE INSERT ON cd
+ BEFORE INSERT OR UPDATE ON cd
FOR EACH ROW
BEGIN
IF :new.cdid IS NULL THEN
END {
for my $dbh (map $_->storage->dbh, grep $_, ($schema, $schema2)) {
eval {
- $dbh->do("DROP SEQUENCE artist_seq");
+ $dbh->do("DROP SEQUENCE artist_autoinc_seq");
+ $dbh->do("DROP SEQUENCE artist_pk_seq");
$dbh->do("DROP SEQUENCE cd_seq");
$dbh->do("DROP SEQUENCE track_seq");
$dbh->do("DROP SEQUENCE pkid1_seq");
projects / dbsrgits/DBIx-Class.git / blobdiff