Automatically mark the cap. framework methods as unimplemented for replication

[dbsrgits/DBIx-Class.git] / lib / DBIx / Class / Storage / DBI / Replicated.pm

diff --git a/lib/DBIx/Class/Storage/DBI/Replicated.pm b/lib/DBIx/Class/Storage/DBI/Replicated.pm
index 0511253..7fff40e 100644 (file)
--- a/lib/DBIx/Class/Storage/DBI/Replicated.pm
+++ b/lib/DBIx/Class/Storage/DBI/Replicated.pm
@@ -356,7 +356,7 @@ has 'write_handler' => (
     _resolve_column_info
     _prune_unused_joins
     _strip_cond_qualifiers
-    _parse_order_by
+    _extract_order_columns
     _resolve_aliastypes_from_select_args
     _execute
     _do_query
@@ -376,25 +376,20 @@ my @unimplemented = qw(
   set_use_dbms_capability
   get_dbms_capability
   set_dbms_capability
-
-  sql_limit_dialect
-
   _dbh_details
 
-  _use_insert_returning
-  _supports_insert_returning
-
-  _use_placeholders
-  _supports_placeholders
-  _determine_supports_placeholders
-
-  _use_typeless_placeholders
-  _supports_typeless_placeholders
-  _determine_supports_typeless_placeholders
+  sql_limit_dialect
 
   _inner_join_to_node
 );
 
+# the capability framework
+# not sure if CMOP->initialize does evil things to DBIC::S::DBI, fix if a problem
+push @unimplemented, ( grep
+  { $_ =~ /^ _ (?: use | supports | determine_supports ) _ /x }
+  ( Class::MOP::Class->initialize('DBIx::Class::Storage::DBI')->get_all_method_names )
+);
+
 for my $method (@unimplemented) {
   __PACKAGE__->meta->add_method($method, sub {
     croak "$method must not be called on ".(blessed shift).' objects';
@@ -754,7 +749,7 @@ sub limit_dialect {
   foreach my $source ($self->all_storages) {
     $source->limit_dialect(@_);
   }
-  return $self->master->quote_char;
+  return $self->master->limit_dialect;
 }
 
 =head2 quote_char