use strict;
use warnings;
-use Carp::Clan qw/^DBIx::Class/;
-use Sub::Name qw/subname/;
-use Scalar::Util qw/blessed/;
+use DBIx::Class::Carp;
+use DBIx::Class::_Util qw( quote_sub perlstring );
+
+# FIXME - this souldn't be needed
+my $cu;
+BEGIN { $cu = \&carp_unique }
use namespace::clean;
"missing foreign relation in many-to-many"
) unless $f_rel;
- {
- no strict 'refs';
- no warnings 'redefine';
-
my $add_meth = "add_to_${meth}";
my $remove_meth = "remove_from_${meth}";
my $set_meth = "set_${meth}";
}
}
- $rel_attrs->{alias} ||= $f_rel;
-
- my $rs_meth_name = join '::', $class, $rs_meth;
- *$rs_meth_name = subname $rs_meth_name, sub {
- my $self = shift;
- my $attrs = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
- my @args = ($f_rel, @_ > 0 ? @_ : undef, { %{$rel_attrs||{}}, %$attrs });
- my $rs = $self->search_related($rel)->search_related(
- $f_rel, @_ > 0 ? @_ : undef, { %{$rel_attrs||{}}, %$attrs }
+ my @main_meth_qsub_args = (
+ {},
+ { attributes => [
+ 'DBIC_method_is_indirect_sugar',
+ ( keys( %{$rel_attrs||{}} )
+ ? 'DBIC_method_is_m2m_sugar_with_attrs'
+ : 'DBIC_method_is_m2m_sugar'
+ ),
+ ] },
+ );
+
+
+ quote_sub "${class}::${meth}", sprintf( <<'EOC', $rs_meth ), @main_meth_qsub_args;
+
+ DBIx::Class::_ENV_::ASSERT_NO_INTERNAL_INDIRECT_CALLS and DBIx::Class::_Util::fail_on_internal_call;
+ DBIx::Class::_ENV_::ASSERT_NO_INTERNAL_WANTARRAY and my $sog = DBIx::Class::_Util::fail_on_internal_wantarray;
+
+ my $rs = shift->%s( @_ );
+
+ wantarray ? $rs->all : $rs;
+EOC
+
+
+ my @extra_meth_qsub_args = (
+ {
+ '$rel_attrs' => \{ alias => $f_rel, %{ $rel_attrs||{} } },
+ '$carp_unique' => \$cu,
+ },
+ { attributes => [
+ 'DBIC_method_is_indirect_sugar',
+ ( keys( %{$rel_attrs||{}} )
+ ? 'DBIC_method_is_m2m_extra_sugar_with_attrs'
+ : 'DBIC_method_is_m2m_extra_sugar'
+ ),
+ ] },
+ );
+
+
+ quote_sub "${class}::${rs_meth}", sprintf( <<'EOC', map { perlstring $_ } ( "${class}::${meth}", $rel, $f_rel ) ), @extra_meth_qsub_args;
+
+ DBIx::Class::_ENV_::ASSERT_NO_INTERNAL_INDIRECT_CALLS
+ and
+ # allow nested calls from our ->many_to_many, see comment below
+ ( (CORE::caller(1))[3] ne %s )
+ and
+ DBIx::Class::_Util::fail_on_internal_call;
+
+ # this little horror is there replicating a deprecation from
+ # within search_rs() itself
+ shift->related_resultset( %s )
+ ->related_resultset( %s )
+ ->search_rs (
+ undef,
+ ( @_ > 1 and ref $_[-1] eq 'HASH' )
+ ? { %%$rel_attrs, %%{ pop @_ } }
+ : $rel_attrs
+ )->search_rs(@_)
+ ;
+EOC
+
+ # the above is the only indirect method, the 3 below have too much logic
+ shift @{$extra_meth_qsub_args[1]{attributes}};
+
+
+ quote_sub "${class}::${add_meth}", sprintf( <<'EOC', $add_meth, $rel, $f_rel ), @extra_meth_qsub_args;
+
+ ( @_ >= 2 and @_ <= 3 ) or $_[0]->throw_exception(
+ "'%1$s' expects an object or hashref to link to, and an optional hashref of link data"
);
- return $rs;
- };
- my $meth_name = join '::', $class, $meth;
- *$meth_name = subname $meth_name, sub {
- my $self = shift;
- my $rs = $self->$rs_meth( @_ );
- return (wantarray ? $rs->all : $rs);
- };
+ $_[0]->throw_exception(
+ "The optional link data supplied to '%1$s' is not a hashref (it was previously ignored)"
+ ) if $_[2] and ref $_[2] ne 'HASH';
- my $add_meth_name = join '::', $class, $add_meth;
- *$add_meth_name = subname $add_meth_name, sub {
- my $self = shift;
- @_ > 0 or $self->throw_exception(
- "${add_meth} needs an object or hashref"
- );
- my $source = $self->result_source;
- my $schema = $source->schema;
- my $rel_source_name = $source->relationship_info($rel)->{source};
- my $rel_source = $schema->resultset($rel_source_name)->result_source;
- my $f_rel_source_name = $rel_source->relationship_info($f_rel)->{source};
- my $f_rel_rs = $schema->resultset($f_rel_source_name)->search({}, $rel_attrs||{});
-
- my $obj;
- if (ref $_[0]) {
- if (ref $_[0] eq 'HASH') {
- $obj = $f_rel_rs->find_or_create($_[0]);
- } else {
- $obj = $_[0];
- }
- } else {
- $obj = $f_rel_rs->find_or_create({@_});
+ my( $self, $far_obj ) = @_;
+
+ my $guard;
+
+ # the API is always expected to return the far object, possibly
+ # creating it in the process
+ if( not defined Scalar::Util::blessed( $far_obj ) ) {
+
+ $guard = $self->result_source->schema->storage->txn_scope_guard;
+
+ # reify the hash into an actual object
+ $far_obj = $self->result_source
+ ->related_source( q{%2$s} )
+ ->related_source( q{%3$s} )
+ ->resultset
+ ->search_rs( undef, $rel_attrs )
+ ->find_or_create( $far_obj );
}
- my $link_vals = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
- my $link = $self->search_related($rel)->new_result($link_vals);
- $link->set_from_related($f_rel, $obj);
+ my $link = $self->new_related(
+ q{%2$s},
+ $_[2] || {},
+ );
+
+ $link->set_from_related( q{%3$s}, $far_obj );
+
$link->insert();
- return $obj;
- };
- my $set_meth_name = join '::', $class, $set_meth;
- *$set_meth_name = subname $set_meth_name, sub {
+ $guard->commit if $guard;
+
+ $far_obj;
+EOC
+
+
+ quote_sub "${class}::${set_meth}", sprintf( <<'EOC', $set_meth, $add_meth, $rel, $f_rel ), @extra_meth_qsub_args;
+
my $self = shift;
- @_ > 0 or $self->throw_exception(
- "{$set_meth} needs a list of objects or hashrefs"
+
+ my $set_to = ( ref $_[0] eq 'ARRAY' )
+ ? ( shift @_ )
+ : do {
+ $carp_unique->(
+ "Calling '%1$s' with a list of items to link to is deprecated, use an arrayref instead"
+ );
+
+ # gobble up everything from @_ into a new arrayref
+ [ splice @_ ]
+ }
+ ;
+
+ # make sure folks are not invoking a bizarre mix of deprecated and curent syntax
+ $self->throw_exception(
+ "'%1$s' expects an arrayref of objects or hashrefs to link to, and an optional hashref of link data"
+ ) if (
+ @_ > 1
+ or
+ ( defined $_[0] and ref $_[0] ne 'HASH' )
);
- my @to_set = (ref($_[0]) eq 'ARRAY' ? @{ $_[0] } : @_);
+
+ my $guard;
+
+ # there will only be a single delete() op, unless we have what to set to
+ $guard = $self->result_source->schema->storage->txn_scope_guard
+ if @$set_to;
+
# if there is a where clause in the attributes, ensure we only delete
# rows that are within the where restriction
- if ($rel_attrs && $rel_attrs->{where}) {
- $self->search_related( $rel, $rel_attrs->{where},{join => $f_rel})->delete;
- } else {
- $self->search_related( $rel, {} )->delete;
- }
+ $self->related_resultset( q{%3$s} )
+ ->search_rs(
+ ( $rel_attrs->{where}
+ ? ( $rel_attrs->{where}, { join => q{%4$s} } )
+ : ()
+ )
+ )->delete;
+
# add in the set rel objects
- $self->$add_meth($_, ref($_[1]) ? $_[1] : {}) for (@to_set);
- };
-
- my $remove_meth_name = join '::', $class, $remove_meth;
- *$remove_meth_name = subname $remove_meth_name, sub {
- my ($self, $obj) = @_;
- $self->throw_exception("${remove_meth} needs an object")
- unless blessed ($obj);
- my $rel_source = $self->search_related($rel)->result_source;
- my $cond = $rel_source->relationship_info($f_rel)->{cond};
- my ($link_cond, $crosstable) = $rel_source->_resolve_condition(
- $cond, $obj, $f_rel, $f_rel
- );
+ $self->%2$s(
+ $_,
+ @_, # at this point @_ is either empty or contains a lone link-data hash
+ ) for @$set_to;
- $self->throw_exception(
- "Custom relationship '$rel' does not resolve to a join-free condition, "
- ."unable to use with the ManyToMany helper '$f_rel'"
- ) if $crosstable;
+ $guard->commit if $guard;
+EOC
+
+
+ # the last method needs no captures - just kill it all with fire
+ $extra_meth_qsub_args[0] = {};
+
+
+ quote_sub "${class}::${remove_meth}", sprintf( <<'EOC', $remove_meth, $rel, $f_rel ), @extra_meth_qsub_args;
+
+ $_[0]->throw_exception("'%1$s' expects an object")
+ unless defined Scalar::Util::blessed( $_[1] );
- $self->search_related($rel, $link_cond)->delete;
- };
+ $_[0]->related_resultset( q{%2$s} )
+ ->search_rs( $_[1]->ident_condition( q{%3$s} ), { join => q{%3$s} } )
+ ->delete;
+EOC
- }
}
1;
projects / dbsrgits/DBIx-Class.git / blobdiff