Fix IC::DT to stop autovivifying columninfo keys

[dbsrgits/DBIx-Class.git] / lib / DBIx / Class / InflateColumn / DateTime.pm

diff --git a/lib/DBIx/Class/InflateColumn/DateTime.pm b/lib/DBIx/Class/InflateColumn/DateTime.pm
index 0966657..dda4a10 100644 (file)
--- a/lib/DBIx/Class/InflateColumn/DateTime.pm
+++ b/lib/DBIx/Class/InflateColumn/DateTime.pm
@@ -4,6 +4,8 @@ use strict;
 use warnings;
 use base qw/DBIx::Class/;
 use Carp::Clan qw/^DBIx::Class/;
+use Try::Tiny;
+use namespace::clean;
 
 =head1 NAME
 
@@ -11,7 +13,7 @@ DBIx::Class::InflateColumn::DateTime - Auto-create DateTime objects from date an
 
 =head1 SYNOPSIS
 
-Load this component and then declare one or more 
+Load this component and then declare one or more
 columns to be of the datetime, timestamp or date datatype.
 
   package Event;
@@ -62,9 +64,9 @@ use C<DateTime::Format::ISO8601> thusly:
 
 =head1 DESCRIPTION
 
-This module figures out the type of DateTime::Format::* class to 
-inflate/deflate with based on the type of DBIx::Class::Storage::DBI::* 
-that you are using.  If you switch from one database to a different 
+This module figures out the type of DateTime::Format::* class to
+inflate/deflate with based on the type of DBIx::Class::Storage::DBI::*
+that you are using.  If you switch from one database to a different
 one your code should continue to work without modification (though note
 that this feature is new as of 0.07, so it may not be perfect yet - bug
 reports to the list very much welcome).
@@ -132,27 +134,24 @@ sub register_column {
       $info->{_ic_dt_method} ||= "timestamp_without_timezone";
     } elsif ($type eq "smalldatetime") {
       $type = "datetime";
-      $info->{_ic_dt_method} ||= "datetime";
+      $info->{_ic_dt_method} ||= "smalldatetime";
     }
   }
 
-  my $timezone;
-  if ( defined $info->{extra}{timezone} ) {
-    carp "Putting timezone into extra => { timezone => '...' } has been deprecated, ".
-         "please put it directly into the '$column' column definition.";
-    $timezone = $info->{extra}{timezone};
-  }
+  if ($info->{extra}) {
+    if ( defined $info->{extra}{timezone} ) {
+      carp "Putting timezone into extra => { timezone => '...' } has been deprecated, ".
+           "please put it directly into the '$column' column definition.";
+      $info->{timezone} = $info->{extra}{timezone} unless defined $info->{timezone};
+    }
 
-  my $locale;
-  if ( defined $info->{extra}{locale} ) {
-    carp "Putting locale into extra => { locale => '...' } has been deprecated, ".
-         "please put it directly into the '$column' column definition.";
-    $locale = $info->{extra}{locale};
+    if ( defined $info->{extra}{locale} ) {
+     carp "Putting locale into extra => { locale => '...' } has been deprecated, ".
+          "please put it directly into the '$column' column definition.";
+     $info->{locale} = $info->{extra}{locale} unless defined $info->{locale};
+    }
   }
 
-  $locale   = $info->{locale}   if defined $info->{locale};
-  $timezone = $info->{timezone} if defined $info->{timezone};
-
   my $undef_if_invalid = $info->{datetime_undef_if_invalid};
 
   if ($type eq 'datetime' || $type eq 'date' || $type eq 'timestamp') {
@@ -172,13 +171,18 @@ sub register_column {
           inflate => sub {
             my ($value, $obj) = @_;
 
-            my $dt = eval { $obj->_inflate_to_datetime( $value, \%info ) };
-            if (my $err = $@ ) {
-              return undef if ($undef_if_invalid);
-              $self->throw_exception ("Error while inflating ${value} for ${column} on ${self}: $err");
-            }
-
-            return $obj->_post_inflate_datetime( $dt, \%info );
+            my $dt = try
+              { $obj->_inflate_to_datetime( $value, \%info ) }
+              catch {
+                $self->throw_exception ("Error while inflating ${value} for ${column} on ${self}: $_")
+                  unless $undef_if_invalid;
+                undef;  # rv
+              };
+
+            return (defined $dt)
+              ? $obj->_post_inflate_datetime( $dt, \%info )
+              : undef
+            ;
           },
           deflate => sub {
             my ($value, $obj) = @_;
@@ -218,24 +222,8 @@ sub _datetime_parser {
 sub _post_inflate_datetime {
   my( $self, $dt, $info ) = @_;
 
-  my $timezone;
-  if (exists $info->{timezone}) {
-    $timezone = $info->{timezone};
-  }
-  elsif (exists $info->{extra} and exists $info->{extra}{timezone}) {
-    $timezone = $info->{extra}{timezone};
-  }
-
-  my $locale;
-  if (exists $info->{locale}) {
-    $locale = $info->{locale};
-  }
-  elsif (exists $info->{extra} and exists $info->{extra}{locale}) {
-    $locale = $info->{extra}{locale};
-  }
-
-  $dt->set_time_zone($timezone) if $timezone;
-  $dt->set_locale($locale) if $locale;
+  $dt->set_time_zone($info->{timezone}) if defined $info->{timezone};
+  $dt->set_locale($info->{locale}) if defined $info->{locale};
 
   return $dt;
 }
@@ -243,33 +231,17 @@ sub _post_inflate_datetime {
 sub _pre_deflate_datetime {
   my( $self, $dt, $info ) = @_;
 
-  my $timezone;
-  if (exists $info->{timezone}) {
-    $timezone = $info->{timezone};
-  }
-  elsif (exists $info->{extra} and exists $info->{extra}{timezone}) {
-    $timezone = $info->{extra}{timezone};
-  }
-
-  my $locale;
-  if (exists $info->{locale}) {
-    $locale = $info->{locale};
-  }
-  elsif (exists $info->{extra} and exists $info->{extra}{locale}) {
-    $locale = $info->{extra}{locale};
-  }
-
-  if ($timezone) {
+  if (defined $info->{timezone}) {
     carp "You're using a floating timezone, please see the documentation of"
       . " DBIx::Class::InflateColumn::DateTime for an explanation"
       if ref( $dt->time_zone ) eq 'DateTime::TimeZone::Floating'
           and not $info->{floating_tz_ok}
           and not $ENV{DBIC_FLOATING_TZ_OK};
 
-    $dt->set_time_zone($timezone);
+    $dt->set_time_zone($info->{timezone});
   }
 
-  $dt->set_locale($locale) if $locale;
+  $dt->set_locale($info->{locale}) if defined $info->{locale};
 
   return $dt;
 }
@@ -327,11 +299,11 @@ use the old way you'll see a warning - please fix your code then!
 
 =over 4
 
-=item More information about the add_columns method, and column metadata, 
+=item More information about the add_columns method, and column metadata,
       can be found in the documentation for L<DBIx::Class::ResultSource>.
 
 =item Further discussion of problems inherent to the Floating timezone:
-      L<Floating DateTimes|DateTime/Floating_DateTimes> 
+      L<Floating DateTimes|DateTime/Floating_DateTimes>
       and L<< $dt->set_time_zone|DateTime/"Set" Methods >>
 
 =back