Add an explicit deduplication of identical condition in cond normalizer
[dbsrgits/DBIx-Class.git] / xt / extra / internals / sqla_condition_parsers.t
CommitLineData
c0329273 1BEGIN { do "./t/lib/ANFANG.pm" or die ( $@ || $! ) }
2
8d005ad9 3use strict;
4use warnings;
5use Test::More;
6use Test::Warn;
e466c62b 7use Test::Exception;
8d005ad9 8
c0329273 9
a5a7bb73 10use DBICTest ':DiffSQL';
8fc4291e 11use DBIx::Class::_Util qw( UNRESOLVABLE_CONDITION dump_value );
497d0451 12use DBIx::Class::SQLMaker::Util qw( normalize_sqla_condition extract_equality_conditions );
8d005ad9 13
ff7d03e6 14BEGIN {
15 if ( eval { require Test::Differences } ) {
16 no warnings 'redefine';
17 *is_deeply = \&Test::Differences::eq_or_diff;
18 }
19}
8d005ad9 20
497d0451 21my $sm = DBICTest->init_schema( no_deploy => 1)->storage->sql_maker;
8d005ad9 22
7638636b 23{
24 package # hideee
25 DBICTest::SillyInt;
26
27 use overload
28 fallback => 1,
29 '0+' => sub { ${$_[0]} },
30 ;
31}
32my $num = bless( \do { my $foo = 69 }, 'DBICTest::SillyInt' );
33
34is($num, 69, 'test overloaded object is "sane"');
35is("$num", 69, 'test overloaded object is "sane"');
36
d6c13bfd 37my $AttUQoLtUaE = 42;
38my $PVIVmaker = $AttUQoLtUaE . '';
39
e466c62b 40my @tests = (
8d005ad9 41 {
42 where => { artistid => 1, charfield => undef },
497d0451 43 normalized => { artistid => 1, charfield => undef },
8d005ad9 44 sql => 'WHERE artistid = ? AND charfield IS NULL',
497d0451 45 equality_extract => { artistid => 1 },
46 equality_considering_nulls_extract => { artistid => 1, charfield => undef },
8d005ad9 47 },
48 {
49 where => { -and => [ artistid => 1, charfield => undef, { rank => 13 } ] },
497d0451 50 normalized => { artistid => 1, charfield => undef, rank => 13 },
8d005ad9 51 sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?',
497d0451 52 equality_extract => { artistid => 1, rank => 13 },
53 equality_considering_nulls_extract => { artistid => 1, charfield => undef, rank => 13 },
8d005ad9 54 },
55 {
56 where => { -and => [ { artistid => 1, charfield => undef}, { rank => 13 } ] },
497d0451 57 normalized => { artistid => 1, charfield => undef, rank => 13 },
8d005ad9 58 sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?',
497d0451 59 equality_extract => { artistid => 1, rank => 13 },
60 equality_considering_nulls_extract => { artistid => 1, charfield => undef, rank => 13 },
8d005ad9 61 },
62 {
63 where => { -and => [ -or => { name => 'Caterwauler McCrae' }, 'rank' ] },
497d0451 64 normalized => { name => 'Caterwauler McCrae', rank => undef },
8d005ad9 65 sql => 'WHERE name = ? AND rank IS NULL',
497d0451 66 equality_extract => { name => 'Caterwauler McCrae' },
67 equality_considering_nulls_extract => { name => 'Caterwauler McCrae', rank => undef },
8d005ad9 68 },
69 {
70 where => { -and => [ [ [ artist => {'=' => \'foo' } ] ], { name => \[ '= ?', 'bar' ] } ] },
497d0451 71 normalized => { artist => {'=' => \'foo' }, name => \[ '= ?', 'bar' ] },
8d005ad9 72 sql => 'WHERE artist = foo AND name = ?',
497d0451 73 equality_extract => { artist => \'foo' },
8d005ad9 74 },
75 {
76 where => { -and => [ -or => { name => 'Caterwauler McCrae', artistid => 2 } ] },
497d0451 77 normalized => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] },
8d005ad9 78 sql => 'WHERE artistid = ? OR name = ?',
497d0451 79 equality_extract => {},
8e40a627 80 },
81 {
82 where => { -or => { name => 'Caterwauler McCrae', artistid => 2 } },
497d0451 83 normalized => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] },
8e40a627 84 sql => 'WHERE artistid = ? OR name = ?',
497d0451 85 equality_extract => {},
8d005ad9 86 },
87 {
7638636b 88 where => { -and => [ \'foo=bar', [ { artistid => { '=', $num } } ], { name => 'Caterwauler McCrae'} ] },
497d0451 89 normalized => { -and => [ \'foo=bar' ], name => 'Caterwauler McCrae', artistid => $num },
8d005ad9 90 sql => 'WHERE foo=bar AND artistid = ? AND name = ?',
497d0451 91 equality_extract => { name => 'Caterwauler McCrae', artistid => $num },
8d005ad9 92 },
93 {
07add744 94 where => { -and => [ \'foo=bar', [ { artistid => { '=', $num } } ], { name => 'Caterwauler McCrae'}, \'buzz=bozz' ] },
d6c13bfd 95 normalized => { -and => [ \'buzz=bozz', \'foo=bar' ], name => 'Caterwauler McCrae', artistid => $num },
497d0451 96 sql => 'WHERE foo=bar AND artistid = ? AND name = ? AND buzz=bozz',
d6c13bfd 97 normalized_sql => 'WHERE buzz=bozz AND foo=bar AND artistid = ? AND name = ?',
497d0451 98 equality_extract => { name => 'Caterwauler McCrae', artistid => $num },
07add744 99 },
100 {
7638636b 101 where => { artistid => [ $num ], rank => [ 13, 2, 3 ], charfield => [ undef ] },
497d0451 102 normalized => { artistid => $num, charfield => undef, rank => [13, 2, 3] },
8d005ad9 103 sql => 'WHERE artistid = ? AND charfield IS NULL AND ( rank = ? OR rank = ? OR rank = ? )',
497d0451 104 equality_extract => { artistid => $num },
105 equality_considering_nulls_extract => { artistid => $num, charfield => undef },
8d005ad9 106 },
107 {
108 where => { artistid => { '=' => 1 }, rank => { '>' => 12 }, charfield => { '=' => undef } },
497d0451 109 normalized => { artistid => 1, charfield => undef, rank => { '>' => 12 } },
8d005ad9 110 sql => 'WHERE artistid = ? AND charfield IS NULL AND rank > ?',
497d0451 111 equality_extract => { artistid => 1 },
112 equality_considering_nulls_extract => { artistid => 1, charfield => undef },
8d005ad9 113 },
114 {
953d5b7d 115 where => { artistid => { '=' => [ 1 ], }, charfield => { '=' => [ -AND => \'1', \['?',2] ] }, rank => { '=' => [ -OR => $num, $num ] } },
d6c13bfd 116 normalized => { artistid => 1, charfield => [-and => { '=' => \'1' }, { '=' => \['?',2] } ], rank => { '=' => [$num, $num] } },
497d0451 117 sql => 'WHERE artistid = ? AND charfield = 1 AND charfield = ? AND ( rank = ? OR rank = ? )',
497d0451 118 equality_extract => { artistid => 1, charfield => UNRESOLVABLE_CONDITION },
8d005ad9 119 },
120 {
121 where => { -and => [ artistid => 1, artistid => 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => [ -or => { '=', 2 } ], rank => [-and => undef, { '=', undef }, { '!=', 2 } ] },
497d0451 122 normalized => { artistid => [ -and => 1, 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => 2, rank => [ -and => { '!=', 2 }, undef ] },
123 sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank IS NULL AND rank IS NULL AND rank != ?',
124 normalized_sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank != ? AND rank IS NULL',
125 equality_extract => {
8e40a627 126 artistid => UNRESOLVABLE_CONDITION,
127 name => 2,
128 charfield => 2,
129 },
497d0451 130 equality_considering_nulls_extract => {
8e40a627 131 artistid => UNRESOLVABLE_CONDITION,
132 name => 2,
133 charfield => 2,
134 rank => undef,
135 },
8d005ad9 136 },
135ac69d 137 (map { {
138 where => $_,
497d0451 139 sql => 'WHERE (rank = 13 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank != 42)',
d6c13bfd 140 normalized_sql => 'WHERE (artistid = ? OR charfield IS NULL OR rank != 42) AND (artistid = ? OR charfield IS NULL OR rank = 13)',
497d0451 141 normalized => { -and => [
135ac69d 142 { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] },
d6c13bfd 143 { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] },
135ac69d 144 ] },
497d0451 145 equality_extract => {},
146 equality_considering_nulls_extract => {},
135ac69d 147 } } (
ff7d03e6 148
135ac69d 149 { -and => [
150 -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ],
d6c13bfd 151 -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \$AttUQoLtUaE } },
135ac69d 152 ] },
153
154 {
155 -OR => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ],
156 -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } },
157 },
ff7d03e6 158
135ac69d 159 ) ),
160 {
c1f3f2e8 161 where => { -or => [
162 -and => [ foo => { '!=', { -value => undef } }, bar => { -in => [ 69, 42 ] } ],
163 foo => { '=', { -value => undef } },
164 baz => { '!=' => { -ident => 'bozz' } },
165 baz => { -ident => 'buzz' },
166 ] },
497d0451 167 sql => 'WHERE ( foo IS NOT NULL AND bar IN ( ?, ? ) ) OR foo IS NULL OR baz != bozz OR baz = buzz',
168 normalized_sql => 'WHERE baz != bozz OR baz = buzz OR foo IS NULL OR ( bar IN ( ?, ? ) AND foo IS NOT NULL )',
169 normalized => { -or => [
c1f3f2e8 170 baz => { '!=' => { -ident => 'bozz' } },
171 baz => { '=' => { -ident => 'buzz' } },
95da0f23 172 foo => undef,
173 { bar => { -in => [ 69, 42 ] }, foo => { '!=', undef } }
174 ] },
497d0451 175 equality_extract => {},
95da0f23 176 },
177 {
135ac69d 178 where => { -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => { '=' => 1 }, genreid => { '=' => \['?', 2] } ] },
497d0451 179 sql => 'WHERE rank = 13 OR charfield IS NULL OR artistid = ? OR genreid = ?',
180 normalized_sql => 'WHERE artistid = ? OR charfield IS NULL OR genreid = ? OR rank = 13',
181 normalized => { -or => [ artistid => 1, charfield => undef, genreid => { '=' => \['?', 2] }, rank => { '=' => \13 } ] },
182 equality_extract => {},
183 equality_considering_nulls_extract => {},
135ac69d 184 },
185 {
186 where => { -and => [
d6c13bfd 187 -or => [ rank => { '=' => \$AttUQoLtUaE }, charfield => { '=' => undef }, artistid => 1 ],
188 -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '=' => \42 } },
135ac69d 189 ] },
d6c13bfd 190 normalized => {
191 -or => [ artistid => 1, charfield => undef, rank => { '=' => \42 } ],
192 },
193 sql => 'WHERE (rank = 42 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank = 42)',
194 normalized_sql => 'WHERE artistid = ? OR charfield IS NULL OR rank = 42',
497d0451 195 equality_extract => {},
196 equality_considering_nulls_extract => {},
135ac69d 197 },
198 {
199 where => { -and => [
d6c13bfd 200 { -or => [ \42 ] },
201 { -and => [
202 { -or => [ \$AttUQoLtUaE ] },
203 { -or => [ \13 ] },
204 ] },
205 ] },
206 normalized => {
207 -and => [ \13, \42 ],
208 },
209 sql => 'WHERE 42 AND 42 AND 13',
210 normalized_sql => 'WHERE 13 AND 42',
211 equality_extract => {},
212 },
213 {
214 where => { -and => [
135ac69d 215 -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ],
216 -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } },
217 -and => [ foo => { '=' => \1 }, bar => 2 ],
218 -and => [ foo => 3, bar => { '=' => \4 } ],
219 -exists => \'(SELECT 1)',
220 -exists => \'(SELECT 2)',
221 -not => { foo => 69 },
222 -not => { foo => 42 },
223 ]},
224 sql => 'WHERE
225 ( rank = 13 OR charfield IS NULL OR artistid = ? )
226 AND ( artistid = ? OR charfield IS NULL OR rank != 42 )
227 AND foo = 1
228 AND bar = ?
229 AND foo = ?
230 AND bar = 4
231 AND (EXISTS (SELECT 1))
232 AND (EXISTS (SELECT 2))
233 AND NOT foo = ?
234 AND NOT foo = ?
235 ',
497d0451 236 normalized_sql => 'WHERE
d6c13bfd 237 (EXISTS (SELECT 1))
135ac69d 238 AND (EXISTS (SELECT 2))
239 AND NOT foo = ?
240 AND NOT foo = ?
d6c13bfd 241 AND ( artistid = ? OR charfield IS NULL OR rank != 42 )
242 AND ( artistid = ? OR charfield IS NULL OR rank = 13 )
135ac69d 243 AND bar = 4
244 AND bar = ?
245 AND foo = 1
246 AND foo = ?
247 ',
497d0451 248 normalized => {
135ac69d 249 -and => [
135ac69d 250 { -exists => \'(SELECT 1)' },
251 { -exists => \'(SELECT 2)' },
135ac69d 252 { -not => { foo => 42 } },
d6c13bfd 253 { -not => { foo => 69 } },
254 { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] },
255 { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] },
135ac69d 256 ],
257 foo => [ -and => { '=' => \1 }, 3 ],
258 bar => [ -and => { '=' => \4 }, 2 ],
259 },
497d0451 260 equality_extract => {
135ac69d 261 foo => UNRESOLVABLE_CONDITION,
262 bar => UNRESOLVABLE_CONDITION,
263 },
497d0451 264 equality_considering_nulls_extract => {
135ac69d 265 foo => UNRESOLVABLE_CONDITION,
266 bar => UNRESOLVABLE_CONDITION,
267 },
268 },
8d005ad9 269 {
270 where => { -and => [
271 [ '_macro.to' => { -like => '%correct%' }, '_wc_macros.to' => { -like => '%correct%' } ],
272 { -and => [ { 'group.is_active' => 1 }, { 'me.is_active' => 1 } ] }
273 ] },
497d0451 274 normalized => {
8d005ad9 275 'group.is_active' => 1,
276 'me.is_active' => 1,
277 -or => [
278 '_macro.to' => { -like => '%correct%' },
279 '_wc_macros.to' => { -like => '%correct%' },
280 ],
281 },
282 sql => 'WHERE ( _macro.to LIKE ? OR _wc_macros.to LIKE ? ) AND group.is_active = ? AND me.is_active = ?',
497d0451 283 equality_extract => { 'group.is_active' => 1, 'me.is_active' => 1 },
8d005ad9 284 },
5f35ba0f 285
b5ce6748 286 {
5f35ba0f 287 where => { -and => [
288 artistid => { -value => [1] },
289 charfield => { -ident => 'foo' },
290 name => { '=' => { -value => undef } },
291 rank => { '=' => { -ident => 'bar' } },
aa072cab 292 arrayfield => { '>' => { -value => [3,1] } },
5f35ba0f 293 ] },
497d0451 294 normalized => {
5f35ba0f 295 artistid => { -value => [1] },
296 name => undef,
297 charfield => { '=', { -ident => 'foo' } },
298 rank => { '=' => { -ident => 'bar' } },
aa072cab 299 arrayfield => { '>' => { -value => [3,1] } },
5f35ba0f 300 },
aa072cab 301 sql => 'WHERE artistid = ? AND charfield = foo AND name IS NULL AND rank = bar AND arrayfield > ?',
302 normalized_sql => 'WHERE arrayfield > ? AND artistid = ? AND charfield = foo AND name IS NULL AND rank = bar',
497d0451 303 equality_extract => {
5f35ba0f 304 artistid => [1],
305 charfield => { -ident => 'foo' },
306 rank => { -ident => 'bar' },
307 },
497d0451 308 equality_considering_nulls_extract => {
5f35ba0f 309 artistid => [1],
310 name => undef,
311 charfield => { -ident => 'foo' },
312 rank => { -ident => 'bar' },
313 },
b5ce6748 314 },
5f35ba0f 315
8d005ad9 316 {
317 where => { artistid => [] },
497d0451 318 normalized => { artistid => [] },
319 equality_extract => {},
8d005ad9 320 },
321 (map {
322 {
323 where => { -and => $_ },
497d0451 324 normalized => undef,
325 equality_extract => {},
8d005ad9 326 sql => '',
327 },
328 {
329 where => { -or => $_ },
497d0451 330 normalized => undef,
331 equality_extract => {},
8d005ad9 332 sql => '',
333 },
22485a7e 334 {
335 where => { -or => [ foo => 1, $_ ] },
497d0451 336 normalized => { foo => 1 },
337 equality_extract => { foo => 1 },
22485a7e 338 sql => 'WHERE foo = ?',
339 },
340 {
341 where => { -or => [ $_, foo => 1 ] },
497d0451 342 normalized => { foo => 1 },
343 equality_extract => { foo => 1 },
22485a7e 344 sql => 'WHERE foo = ?',
345 },
346 {
347 where => { -and => [ fuu => 2, $_, foo => 1 ] },
497d0451 348 sql => 'WHERE fuu = ? AND foo = ?',
349 normalized_sql => 'WHERE foo = ? AND fuu = ?',
350 normalized => { foo => 1, fuu => 2 },
351 equality_extract => { foo => 1, fuu => 2 },
22485a7e 352 },
8d005ad9 353 } (
354 # bare
355 [], {},
356 # singles
357 [ {} ], [ [] ],
358 # doubles
359 [ [], [] ], [ {}, {} ], [ [], {} ], [ {}, [] ],
360 # tripples
361 [ {}, [], {} ], [ [], {}, [] ]
362 )),
363
364 # FIXME legacy compat crap, possibly worth undef/dieing in SQLMaker
497d0451 365 { where => { artistid => {} }, sql => '', normalized => undef, equality_extract => {}, equality_considering_nulls_extract => {} },
8d005ad9 366
367 # batshit insanity, just to be thorough
368 {
369 where => { -and => [ [ 'artistid' ], [ -and => [ artistid => { '!=', 69 }, artistid => undef, artistid => { '=' => 200 } ]], artistid => [], { -or => [] }, { -and => [] }, [ 'charfield' ], { name => [] }, 'rank' ] },
497d0451 370 normalized => { artistid => [ -and => [], { '!=', 69 }, undef, 200 ], charfield => undef, name => [], rank => undef },
371 sql => 'WHERE artistid IS NULL AND artistid != ? AND artistid IS NULL AND artistid = ? AND 0=1 AND charfield IS NULL AND 0=1 AND rank IS NULL',
372 normalized_sql => 'WHERE 0=1 AND artistid != ? AND artistid IS NULL AND artistid = ? AND charfield IS NULL AND 0=1 AND rank IS NULL',
373 equality_extract => { artistid => UNRESOLVABLE_CONDITION },
374 equality_considering_nulls_extract => { artistid => UNRESOLVABLE_CONDITION, charfield => undef, rank => undef },
8d005ad9 375 },
8acda57c 376
377 # original test from RT#93244
378 {
379 where => {
380 -and => [
381 \[
382 "LOWER(me.title) LIKE ?",
383 '%spoon%',
384 ],
385 [ { 'me.title' => 'Spoonful of bees' } ],
386 ]},
497d0451 387 normalized => {
07add744 388 -and => [ \[
8acda57c 389 "LOWER(me.title) LIKE ?",
390 '%spoon%',
07add744 391 ]],
8acda57c 392 'me.title' => 'Spoonful of bees',
393 },
394 sql => 'WHERE LOWER(me.title) LIKE ? AND me.title = ?',
497d0451 395 equality_extract => { 'me.title' => 'Spoonful of bees' },
07add744 396 },
397
398 # crazy literals
399 {
400 where => {
401 -or => [
402 \'foo = bar',
403 ],
404 },
405 sql => 'WHERE foo = bar',
497d0451 406 normalized => {
07add744 407 -and => [
408 \'foo = bar',
409 ],
410 },
497d0451 411 equality_extract => {},
07add744 412 },
413 {
414 where => {
415 -or => [
416 \'foo = bar',
417 \'baz = ber',
418 ],
419 },
497d0451 420 sql => 'WHERE foo = bar OR baz = ber',
421 normalized_sql => 'WHERE baz = ber OR foo = bar',
422 normalized => {
07add744 423 -or => [
424 \'baz = ber',
425 \'foo = bar',
426 ],
427 },
497d0451 428 equality_extract => {},
07add744 429 },
430 {
431 where => {
432 -and => [
433 \'foo = bar',
434 \'baz = ber',
435 ],
436 },
497d0451 437 normalized => {
07add744 438 -and => [
07add744 439 \'baz = ber',
d6c13bfd 440 \'foo = bar',
07add744 441 ],
442 },
d6c13bfd 443 sql => 'WHERE foo = bar AND baz = ber',
444 normalized_sql => 'WHERE baz = ber AND foo = bar',
497d0451 445 equality_extract => {},
07add744 446 },
447 {
448 where => {
449 -and => [
450 \'foo = bar',
451 \'baz = ber',
452 x => { -ident => 'y' },
453 ],
454 },
497d0451 455 normalized => {
07add744 456 -and => [
07add744 457 \'baz = ber',
d6c13bfd 458 \'foo = bar',
07add744 459 ],
460 x => { '=' => { -ident => 'y' } }
461 },
d6c13bfd 462 sql => 'WHERE foo = bar AND baz = ber AND x = y',
463 normalized_sql => 'WHERE baz = ber AND foo = bar AND x = y',
497d0451 464 equality_extract => { x => { -ident => 'y' } },
07add744 465 },
e466c62b 466);
467
468# these die as of SQLA 1.80 - make sure we do not transform them
469# into something usable instead
470for my $lhs (undef, '', { -ident => 'foo' }, { -value => 'foo' } ) {
471 no warnings 'uninitialized';
472
473 for my $w (
474 ( map { { -or => $_ }, (ref $lhs ? () : { @$_ } ) }
475 [ $lhs => "foo" ],
476 [ $lhs => { "=" => "bozz" } ],
477 [ $lhs => { "=" => \"bozz" } ],
478 [ $lhs => { -max => \"bizz" } ],
479 ),
480
481 (ref $lhs) ? () : (
482 { -or => [ -and => { $lhs => "baz" }, bizz => "buzz" ] },
483 { -or => [ foo => "bar", { $lhs => "baz" }, bizz => "buzz" ] },
484 { foo => "bar", -or => { $lhs => "baz" } },
485 { foo => "bar", -or => { $lhs => \"baz" }, bizz => "buzz" },
486 ),
487
488 { foo => "bar", -and => [ $lhs => \"baz" ], bizz => "buzz" },
489 { foo => "bar", -or => [ $lhs => \"baz" ], bizz => "buzz" },
490
491 { -or => [ foo => "bar", [ $lhs => \"baz" ], bizz => "buzz" ] },
492 { -or => [ foo => "bar", $lhs => \"baz", bizz => "buzz" ] },
493 { -or => [ foo => "bar", $lhs => \["baz"], bizz => "buzz" ] },
494 { -or => [ $lhs => \"baz" ] },
495 { -or => [ $lhs => \["baz"] ] },
496
497 ) {
498 push @tests, {
499 where => $w,
500 throw => qr/
501 \QSupplying an empty left hand side argument is not supported in \E(?:array|hash)-pairs
502 |
503 \QIllegal use of top-level '-\E(?:value|ident)'
504 /x,
505 }
506 }
507}
508
509# these are deprecated as of SQLA 1.79 - make sure we do not transform
510# them without losing the warning
511for my $lhs (undef, '') {
512 for my $rhs ( \"baz", \[ "baz" ] ) {
513 no warnings 'uninitialized';
514
515 my $expected_warning = qr/\QHash-pairs consisting of an empty string with a literal are deprecated/;
516
517 push @tests, {
518 where => { $lhs => $rhs },
497d0451 519 normalized => { -and => [ $rhs ] },
520 equality_extract => {},
e466c62b 521 sql => 'WHERE baz',
522 warn => $expected_warning,
523 };
524
525 for my $w (
526 { foo => "bar", -and => { $lhs => $rhs }, bizz => "buzz" },
527 { foo => "bar", $lhs => $rhs, bizz => "buzz" },
528 ) {
529 push @tests, {
530 where => $w,
497d0451 531 normalized => {
e466c62b 532 -and => [ $rhs ],
533 bizz => "buzz",
534 foo => "bar",
535 },
497d0451 536 equality_extract => {
e466c62b 537 foo => "bar",
538 bizz => "buzz",
539 },
540 sql => 'WHERE baz AND bizz = ? AND foo = ?',
541 warn => $expected_warning,
542 };
543 }
544 }
545}
546
547# lots of extra silly tests with a false column
548for my $eq (
549 \"= baz",
550 \[ "= baz" ],
551 { '=' => { -ident => 'baz' } },
552 { '=' => \'baz' },
8d005ad9 553) {
e466c62b 554 for my $where (
555 { foo => "bar", -and => [ 0 => $eq ], bizz => "buzz" },
556 { foo => "bar", -or => [ 0 => $eq ], bizz => "buzz" },
557 { foo => "bar", -and => { 0 => $eq }, bizz => "buzz" },
558 { foo => "bar", -or => { 0 => $eq }, bizz => "buzz" },
559 { foo => "bar", 0 => $eq, bizz => "buzz" },
560 ) {
561 push @tests, {
562 where => $where,
497d0451 563 normalized => {
e466c62b 564 0 => $eq,
565 foo => 'bar',
566 bizz => 'buzz',
567 },
497d0451 568 equality_extract => {
e466c62b 569 foo => 'bar',
570 bizz => 'buzz',
571 ( ref $eq eq 'HASH' ? ( 0 => $eq->{'='} ) : () ),
572 },
573 sql => 'WHERE 0 = baz AND bizz = ? AND foo = ?',
574 };
8d005ad9 575
e466c62b 576 push @tests, {
577 where => { -or => $where },
497d0451 578 normalized => { -or => [
e466c62b 579 "0" => $eq,
580 bizz => 'buzz',
581 foo => 'bar',
582 ]},
497d0451 583 equality_extract => {},
e466c62b 584 sql => 'WHERE 0 = baz OR bizz = ? OR foo = ?',
585 }
586
587 }
588
589 for my $where (
590 [ foo => "bar", -and => [ 0 => $eq ], bizz => "buzz" ],
591 [ foo => "bar", -or => [ 0 => $eq ], bizz => "buzz" ],
592 [ foo => "bar", -and => { 0 => $eq }, bizz => "buzz" ],
593 [ foo => "bar", -or => { 0 => $eq }, bizz => "buzz" ],
594 [ foo => "bar", 0 => $eq, bizz => "buzz" ],
595 ) {
596 push @tests, {
597 where => { -or => $where },
497d0451 598 normalized => { -or => [
e466c62b 599 "0" => $eq,
600 bizz => 'buzz',
601 foo => 'bar',
602 ]},
497d0451 603 equality_extract => {},
604 sql => 'WHERE foo = ? OR 0 = baz OR bizz = ?',
605 normalized_sql => 'WHERE 0 = baz OR bizz = ? OR foo = ?',
e466c62b 606 }
607 }
608
609 for my $where (
610 [ {foo => "bar"}, -and => { 0 => "baz" }, bizz => "buzz" ],
611 [ -or => [ foo => "bar", -or => { 0 => "baz" }, bizz => "buzz" ] ],
612 ) {
613 push @tests, {
614 where => { -or => $where },
497d0451 615 normalized => { -or => [
e466c62b 616 "0" => 'baz',
617 bizz => 'buzz',
618 foo => 'bar',
619 ]},
497d0451 620 equality_extract => {},
621 sql => 'WHERE foo = ? OR 0 = ? OR bizz = ?',
622 normalized_sql => 'WHERE 0 = ? OR bizz = ? OR foo = ?',
e466c62b 623 };
624 }
625
626};
627
628for my $t (@tests) {
8d005ad9 629 for my $w (
630 $t->{where},
953d5b7d 631 $t->{where}, # do it twice, make sure we didn't destory the condition
8d005ad9 632 [ -and => $t->{where} ],
953d5b7d 633 [ -AND => $t->{where} ],
634 { -OR => [ -AND => $t->{where} ] },
e466c62b 635 ( ( keys %{$t->{where}} == 1 and length( (keys %{$t->{where}})[0] ) )
636 ? [ %{$t->{where}} ]
637 : ()
638 ),
8e40a627 639 ( (keys %{$t->{where}} == 1 and $t->{where}{-or})
640 ? ( ref $t->{where}{-or} eq 'HASH'
641 ? [ map { $_ => $t->{where}{-or}{$_} } sort keys %{$t->{where}{-or}} ]
642 : $t->{where}{-or}
643 )
644 : ()
645 ),
8d005ad9 646 ) {
e466c62b 647 die unless Test::Builder->new->is_passing;
648
8fc4291e 649 my $name = do { local $Data::Dumper::Indent = 0; dump_value $w };
8d005ad9 650
497d0451 651 my ($normalized_cond, $normalized_cond_as_sql);
8d005ad9 652
e466c62b 653 if ($t->{throw}) {
654 throws_ok {
497d0451 655 $sm->where( normalize_sqla_condition($w) );
e466c62b 656 } $t->{throw}, "Exception on attempted collapse/render of $name"
657 and
658 next;
659 }
8d005ad9 660
e466c62b 661 warnings_exist {
497d0451 662 $normalized_cond = normalize_sqla_condition($w);
663 ($normalized_cond_as_sql) = $sm->where($normalized_cond);
e466c62b 664 } $t->{warn} || [], "Expected warning when collapsing/rendering $name";
07add744 665
8d005ad9 666 is_deeply(
497d0451 667 $normalized_cond,
668 $t->{normalized},
8d005ad9 669 "Expected collapsed condition produced on $name",
670 );
671
e466c62b 672 my ($original_sql) = do {
673 local $SIG{__WARN__} = sub {};
674 $sm->where($w);
675 };
676
677 is_same_sql ( $original_sql, $t->{sql}, "Expected original SQL from $name" )
678 if exists $t->{sql};
679
680 is_same_sql(
497d0451 681 $normalized_cond_as_sql,
682 ( $t->{normalized_sql} || $t->{sql} || $original_sql ),
683 "Normalization did not alter *the semantics* of the final SQL based on $name",
e466c62b 684 );
685
8d005ad9 686 is_deeply(
497d0451 687 extract_equality_conditions($normalized_cond),
688 $t->{equality_extract},
689 "Expected equality_conditions produced on $name",
8d005ad9 690 );
8e40a627 691
692 is_deeply(
497d0451 693 extract_equality_conditions($normalized_cond, 'consider_nulls'),
694 ( $t->{equality_considering_nulls_extract} || $t->{equality_extract} ),
695 "Expected equality_conditions including NULLs produced on $name",
696 );
ff7d03e6 697
e466c62b 698 is_deeply(
497d0451 699 $normalized_cond,
700 $t->{normalized},
701 "Collapsed condition result unaltered by equality conditions extractor",
e466c62b 702 );
8d005ad9 703 }
704}
705
aa072cab 706# test separately
707is_deeply(
708 normalize_sqla_condition( UNRESOLVABLE_CONDITION ),
709 { -and => [ UNRESOLVABLE_CONDITION ] },
710);
711
8d005ad9 712done_testing;