Now that we have the tools leak-track much more stuff when XS is there
[dbsrgits/DBIx-Class.git] / t / 52leaks.t
CommitLineData
66917da3 1# work around brain damage in PPerl (yes, it has to be a global)
2$SIG{__WARN__} = sub {
3 warn @_ unless $_[0] =~ /\QUse of "goto" to jump into a construct is deprecated/
4} if ($ENV{DBICTEST_IN_PERSISTENT_ENV});
5
6# the persistent environments run with this flag first to see if
7# we will run at all (e.g. it will fail if $^X doesn't match)
8exit 0 if $ENV{DBICTEST_PERSISTENT_ENV_BAIL_EARLY};
9
f05edfd1 10# Do the override as early as possible so that CORE::bless doesn't get compiled away
11# We will replace $bless_override only if we are in author mode
12my $bless_override;
13BEGIN {
14 $bless_override = sub {
15 CORE::bless( $_[0], (@_ > 1) ? $_[1] : caller() );
16 };
17 *CORE::GLOBAL::bless = sub { goto $bless_override };
18}
19
50261284 20use strict;
21use warnings;
a917fb06 22use Test::More;
d5e5fb4b 23
66917da3 24my $TB = Test::More->builder;
25if ($ENV{DBICTEST_IN_PERSISTENT_ENV}) {
7be5717e 26 # without this explicit close older TBs warn in END after a ->reset
27 if ($TB->VERSION < 1.005) {
28 close ($TB->$_) for (qw/output failure_output todo_output/);
29 }
66917da3 30
7be5717e 31 # if I do not do this, I get happy sigpipes on new TB, no idea why
32 # (the above close-and-forget doesn't work - new TB does *not* reopen
33 # its handles automatically anymore)
34 else {
35 for (qw/failure_output todo_output/) {
36 close $TB->$_;
37 open ($TB->$_, '>&', *STDERR);
38 }
66917da3 39
7be5717e 40 close $TB->output;
41 open ($TB->output, '>&', *STDOUT);
42 }
43
44 # so done_testing can work on every persistent pass
45 $TB->reset;
66917da3 46}
47
d5e5fb4b 48use lib qw(t/lib);
49use DBICTest::RunMode;
21aa86aa 50use DBICTest::Util::LeakTracer qw(populate_weakregistry assert_empty_weakregistry visit_refs);
e0b2dc74 51use DBIx::Class;
d12d8272 52BEGIN {
d5e5fb4b 53 plan skip_all => "Your perl version $] appears to leak like a sieve - skipping test"
dee99c24 54 if DBIx::Class::_ENV_::PEEPEENESS;
d12d8272 55}
56
a8c2c746 57# this is what holds all weakened refs to be checked for leakage
58my $weak_registry = {};
59
6a43bc0c 60# whether or to invoke IC::DT
61my $has_dt;
62
a8c2c746 63# Skip the heavy-duty leak tracing when just doing an install
64unless (DBICTest::RunMode->is_plain) {
f05edfd1 65
eb7aa960 66 # redefine the bless override so that we can catch each and every object created
a8c2c746 67 no warnings qw/redefine once/;
68 no strict qw/refs/;
69
f05edfd1 70 $bless_override = sub {
71
a8c2c746 72 my $obj = CORE::bless(
73 $_[0], (@_ > 1) ? $_[1] : do {
74 my ($class, $fn, $line) = caller();
75 fail ("bless() of $_[0] into $class without explicit class specification at $fn line $line")
76 if $class =~ /^ (?: DBIx\:\:Class | DBICTest ) /x;
77 $class;
78 }
79 );
80
8d6b1478 81 # unicode is tricky, and now we happen to invoke it early via a
82 # regex in connection()
83 return $obj if (ref $obj) =~ /^utf8/;
84
7be5717e 85 # Test Builder is now making a new object for every pass/fail (que bloat?)
86 # and as such we can't really store any of its objects (since it will
87 # re-populate the registry while checking it, ewwww!)
88 return $obj if (ref $obj) =~ /^TB2::/;
89
a8c2c746 90 # weaken immediately to avoid weird side effects
65d35121 91 return populate_weakregistry ($weak_registry, $obj );
a8c2c746 92 };
93
eb7aa960 94 require Try::Tiny;
a8c2c746 95 for my $func (qw/try catch finally/) {
96 my $orig = \&{"Try::Tiny::$func"};
97 *{"Try::Tiny::$func"} = sub (&;@) {
65d35121 98 populate_weakregistry( $weak_registry, $_[0] );
a8c2c746 99 goto $orig;
100 }
101 }
eb7aa960 102
103 # Some modules are known to install singletons on-load
104 # Load them and empty the registry
105
106 # this loads the DT armada
107 $has_dt = DBIx::Class::Optional::Dependencies->req_ok_for('test_dt_sqlite');
108
109 require Errno;
110 require DBI;
111 require DBD::SQLite;
112 require FileHandle;
e6ff3658 113 require Moo;
eb7aa960 114
115 %$weak_registry = ();
a8c2c746 116}
117
118{
66917da3 119 use_ok ('DBICTest');
a917fb06 120
a8c2c746 121 my $schema = DBICTest->init_schema;
122 my $rs = $schema->resultset ('Artist');
123 my $storage = $schema->storage;
a917fb06 124
a8c2c746 125 ok ($storage->connected, 'we are connected');
a917fb06 126
052b8ce2 127 my $row_obj = $rs->search({}, { rows => 1})->next; # so that commits/rollbacks work
a8c2c746 128 ok ($row_obj, 'row from db');
129
052b8ce2 130 # txn_do to invoke more codepaths
a8c2c746 131 my ($mc_row_obj, $pager, $pager_explicit_count) = $schema->txn_do (sub {
132
9345b14c 133 my $artist = $schema->resultset('Artist')->create ({
a8c2c746 134 name => 'foo artist',
135 cds => [{
136 title => 'foo cd',
137 year => 1984,
187ec69a 138 tracks => [
139 { title => 't1' },
140 { title => 't2' },
141 ],
142 genre => { name => 'mauve' },
a8c2c746 143 }],
144 });
145
146 my $pg = $rs->search({}, { rows => 1})->page(2)->pager;
147
148 my $pg_wcount = $rs->page(4)->pager->total_entries (66);
149
150 return ($artist, $pg, $pg_wcount);
151 });
152
9345b14c 153 # more codepaths - error handling in txn_do
154 {
155 eval { $schema->txn_do ( sub {
156 $storage->_dbh->begin_work;
157 fail ('how did we get so far?!');
158 } ) };
159
160 eval { $schema->txn_do ( sub {
161 $schema->txn_do ( sub {
162 die "It's called EXCEPTION";
163 fail ('how did we get so far?!');
164 } );
165 fail ('how did we get so far?!');
166 } ) };
167 like( $@, qr/It\'s called EXCEPTION/, 'Exception correctly propagated in nested txn_do' );
168 }
169
170 # dbh_do codepath
187ec69a 171 my ($rs_bind_circref, $cond_rowobj) = $schema->storage->dbh_do ( sub {
172 my $row = $_[0]->schema->resultset('Artist')->new({});
173 my $rs = $_[0]->schema->resultset('Artist')->search({
174 name => $row, # this is deliberately bogus, see FIXME below!
175 });
176 return ($rs, $row);
177 });
178
a8c2c746 179 is ($pager->next_page, 3, 'There is one more page available');
180
181 # based on 66 per 10 pages
182 is ($pager_explicit_count->last_page, 7, 'Correct last page');
551e711a 183
052b8ce2 184 # do some population (invokes some extra codepaths)
185 # also exercise the guard code and the manual txn control
186 {
187 my $guard = $schema->txn_scope_guard;
188 # populate with bindvars
189 $rs->populate([{ name => 'James Bound' }]);
190 $guard->commit;
191
192 $schema->txn_begin;
193 # populate mixed
194 $rs->populate([{ name => 'James Rebound', rank => \ '11' }]);
195 $schema->txn_commit;
196
197 $schema->txn_begin;
198 # and without bindvars
199 $rs->populate([{ name => \ '"James Unbound"' }]);
200 $schema->txn_rollback;
201 }
202
0a03206a 203 # prefetching
204 my $cds_rs = $schema->resultset('CD');
205 my $cds_with_artist = $cds_rs->search({}, { prefetch => 'artist' });
206 my $cds_with_tracks = $cds_rs->search({}, { prefetch => 'tracks' });
207 my $cds_with_stuff = $cds_rs->search({}, { prefetch => [ 'genre', { artist => { cds => { tracks => 'cd_single' } } } ] });
208
209 # implicit pref
210 my $cds_with_impl_artist = $cds_rs->search({}, { columns => [qw/me.title artist.name/], join => 'artist' });
211
212 # get_column
213 my $getcol_rs = $cds_rs->get_column('me.cdid');
214 my $pref_getcol_rs = $cds_with_stuff->get_column('me.cdid');
215
216 # fire the column getters
217 my @throwaway = $pref_getcol_rs->all;
218
a8c2c746 219 my $base_collection = {
a8c2c746 220 resultset => $rs,
307ab4c5 221
0a03206a 222 pref_precursor => $cds_rs,
223
224 pref_rs_single => $cds_with_artist,
225 pref_rs_multi => $cds_with_tracks,
226 pref_rs_nested => $cds_with_stuff,
227
228 pref_rs_implicit => $cds_with_impl_artist,
229
230 pref_row_single => $cds_with_artist->next,
231 pref_row_multi => $cds_with_tracks->next,
232 pref_row_nested => $cds_with_stuff->next,
233
234 # even though this does not leak Storable croaks on it :(((
235 #pref_row_implicit => $cds_with_impl_artist->next,
236
237 get_column_rs_plain => $getcol_rs,
238 get_column_rs_pref => $pref_getcol_rs,
239
37aafa2e 240 # twice so that we make sure only one H::M object spawned
241 chained_resultset => $rs->search_rs ({}, { '+columns' => [ 'foo' ] } ),
242 chained_resultset2 => $rs->search_rs ({}, { '+columns' => [ 'bar' ] } ),
243
a8c2c746 244 row_object => $row_obj,
551e711a 245
187ec69a 246 mc_row_object => $mc_row_obj,
247
a8c2c746 248 result_source => $rs->result_source,
551e711a 249
4376a157 250 result_source_handle => $rs->result_source->handle,
251
a8c2c746 252 pager_explicit_count => $pager_explicit_count,
187ec69a 253
254 leaky_resultset => $rs_bind_circref,
255 leaky_resultset_cond => $cond_rowobj,
a8c2c746 256 };
574d9b69 257
218b7c12 258 # this needs to fire, even if it can't find anything
259 # see FIXME below
344f761c 260 # we run this only on smokers - trying to establish a pattern
261 $rs_bind_circref->next
262 if ( ($ENV{TRAVIS}||'') ne 'true' and DBICTest::RunMode->is_smoker);
218b7c12 263
eb7aa960 264 require Storable;
4376a157 265 %$base_collection = (
266 %$base_collection,
267 refrozen => Storable::dclone( $base_collection ),
268 rerefrozen => Storable::dclone( Storable::dclone( $base_collection ) ),
0a03206a 269 pref_row_implicit => $cds_with_impl_artist->next,
4376a157 270 schema => $schema,
271 storage => $storage,
272 sql_maker => $storage->sql_maker,
273 dbh => $storage->_dbh,
cd122820 274 fresh_pager => $rs->page(5)->pager,
275 pager => $pager,
4376a157 276 );
277
21aa86aa 278 # FIXME - ideally this kind of collector ought to be global, but attempts
279 # with an invasive debugger-based tracer did not quite work out... yet
280 # Manually scan the innards of everything we have in the base collection
281 # we assembled so far (skip the DT madness below) *recursively*
282 #
283 # Only do this when we do have the bits to look inside CVs properly,
284 # without it we are liable to pick up object defaults that are locked
285 # in method closures
286 if (DBICTest::Util::LeakTracer::CV_TRACING) {
287 visit_refs(
288 refs => [ $base_collection ],
289 action => sub {
290 populate_weakregistry ($weak_registry, $_[0]);
291 1; # true means "keep descending"
292 },
293 );
294 }
295
6a43bc0c 296 if ($has_dt) {
297 my $rs = $base_collection->{icdt_rs} = $schema->resultset('Event');
298
299 my $now = DateTime->now;
300 for (1..5) {
301 $base_collection->{"icdt_row_$_"} = $rs->create({
302 created_on => DateTime->new(year => 2011, month => 1, day => $_, time_zone => "-0${_}00" ),
303 starts_at => $now->clone->add(days => $_),
304 });
305 }
306
307 # re-search
308 my @dummy = $rs->all;
309 }
310
eb7aa960 311 # dbh's are created in XS space, so pull them separately
312 for ( grep { defined } map { @{$_->{ChildHandles}} } values %{ {DBI->installed_drivers()} } ) {
313 $base_collection->{"DBI handle $_"} = $_;
314 }
315
65d35121 316 populate_weakregistry ($weak_registry, $base_collection->{$_}, "basic $_")
317 for keys %$base_collection;
551e711a 318}
319
50261284 320# check that "phantom-chaining" works - we never lose track of the original $schema
321# and have access to the entire tree without leaking anything
322{
323 my $phantom;
324 for (
39b80a73 325 sub { DBICTest->init_schema( sqlite_use_file => 0 ) },
50261284 326 sub { shift->source('Artist') },
327 sub { shift->resultset },
328 sub { shift->result_source },
329 sub { shift->schema },
330 sub { shift->resultset('Artist') },
331 sub { shift->find_or_create({ name => 'detachable' }) },
332 sub { shift->result_source },
333 sub { shift->schema },
334 sub { shift->clone },
187ec69a 335 sub { shift->resultset('CD') },
336 sub { shift->next },
337 sub { shift->artist },
338 sub { shift->search_related('cds') },
50261284 339 sub { shift->next },
187ec69a 340 sub { shift->search_related('artist') },
50261284 341 sub { shift->result_source },
342 sub { shift->resultset },
343 sub { shift->create({ name => 'detached' }) },
344 sub { shift->update({ name => 'reattached' }) },
345 sub { shift->discard_changes },
346 sub { shift->delete },
347 sub { shift->insert },
348 ) {
65d35121 349 $phantom = populate_weakregistry ( $weak_registry, scalar $_->($phantom) );
50261284 350 }
351
352 ok( $phantom->in_storage, 'Properly deleted/reinserted' );
353 is( $phantom->name, 'reattached', 'Still correct name' );
354}
a8c2c746 355
307ab4c5 356# Naturally we have some exceptions
357my $cleared;
96577657 358for my $addr (keys %$weak_registry) {
359 my $names = join "\n", keys %{$weak_registry->{$addr}{slot_names}};
360
361 if ($names =~ /^Test::Builder/m) {
c8194884 362 # T::B 2.0 has result objects and other fancyness
96577657 363 delete $weak_registry->{$addr};
c8194884 364 }
96577657 365 elsif ($names =~ /^Hash::Merge/m) {
37aafa2e 366 # only clear one object of a specific behavior - more would indicate trouble
96577657 367 delete $weak_registry->{$addr}
368 unless $cleared->{hash_merge_singleton}{$weak_registry->{$addr}{weakref}{behavior}}++;
307ab4c5 369 }
370}
371
187ec69a 372# FIXME !!!
373# There is an actual strong circular reference taking place here, but because
374# half of it is in XS no leaktracer sees it, and Devel::FindRef is equally
375# stumped when trying to trace the origin. The problem is:
376#
728f32b5 377# $cond_object --> result_source --> schema --> storage --> $dbh --> {CachedKids}
187ec69a 378# ^ /
379# \-------- bound value on prepared/cached STH <-----------/
380#
728f32b5 381{
382 local $TODO = 'This fails intermittently - see RT#82942';
96577657 383 if ( my $r = ($weak_registry->{'basic leaky_resultset_cond'}||{})->{weakref} ) {
728f32b5 384 ok(! defined $r, 'Self-referential RS conditions no longer leak!')
385 or $r->result_source(undef);
386 }
187ec69a 387}
388
65d35121 389assert_empty_weakregistry ($weak_registry);
551e711a 390
66917da3 391# we got so far without a failure - this is a good thing
392# now let's try to rerun this script under a "persistent" environment
393# this is ugly and dirty but we do not yet have a Test::Embedded or
394# similar
395
f3ec358e 396# set up -I
397require Config;
398$ENV{PERL5LIB} = join ($Config::Config{path_sep}, @INC);
399($ENV{PATH}) = $ENV{PATH} =~ /(.+)/;
400
401
7be5717e 402my $persistence_tests = {
403 PPerl => {
404 cmd => [qw/pperl --prefork=1/, __FILE__],
405 },
406 'CGI::SpeedyCGI' => {
407 cmd => [qw/speedy -- -t5/, __FILE__],
408 },
409};
66917da3 410
411# scgi is smart and will auto-reap after -t amount of seconds
7be5717e 412# pperl needs an actual killer :(
413$persistence_tests->{PPerl}{termcmd} = [
414 $persistence_tests->{PPerl}{cmd}[0],
415 '--kill',
416 @{$persistence_tests->{PPerl}{cmd}}[ 1 .. $#{$persistence_tests->{PPerl}{cmd}} ],
417];
66917da3 418
419SKIP: {
420 skip 'Test already in a persistent loop', 1
421 if $ENV{DBICTEST_IN_PERSISTENT_ENV};
422
66917da3 423 skip 'Main test failed - skipping persistent env tests', 1
424 unless $TB->is_passing;
425
66917da3 426 local $ENV{DBICTEST_IN_PERSISTENT_ENV} = 1;
427
7be5717e 428 require IPC::Open2;
429
430 for my $type (keys %$persistence_tests) { SKIP: {
53a5200d 431 unless (eval "require $type") {
432 # Don't terminate what we didn't start
433 delete $persistence_tests->{$type}{termcmd};
434 skip "$type module not found", 1;
435 }
7be5717e 436
437 my @cmd = @{$persistence_tests->{$type}{cmd}};
66917da3 438
439 # since PPerl is racy and sucks - just prime the "server"
440 {
441 local $ENV{DBICTEST_PERSISTENT_ENV_BAIL_EARLY} = 1;
7be5717e 442 system(@cmd);
66917da3 443 sleep 1;
444
7be5717e 445 # see if the thing actually runs, if not - might as well bail now
446 skip "Something is wrong with $type ($!)", 1
447 if system(@cmd);
66917da3 448 }
449
450 for (1,2,3) {
7be5717e 451 note ("Starting run in persistent env ($type pass $_)");
452 IPC::Open2::open2(my $out, undef, @cmd);
453 my @out_lines;
454 while (my $ln = <$out>) {
455 next if $ln =~ /^\s*$/;
456 push @out_lines, " $ln";
457 last if $ln =~ /^\d+\.\.\d+$/; # this is persistence, we need to terminate reading on our end
458 }
459 print $_ for @out_lines;
460 close $out;
461 wait;
462 ok (!$?, "Run in persistent env ($type pass $_): exit $?");
463 ok (scalar @out_lines, "Run in persistent env ($type pass $_): got output");
66917da3 464 }
465
7be5717e 466 ok (! system (@{$persistence_tests->{$type}{termcmd}}), "killed $type server instance")
467 if $persistence_tests->{$type}{termcmd};
468 }}
66917da3 469}
470
551e711a 471done_testing;
66917da3 472
473# just an extra precaution in case we blew away from the SKIP - since there are no
474# PID files to go by (man does pperl really suck :(
475END {
476 unless ($ENV{DBICTEST_IN_PERSISTENT_ENV}) {
7be5717e 477 close $_ for (*STDIN, *STDOUT, *STDERR);
66917da3 478 local $?; # otherwise test will inherit $? of the system()
53a5200d 479 system (@{$persistence_tests->{PPerl}{termcmd}})
480 if $persistence_tests->{PPerl}{termcmd};
66917da3 481 }
482}