Refactor sth preparation/binding - no functional changes
authorPeter Rabbitson <ribasushi@cpan.org>
Sun, 31 Mar 2013 13:06:59 +0000 (15:06 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Mon, 1 Apr 2013 04:52:16 +0000 (06:52 +0200)
commit9930caaf7e7c250d914cb1440d9a0f1dd2a1dedc
tree4654ddb244d33e5ff7e6348fc872cb482f511b1a
parent863b05398ad6c8988b7ede26d49b481e6b3324f9
Refactor sth preparation/binding - no functional changes

Notable internal changes:

- _dbi_attrs_for_bind call is moved out of _dbh_execute - there is no point
  recalculating these on retry
- _dbh_execute changed signature: $ident => $bind_attrs
- sth, _sth and _dbh_sth are no more - instead we now have _prepare_sth and
  _bind_sth_params

The test in t/storage/base.t has not been actually working for years (it
did not register a spurious success with $count == 0). Removing it is safe
as t/storage/reconnect.t tests the same codepath more thoroughly
Changes
lib/DBIx/Class/CDBICompat/ImaDBI.pm
lib/DBIx/Class/Storage/DBI.pm
lib/DBIx/Class/Storage/DBI/ADO.pm
lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm
lib/DBIx/Class/Storage/DBI/Replicated.pm
t/storage/base.t
t/storage/disable_sth_caching.t