11 years agorender order by elements without quoting to get identifier names in _extract_order_cr...
Matt S Trout [Sat, 26 Oct 2013 19:14:09 +0000]
render order by elements without quoting to get identifier names in _extract_order_criteria

11 years agoTHROW AWAY this commit on rebase - dirty bootstrap
Peter Rabbitson [Mon, 14 Oct 2013 10:21:11 +0000]
THROW AWAY this commit on rebase - dirty bootstrap

11 years agoimprove order by error message
Matt S Trout [Sat, 12 Oct 2013 19:45:55 +0000]
improve order by error message

11 years agoFetchFirst does not inject an order because me.title is unique
Matt S Trout [Sat, 12 Oct 2013 18:54:35 +0000]
FetchFirst does not inject an order because me.title is unique

11 years agot/sqlmaker/limit_dialects/toplimit.t - add missing me.id - fairly sure this was a bug
Matt S Trout [Sat, 12 Oct 2013 16:18:27 +0000]
t/sqlmaker/limit_dialects/toplimit.t - add missing me.id - fairly sure this was a bug

11 years agocomplete murdering emulate_limit
Matt S Trout [Sat, 12 Oct 2013 16:12:28 +0000]
complete murdering emulate_limit

11 years agot/sqlmaker/quotes/quotes_newstyle.t - ORDER BY parsing means we quote, but not misquote
Matt S Trout [Sat, 12 Oct 2013 16:01:39 +0000]
t/sqlmaker/quotes/quotes_newstyle.t - ORDER BY parsing means we quote, but not misquote

11 years agot/sqlmaker/quotes/quotes.t - ORDER BY parsing means we quote, but not misquote
Matt S Trout [Sat, 12 Oct 2013 16:00:52 +0000]
t/sqlmaker/quotes/quotes.t - ORDER BY parsing means we quote, but not misquote

11 years agoclean up OracleJoins
Matt S Trout [Sat, 12 Oct 2013 15:59:18 +0000]
clean up OracleJoins

11 years agooraclejoins fix
Matt S Trout [Sat, 12 Oct 2013 15:19:11 +0000]
oraclejoins fix

11 years agot/sqlmaker/oracle.t - parens and quoting fixes
Matt S Trout [Sat, 12 Oct 2013 15:14:56 +0000]
t/sqlmaker/oracle.t - parens and quoting fixes

11 years agot/sqlmaker/limit_dialects/toplimit.t - ORDER BY title -> me.title
Matt S Trout [Sat, 12 Oct 2013 15:05:00 +0000]
t/sqlmaker/limit_dialects/toplimit.t - ORDER BY title -> me.title

11 years agot/sqlmaker/limit_dialects/rownum.t - ROWNUM -> ROWNUM AS
Matt S Trout [Sat, 12 Oct 2013 15:03:38 +0000]
t/sqlmaker/limit_dialects/rownum.t - ROWNUM -> ROWNUM AS

11 years agot/sqlmaker/limit_dialects/rno.t - ORDER BY on column of "main" table
Matt S Trout [Sat, 12 Oct 2013 14:54:52 +0000]
t/sqlmaker/limit_dialects/rno.t - ORDER BY on column of "main" table

11 years agot/sqlmaker/limit_dialects/fetch_first.t - minor SQL tweaks
Matt S Trout [Sat, 12 Oct 2013 14:39:02 +0000]
t/sqlmaker/limit_dialects/fetch_first.t - minor SQL tweaks

11 years agocorrectly carry DESC on simple orderings for complex prefetch
Matt S Trout [Wed, 9 Oct 2013 18:36:13 +0000]
correctly carry DESC on simple orderings for complex prefetch

11 years agomake multicolumn IN work for update/delete
Matt S Trout [Wed, 9 Oct 2013 18:13:23 +0000]
make multicolumn IN work for update/delete

11 years agoswitch _adjust_select_args_for_complex_prefetch order by handling to part-DQ
Matt S Trout [Wed, 9 Oct 2013 17:46:13 +0000]
switch _adjust_select_args_for_complex_prefetch order by handling to part-DQ

11 years agoswitch having code in _count_subq_rs to DQ SQLA, update regexp
Matt S Trout [Wed, 9 Oct 2013 15:52:39 +0000]
switch having code in _count_subq_rs to DQ SQLA, update regexp

11 years agomake _resolve_aliastypes_from_select_args handle an undef select
Matt S Trout [Wed, 9 Oct 2013 15:15:59 +0000]
make _resolve_aliastypes_from_select_args handle an undef select

11 years agoclear renderer objects before dicking around with them as well as after
Matt S Trout [Wed, 9 Oct 2013 15:15:44 +0000]
clear renderer objects before dicking around with them as well as after

11 years agot/53lean_startup.t - permit Module::Runtime, Data::Query::Constants, Data::Query...
Matt S Trout [Mon, 7 Oct 2013 14:00:45 +0000]
t/53lean_startup.t - permit Module::Runtime, Data::Query::Constants, Data::Query::ExprHelpers

11 years agot/76joins.t - join_type inner now produces just JOIN
Matt S Trout [Mon, 7 Oct 2013 13:58:34 +0000]
t/76joins.t - join_type inner now produces just JOIN

11 years agoident dequalification in _rs_update_delete using DQ
Matt S Trout [Mon, 7 Oct 2013 13:47:25 +0000]
ident dequalification in _rs_update_delete using DQ

11 years agoRowCountOrGenericSubQ can FOAD, as per ribasushi
Matt S Trout [Mon, 7 Oct 2013 12:43:21 +0000]
RowCountOrGenericSubQ can FOAD, as per ribasushi

11 years agofix stupid mistake in _extract_order_criteria
Matt S Trout [Mon, 7 Oct 2013 12:25:13 +0000]
fix stupid mistake in _extract_order_criteria

11 years agoswitch _resolve_aliastypes_from_select_args to calling slightly saner methods
Matt S Trout [Mon, 7 Oct 2013 11:40:53 +0000]
switch _resolve_aliastypes_from_select_args to calling slightly saner methods

11 years agoremove vestigial dwarn
Matt S Trout [Mon, 7 Oct 2013 11:40:24 +0000]
remove vestigial dwarn

11 years agoonly generate a cond for update/delete if we actually have one
Matt S Trout [Mon, 7 Oct 2013 10:03:10 +0000]
only generate a cond for update/delete if we actually have one

11 years agoimport sqlmaker work from the dq branch
Matt S Trout [Mon, 7 Oct 2013 09:56:19 +0000]
import sqlmaker work from the dq branch

11 years agoFail early properly even in the presence of -jN
Peter Rabbitson [Wed, 2 Oct 2013 23:15:30 +0000]
Fail early properly even in the presence of -jN

Without the reordering of prints and without the mysterious sleep() call it
seems that prove just loses the STDERR text entirely

11 years agofix pod formatting of this code snippet
Karen Etheridge [Wed, 2 Oct 2013 21:38:49 +0000]
fix pod formatting of this code snippet

11 years agoStop using the deprecated Class::MOP::load_class()
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:41:55 +0000]
Stop using the deprecated Class::MOP::load_class()

Use MooseX::Types::LoadableClass instead, requiring the version that
fixes the constraints to not throw an exception on syntactically
invalid names, so that we can coerce a prefix onto ::Foo.

11 years agoFurther tradeoffs on relationship sanity checking (augments 9e7525a2)
Arthur Axel 'fREW' Schmidt [Thu, 25 Jul 2013 15:03:58 +0000]
Further tradeoffs on relationship sanity checking (augments 9e7525a2)

It turns out what we did earlier is not enough - what is truly needed is
shutting off *all* checks on non-belongs_to rels. Otherwise industrious devs
will inevitable tie themselves into a circual loading order knot.

The problem (as in 9e7525a2) is not so much that we need to bend over
backwards to support circular loads, but that these problems could very
well be masked by stable hash ordering of perl < 5.18. In other words this
commit serves to prevent perfectly working code from suffering intermittent
and hard-to-debug issues when someone upgrades their perl in 2018.

11 years agoFail early if full test is run in a stale checkout
Peter Rabbitson [Tue, 1 Oct 2013 06:03:05 +0000]
Fail early if full test is run in a stale checkout

11 years agoProper fix for t/storage/replicated.t (augments 617474ab7e)
Peter Rabbitson [Wed, 2 Oct 2013 06:42:48 +0000]
Proper fix for t/storage/replicated.t (augments 617474ab7e)

Instead of blindly changing the use_ok to use figured out and moved together
the pieces responsible for the dance in the 1st place

11 years agoFix t/storage/replicated.t class loading problem
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:12:14 +0000]
Fix t/storage/replicated.t class loading problem

Do all the skip_all in BEGIN {}, and just 'use' the modules instead of
use_ok().

11 years agoThrow clearer exception on ->new_related() with a non-existent relationship
Dagfinn Ilmari Mannsåker [Tue, 1 Oct 2013 19:04:22 +0000]
Throw clearer exception on ->new_related() with a non-existent relationship

11 years agoSmoker-wide parallel testing of installed deps
Peter Rabbitson [Tue, 24 Sep 2013 13:59:48 +0000]
Smoker-wide parallel testing of installed deps

11 years agoBetter diagnostics of skipped non-essential tests
Peter Rabbitson [Mon, 23 Sep 2013 19:36:03 +0000]
Better diagnostics of skipped non-essential tests

11 years agoEngage nuclear option of travis testing
Peter Rabbitson [Mon, 23 Sep 2013 11:16:39 +0000]
Engage nuclear option of travis testing

For the record - I am not happy about having to make this commit. However the
reality is that for every basic toolchain module I fix, another two are broken
by dzil-addicted (though well meaning) folks. Since this essentially paralyzes
any useful work, resort to simply ignoring some of the meaningless tests that
are autopopulated by ill-designed dzil author bundles.

This allows to revert 655d80dd, 72cd4007, and generally streamline the set of
workarounds

A preemptive note for anyone who is concerned that I am wasting precious tuits
on a dubious goal. Please realize that one of the corner stones of my personal
desire to participate in OSS comes from disdain of forced obsolescence (i.e.
one shall upgrade each and every year because the author feels like it). If I
can not guarantee my software performs correctly on old but usable versions of
our beloved VM - a massive portion of the very reason I "keep playing" goes
away entirely. With that gone the world beyond OSS suddenly becomes
exceedingly more appealing, at least much more appealing as opposed to pushing
features into a library unusable by most real-world production environments.
Additionally whether I or anyone else has encountered users benefitting from
my efforts is not relevant - the DarkPan universe is vast.

In other words instead of seeing these activities as a mindless fetish,  see
them for what they are: one of the main reasons I am a CPAN contributor to
begin with.

--ribasushi

11 years agoDelist Example and add QuickStart to the DocMap
Peter Rabbitson [Tue, 17 Sep 2013 08:42:58 +0000]
Delist Example and add QuickStart to the DocMap

Pending my review of PR#35

11 years agoUpdate DocMap - include missing local Manual pages (PR#22)
Scott R. Godin [Thu, 4 Apr 2013 19:41:17 +0000]
Update DocMap - include missing local Manual pages (PR#22)

some of the local Manual pages are not mentioned in the DocMap which should be,
as people will use the DocMap as a stepping point, and may thus overlook them

11 years agoA fixed DBD::Firebird went to CPAN as well
Peter Rabbitson [Tue, 17 Sep 2013 07:57:51 +0000]
A fixed DBD::Firebird went to CPAN as well

11 years agoThese workarounds are thankfully no longer needed
Peter Rabbitson [Tue, 17 Sep 2013 07:52:02 +0000]
These workarounds are thankfully no longer needed

Loading strictures will only complain about missing optdeps if used
within a t/, and dbic is (and will remain, sorry Matt) structures-free
deliberately, so there you have it

11 years agoThis was fixed in March 2013
Peter Rabbitson [Tue, 17 Sep 2013 06:16:05 +0000]
This was fixed in March 2013

11 years agoswitch from Class::MOP::class_of to Moose::Util::find_meta
Karen Etheridge [Sun, 15 Sep 2013 21:12:15 +0000]
switch from Class::MOP::class_of to Moose::Util::find_meta

11 years agoAugment test suite with oddball relationship declarations
Peter Rabbitson [Sat, 7 Sep 2013 16:05:38 +0000]
Augment test suite with oddball relationship declarations

Among other things this tests for the issue described/solved in 9e7525a2

11 years agoReorder relationship sanity checks, run them only on known loaded classes
Peter Rabbitson [Mon, 16 Sep 2013 17:16:48 +0000]
Reorder relationship sanity checks, run them only on known loaded classes

This avoids load-order issues in contrived situations where column definitions are
split across class inheritance (which gets rather fun doe to the prorotypical
inheritance of resultsource instances themselves)

While not an immediate problem in code in the wild, the hash randomization in 5.18
now leads to random load order, and as a result more load-order combinations are
tried and can eventually fail. This should reduce these situations to a minimum,
and 79061be1 should keep us appraised of any problems while DBICT:Schema evolves

Ideally the checks will be lifted up to schema-composition time, but we are not
there yet, one yak at a time.

11 years agoConsolidate single-pk checks from relationship inferrence codepaths
Peter Rabbitson [Fri, 13 Sep 2013 12:52:41 +0000]
Consolidate single-pk checks from relationship inferrence codepaths

11 years agoMore unreachable code - we've already thrown on !defined $pri
Peter Rabbitson [Wed, 11 Sep 2013 09:31:30 +0000]
More unreachable code - we've already thrown on !defined $pri

11 years agotypo fix
David Steinbrunner [Fri, 13 Sep 2013 11:33:07 +0000]
typo fix

11 years agoMOAR workarounds - freeze CMM at a usable version
Peter Rabbitson [Fri, 13 Sep 2013 03:39:15 +0000]
MOAR workarounds - freeze CMM at a usable version

The dzil conversion introduced dependency on MBT which is extremely
hard to get going on older perls, left alone all dists made with it

Hopefully it will get fixed:
https://rt.cpan.org/Ticket/Display.html?id=88641

11 years agoDisable perl introduced in ced296a8 until fixed Carp.pm is shipped
Peter Rabbitson [Wed, 11 Sep 2013 00:30:32 +0000]
Disable perl introduced in ced296a8 until fixed Carp.pm is shipped

https://rt.cpan.org/Public/Bug/Display.html?id=88531

11 years agoRun travis-prove under taint mode
Peter Rabbitson [Sat, 7 Sep 2013 16:13:52 +0000]
Run travis-prove under taint mode

11 years agoFix 79061be1 not working under -T
Peter Rabbitson [Sat, 7 Sep 2013 16:05:38 +0000]
Fix 79061be1 not working under -T

11 years agoExcise unreachable code
Peter Rabbitson [Thu, 8 Aug 2013 10:38:32 +0000]
Excise unreachable code

11 years agoRename internal rsrc method to be more descriptive, stop proxying it
Peter Rabbitson [Thu, 8 Aug 2013 06:58:58 +0000]
Rename internal rsrc method to be more descriptive, stop proxying it

11 years agoMake sure we can load each DBICTest::Schema result individually
Peter Rabbitson [Wed, 7 Aug 2013 07:09:19 +0000]
Make sure we can load each DBICTest::Schema result individually

This will ensure tests always fail if some sort of circular load order
issue is encountered, and we won't have to wait for a particular random
loading sequence to blow up the tests

11 years agoReorder travis tests by length, add 5.12.4
Peter Rabbitson [Mon, 9 Sep 2013 06:49:21 +0000]
Reorder travis tests by length, add 5.12.4

11 years agoOnly run our own tests concurrently, not stuff in after_success
Peter Rabbitson [Sun, 8 Sep 2013 16:04:17 +0000]
Only run our own tests concurrently, not stuff in after_success

11 years agoCheck that each preinstall on an old CPAN.pm completes
Peter Rabbitson [Sun, 8 Sep 2013 15:23:14 +0000]
Check that each preinstall on an old CPAN.pm completes

11 years agoEU::MM on < 5.8.9 got fixed
Peter Rabbitson [Sun, 8 Sep 2013 10:40:05 +0000]
EU::MM on < 5.8.9 got fixed

11 years agoChange CPAN mirror again - metacpan is a complete backpan-backed mirror
Peter Rabbitson [Sun, 8 Sep 2013 12:10:03 +0000]
Change CPAN mirror again - metacpan is a complete backpan-backed mirror

This way the deletion of the usable version of Tree::DAG_Node won't
affect testing

11 years agoLock down Tree::DAG_Node version until new Test::Warn appears
Peter Rabbitson [Fri, 6 Sep 2013 09:04:49 +0000]
Lock down Tree::DAG_Node version until new Test::Warn appears

This will make travis green again

https://github.com/chorny/test-warn/pull/4
(also https://rt.cpan.org/Public/Bug/Display.html?id=88435)

11 years agoFix typoed variable (just remote the shorthand entirely) ^Simon^++
Peter Rabbitson [Mon, 2 Sep 2013 05:36:30 +0000]
Fix typoed variable (just remote the shorthand entirely) ^Simon^++

11 years agoMore typo fixes
Olly Betts [Thu, 16 May 2013 22:00:00 +0000]
More typo fixes

11 years agoChanges for 113e8d16 and 64c50e81
Peter Rabbitson [Thu, 29 Aug 2013 01:57:12 +0000]
Changes for 113e8d16 and 64c50e81

11 years agoPrevent DBD::Firebird and DBD::InterBase from colliding on same DSN
Peter Rabbitson [Thu, 29 Aug 2013 01:40:52 +0000]
Prevent DBD::Firebird and DBD::InterBase from colliding on same DSN

11 years agoManpages are of no use on travis
Peter Rabbitson [Thu, 29 Aug 2013 02:41:00 +0000]
Manpages are of no use on travis

11 years agoDo one poisoned env testrun with a threaded perl
Peter Rabbitson [Thu, 29 Aug 2013 01:00:39 +0000]
Do one poisoned env testrun with a threaded perl

11 years agoOnly smoke blead-pan on allowed-to-fail runs
Peter Rabbitson [Thu, 29 Aug 2013 00:50:25 +0000]
Only smoke blead-pan on allowed-to-fail runs

11 years agoMove bleadperl to 'fail ok' submatrix - too much churn
Peter Rabbitson [Wed, 28 Aug 2013 12:01:00 +0000]
Move bleadperl to 'fail ok' submatrix - too much churn

11 years agoWork around https://rt.cpan.org/Ticket/Display.html?id=88222
Peter Rabbitson [Thu, 29 Aug 2013 00:09:01 +0000]
Work around https://rt.cpan.org/Ticket/Display.html?id=88222

11 years agoTemporary work around yet another cpanm issue
Peter Rabbitson [Mon, 26 Aug 2013 07:53:21 +0000]
Temporary work around yet another cpanm issue

11 years agoUse the same mirror for cpanm as we use for CPAN
Peter Rabbitson [Mon, 26 Aug 2013 03:06:59 +0000]
Use the same mirror for cpanm as we use for CPAN

11 years agoSwitch travis-perl tests to 5.18
Peter Rabbitson [Mon, 26 Aug 2013 02:33:27 +0000]
Switch travis-perl tests to 5.18

11 years agoI did manage to screw up locking in parallel testing after all
Peter Rabbitson [Mon, 26 Aug 2013 04:47:46 +0000]
I did manage to screw up locking in parallel testing after all

We try to grab a new engine lock within the same test before releasing
the one for the previous engine

11 years agoAdjust DBD::Firebird travis init
Peter Rabbitson [Mon, 26 Aug 2013 01:21:13 +0000]
Adjust DBD::Firebird travis init

11 years agoSync Example.pod with reality, though in fairness it just needs to die...
Peter Rabbitson [Mon, 26 Aug 2013 12:33:37 +0000]
Sync Example.pod with reality, though in fairness it just needs to die...

11 years agoAutomatically regenerate the example ddl/db from the example Schema
Peter Rabbitson [Mon, 26 Aug 2013 12:19:43 +0000]
Automatically regenerate the example ddl/db from the example Schema

11 years agoGeneralize the SQLite DDL generation tool (see next commit)
Peter Rabbitson [Mon, 26 Aug 2013 11:05:52 +0000]
Generalize the SQLite DDL generation tool (see next commit)

11 years agoUpdate example Result classes for proper DDL generation
Peter Rabbitson [Mon, 26 Aug 2013 11:10:59 +0000]
Update example Result classes for proper DDL generation

Also given that this is one of the first things a newbie sees, it is prudent
to stick to canonical definition

11 years agoTeach the example scripts how to find their DB from anywhere
Peter Rabbitson [Mon, 26 Aug 2013 12:18:36 +0000]
Teach the example scripts how to find their DB from anywhere

11 years agoThese comments are woefully outdated
Peter Rabbitson [Mon, 26 Aug 2013 11:58:22 +0000]
These comments are woefully outdated

Setting DBIC_TRACE=1 won't help either - we use the fast-path insert which
mean the user won't see anything

11 years agoStandardize examples/docs on Schema::Loader schema naming
Peter Rabbitson [Mon, 26 Aug 2013 01:57:42 +0000]
Standardize examples/docs on Schema::Loader schema naming

A new user is very likely to encounter this naming convention these days

11 years agoNew podlators are allergic to leading link space
Peter Rabbitson [Mon, 26 Aug 2013 02:01:22 +0000]
New podlators are allergic to leading link space

11 years agoExtra paragraph dropped from 113e8d16 for some reason
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 [Thu, 4 Apr 2013 05:53:52 +0000]
Extra paragraph dropped from 113e8d16 for some reason

11 years agoFixup weird wording introduced in 54e4be92
Peter Rabbitson [Thu, 22 Aug 2013 03:49:31 +0000]
Fixup weird wording introduced in 54e4be92

11 years agoApparently on_failure email flag affects the original author as well
Peter Rabbitson [Thu, 22 Aug 2013 03:31:27 +0000]
Apparently on_failure email flag affects the original author as well

Without this only the first committer who broke stuff will get an email
the rest of the breakage will remain silent

11 years agoFix name mangle in Replicated.pm broken by e8c31aec and then by 4a0eed52
Peter Rabbitson [Thu, 22 Aug 2013 03:17:15 +0000]
Fix name mangle in Replicated.pm broken by e8c31aec and then by 4a0eed52

11 years agoOCD - undo some incorrect changes of non-typos from 4a0eed52f
Peter Rabbitson [Thu, 22 Aug 2013 03:03:11 +0000]
OCD - undo some incorrect changes of non-typos from 4a0eed52f

11 years agotypo fixes
David Steinbrunner [Tue, 6 Aug 2013 11:14:21 +0000]
typo fixes

11 years agoAugment 84d8c2ad so that the custom join specification isn't so prominent
Peter Rabbitson [Mon, 22 Jul 2013 05:08:18 +0000]
Augment 84d8c2ad so that the custom join specification isn't so prominent

Also add a warning to (hopefully) deter folks from using these for simple
shit, where a schema redesign would suffice.

11 years agoperlbrew exits with 0 if `perlbrew use` fails :(
Peter Rabbitson [Mon, 22 Jul 2013 04:26:25 +0000]
perlbrew exits with 0 if `perlbrew use` fails :(

11 years agoIgnore stderr in extract_prereqs - only rely on $?
Peter Rabbitson [Mon, 22 Jul 2013 03:36:42 +0000]
Ignore stderr in extract_prereqs - only rely on $?

11 years agoInstall EU::CB in a separate step as to not tickle an old CPAN bug
Peter Rabbitson [Mon, 22 Jul 2013 03:06:19 +0000]
Install EU::CB in a separate step as to not tickle an old CPAN bug

Older CPAN.pm had a problem with the circular dependency resolution firing
erroneously *after* everything was successfully installed, e.g.:

https://s3.amazonaws.com/archive.travis-ci.org/jobs/9336470/log.txt

(scroll to the end)

11 years agoFix test error failing after "undef\n=>" was fixed to stringify
Peter Rabbitson [Sun, 21 Jul 2013 11:48:00 +0000]
Fix test error failing after "undef\n=>" was fixed to stringify

http://perl5.git.perl.org/perl.git/commit/21791330af

11 years agoTemporary inslatt Pod::POM via cpan
Peter Rabbitson [Sun, 21 Jul 2013 07:54:58 +0000]
Temporary inslatt Pod::POM via cpan

Pod::POM installation tickles a toolchain deficiency
https://rt.cpan.org/Ticket/Display.html?id=87124
https://github.com/miyagawa/cpanminus/issues/291

11 years agoAllow spaces in parallel installation module spec
Peter Rabbitson [Sat, 20 Jul 2013 21:57:40 +0000]
Allow spaces in parallel installation module spec