Rafael Kitover [Thu, 24 Sep 2009 06:47:39 +0000]
clean up set_identity stuff
Peter Rabbitson [Mon, 21 Sep 2009 00:06:21 +0000]
All sybase bulk-insert code by Caelum
Peter Rabbitson [Sun, 20 Sep 2009 23:18:40 +0000]
Merge 'sybase_insert_bulk' into 'sybase_support'
main sybase branch ready
Peter Rabbitson [Sun, 20 Sep 2009 22:58:09 +0000]
Part one of the sybase work by Caelum (mostly reviewed)
Peter Rabbitson [Sun, 20 Sep 2009 22:51:43 +0000]
Merge 'trunk' into 'sybase_support'
r7694@Thesaurus (orig r7683): ribasushi | 2009-09-18 12:36:42 +0200
r6389@Thesaurus (orig r6388): caelum | 2009-05-23 22:48:06 +0200
recreating Sybase branch
r6395@Thesaurus (orig r6394): caelum | 2009-05-24 01:47:32 +0200
try not to fuck mssql with the sybase crap
r6488@Thesaurus (orig r6487): caelum | 2009-06-03 17:31:24 +0200
resolve conflict
r6490@Thesaurus (orig r6489): caelum | 2009-06-03 18:25:36 +0200
add missing files to sybase branch
r6492@Thesaurus (orig r6491): caelum | 2009-06-04 01:51:39 +0200
fix Sybase DT stuff and storage bases
r6493@Thesaurus (orig r6492): caelum | 2009-06-04 02:10:45 +0200
fix base for mssql (can't be a sybase anymore)
r6494@Thesaurus (orig r6493): caelum | 2009-06-04 02:20:37 +0200
test sybase SMALLDATETIME inflation
r6495@Thesaurus (orig r6494): caelum | 2009-06-04 04:52:31 +0200
update Sybase docs
r6501@Thesaurus (orig r6500): caelum | 2009-06-04 14:50:49 +0200
sybase limit count without offset now works
r6504@Thesaurus (orig r6503): caelum | 2009-06-04 18:03:01 +0200
use TOP for sybase limit count thanks to refactored count
r6505@Thesaurus (orig r6504): caelum | 2009-06-04 18:41:54 +0200
back to counting rows for Sybase LIMIT counts
r6506@Thesaurus (orig r6505): caelum | 2009-06-04 19:07:48 +0200
minor sybase count fix
r6512@Thesaurus (orig r6511): caelum | 2009-06-05 01:02:48 +0200
test sybase group_by count, works
r6513@Thesaurus (orig r6512): caelum | 2009-06-05 01:28:18 +0200
set date format on _rebless correctly
r6516@Thesaurus (orig r6515): caelum | 2009-06-05 02:24:46 +0200
manually merged in sybase_noquote branch
r6518@Thesaurus (orig r6517): caelum | 2009-06-05 06:34:25 +0200
shit doesn't work yet
r6520@Thesaurus (orig r6519): caelum | 2009-06-05 16:55:41 +0200
update sybase types which shouldn't be quoted
r6525@Thesaurus (orig r6524): caelum | 2009-06-06 04:40:51 +0200
tweaks to sybase types
r6527@Thesaurus (orig r6526): caelum | 2009-06-06 05:36:03 +0200
temporary sybase noquote hack
r6595@Thesaurus (orig r6594): caelum | 2009-06-10 13:46:37 +0200
Sybase::NoBindVars now correctly quotes
r6596@Thesaurus (orig r6595): caelum | 2009-06-10 14:04:19 +0200
cache rsrc in NoBindVars, use name_sep
r6597@Thesaurus (orig r6596): caelum | 2009-06-10 14:35:52 +0200
Sybase count by first pk, if available
r6599@Thesaurus (orig r6598): caelum | 2009-06-10 15:00:42 +0200
cache rsrc in NoBindVars correctly
r6600@Thesaurus (orig r6599): caelum | 2009-06-10 15:27:41 +0200
handle unknown rsrc in NoBindVars and Sybase::NoBindVars
r6605@Thesaurus (orig r6604): caelum | 2009-06-10 18:17:31 +0200
cache rsrc properly in NoBindVars, return undef if no rsrc
r6658@Thesaurus (orig r6657): caelum | 2009-06-13 05:57:40 +0200
switch to DateTime::Format::Sybase
r6700@Thesaurus (orig r6699): caelum | 2009-06-17 16:25:28 +0200
rename and document dt setup method, will be an on_connect_call at later merge point
r6701@Thesaurus (orig r6700): caelum | 2009-06-17 16:30:08 +0200
more dt docs reorg
r6715@Thesaurus (orig r6714): caelum | 2009-06-19 01:28:17 +0200
todo tests for text/image columns in sybase
r6716@Thesaurus (orig r6715): caelum | 2009-06-19 01:46:56 +0200
added connect_call_blob_setup for Sybase
r6724@Thesaurus (orig r6723): caelum | 2009-06-19 17:12:20 +0200
cleanups
r6771@Thesaurus (orig r6770): caelum | 2009-06-23 16:42:32 +0200
minor changes
r6788@Thesaurus (orig r6787): caelum | 2009-06-25 05:31:06 +0200
fixup POD, comment out count
r6811@Thesaurus (orig r6810): caelum | 2009-06-28 02:14:56 +0200
prototype blob implementation
r6857@Thesaurus (orig r6856): caelum | 2009-06-29 23:45:19 +0200
branch pushed, removing
r6868@Thesaurus (orig r6867): caelum | 2009-06-30 03:39:51 +0200
merge on_connect_call updates
r6877@Thesaurus (orig r6876): caelum | 2009-06-30 12:46:43 +0200
code cleanups
r6957@Thesaurus (orig r6956): caelum | 2009-07-03 02:32:48 +0200
minor changes
r6959@Thesaurus (orig r6958): caelum | 2009-07-03 05:04:12 +0200
fix sybase mro
r7001@Thesaurus (orig r7000): caelum | 2009-07-07 13:34:23 +0200
fix sybase rebless to NoBindVars
r7021@Thesaurus (orig r7020): caelum | 2009-07-10 12:52:13 +0200
fix NoBindVars
r7053@Thesaurus (orig r7052): caelum | 2009-07-15 01:39:02 +0200
set maxConnect in DSN and add docs
r7065@Thesaurus (orig r7064): caelum | 2009-07-17 09:39:54 +0200
make insertion of blobs into tables with identity columns work, other minor fixes
r7070@Thesaurus (orig r7069): caelum | 2009-07-17 23:30:13 +0200
some compatibility updated for older DBD::Sybase versions, some initial work on _select_args for blobs
r7072@Thesaurus (orig r7071): caelum | 2009-07-19 23:57:11 +0200
mangling _select_args turned out to be unnecessary
r7073@Thesaurus (orig r7072): caelum | 2009-07-20 01:02:19 +0200
minor cleanups
r7074@Thesaurus (orig r7073): caelum | 2009-07-20 15:47:48 +0200
blob update now works
r7076@Thesaurus (orig r7075): caelum | 2009-07-20 19:06:46 +0200
change the (incorrect) version check to a check for FreeTDS
r7077@Thesaurus (orig r7076): caelum | 2009-07-20 19:13:25 +0200
better check for FreeTDS thanks to arcanez
r7089@Thesaurus (orig r7086): caelum | 2009-07-22 07:09:21 +0200
minor cleanups
r7091@Thesaurus (orig r7088): caelum | 2009-07-22 17:05:37 +0200
remove unnecessary test Result class
r7092@Thesaurus (orig r7089): caelum | 2009-07-23 00:47:14 +0200
fix doc for how to check for FreeTDS
r7095@Thesaurus (orig r7092): caelum | 2009-07-23 14:35:53 +0200
doc tweak
r7115@Thesaurus (orig r7112): caelum | 2009-07-24 09:58:24 +0200
add support for IDENTITY_INSERT
r7117@Thesaurus (orig r7114): caelum | 2009-07-24 16:19:08 +0200
savepoint support
r7120@Thesaurus (orig r7117): caelum | 2009-07-24 20:35:37 +0200
fix race condition in last_insert_id with placeholders
r7121@Thesaurus (orig r7118): caelum | 2009-07-24 21:22:25 +0200
code cleanup
r7124@Thesaurus (orig r7121): caelum | 2009-07-25 16:19:58 +0200
use _resolve_column_info in NoBindVars
r7125@Thesaurus (orig r7122): caelum | 2009-07-25 21:23:49 +0200
make insert work as a nested transaction too
r7126@Thesaurus (orig r7123): caelum | 2009-07-25 22:52:17 +0200
add money type support
r7128@Thesaurus (orig r7125): caelum | 2009-07-27 03:48:35 +0200
better FreeTDS support
r7130@Thesaurus (orig r7127): caelum | 2009-07-28 06:23:54 +0200
minor refactoring, cleanups, doc updates
r7131@Thesaurus (orig r7128): caelum | 2009-07-28 09:32:45 +0200
forgot to set mro in dbi::cursor
r7141@Thesaurus (orig r7138): caelum | 2009-07-30 10:21:20 +0200
better test for "smalldatetime" in Sybase
r7146@Thesaurus (orig r7143): caelum | 2009-07-30 15:37:18 +0200
update sqlite test schema
r7207@Thesaurus (orig r7204): caelum | 2009-08-04 23:40:16 +0200
update Changes
r7222@Thesaurus (orig r7219): caelum | 2009-08-05 11:02:26 +0200
fix a couple minor issues after pull from trunk
r7260@Thesaurus (orig r7257): caelum | 2009-08-07 14:45:18 +0200
add note about where to get Schema::Loader
r7273@Thesaurus (orig r7270): ribasushi | 2009-08-09 01:19:49 +0200
Changes and minor code rewrap
r7285@Thesaurus (orig r7282): ribasushi | 2009-08-10 08:08:06 +0200
pesky whitespace
r7286@Thesaurus (orig r7283): ribasushi | 2009-08-10 08:11:46 +0200
privatize dormant method - it may be useful for sybase at *some* point
r7287@Thesaurus (orig r7284): ribasushi | 2009-08-10 08:19:55 +0200
Whoops
r7289@Thesaurus (orig r7286): caelum | 2009-08-10 08:44:51 +0200
document placeholders_with_type_conversion_supported and add a redispatch to reblessed storage in DBI::update
r7290@Thesaurus (orig r7287): caelum | 2009-08-10 10:07:45 +0200
fix and test redispatch to reblessed storage insert/update
r7292@Thesaurus (orig r7289): caelum | 2009-08-10 10:32:37 +0200
rename get_connected_schema to get_schema in sybase test
r7345@Thesaurus (orig r7342): ribasushi | 2009-08-18 22:45:06 +0200
Fix Changes
r7367@Thesaurus (orig r7364): ribasushi | 2009-08-23 10:00:34 +0200
Minaor speedup
r7368@Thesaurus (orig r7365): ribasushi | 2009-08-23 10:01:10 +0200
Generalize and hide placeholder support check
r7369@Thesaurus (orig r7366): ribasushi | 2009-08-23 10:04:26 +0200
Rename the common sybase driver
r7373@Thesaurus (orig r7370): caelum | 2009-08-24 13:21:51 +0200
make insert only use a txn if needed, add connect_call_unsafe_insert
r7374@Thesaurus (orig r7371): caelum | 2009-08-24 14:42:57 +0200
add test for IDENTITY_INSERT
r7378@Thesaurus (orig r7375): caelum | 2009-08-24 15:51:48 +0200
use debugobj->callback instead of local *_query_start in test to capture query
r7379@Thesaurus (orig r7376): caelum | 2009-08-24 17:19:46 +0200
remove duplicate oracle method and fix an mssql method call
r7417@Thesaurus (orig r7414): caelum | 2009-08-29 07:23:45 +0200
update link to Schema::Loader branch
r7427@Thesaurus (orig r7424): caelum | 2009-08-29 09:31:41 +0200
switch to ::DBI::AutoCast
r7428@Thesaurus (orig r7425): ribasushi | 2009-08-29 13:36:22 +0200
Cleanup:
Added commented method signatures for easier debugging
privatize transform_unbound_value as _prep_bind_value
Remove \@_ splice's in lieu of of simple shifts
Exposed TYPE_MAPPING used by native_data_type via our
Removed use of txn_do - internal code uses the scope guard
Renamed some variables, whitespace cleanup, the works
r7429@Thesaurus (orig r7426): ribasushi | 2009-08-29 13:40:48 +0200
Varname was absolutely correct
r7430@Thesaurus (orig r7427): caelum | 2009-08-29 14:09:13 +0200
minor changes for tests to pass again
r7431@Thesaurus (orig r7428): caelum | 2009-08-29 21:08:51 +0200
fix inserts with active cursors
r7432@Thesaurus (orig r7429): caelum | 2009-08-29 22:53:02 +0200
remove extra connection
r7434@Thesaurus (orig r7431): caelum | 2009-08-30 00:02:20 +0200
test correlated subquery
r7442@Thesaurus (orig r7439): ribasushi | 2009-08-30 09:07:00 +0200
Put the ocmment back
r7443@Thesaurus (orig r7440): ribasushi | 2009-08-30 09:15:41 +0200
Change should_quote_value to interpolate_unquoted to make it harder to stop quoting by accident (it's easier to return a undef by accident than a 1)
r7446@Thesaurus (orig r7443): caelum | 2009-08-30 18:19:46 +0200
added txn_scope_guards for blob operations
r7447@Thesaurus (orig r7444): ribasushi | 2009-08-30 18:56:43 +0200
Rename insert_txn to unsafe_insert
r7512@Thesaurus (orig r7509): ribasushi | 2009-09-03 20:24:14 +0200
Minor cleanups
r7575@Thesaurus (orig r7572): caelum | 2009-09-05 07:23:57 +0200
pending review by mpeppler
r7593@Thesaurus (orig r7590): ribasushi | 2009-09-07 09:10:05 +0200
Release 0.08111 tag
r7594@Thesaurus (orig r7591): ribasushi | 2009-09-07 09:14:33 +0200
Whoops this should not have committed
r7602@Thesaurus (orig r7599): caelum | 2009-09-07 21:31:38 +0200
fix _insert_dbh code to only connect when needed, doc update
r7607@Thesaurus (orig r7604): caelum | 2009-09-09 02:15:54 +0200
remove unsafe_insert
r7608@Thesaurus (orig r7605): ribasushi | 2009-09-09 09:14:20 +0200
Localisation ain't free, we don't do it unless we have to
r7609@Thesaurus (orig r7606): ribasushi | 2009-09-09 09:40:29 +0200
Much simpler
r7610@Thesaurus (orig r7607): ribasushi | 2009-09-09 10:38:41 +0200
Reduce amount of perl-golf :)
r7611@Thesaurus (orig r7608): ribasushi | 2009-09-09 10:41:15 +0200
This should not have worked - I guess we lack tests?
r7614@Thesaurus (orig r7611): caelum | 2009-09-09 12:08:36 +0200
test multi-row blob update
r7619@Thesaurus (orig r7616): caelum | 2009-09-09 18:01:15 +0200
remove Sub::Name hack for method dispatch, pass $next instead
r7620@Thesaurus (orig r7617): caelum | 2009-09-10 02:16:03 +0200
do blob update over _insert_dbh
r7661@Thesaurus (orig r7650): caelum | 2009-09-13 10:27:44 +0200
change _insert_dbh to _insert_storage
r7663@Thesaurus (orig r7652): caelum | 2009-09-13 11:52:20 +0200
make sure _init doesn't loop, steal insert_bulk from mssql, add some insert_bulk tests
r7664@Thesaurus (orig r7653): caelum | 2009-09-13 13:27:51 +0200
allow subclassing of methods proxied to _writer_storage
r7666@Thesaurus (orig r7655): caelum | 2009-09-14 15:09:21 +0200
sybase bulk API support stuff (no blobs yet, coming soon...)
r7667@Thesaurus (orig r7656): caelum | 2009-09-14 15:33:14 +0200
add another test for sybase bulk stuff (passes)
r7668@Thesaurus (orig r7657): caelum | 2009-09-14 15:44:06 +0200
minor change (fix inverted boolean for warning)
r7669@Thesaurus (orig r7658): caelum | 2009-09-14 15:48:52 +0200
remove @args from DBI::sth, use full arg list
r7676@Thesaurus (orig r7665): caelum | 2009-09-16 15:06:35 +0200
use execute_array for insert_bulk, test insert_bulk with blobs, clean up blob tests a bit
r7680@Thesaurus (orig r7669): ribasushi | 2009-09-16 19:36:19 +0200
Remove branched changes
r7682@Thesaurus (orig r7671): caelum | 2009-09-17 03:03:34 +0200
I'll rewrite this bit tomorrow to be less retarded
r7684@Thesaurus (orig r7673): caelum | 2009-09-18 04:03:15 +0200
fix yesterday's stuff, identity_update works, blob updates are better
r7686@Thesaurus (orig r7675): caelum | 2009-09-18 04:22:38 +0200
column no longer necessary in test
r7688@Thesaurus (orig r7677): caelum | 2009-09-18 08:33:14 +0200
fix freetds
r7691@Thesaurus (orig r7680): ribasushi | 2009-09-18 12:25:42 +0200
r7678@Thesaurus (orig r7667): ribasushi | 2009-09-16 19:31:14 +0200
New subbranch
r7679@Thesaurus (orig r7668): ribasushi | 2009-09-16 19:34:29 +0200
Caelum's work so far
r7690@Thesaurus (orig r7679): caelum | 2009-09-18 11:10:16 +0200
support for blobs in insert_bulk fallback
r7692@Thesaurus (orig r7681): ribasushi | 2009-09-18 12:28:09 +0200
Rollback all bulk insert code before merge
r7699@Thesaurus (orig r7688): ribasushi | 2009-09-18 14:12:05 +0200
Cleanup exception handling
r7700@Thesaurus (orig r7689): ribasushi | 2009-09-18 14:22:02 +0200
duh
r7701@Thesaurus (orig r7690): ribasushi | 2009-09-18 14:25:06 +0200
Minor cleanup of RSC with has_many joins
r7702@Thesaurus (orig r7691): ribasushi | 2009-09-18 14:32:15 +0200
Changes and dev notes in makefile
r7705@Thesaurus (orig r7694): ribasushi | 2009-09-18 14:52:26 +0200
Nothing says the grouping column can not be nullable
r7706@Thesaurus (orig r7695): ribasushi | 2009-09-18 14:53:33 +0200
Changes
r7707@Thesaurus (orig r7696): ribasushi | 2009-09-18 20:09:04 +0200
This code belogs in Storage::DBI
r7708@Thesaurus (orig r7697): ribasushi | 2009-09-18 20:38:26 +0200
Clear up some legacy cruft and straighten inheritance
r7710@Thesaurus (orig r7699): ribasushi | 2009-09-21 00:25:20 +0200
Backout sybase changes
r7713@Thesaurus (orig r7702): ribasushi | 2009-09-21 00:46:32 +0200
Missed a part of the revert
Peter Rabbitson [Sun, 20 Sep 2009 22:46:32 +0000]
Missed a part of the revert
Peter Rabbitson [Sun, 20 Sep 2009 22:25:20 +0000]
Backout sybase changes
Peter Rabbitson [Fri, 18 Sep 2009 18:38:26 +0000]
Clear up some legacy cruft and straighten inheritance
Peter Rabbitson [Fri, 18 Sep 2009 18:09:04 +0000]
This code belogs in Storage::DBI
Peter Rabbitson [Fri, 18 Sep 2009 12:53:33 +0000]
Changes
Peter Rabbitson [Fri, 18 Sep 2009 12:52:26 +0000]
Nothing says the grouping column can not be nullable
Peter Rabbitson [Fri, 18 Sep 2009 12:36:58 +0000]
Merge 'trunk' into 'sybase_insert_bulk'
r7699@Thesaurus (orig r7688): ribasushi | 2009-09-18 14:12:05 +0200
Cleanup exception handling
r7700@Thesaurus (orig r7689): ribasushi | 2009-09-18 14:22:02 +0200
duh
r7701@Thesaurus (orig r7690): ribasushi | 2009-09-18 14:25:06 +0200
Minor cleanup of RSC with has_many joins
r7702@Thesaurus (orig r7691): ribasushi | 2009-09-18 14:32:15 +0200
Changes and dev notes in makefile
Peter Rabbitson [Fri, 18 Sep 2009 12:36:29 +0000]
Factor out dumper copy/paste
Peter Rabbitson [Fri, 18 Sep 2009 12:32:15 +0000]
Changes and dev notes in makefile
Peter Rabbitson [Fri, 18 Sep 2009 12:25:06 +0000]
Minor cleanup of RSC with has_many joins
Peter Rabbitson [Fri, 18 Sep 2009 12:22:02 +0000]
duh
Peter Rabbitson [Fri, 18 Sep 2009 12:12:05 +0000]
Cleanup exception handling
Peter Rabbitson [Fri, 18 Sep 2009 10:44:08 +0000]
All of caelum's work so far (not reviewed)
Peter Rabbitson [Fri, 18 Sep 2009 10:36:42 +0000]
Merge 'sybase' into 'trunk'
Peter Rabbitson [Fri, 18 Sep 2009 10:28:09 +0000]
Rollback all bulk insert code before merge
Peter Rabbitson [Fri, 18 Sep 2009 10:25:42 +0000]
Merge 'sybase_bulk_insert' into 'sybase'
r7678@Thesaurus (orig r7667): ribasushi | 2009-09-16 19:31:14 +0200
New subbranch
r7679@Thesaurus (orig r7668): ribasushi | 2009-09-16 19:34:29 +0200
Caelum's work so far
r7690@Thesaurus (orig r7679): caelum | 2009-09-18 11:10:16 +0200
support for blobs in insert_bulk fallback
Rafael Kitover [Fri, 18 Sep 2009 09:10:16 +0000]
support for blobs in insert_bulk fallback
Rafael Kitover [Fri, 18 Sep 2009 07:33:14 +0000]
Merge 'sybase' into 'sybase_bulk_insert'
Rafael Kitover [Fri, 18 Sep 2009 06:33:14 +0000]
fix freetds
Rafael Kitover [Fri, 18 Sep 2009 02:22:38 +0000]
column no longer necessary in test
Rafael Kitover [Fri, 18 Sep 2009 02:03:15 +0000]
fix yesterday's stuff, identity_update works, blob updates are better
Peter Rabbitson [Thu, 17 Sep 2009 11:54:44 +0000]
Fix left-join chaining
Rafael Kitover [Thu, 17 Sep 2009 01:03:34 +0000]
I'll rewrite this bit tomorrow to be less retarded
Peter Rabbitson [Wed, 16 Sep 2009 21:01:24 +0000]
Merge 'sybase' into 'sybase_bulk_insert'
r7666@Thesaurus (orig r7655): caelum | 2009-09-14 15:09:21 +0200
sybase bulk API support stuff (no blobs yet, coming soon...)
r7667@Thesaurus (orig r7656): caelum | 2009-09-14 15:33:14 +0200
add another test for sybase bulk stuff (passes)
r7668@Thesaurus (orig r7657): caelum | 2009-09-14 15:44:06 +0200
minor change (fix inverted boolean for warning)
r7669@Thesaurus (orig r7658): caelum | 2009-09-14 15:48:52 +0200
remove @args from DBI::sth, use full arg list
r7676@Thesaurus (orig r7665): caelum | 2009-09-16 15:06:35 +0200
use execute_array for insert_bulk, test insert_bulk with blobs, clean up blob tests a bit
r7677@Thesaurus (orig r7666): caelum | 2009-09-16 15:09:23 +0200
r20647@hlagh (orig r7659): ribasushi | 2009-09-14 12:24:44 -0400
Someone claimed this is a problem...
r20650@hlagh (orig r7662): ribasushi | 2009-09-15 03:43:46 -0400
Warn when distinct is used with group_by
r20651@hlagh (orig r7663): rbuels | 2009-09-15 16:45:32 -0400
doc patch, clarified warning about using find_or_create() and friends on tables with auto-increment or similar columns
r20652@hlagh (orig r7664): rbuels | 2009-09-15 16:55:15 -0400
another doc clarification regarding auto-inc columns with find_or_create() and such functions
r7680@Thesaurus (orig r7669): ribasushi | 2009-09-16 19:36:19 +0200
Remove branched changes
Peter Rabbitson [Wed, 16 Sep 2009 17:36:19 +0000]
Remove branched changes
Peter Rabbitson [Wed, 16 Sep 2009 17:34:29 +0000]
Caelum's work so far
Rafael Kitover [Wed, 16 Sep 2009 13:09:23 +0000]
Merge 'trunk' into 'sybase'
r20647@hlagh (orig r7659): ribasushi | 2009-09-14 12:24:44 -0400
Someone claimed this is a problem...
r20650@hlagh (orig r7662): ribasushi | 2009-09-15 03:43:46 -0400
Warn when distinct is used with group_by
r20651@hlagh (orig r7663): rbuels | 2009-09-15 16:45:32 -0400
doc patch, clarified warning about using find_or_create() and friends on tables with auto-increment or similar columns
r20652@hlagh (orig r7664): rbuels | 2009-09-15 16:55:15 -0400
another doc clarification regarding auto-inc columns with find_or_create() and such functions
Rafael Kitover [Wed, 16 Sep 2009 13:06:35 +0000]
use execute_array for insert_bulk, test insert_bulk with blobs, clean up blob tests a bit
Robert Buels [Tue, 15 Sep 2009 20:55:15 +0000]
another doc clarification regarding auto-inc columns with find_or_create() and such functions
Robert Buels [Tue, 15 Sep 2009 20:45:32 +0000]
doc patch, clarified warning about using find_or_create() and friends on tables with auto-increment or similar columns
Peter Rabbitson [Tue, 15 Sep 2009 07:43:46 +0000]
Warn when distinct is used with group_by
Peter Rabbitson [Mon, 14 Sep 2009 16:24:44 +0000]
Someone claimed this is a problem...
Rafael Kitover [Mon, 14 Sep 2009 13:48:52 +0000]
remove @args from DBI::sth, use full arg list
Rafael Kitover [Mon, 14 Sep 2009 13:44:06 +0000]
minor change (fix inverted boolean for warning)
Rafael Kitover [Mon, 14 Sep 2009 13:33:14 +0000]
add another test for sybase bulk stuff (passes)
Rafael Kitover [Mon, 14 Sep 2009 13:09:21 +0000]
sybase bulk API support stuff (no blobs yet, coming soon...)
Rafael Kitover [Sun, 13 Sep 2009 11:27:51 +0000]
allow subclassing of methods proxied to _writer_storage
Rafael Kitover [Sun, 13 Sep 2009 09:52:20 +0000]
make sure _init doesn't loop, steal insert_bulk from mssql, add some insert_bulk tests
Rafael Kitover [Sun, 13 Sep 2009 08:29:25 +0000]
Merge 'trunk' into 'sybase'
r20609@hlagh (orig r7621): mo | 2009-09-10 12:53:32 -0400
added test to make sure that store_column is called even for non-dirty columns
r20610@hlagh (orig r7622): bluefeet | 2009-09-10 13:03:21 -0400
Fix RSC->reset() to no longer return $self, which fixes Cursor::Cached + RSC.
r20611@hlagh (orig r7623): ribasushi | 2009-09-10 13:32:03 -0400
The real fix
r20612@hlagh (orig r7624): matthewt | 2009-09-10 20:33:17 -0400
make it clear that we are not supposed to have optional deps
r20613@hlagh (orig r7625): ribasushi | 2009-09-11 00:30:03 -0400
Changes so far
r20614@hlagh (orig r7626): ribasushi | 2009-09-11 00:39:45 -0400
Fix borked makefile
r20615@hlagh (orig r7627): ribasushi | 2009-09-11 09:39:42 -0400
Fixed minor problem with txn scope guard - rollback exceptions were never reported
r20617@hlagh (orig r7629): ribasushi | 2009-09-11 17:06:54 -0400
Extend prefetch tests
r20618@hlagh (orig r7630): ribasushi | 2009-09-11 17:13:45 -0400
Reverting http://dev.catalyst.perl.org/svnweb/bast/revision?rev=4278 - it seems to pass fine now
r20619@hlagh (orig r7631): ribasushi | 2009-09-11 18:15:50 -0400
Add single() ro RSC
r20620@hlagh (orig r7632): ribasushi | 2009-09-11 18:44:01 -0400
This is how the txnguard should really work
r20621@hlagh (orig r7633): ribasushi | 2009-09-11 18:58:21 -0400
Fix borked example
r20622@hlagh (orig r7634): ribasushi | 2009-09-11 18:58:58 -0400
scopeguard almost done
r20623@hlagh (orig r7635): brunov | 2009-09-11 19:25:12 -0400
Update DBIx::Class::Manual::Example.pod to reflect previous changes in examples/Schema/insertdb.pl
r20624@hlagh (orig r7636): brunov | 2009-09-11 19:27:17 -0400
Added Bruno Vecchi to the Contributors section in DBIx/Class.pm
r20625@hlagh (orig r7637): ribasushi | 2009-09-11 19:31:16 -0400
Final scopeguard tweak (?)
r20629@hlagh (orig r7641): ribasushi | 2009-09-12 06:46:51 -0400
Even better localization of $@, and don't use Test::Warn for the time being, as something is freaking out Sub::UpLevel
Rafael Kitover [Sun, 13 Sep 2009 08:27:44 +0000]
change _insert_dbh to _insert_storage
Peter Rabbitson [Sat, 12 Sep 2009 10:46:51 +0000]
Even better localization of $@, and don't use Test::Warn for the time being, as something is freaking out Sub::UpLevel
Peter Rabbitson [Fri, 11 Sep 2009 23:31:16 +0000]
Final scopeguard tweak (?)
Bruno Vecchi [Fri, 11 Sep 2009 23:27:17 +0000]
Added Bruno Vecchi to the Contributors section in DBIx/Class.pm
Bruno Vecchi [Fri, 11 Sep 2009 23:25:12 +0000]
Update DBIx::Class::Manual::Example.pod to reflect previous changes in examples/Schema/insertdb.pl
Peter Rabbitson [Fri, 11 Sep 2009 22:58:58 +0000]
scopeguard almost done
Peter Rabbitson [Fri, 11 Sep 2009 22:58:21 +0000]
Fix borked example
Peter Rabbitson [Fri, 11 Sep 2009 22:44:01 +0000]
This is how the txnguard should really work
Peter Rabbitson [Fri, 11 Sep 2009 22:15:50 +0000]
Add single() ro RSC
Peter Rabbitson [Fri, 11 Sep 2009 21:13:45 +0000]
Reverting dev.catalyst.perl.org/svnweb/bast/revision?rev=4278 - it seems to pass fine now
Peter Rabbitson [Fri, 11 Sep 2009 21:06:54 +0000]
Extend prefetch tests
Peter Rabbitson [Fri, 11 Sep 2009 13:39:42 +0000]
Fixed minor problem with txn scope guard - rollback exceptions were never reported
Peter Rabbitson [Fri, 11 Sep 2009 04:39:45 +0000]
Fix borked makefile
Peter Rabbitson [Fri, 11 Sep 2009 04:30:03 +0000]
Changes so far
Matt S Trout [Fri, 11 Sep 2009 00:33:17 +0000]
make it clear that we are not supposed to have optional deps
Peter Rabbitson [Thu, 10 Sep 2009 17:32:03 +0000]
The real fix
Aran Deltac [Thu, 10 Sep 2009 17:03:21 +0000]
Fix RSC->reset() to no longer return $self, which fixes Cursor::Cached + RSC.
Moritz Onken [Thu, 10 Sep 2009 16:53:32 +0000]
added test to make sure that store_column is called even for non-dirty columns
Rafael Kitover [Thu, 10 Sep 2009 00:16:03 +0000]
do blob update over _insert_dbh
Rafael Kitover [Wed, 9 Sep 2009 16:01:15 +0000]
remove Sub::Name hack for method dispatch, pass $next instead
Rafael Kitover [Wed, 9 Sep 2009 15:28:45 +0000]
Merge 'trunk' into 'sybase'
r20588@hlagh (orig r7613): ribasushi | 2009-09-09 08:16:12 -0400
Fix warning
r20589@hlagh (orig r7614): ribasushi | 2009-09-09 08:42:49 -0400
Really sanify exception text
Peter Rabbitson [Wed, 9 Sep 2009 12:42:49 +0000]
Really sanify exception text
Peter Rabbitson [Wed, 9 Sep 2009 12:16:12 +0000]
Fix warning
Rafael Kitover [Wed, 9 Sep 2009 10:27:02 +0000]
Merge 'trunk' into 'sybase'
r20554@hlagh (orig r7595): wreis | 2009-09-07 09:31:38 -0400
improved warn for Storable hooks in ResultSourceHandle
r20558@hlagh (orig r7597): ribasushi | 2009-09-07 10:26:59 -0400
Whoops - last_insert_id allows for multiple autoinc columns - support it in pg
r20560@hlagh (orig r7598): ribasushi | 2009-09-07 10:46:14 -0400
Prune duplicate constraints from the find() condition
r20578@hlagh (orig r7603): frew | 2009-09-08 14:13:29 -0400
Turn IDENTITY_INSERT back off after inserts
Rafael Kitover [Wed, 9 Sep 2009 10:08:36 +0000]
test multi-row blob update
Peter Rabbitson [Wed, 9 Sep 2009 08:41:15 +0000]
This should not have worked - I guess we lack tests?
Peter Rabbitson [Wed, 9 Sep 2009 08:38:41 +0000]
Reduce amount of perl-golf :)
Peter Rabbitson [Wed, 9 Sep 2009 07:40:29 +0000]
Much simpler
Peter Rabbitson [Wed, 9 Sep 2009 07:14:20 +0000]
Localisation ain't free, we don't do it unless we have to
Rafael Kitover [Wed, 9 Sep 2009 00:15:54 +0000]
remove unsafe_insert
Arthur Axel "fREW" Schmidt [Tue, 8 Sep 2009 18:13:29 +0000]
Turn IDENTITY_INSERT back off after inserts
Rafael Kitover [Mon, 7 Sep 2009 19:31:38 +0000]
fix _insert_dbh code to only connect when needed, doc update
Peter Rabbitson [Mon, 7 Sep 2009 14:46:14 +0000]
Prune duplicate constraints from the find() condition
Peter Rabbitson [Mon, 7 Sep 2009 14:26:59 +0000]
Whoops - last_insert_id allows for multiple autoinc columns - support it in pg
Wallace Reis [Mon, 7 Sep 2009 13:31:38 +0000]
improved warn for Storable hooks in ResultSourceHandle
Peter Rabbitson [Mon, 7 Sep 2009 10:38:31 +0000]
Merge 'trunk' into 'sybase'
r7511@Thesaurus (orig r7508): matthewt | 2009-09-03 20:12:53 +0200
get the COPYRIGHT in the right pless to not confuse META.yml generation
r7513@Thesaurus (orig r7510): ribasushi | 2009-09-03 20:41:22 +0200
r7514@Thesaurus (orig r7511): ribasushi | 2009-09-03 20:41:34 +0200
r7472@Thesaurus (orig r7469): norbi | 2009-09-01 21:43:08 +0200
r7635@vger: mendel | 2009-09-01 21:02:23 +0200
Added pointer to 'SQL functions on the lhs' to the 'using stored procs' section.
r7515@Thesaurus (orig r7512): ribasushi | 2009-09-03 20:41:44 +0200
r7473@Thesaurus (orig r7470): norbi | 2009-09-01 21:43:19 +0200
r7636@vger: mendel | 2009-09-01 21:09:43 +0200
Mentions the possibiliby of creating indexes on SQL function return values.
r7516@Thesaurus (orig r7513): ribasushi | 2009-09-03 20:41:52 +0200
r7474@Thesaurus (orig r7471): norbi | 2009-09-01 21:43:31 +0200
r7637@vger: mendel | 2009-09-01 21:19:14 +0200
Rewrote 'SQL functions on the lhs' to use the new SQLA literal SQL + bind feature.
r7517@Thesaurus (orig r7514): ribasushi | 2009-09-03 20:41:59 +0200
r7475@Thesaurus (orig r7472): norbi | 2009-09-01 21:43:42 +0200
r7638@vger: mendel | 2009-09-01 21:20:17 +0200
Added a comment to the example code to stress that it does not work.
r7518@Thesaurus (orig r7515): ribasushi | 2009-09-03 20:42:10 +0200
r7476@Thesaurus (orig r7473): norbi | 2009-09-01 21:43:54 +0200
r7639@vger: mendel | 2009-09-01 21:28:18 +0200
Added pointer to DBIx::Class::DynamicSubclass.
r7519@Thesaurus (orig r7516): ribasushi | 2009-09-03 20:42:15 +0200
r7477@Thesaurus (orig r7474): norbi | 2009-09-01 21:44:03 +0200
r7640@vger: mendel | 2009-09-01 21:30:13 +0200
Replaced deprecated \'colname DESC' order_by syntax with { -desc => 'colname' } syntax.
r7520@Thesaurus (orig r7517): ribasushi | 2009-09-03 20:42:22 +0200
r7478@Thesaurus (orig r7475): norbi | 2009-09-01 21:44:17 +0200
r7641@vger: mendel | 2009-09-01 21:32:48 +0200
Rewrote 'SQL functions on the lhs' to use the new SQLA literal SQL + bind feature.
r7521@Thesaurus (orig r7518): ribasushi | 2009-09-03 20:42:26 +0200
r7479@Thesaurus (orig r7476): norbi | 2009-09-01 21:44:28 +0200
r7642@vger: mendel | 2009-09-01 21:42:25 +0200
Added many-to-many add_to_*() example to stress that it returns the related row and not the linking table row.
r7522@Thesaurus (orig r7519): ribasushi | 2009-09-03 20:42:32 +0200
r7480@Thesaurus (orig r7477): norbi | 2009-09-01 22:14:25 +0200
r7653@vger: mendel | 2009-09-01 22:14:11 +0200
Fixed wrong literal SQL + bind examples (missing operator and placeholders).
r7523@Thesaurus (orig r7520): ribasushi | 2009-09-03 20:42:37 +0200
r7481@Thesaurus (orig r7478): norbi | 2009-09-01 22:30:48 +0200
r7655@vger: mendel | 2009-09-01 22:30:35 +0200
Fixed the bind value column names in the SQL literal + bind examples.
r7524@Thesaurus (orig r7521): ribasushi | 2009-09-03 20:42:45 +0200
r7482@Thesaurus (orig r7479): norbi | 2009-09-01 22:52:21 +0200
r7657@vger: mendel | 2009-09-01 22:52:09 +0200
Further improvement in the bind value column names in the SQL literal + bind examples.
r7549@Thesaurus (orig r7546): ribasushi | 2009-09-04 08:47:19 +0200
Stop connecting to determine dt-parser (test is in pg branch)
r7553@Thesaurus (orig r7550): ribasushi | 2009-09-04 11:20:48 +0200
Require sqla with bool support
r7560@Thesaurus (orig r7557): ribasushi | 2009-09-04 19:17:32 +0200
Dumper follies
r7561@Thesaurus (orig r7558): ribasushi | 2009-09-04 19:27:50 +0200
Even better sqla
r7570@Thesaurus (orig r7567): ribasushi | 2009-09-04 20:49:53 +0200
r7459@Thesaurus (orig r7456): rbuels | 2009-09-01 12:46:46 +0200
making another pg_unqualified_schema branch, for real this time
r7460@Thesaurus (orig r7457): rbuels | 2009-09-01 12:51:31 +0200
reworked tests for pg last_insert_id in presence of un-schema-qualified things. adds some todo tests, including a case for which is does not seem to be possible to correctly guess the sequence to use for the liid
r7461@Thesaurus (orig r7458): rbuels | 2009-09-01 12:54:34 +0200
in Pg storage, added a warning for case when the nextval sequence is not schema qualified
r7462@Thesaurus (orig r7459): rbuels | 2009-09-01 13:01:31 +0200
tweak to Pg test, warnings_like -> warnings_exist
r7463@Thesaurus (orig r7460): ribasushi | 2009-09-01 13:34:59 +0200
Rewrap todo properly
r7490@Thesaurus (orig r7487): ribasushi | 2009-09-02 14:16:01 +0200
Make pg sequence autodetect deterministic (or throw exceptions). Test needs adjusting
r7491@Thesaurus (orig r7488): rbuels | 2009-09-02 19:15:01 +0200
some reorganization and cleanup of pg-specific tests
r7492@Thesaurus (orig r7489): rbuels | 2009-09-02 20:08:31 +0200
more cleanup of 72pg.t
r7495@Thesaurus (orig r7492): rbuels | 2009-09-02 20:48:12 +0200
more cleanup of pg tests, added cascade to drop function, cleaned up create and drop of schemas to use dbh_do
r7496@Thesaurus (orig r7493): rbuels | 2009-09-02 20:50:42 +0200
oops, missed something screwed up by the pull
r7525@Thesaurus (orig r7522): rbuels | 2009-09-03 20:45:53 +0200
added __END__ before pod in Pg storage
r7526@Thesaurus (orig r7523): rbuels | 2009-09-03 20:46:00 +0200
renamed pg test schemas to be more organized
r7531@Thesaurus (orig r7528): rbuels | 2009-09-04 00:28:11 +0200
more pg test cleanup
r7532@Thesaurus (orig r7529): rbuels | 2009-09-04 00:28:17 +0200
more pg test cleanup
r7533@Thesaurus (orig r7530): rbuels | 2009-09-04 00:28:25 +0200
starting work on extended set of Pg auto-pk tests
r7534@Thesaurus (orig r7531): rbuels | 2009-09-04 00:28:31 +0200
more work on extended set of Pg auto-pk tests
r7535@Thesaurus (orig r7532): rbuels | 2009-09-04 00:28:39 +0200
more work on pg tests
r7536@Thesaurus (orig r7533): rbuels | 2009-09-04 00:28:45 +0200
more work on extended set of Pg auto-pk tests
r7537@Thesaurus (orig r7534): rbuels | 2009-09-04 00:28:50 +0200
added .gitignore for users of git-svn
r7538@Thesaurus (orig r7535): rbuels | 2009-09-04 00:28:58 +0200
more work on extended set of Pg auto-pk tests
r7539@Thesaurus (orig r7536): rbuels | 2009-09-04 00:29:04 +0200
added darcs and git to MANIFEST.SKIP version control skipping section
r7540@Thesaurus (orig r7537): rbuels | 2009-09-04 00:41:26 +0200
more work on extended set of Pg auto-pk tests
r7541@Thesaurus (orig r7538): rbuels | 2009-09-04 00:41:32 +0200
more work on extended set of Pg auto-pk tests
r7542@Thesaurus (orig r7539): rbuels | 2009-09-04 00:41:38 +0200
more work on extended set of Pg auto-pk tests
r7543@Thesaurus (orig r7540): rbuels | 2009-09-04 02:20:23 +0200
more work on extended set of Pg auto-pk tests
r7544@Thesaurus (orig r7541): rbuels | 2009-09-04 02:20:32 +0200
rewrote autoinc fetcher as a query into the pg_catalog. all the old tests pass now, but not my new tests. the new tests might be buggy
r7545@Thesaurus (orig r7542): rbuels | 2009-09-04 02:20:39 +0200
oops, forgot to put the drop for the extended tests back in the pg tests
r7546@Thesaurus (orig r7543): rbuels | 2009-09-04 02:41:56 +0200
couple of comment/documentation tweaks to pg storage driver
r7547@Thesaurus (orig r7544): rbuels | 2009-09-04 02:42:02 +0200
fixed my tests
r7548@Thesaurus (orig r7545): rbuels | 2009-09-04 02:42:09 +0200
clarified the POD in Pg storage driver regarding multi-schema support
r7551@Thesaurus (orig r7548): ribasushi | 2009-09-04 08:51:30 +0200
Proper unconnected test
r7554@Thesaurus (orig r7551): ribasushi | 2009-09-04 11:26:12 +0200
Fixes to pg test after review:
- Move the store_column test to 60core.t
- Streamline the select ... for update test
- Disable all exception warnings for normal test runs
r7555@Thesaurus (orig r7552): ribasushi | 2009-09-04 11:56:00 +0200
Rewrite selector using sqla
r7562@Thesaurus (orig r7559): rbuels | 2009-09-04 19:42:52 +0200
moved search_path querying function from Pg storage driver into tests
r7563@Thesaurus (orig r7560): rbuels | 2009-09-04 19:43:00 +0200
refactored how Pg storage driver calls sequence search, made erorror message more informative when query into pg_catalog fails
r7564@Thesaurus (orig r7561): rbuels | 2009-09-04 19:43:08 +0200
tweaked pg sequence discovery error message a bit more
r7565@Thesaurus (orig r7562): rbuels | 2009-09-04 19:43:17 +0200
added big block comment explaining Pg sequence discovery strategy
r7566@Thesaurus (orig r7563): rbuels | 2009-09-04 20:35:10 +0200
added code to use DBD::Pg column_info to fetch column default if recent enough
r7567@Thesaurus (orig r7564): rbuels | 2009-09-04 20:35:18 +0200
tweaked comment
r7568@Thesaurus (orig r7565): rbuels | 2009-09-04 20:35:30 +0200
oops, DBD::Pg 2.15.1 should be included in working versions
r7572@Thesaurus (orig r7569): ribasushi | 2009-09-04 21:32:01 +0200
Stop double-caching datetime_parser - keep it in the storage only
r7573@Thesaurus (orig r7570): ribasushi | 2009-09-04 21:36:39 +0200
No Serialize::Storable in core
r7574@Thesaurus (orig r7571): ribasushi | 2009-09-04 21:49:54 +0200
Changes
r7580@Thesaurus (orig r7577): ribasushi | 2009-09-06 12:28:44 +0200
Add mysterious exception test
r7582@Thesaurus (orig r7579): ribasushi | 2009-09-06 15:43:10 +0200
No connection - no cleanup
r7583@Thesaurus (orig r7580): ribasushi | 2009-09-06 15:45:51 +0200
Streamline test
r7584@Thesaurus (orig r7581): ribasushi | 2009-09-06 17:39:03 +0200
Test cleanup:
Benchmark and Data::Dumper have been in core forever
Make POD testing conditional as shown in http://use.perl.org/~Alias/journal/38822
Remove some dead cdbi test files
Stop openly giving contributors an option to override the authorcheck
r7585@Thesaurus (orig r7582): ribasushi | 2009-09-06 17:48:32 +0200
Done long time ago
r7586@Thesaurus (orig r7583): ribasushi | 2009-09-06 17:56:27 +0200
Release 0.08110
r7588@Thesaurus (orig r7585): ribasushi | 2009-09-06 18:33:46 +0200
Stop eating exceptions in ::Storage::DBI::DESTROY
r7589@Thesaurus (orig r7586): ribasushi | 2009-09-06 20:35:30 +0200
Centralize identity insert control for mssql (it seems that issuing an OFF is not necessary)
r7590@Thesaurus (orig r7587): ribasushi | 2009-09-06 20:45:41 +0200
Clearer MSSQL error message
r7591@Thesaurus (orig r7588): ribasushi | 2009-09-06 23:58:22 +0200
Fix mssql pod
r7592@Thesaurus (orig r7589): ribasushi | 2009-09-07 09:06:05 +0200
Release 0.08111
Peter Rabbitson [Mon, 7 Sep 2009 07:14:33 +0000]
Whoops this should not have committed
Peter Rabbitson [Mon, 7 Sep 2009 07:10:05 +0000]
Release 0.08111 tag
Peter Rabbitson [Mon, 7 Sep 2009 07:06:05 +0000]
Release 0.08111
Peter Rabbitson [Sun, 6 Sep 2009 21:58:22 +0000]
Fix mssql pod
Peter Rabbitson [Sun, 6 Sep 2009 18:45:41 +0000]
Clearer MSSQL error message
Peter Rabbitson [Sun, 6 Sep 2009 18:35:30 +0000]
Centralize identity insert control for mssql (it seems that issuing an OFF is not necessary)
Peter Rabbitson [Sun, 6 Sep 2009 16:33:46 +0000]
Stop eating exceptions in ::Storage::DBI::DESTROY
Peter Rabbitson [Sun, 6 Sep 2009 15:56:27 +0000]
Release 0.08110
Peter Rabbitson [Sun, 6 Sep 2009 15:48:32 +0000]
Done long time ago
Peter Rabbitson [Sun, 6 Sep 2009 15:39:03 +0000]
Test cleanup:
Benchmark and Data::Dumper have been in core forever
Make POD testing conditional as shown in http://use.perl.org/~Alias/journal/38822
Remove some dead cdbi test files
Stop openly giving contributors an option to override the authorcheck
Peter Rabbitson [Sun, 6 Sep 2009 13:45:51 +0000]
Streamline test
Peter Rabbitson [Sun, 6 Sep 2009 13:43:10 +0000]
No connection - no cleanup
Peter Rabbitson [Sun, 6 Sep 2009 10:28:44 +0000]
Add mysterious exception test
Rafael Kitover [Sat, 5 Sep 2009 05:23:57 +0000]
pending review by mpeppler
Peter Rabbitson [Fri, 4 Sep 2009 19:49:54 +0000]
Changes
Peter Rabbitson [Fri, 4 Sep 2009 19:36:39 +0000]
No Serialize::Storable in core
Peter Rabbitson [Fri, 4 Sep 2009 19:32:01 +0000]
Stop double-caching datetime_parser - keep it in the storage only
Peter Rabbitson [Fri, 4 Sep 2009 18:49:53 +0000]
Merge 'pg_unqualified_schema' into 'trunk'
Robert Buels [Fri, 4 Sep 2009 18:35:30 +0000]
oops, DBD::Pg 2.15.1 should be included in working versions
Robert Buels [Fri, 4 Sep 2009 18:35:18 +0000]
tweaked comment