Peter Rabbitson [Wed, 10 Jun 2009 12:48:39 +0000]
Adjust changelog
Peter Rabbitson [Wed, 10 Jun 2009 11:43:31 +0000]
What was I thinking - resultsource does not have an ->alias
Peter Rabbitson [Wed, 10 Jun 2009 11:33:37 +0000]
Merge 'mystery_join' into 'trunk'
r6544@Thesaurus (orig r6543): ribasushi | 2009-06-08 11:44:59 +0200
Attempt to figure out why do we repeat joins on complex search_related
r6586@Thesaurus (orig r6585): ribasushi | 2009-06-10 11:22:05 +0200
Move the rs preservation test to a more suitable place
r6589@Thesaurus (orig r6588): ribasushi | 2009-06-10 13:15:48 +0200
Finally commit trully failing test
r6590@Thesaurus (orig r6589): ribasushi | 2009-06-10 13:33:14 +0200
Duh, this was a pretty simple bug
Peter Rabbitson [Wed, 10 Jun 2009 11:33:14 +0000]
Duh, this was a pretty simple bug
Peter Rabbitson [Wed, 10 Jun 2009 11:15:48 +0000]
Finally commit trully failing test
Peter Rabbitson [Wed, 10 Jun 2009 11:00:02 +0000]
Merge 'trunk' into 'mystery_join'
r6553@Thesaurus (orig r6552): ribasushi | 2009-06-08 23:56:41 +0200
duh
r6557@Thesaurus (orig r6556): ash | 2009-06-09 12:20:34 +0200
Addjust bug to show problem with rows => 1 + child rel
r6558@Thesaurus (orig r6557): ribasushi | 2009-06-09 13:12:46 +0200
Require a recent bugfixed Devel::Cycle
r6560@Thesaurus (orig r6559): ash | 2009-06-09 15:07:30 +0200
Make IC::DT extra warning state the column name too
r6575@Thesaurus (orig r6574): ribasushi | 2009-06-10 00:19:48 +0200
AuthorCheck fixes
r6579@Thesaurus (orig r6578): ribasushi | 2009-06-10 00:52:17 +0200
r6522@Thesaurus (orig r6521): ribasushi | 2009-06-05 19:27:55 +0200
New branch to try resultsource related stuff
r6545@Thesaurus (orig r6544): ribasushi | 2009-06-08 13:00:54 +0200
First stab at adding resultsources to each join in select - works won-der-ful-ly
r6546@Thesaurus (orig r6545): ribasushi | 2009-06-08 13:14:08 +0200
Commit failing test and thoughts on search arg deflation
r6576@Thesaurus (orig r6575): ribasushi | 2009-06-10 00:31:55 +0200
Todoify DT in search deflation test until after 0.09
r6577@Thesaurus (orig r6576): ribasushi | 2009-06-10 00:48:07 +0200
Factor out the $ident resolver
r6581@Thesaurus (orig r6580): ribasushi | 2009-06-10 01:21:50 +0200
Move as_query out of the cursor
r6582@Thesaurus (orig r6581): ribasushi | 2009-06-10 01:27:19 +0200
Think before commit
r6583@Thesaurus (orig r6582): ribasushi | 2009-06-10 09:37:19 +0200
Clarify and disable rows/prefetch test - fix is easy, but architecturally unsound - need more time
Peter Rabbitson [Wed, 10 Jun 2009 09:22:05 +0000]
Move the rs preservation test to a more suitable place
Peter Rabbitson [Wed, 10 Jun 2009 07:37:19 +0000]
Clarify and disable rows/prefetch test - fix is easy, but architecturally unsound - need more time
Peter Rabbitson [Tue, 9 Jun 2009 23:27:19 +0000]
Think before commit
Peter Rabbitson [Tue, 9 Jun 2009 23:21:50 +0000]
Move as_query out of the cursor
Peter Rabbitson [Tue, 9 Jun 2009 22:52:17 +0000]
Merge 'rsrc_in_storage' into 'trunk'
Peter Rabbitson [Tue, 9 Jun 2009 22:48:07 +0000]
Factor out the $ident resolver
Peter Rabbitson [Tue, 9 Jun 2009 22:31:55 +0000]
Todoify DT in search deflation test until after 0.09
Peter Rabbitson [Tue, 9 Jun 2009 22:19:48 +0000]
AuthorCheck fixes
Ash Berlin [Tue, 9 Jun 2009 13:07:30 +0000]
Make IC::DT extra warning state the column name too
Peter Rabbitson [Tue, 9 Jun 2009 11:12:46 +0000]
Require a recent bugfixed Devel::Cycle
Ash Berlin [Tue, 9 Jun 2009 10:20:34 +0000]
Addjust bug to show problem with rows => 1 + child rel
Peter Rabbitson [Mon, 8 Jun 2009 21:56:41 +0000]
duh
Peter Rabbitson [Mon, 8 Jun 2009 11:14:08 +0000]
Commit failing test and thoughts on search arg deflation
Peter Rabbitson [Mon, 8 Jun 2009 11:00:54 +0000]
First stab at adding resultsources to each join in select - works won-der-ful-ly
Peter Rabbitson [Mon, 8 Jun 2009 09:36:56 +0000]
Simply order_by/_virtual_order_by handling
Peter Rabbitson [Sun, 7 Jun 2009 23:24:06 +0000]
Fix find_or_new/create to stop returning random rows when default value insert is requested
Peter Rabbitson [Sun, 7 Jun 2009 23:03:04 +0000]
Make podcoverage happy
Peter Rabbitson [Sun, 7 Jun 2009 22:59:21 +0000]
Add mysql empty insert SQL override
Make SQLAHacks parts loadable at runtime via ensure_class_loaded
Peter Rabbitson [Sun, 7 Jun 2009 21:36:43 +0000]
Make empty/default inserts use standard SQL
Peter Rabbitson [Sun, 7 Jun 2009 21:07:55 +0000]
Fix for mysql subquery problem
Peter Rabbitson [Sat, 6 Jun 2009 08:50:56 +0000]
Port another forgotten MC fix
Peter Rabbitson [Sat, 6 Jun 2009 08:47:47 +0000]
TODOified reentrancy counter - this shall be used to optimize MC some day
Peter Rabbitson [Sat, 6 Jun 2009 08:45:10 +0000]
rename MC test dir
Peter Rabbitson [Fri, 5 Jun 2009 17:25:56 +0000]
Factor out the grouped count subquery SELECTor so specific storage classes can override it
Trim attribute deletion lists - we work with _resolved_attrs - +X are already folded into X and the like
Peter Rabbitson [Fri, 5 Jun 2009 14:28:58 +0000]
This was dumb - of course I want a copy
Otherwise the next serach_related will work with a contaminated seen_joins
Peter Rabbitson [Thu, 4 Jun 2009 21:51:13 +0000]
It seems that this localisation can lead to problems
Unfortunately no test case as the trigger was buried deep within Reaction, I coulnd't figure out an isolation
Peter Rabbitson [Thu, 4 Jun 2009 20:54:28 +0000]
having without group_by is useless - thus do not supply a group_by on count, let things die
Peter Rabbitson [Thu, 4 Jun 2009 13:38:21 +0000]
Really delegate counting to the storage class - now we have either a grouped count or a regular one
Peter Rabbitson [Thu, 4 Jun 2009 09:52:18 +0000]
Delegate actual counting to the storage class
Peter Rabbitson [Thu, 4 Jun 2009 07:35:25 +0000]
Move relationship tests around
Peter Rabbitson [Wed, 3 Jun 2009 08:14:51 +0000]
Require a recent version of Date::Simple during CDBI tests
Peter Rabbitson [Mon, 1 Jun 2009 14:49:09 +0000]
Fix fallout from another botched merge (I suck, part 2)
Peter Rabbitson [Mon, 1 Jun 2009 14:41:49 +0000]
Merge 'order_by_refactor' into 'trunk'
Peter Rabbitson [Mon, 1 Jun 2009 10:24:41 +0000]
deploy-related pod fixes
Peter Rabbitson [Sun, 31 May 2009 14:07:18 +0000]
Last set of Makefile.PL optimizations
Peter Rabbitson [Sun, 31 May 2009 09:24:15 +0000]
There is a saner way to write out resources
Peter Rabbitson [Sun, 31 May 2009 07:42:35 +0000]
Throw away the makefile SQLite test - it served its purpose
Peter Rabbitson [Sun, 31 May 2009 07:37:37 +0000]
M::I 0.89 finally resolves all provlems with auto_install
Peter Rabbitson [Sat, 30 May 2009 17:46:09 +0000]
populate() fix and Changes
Peter Rabbitson [Sat, 30 May 2009 17:17:02 +0000]
Add changes
Peter Rabbitson [Sat, 30 May 2009 17:13:23 +0000]
Evil hack to make Carp::Clan work throughout SQLA as well
Peter Rabbitson [Sat, 30 May 2009 15:15:57 +0000]
Greatly simplify _order_by override to fallback on new SQLA
Peter Rabbitson [Sat, 30 May 2009 14:55:37 +0000]
Restructure bind tests
Peter Rabbitson [Sat, 30 May 2009 14:54:37 +0000]
TODOify some of the order with bind tests
Moritz Onken [Sat, 30 May 2009 09:06:54 +0000]
order_by tests
Peter Rabbitson [Sat, 30 May 2009 07:34:20 +0000]
Add better error reporting on bulk_insert (ash++)
Peter Rabbitson [Sat, 30 May 2009 05:40:24 +0000]
Patch + test for more informative exceptions on load_namespace a non-rs class
Peter Rabbitson [Thu, 28 May 2009 11:02:22 +0000]
Fix multiprefetch warning - we can now count properly
Peter Rabbitson [Thu, 28 May 2009 08:20:57 +0000]
Commit rather useless but already written mysql test extension
Peter Rabbitson [Tue, 26 May 2009 20:02:29 +0000]
Release 0.08103
Peter Rabbitson [Tue, 26 May 2009 19:28:49 +0000]
Attempt to reproduce reported mysql error (failed) - fixed another bug in ResultSetColumn along the way
Peter Rabbitson [Tue, 26 May 2009 18:49:49 +0000]
fix comments
Peter Rabbitson [Tue, 26 May 2009 15:20:57 +0000]
Minor fixes of the return value of rs->update/delete
Peter Rabbitson [Tue, 26 May 2009 14:36:55 +0000]
Fix test skip message
Peter Rabbitson [Tue, 26 May 2009 14:29:55 +0000]
Merge 'top_limit_altfix' into 'trunk'
Ash Berlin [Tue, 26 May 2009 14:17:44 +0000]
Fix 'timestamp with time zone' columns for IC::DT inflation
Peter Rabbitson [Tue, 26 May 2009 06:15:34 +0000]
TODOified test for RT#40701
Peter Rabbitson [Mon, 25 May 2009 17:42:02 +0000]
This method does not exist anymore
Tom Hukins [Mon, 25 May 2009 16:33:46 +0000]
Small documentation improvement: link to a documented method.
Peter Rabbitson [Mon, 25 May 2009 15:45:33 +0000]
Too much logic for no benefit - always populate _virtual_order_by
Peter Rabbitson [Mon, 25 May 2009 14:53:13 +0000]
Actually don't need this anymore
Peter Rabbitson [Mon, 25 May 2009 14:08:40 +0000]
Merge 'top_limit_tweaks' into 'top_limit_altfix'
Shoot another Top problem, move test from top_limit_tweaks branch and delete
Peter Rabbitson [Mon, 25 May 2009 09:24:32 +0000]
The Top limit emulation bundled with SQLA::Limit assumes that the limited resultset will be _always_ sorted. In order to fix this, I reimplemented _Top in SQLAHacks with a slight modification. Now the original order_by is passed to the outside of the nested select block, while order_up/down are calculated either based on the original order_by, or if one is not present an order by all PKs is attempted.
Since I do not have access to $rsrc in SQLA, I pass the list of PKs as an extra group_by hash entry. This appears to be rather safe, and besides we already pollute order_by with group_by and having (which seems to work rather well).
The only thing I am unsure about is the need for _gen_virtual_order(). Initially I was going to generate the pk list, only if we use the Top limit. Then it turned out there is no limit dialect before we connect, so I commented it out. Now all it does is check for a limit condition and returns the PK list. Is this necessary at all?
Peter Rabbitson [Mon, 25 May 2009 09:11:01 +0000]
Define how Top limit emulation should behave
Peter Rabbitson [Mon, 25 May 2009 07:47:01 +0000]
Forgotten podcoverage override
Peter Rabbitson [Mon, 25 May 2009 07:42:45 +0000]
Move the DB2 Limit syntax setting into the storage class
Peter Rabbitson [Mon, 25 May 2009 06:48:38 +0000]
Factor out the order_by sqlahacks resolver
Rafael Kitover [Sun, 24 May 2009 23:53:12 +0000]
added test to make sure only one connection to ODBC/MSSQL is made
Rafael Kitover [Sun, 24 May 2009 23:49:17 +0000]
fix double connect for ODBC/MSSQL
Peter Rabbitson [Sun, 24 May 2009 20:53:15 +0000]
Switch around inheritance of MSSQL drivers, remove some duplicate code
Peter Rabbitson [Sun, 24 May 2009 13:35:07 +0000]
Failing test about warnings triggered in SQLA::Limit when using a subquery
Peter Rabbitson [Sun, 24 May 2009 13:00:50 +0000]
eol adjustments
Peter Rabbitson [Sun, 24 May 2009 12:12:39 +0000]
Deprecate ::DBI::Sybase::MSSQL
Peter Rabbitson [Sun, 24 May 2009 09:43:32 +0000]
SUPER is so last century
Peter Rabbitson [Sun, 24 May 2009 09:42:01 +0000]
Make sure we do not clobber search attributes when using subqueries
Peter Rabbitson [Sun, 24 May 2009 08:47:03 +0000]
MSSQL through ODBC does not like unfinished statements - make sure we finish the scope identity retrieval
(This worked before because of the automatic retry on exception, essentially running any select after insert twice)
Peter Rabbitson [Sat, 23 May 2009 22:50:08 +0000]
Extend distinct deprecation tests and clarify warnings
Peter Rabbitson [Sat, 23 May 2009 22:47:40 +0000]
update changes
Peter Rabbitson [Sat, 23 May 2009 21:37:19 +0000]
Make sure MultiColumnIn quotes column names while munging literal sql
Tested by running t/resultset/update_delete against pg with quote char " and name sep .
Rafael Kitover [Sat, 23 May 2009 21:04:01 +0000]
minor clean up
Peter Rabbitson [Sat, 23 May 2009 20:59:17 +0000]
Extra test and count fixes for prefetch + distinct
Rafael Kitover [Sat, 23 May 2009 20:28:42 +0000]
revert last Sybase changes
Rafael Kitover [Sat, 23 May 2009 19:57:08 +0000]
hide internal Sybase classes from PAUSE
Rafael Kitover [Sat, 23 May 2009 19:46:11 +0000]
Sybase bindvar and IC::DT support
Peter Rabbitson [Sat, 23 May 2009 19:35:59 +0000]
Add storage component of multipk resultset update/delete for multicolumn IN capable rdbms
Switch Pg to that (tested via DBICTEST_DSN)
Peter Rabbitson [Sat, 23 May 2009 19:33:28 +0000]
Tests and test schema adjustments for resultset update/delete
Rafael Kitover [Sat, 23 May 2009 14:44:59 +0000]
Sybase autopk, and a test, no limit support yet
Peter Rabbitson [Sat, 23 May 2009 08:09:46 +0000]
Refactor rs_update_delete (too many methods for no reason)
Make mysql use _per_row_update_delete by default as this is the only thing it understands: http://dev.mysql.com/doc/refman/5.0/en/subquery-errors.html
Ash Berlin [Fri, 22 May 2009 16:54:00 +0000]
Make distinct calculate columns *after* prefetch has been resolved. Tests to come
Rafael Kitover [Fri, 22 May 2009 13:50:45 +0000]
::Replicated -- check for master rebless and reapply role if necessary
Peter Rabbitson [Fri, 22 May 2009 08:35:36 +0000]
duh
Peter Rabbitson [Fri, 22 May 2009 08:31:25 +0000]
Some attributes require a grouped count subquery, some - just a subquery. Differentiate properly
Peter Rabbitson [Fri, 22 May 2009 08:28:58 +0000]
Extend DB2 test
Rafael Kitover [Fri, 22 May 2009 06:09:05 +0000]
fix limit for DB2