12 years agouse more correct subsection links in POD
Graham Knop [Tue, 17 Jan 2012 17:18:43 +0000]
use more correct subsection links in POD

12 years agoremove ::Storage::DBI::sth from POD as it should never have been public
Graham Knop [Tue, 17 Jan 2012 17:25:49 +0000]
remove ::Storage::DBI::sth from POD as it should never have been public

12 years agofix PrettyPrint package link in POD
Graham Knop [Tue, 17 Jan 2012 17:22:00 +0000]
fix PrettyPrint package link in POD

12 years agocorrect organization for SQLite POD
Graham Knop [Tue, 17 Jan 2012 17:20:34 +0000]
correct organization for SQLite POD

12 years agoissue warning for DateTimes passed to ->search
Rafael Kitover [Wed, 18 Jan 2012 14:56:18 +0000]
issue warning for DateTimes passed to ->search

Issue a carp_unique when DateTime objects are detected in binds in
::Storage::DBI with a pointer to the Cookbook recipe for formatting
DateTime objects for queries.

Add a test for the warning in t/inflate/datetime.t, which already has
TODO tests for DTs in ->search.

12 years agoadd POD on how to use Moose in custom ResultSets
Rafael Kitover [Tue, 10 Jan 2012 21:56:03 +0000]
add POD on how to use Moose in custom ResultSets

Thanks to mst for providing the relevant info.

12 years agoTrailing WS crusade - got to save them bits
Peter Rabbitson [Thu, 5 Jan 2012 02:59:41 +0000]
Trailing WS crusade - got to save them bits

12 years agoAdd link to SQLHackers documentation
Jess Robinson [Fri, 9 Dec 2011 17:00:45 +0000]
Add link to SQLHackers documentation

12 years ago- Fix typo (s/get_colum/get_column).
Brad Davis [Wed, 4 Jan 2012 04:52:02 +0000]
- Fix typo (s/get_colum/get_column).

12 years agouse Path::Class for finding subdirs of t and don't use global filehandle for slurping
Alexander Hartmaier [Tue, 3 Jan 2012 12:00:47 +0000]
use Path::Class for finding subdirs of t and don't use global filehandle for slurping

12 years agorefactored HashRefInflators internals
Alexander Hartmaier [Wed, 14 Dec 2011 10:15:44 +0000]
refactored HashRefInflators internals

12 years agoRewrite the HRI bench to produce consistent numbers with less handholding
Peter Rabbitson [Mon, 19 Dec 2011 05:55:18 +0000]
Rewrite the HRI bench to produce consistent numbers with less handholding

- Now we auto-pull from git what we want to benchmark (by default last
  2 commits + uncommitted changes if any)
- Run a very tight benchmarking loop, without requerying SQLite or have
  any other unrelated distractions
- use DumbBench (much saner implementation and results, though slower)

12 years agoAdd live Firebird test for paging fix 8b31f62e
Rafael Kitover [Thu, 1 Dec 2011 17:29:51 +0000]
Add live Firebird test for paging fix 8b31f62e

12 years agoFix and test first_skip/skip_first limit dialects
Peter Rabbitson [Thu, 1 Dec 2011 16:50:57 +0000]
Fix and test first_skip/skip_first limit dialects

Codebase didn't take in account the fact that limit bindvals for
SELECT FIRST x SKIP y and SELECT FIRST x SKIP y need to be inserted
at the head of the bind-assembly chain. Hence introducing a new
bind-chunk position 'pre_select'. While at it move the TOP dialect
to use it as well.

Extensive tests for both dialects, and also augment the test for
the Oracle RowNum dialect (no fixes necessary)

12 years agoStandardize hobbs' email address
Peter Rabbitson [Tue, 29 Nov 2011 06:00:23 +0000]
Standardize hobbs' email address

12 years agoRelease 0.08196 v0.08196
Andrew Rodland [Tue, 29 Nov 2011 05:34:15 +0000]
Release 0.08196

12 years agoMore test fixes following 4a425300 and new DBD::SQLite release
Peter Rabbitson [Tue, 29 Nov 2011 05:31:45 +0000]
More test fixes following 4a425300 and new DBD::SQLite release

12 years agoFix some logic pitfalls in the require tracer
Peter Rabbitson [Sat, 26 Nov 2011 10:00:53 +0000]
Fix some logic pitfalls in the require tracer

12 years agoFix the join/prefetch resolver when dealing with ''/undef/()
Peter Rabbitson [Sat, 26 Nov 2011 01:41:16 +0000]
Fix the join/prefetch resolver when dealing with ''/undef/()

12 years agoModifying links to /condition to point to DBIC::Relationship::Base
Peter Valdemar Mørch [Tue, 2 Aug 2011 18:18:17 +0000]
Modifying links to /condition to point to DBIC::Relationship::Base

Because that is where the condition description is to be found

12 years agoFix copyright... in November
Peter Rabbitson [Fri, 25 Nov 2011 23:22:17 +0000]
Fix copyright... in November

12 years agoMake both pg and mysql execute t/98savepoints.t if present
Peter Rabbitson [Fri, 25 Nov 2011 23:20:16 +0000]
Make both pg and mysql execute t/98savepoints.t if present

12 years agoMake tests pass with DBIC_TRACE and DBIC_TRACE_PROFILE set
Peter Rabbitson [Fri, 25 Nov 2011 23:01:46 +0000]
Make tests pass with DBIC_TRACE and DBIC_TRACE_PROFILE set

12 years agoFix TxnScopeGuard misbehaving on externally set $@ without inner exceptions
Peter Rabbitson [Fri, 25 Nov 2011 22:20:44 +0000]
Fix TxnScopeGuard misbehaving on externally set $@ without inner exceptions

The guard is supposed to warn when it goes out of scope without a commit.
However this doesn't work if $@ was already set before the guard was created
and there were no eval{}s to clear it between definition and destruction.

Fixing this by storing a weakref to the current exception (if any) and
disregarding the contents of $@ if they match the ref we started with.

12 years agoAbstract away the CORE::GLOBAL::require override code, foolproof tests
Peter Rabbitson [Thu, 24 Nov 2011 17:38:09 +0000]
Abstract away the CORE::GLOBAL::require override code, foolproof tests

Rewrite prompted by some weirdness in Package::Stash::XS and require overrides
on older perls < 5.8.7. Besides the cleaner code add a kick-ass require
tracer.

12 years agoMore robust test suite skip-checks, check ENV before loading modules
Peter Rabbitson [Fri, 25 Nov 2011 10:44:16 +0000]
More robust test suite skip-checks, check ENV before loading modules

12 years agoSwitch the nobindvars test from MySQL to the always available SQLite
Peter Rabbitson [Fri, 25 Nov 2011 10:35:00 +0000]
Switch the nobindvars test from MySQL to the always available SQLite

12 years agoSkip error/warn frames within CAG - saner callsite error messages this way
Peter Rabbitson [Tue, 23 Aug 2011 14:10:09 +0000]
Skip error/warn frames within CAG - saner callsite error messages this way

12 years agoDocumented $resultsource->name
Mark A. Stratman [Tue, 14 Jun 2011 17:48:34 +0000]
Documented $resultsource->name

12 years agoDrop Math::BigInt optdep: no fixes concerning us were made since
Peter Rabbitson [Tue, 6 Sep 2011 08:06:12 +0000]
Drop Math::BigInt optdep: no fixes concerning us were made since

12 years agoSilence freetds/ODBC test warnings
Rafael Kitover [Thu, 24 Nov 2011 18:31:22 +0000]
Silence freetds/ODBC test warnings

The freetds+dynamic cursors TODO tests are throwing a warning for undef
in ->find, set the DBIC_NULLABLE_KEY_NOWARN env var to silence them.
This is not a solution of course, but we will deal with it when we
resolve the underlying issues with freetds and dynamic cursors.

12 years agoStart caching the result of various bind_attribute_by_data_type invocations
Peter Rabbitson [Thu, 24 Nov 2011 13:49:11 +0000]
Start caching the result of various bind_attribute_by_data_type invocations

Not only is this a speed win - it also avoids multiple querying of DBD
versions, which can lead to a memory leak (because version.pm is silly).

Still go even further and only check the VERSION of a DBD once unless the
DBD got reloaded.

12 years agoFix uninitializied warnings in ::Storage::Sybase::ASE, shuffle logic a bit
Peter Rabbitson [Thu, 24 Nov 2011 13:45:32 +0000]
Fix uninitializied warnings in ::Storage::Sybase::ASE, shuffle logic a bit

12 years agoFix incorrect Test::Builder dep (RT#72282)
Peter Rabbitson [Thu, 24 Nov 2011 11:44:58 +0000]
Fix incorrect Test::Builder dep (RT#72282)

12 years agoUnhide ::SQLMaker::OracleJoins to properly appear on s.c.o.
Peter Rabbitson [Thu, 6 Jan 2011 08:58:55 +0000]
Unhide ::SQLMaker::OracleJoins to properly appear on s.c.o.

12 years agoPass tests with DBICTEST_SQLITE_USE_FILE set
Peter Rabbitson [Tue, 25 Oct 2011 09:08:22 +0000]
Pass tests with DBICTEST_SQLITE_USE_FILE set

12 years agoChanges for 135e8ce
Peter Rabbitson [Mon, 21 Nov 2011 22:34:40 +0000]
Changes for 135e8ce

13 years agoMark ->with_deferred_fk_checks as RDBMS-specific
Dagfinn Ilmari Mannsåker [Wed, 26 Oct 2011 10:56:12 +0000]
Mark ->with_deferred_fk_checks as RDBMS-specific

13 years agoFixxor pause indexing
Peter Rabbitson [Fri, 12 Aug 2011 15:59:39 +0000]
Fixxor pause indexing

13 years agoEnsure t/53lean_startup.t remains lean
Peter Rabbitson [Fri, 12 Aug 2011 15:54:56 +0000]
Ensure t/53lean_startup.t remains lean

13 years agoCleanup compose_namespace(), clarify leaktests wrt classdata
Peter Rabbitson [Fri, 12 Aug 2011 15:22:52 +0000]
Cleanup compose_namespace(), clarify leaktests wrt classdata

13 years agoFix segfault in t/storage/quote_names.t
Peter Rabbitson [Thu, 11 Aug 2011 07:16:25 +0000]
Fix segfault in t/storage/quote_names.t

13 years agoThrow a sensible error when a malformed 'as'-spec is supplied
Peter Rabbitson [Tue, 9 Aug 2011 04:49:06 +0000]
Throw a sensible error when a malformed 'as'-spec is supplied

13 years agoCleanup warnings in t/55namespaces_cleaned, sophisticate require overload
Peter Rabbitson [Tue, 9 Aug 2011 01:24:21 +0000]
Cleanup warnings in t/55namespaces_cleaned, sophisticate require overload

13 years agoRemove the transparrent hook lazy-pager-count experiment
Peter Rabbitson [Sun, 7 Aug 2011 10:41:46 +0000]
Remove the transparrent hook lazy-pager-count experiment

It has proven a very stable and reliable implementation, but in the quest
for fatpacked DBIC should now go to the archives.

13 years agoThis atrocity will be removed from sqla, do not use here either
Peter Rabbitson [Sun, 31 Jul 2011 20:47:23 +0000]
This atrocity will be removed from sqla, do not use here either

13 years agoFix find() pessimization when invoked with bare values
Peter Rabbitson [Tue, 25 Oct 2011 03:50:18 +0000]
Fix find() pessimization when invoked with bare values

13 years agoAdd Changes entry for DBD::SQLite fixes.
Dagfinn Ilmari Mannsåker [Tue, 25 Oct 2011 01:10:32 +0000]
Add Changes entry for DBD::SQLite fixes.

13 years agoRelax expected error message syntax.
Dagfinn Ilmari Mannsåker [Tue, 25 Oct 2011 00:51:02 +0000]
Relax expected error message syntax.

SQLite 1.34 includes more detail in the error, allow any message
starting with "datatype mismatch".

13 years agoDon't rely on GROUP BY and DISTINCT() sorting identically.
Dagfinn Ilmari Mannsåker [Tue, 25 Oct 2011 00:48:44 +0000]
Don't rely on GROUP BY and DISTINCT() sorting identically.

13 years agoRelease 0.08195 v0.08195
Alexander Hartmaier [Wed, 27 Jul 2011 16:23:20 +0000]
Release 0.08195

13 years agoFix oracle (I am so stupid)
Peter Rabbitson [Wed, 27 Jul 2011 15:37:44 +0000]
Fix oracle (I am so stupid)

13 years agoRelease 0.08194 v0.08194
Alexander Hartmaier [Wed, 20 Jul 2011 16:13:47 +0000]
Release 0.08194

13 years agofix link in replication introduction
Uwe [Wed, 20 Jul 2011 13:22:57 +0000]
fix link in replication introduction

13 years agoCheck DBD::Pg >= 2.17.2 with Pg >= 9.0 for BYTEA
Rafael Kitover [Tue, 19 Jul 2011 18:02:49 +0000]
Check DBD::Pg >= 2.17.2 with Pg >= 9.0 for BYTEA

Checks for DBD::Pg < 2.17.2 when using PostgreSQL version 9.0 or greater
when BYTEA column binds are encountered and prints a warning that a
newer version of DBD::Pg is needed for these types of columns to work in
bind_attribute_by_data_type in the Pg storage.

Skips the t/72pg_bytea.t tests for this combination of versions, as well
as for versions of DBD::Pg less than 2.9.2 regardless of Pg version.

13 years agofix popups during tests on Win32 (hopefully)
Rafael Kitover [Tue, 19 Jul 2011 17:01:20 +0000]
fix popups during tests on Win32 (hopefully)

A tester reports that t/73oracle_hq.t causes an error popup on Win32.
This test was checking for DBD::Oracle (and thereby trying to load it)
before checking for the DBICTEST_ORA_DSN environment variables.

This commit moves the check for necessary environment variables for the
t/73oracle.t and t/73oracle_hq.t test files to before the module
requirements tests, thereby not trying to load DBD::Oracle, and causing
an error popup.

13 years agofix a couple test failures on Win32
Rafael Kitover [Tue, 19 Jul 2011 14:13:37 +0000]
fix a couple test failures on Win32

Adds a skip_all to t/storage/global_destruction.t due to it causing a
segfault triggered by some sort of perl bug.

Adds a \Q...\E to t/94versioning.t in a warning regex as well as
changing a `perl -pi -e` to `perl -pi.bak -e` and removing an extraneous
semicolon for the test to pass.

13 years agoOracle: fix LOB conversions for non-LOBs (RT#69548)
Rafael Kitover [Mon, 18 Jul 2011 16:28:48 +0000]
Oracle: fix LOB conversions for non-LOBs (RT#69548)

Recalculates the LOB binds index for UPDATE queries, as it was
erroneosly not recalculated before. This resulted in non-LOB columns
being treated as LOBs by the SQL mangling code.

ribasushi also optimizes the code for the predominant case of queries
without LOBs in the WHERE clause.

13 years agoFix last test susceptible to spurious warnings, cleanup a bit
Peter Rabbitson [Sun, 17 Jul 2011 19:08:49 +0000]
Fix last test susceptible to spurious warnings, cleanup a bit

13 years agoReshuffle Makefile.PL a bit and add parallel-testing exception
Peter Rabbitson [Sun, 17 Jul 2011 17:43:06 +0000]
Reshuffle Makefile.PL a bit and add parallel-testing exception

13 years agoStop Data::Compare from loading plugins at will
Peter Rabbitson [Sun, 17 Jul 2011 16:58:02 +0000]
Stop Data::Compare from loading plugins at will

13 years agoMoar gitignore
Peter Rabbitson [Fri, 15 Jul 2011 16:30:36 +0000]
Moar gitignore

13 years agoRip out forgotten dep
Peter Rabbitson [Fri, 15 Jul 2011 16:30:20 +0000]
Rip out forgotten dep

13 years agoReally fix t/53lean_startup.t
Peter Rabbitson [Fri, 15 Jul 2011 15:50:02 +0000]
Really fix t/53lean_startup.t

13 years agofix $rs->populate([]) to be a no-op rather than an exception
Matt S Trout [Fri, 15 Jul 2011 10:49:30 +0000]
fix $rs->populate([]) to be a no-op rather than an exception

13 years agoFix spurious test failures caused by use of Data::Compare
Arthur Axel 'fREW' Schmidt [Thu, 14 Jul 2011 21:56:13 +0000]
Fix spurious test failures caused by use of Data::Compare

13 years agofix spurious PAUSE message
Arthur Axel 'fREW' Schmidt [Thu, 14 Jul 2011 17:33:11 +0000]
fix spurious PAUSE message

13 years agoRelease 0.08193 v0.08193
Alexander Hartmaier [Thu, 14 Jul 2011 17:02:30 +0000]
Release 0.08193

13 years agoreplaced Test::Deep::NoTest with Data::Compare to not break Test::Deep tests
Alexander Hartmaier [Thu, 14 Jul 2011 13:54:54 +0000]
replaced Test::Deep::NoTest with Data::Compare to not break Test::Deep tests

13 years agoStop leaking cursors on oracle sequence retrieval
Peter Rabbitson [Wed, 13 Jul 2011 07:58:49 +0000]
Stop leaking cursors on oracle sequence retrieval

13 years agoSQLMaker is a proper C3-enabled class, do not use SUPER::
Peter Rabbitson [Thu, 23 Jun 2011 09:04:58 +0000]
SQLMaker is a proper C3-enabled class, do not use SUPER::

13 years agofixed failing test when DBIC_TRACE_PROFILE is set
Alexander Hartmaier [Wed, 6 Jul 2011 16:18:07 +0000]
fixed failing test when DBIC_TRACE_PROFILE is set

13 years agocheck database driver dependencies for tests
Rafael Kitover [Sun, 3 Jul 2011 17:03:19 +0000]
check database driver dependencies for tests

13 years agoOpen the logfile in append mode
Peter Rabbitson [Fri, 17 Jun 2011 01:49:37 +0000]
Open the logfile in append mode

13 years agoFix t/55namespaces_cleaned (RT#68814)
Peter Rabbitson [Fri, 17 Jun 2011 00:28:22 +0000]
Fix t/55namespaces_cleaned (RT#68814)

13 years agoHow ::Rekey was tested against the DBIC test suite
Peter Rabbitson [Thu, 16 Jun 2011 08:27:59 +0000]
How ::Rekey was tested against the DBIC test suite

13 years agoYet another SQL munging atrocity (shadow needs it)
Peter Rabbitson [Thu, 16 Jun 2011 08:26:59 +0000]
Yet another SQL munging atrocity (shadow needs it)

13 years agoFix all invocations of _resolve_condition to match the new signature
Peter Rabbitson [Thu, 16 Jun 2011 08:22:27 +0000]
Fix all invocations of _resolve_condition to match the new signature

13 years agoDo not consider non-sequence oracle triggers during seq detection
Peter Rabbitson [Wed, 15 Jun 2011 07:21:59 +0000]
Do not consider non-sequence oracle triggers during seq detection

13 years agofix bigint handling in sqlite
Arthur Axel 'fREW' Schmidt [Sun, 12 Jun 2011 03:07:58 +0000]
fix bigint handling in sqlite

13 years agoCorrect test-relationship name/type
Peter Rabbitson [Fri, 10 Jun 2011 22:41:46 +0000]
Correct test-relationship name/type

13 years agoMore robust insert() logic to avoid undef warnings
Peter Rabbitson [Thu, 9 Jun 2011 09:32:43 +0000]
More robust insert() logic to avoid undef warnings

13 years agoMake Ordered play nice with other things hooking update()
Peter Rabbitson [Wed, 8 Jun 2011 11:34:02 +0000]
Make Ordered play nice with other things hooking update()

13 years agoexplicit int cast, prevents the result rounding up to 1000 (4 digits)
David Schmidt [Fri, 17 Jun 2011 14:19:26 +0000]
explicit int cast, prevents the result rounding up to 1000 (4 digits)

13 years agodon't mask missing deps with datetime_undef_if_invalid
Rafael Kitover [Sat, 11 Jun 2011 16:50:50 +0000]
don't mask missing deps with datetime_undef_if_invalid

13 years agoFixed a typo in the POD
moltar [Wed, 8 Jun 2011 17:04:19 +0000]
Fixed a typo in the POD

13 years agodon't add Sys::SigAction to author deps on Win32
Rafael Kitover [Wed, 8 Jun 2011 15:04:24 +0000]
don't add Sys::SigAction to author deps on Win32

13 years agoMake Access inner joins 'INNER JOIN' to avoid JOIN syntax errors
Rafael Kitover [Wed, 8 Jun 2011 12:38:20 +0000]
Make Access inner joins 'INNER JOIN' to avoid JOIN syntax errors

13 years agofixed order of rows difference between first and subsequent pages for Oracle
Alexander Hartmaier [Mon, 6 Jun 2011 15:10:52 +0000]
fixed order of rows difference between first and subsequent pages for Oracle

13 years agoFix stupid oversight in update_all
Peter Rabbitson [Tue, 7 Jun 2011 08:04:13 +0000]
Fix stupid oversight in update_all

13 years agoAugment shorsighted code change in 5ef76b8b
Peter Rabbitson [Tue, 7 Jun 2011 07:58:05 +0000]
Augment shorsighted code change in 5ef76b8b

The way _column_data_in_storage was unconditionally referenced, would
break both id() and ident_values(), which are supposed to construct
the identity based on current object state

13 years agoThe test is designed to work with blob-updates only, remove plain values
Rafael Kitover [Wed, 25 May 2011 22:01:20 +0000]
The test is designed to work with blob-updates only, remove plain values

13 years agoRewrite handling of "storage-side old values" both for PK/ident and for
Peter Rabbitson [Sun, 5 Jun 2011 05:29:42 +0000]
Rewrite handling of "storage-side old values" both for PK/ident and for
Ordered position/grouping

Massive code simplification, also opens the door to vastly simplifying
(and optimizing) DBIx::Class::Helper::Row::StorageValues, as only
differing values are kept by the core

13 years agoMinor cleanup of ResultSource attributes
Peter Rabbitson [Sat, 4 Jun 2011 21:57:47 +0000]
Minor cleanup of ResultSource attributes

13 years agofix doubling of find_related condition
Peter Rabbitson [Fri, 3 Jun 2011 17:00:51 +0000]
fix doubling of find_related condition

13 years agoFix newlines in skip messages
Rafael Kitover [Fri, 3 Jun 2011 17:00:51 +0000]
Fix newlines in skip messages

13 years agoExtra cleanup of leftovers from 70171cd7
Peter Rabbitson [Sat, 4 Jun 2011 07:39:59 +0000]
Extra cleanup of leftovers from 70171cd7

Also some commentary

13 years agoAdded tests for chained sqlt_deploy_hook()'s
Pedro Melo [Tue, 24 May 2011 14:52:33 +0000]
Added tests for chained sqlt_deploy_hook()'s

We need to declare the sqlt_deploy_hook sub's in the code to make sure the
next::method knows they exist.

Signed-off-by: Pedro Melo <melo@simplicidade.org>

13 years agoRevert "Fix incorrect default sqlt_deploy_hook signature" (fed15b916)
Pedro Melo [Tue, 24 May 2011 14:18:34 +0000]
Revert "Fix incorrect default sqlt_deploy_hook signature" (fed15b916)

With this change, code that uses next::can or next::method inside
sql_deploy_hook(), like components, stops working.

Also fix documentation to match the actual code

13 years agoAllow changing attributes on schema cloning
Florian Ragwitz [Mon, 9 May 2011 16:20:57 +0000]
Allow changing attributes on schema cloning