11 years agoDESCRIPTION typo fix
David Steinbrunner [Fri, 29 Mar 2013 14:52:01 +0000]
DESCRIPTION typo fix

11 years agoFix test warnings left in by 11343b34
Peter Rabbitson [Mon, 25 Mar 2013 10:21:20 +0000]
Fix test warnings left in by 11343b34

11 years agoimprove outline by introducing synopsis subheadings
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 [Sun, 24 Mar 2013 11:24:57 +0000]
improve outline by introducing synopsis subheadings

11 years agoimprove mark-up
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 [Sun, 24 Mar 2013 11:23:24 +0000]
improve mark-up

11 years agodevelopment info is less important than user info
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 [Sun, 24 Mar 2013 11:05:11 +0000]
development info is less important than user info

11 years agoAdd daxim to contribs, specify main doc encoding
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 [Sun, 24 Mar 2013 11:31:58 +0000]
Add daxim to contribs, specify main doc encoding

11 years ago9 years of perl and I somehow did not know that...
Peter Rabbitson [Sun, 24 Mar 2013 07:28:53 +0000]
9 years of perl and I somehow did not know that...

11 years agoFix copypasta - strictures test needs no global lock
Peter Rabbitson [Sat, 23 Mar 2013 12:42:44 +0000]
Fix copypasta - strictures test needs no global lock

11 years agoOnly display output of failed workers in parallel_installdeps_notest
Peter Rabbitson [Thu, 21 Mar 2013 08:23:41 +0000]
Only display output of failed workers in parallel_installdeps_notest

11 years agoFile::Path needs to be upgraded separately on smoking
Peter Rabbitson [Wed, 20 Mar 2013 11:09:51 +0000]
File::Path needs to be upgraded separately on smoking

11 years agoAdd deprecation warnings for cols/include_columns
Darius Jokilehto [Tue, 19 Mar 2013 12:18:09 +0000]
Add deprecation warnings for cols/include_columns

* Also update docs and include test

11 years agoFix test failing with some tracing envvars (and smoke on travis too)
Peter Rabbitson [Tue, 19 Mar 2013 08:02:05 +0000]
Fix test failing with some tracing envvars (and smoke on travis too)

11 years agoAbraxxa-proof the distbuild (disallow `make manifest dist`)
Peter Rabbitson [Sun, 10 Mar 2013 10:21:30 +0000]
Abraxxa-proof the distbuild (disallow `make manifest dist`)

This does not work under dmake (there is no $(MAKECMDGOALS)), but it does
not seem to have adverse effects either

11 years agoExclude DBICTest namespace from stacktraces
Peter Rabbitson [Sun, 10 Mar 2013 10:05:06 +0000]
Exclude DBICTest namespace from stacktraces

11 years agoAugment 1b6cbedd (reverting my moronic use of preamble in EU::MM)
Peter Rabbitson [Fri, 8 Mar 2013 17:00:57 +0000]
Augment 1b6cbedd (reverting my moronic use of preamble in EU::MM)

Instead of whacking things during the MY::distdir override, properly
override MY::postamble for upload prereq check injection

11 years agomove the location of the extra upload checks so it isn't the default target
Graham Knop [Fri, 8 Mar 2013 16:56:39 +0000]
move the location of the extra upload checks so it isn't the default target

This should result in equivalent behavior since it is still before the
main upload rule.

11 years agoMore comprehensive test of qualifier stripping for update/delete
Peter Rabbitson [Fri, 8 Mar 2013 10:06:33 +0000]
More comprehensive test of qualifier stripping for update/delete

11 years agoChange the rt link from one requiring a login to a publicly accessible one
Christian Walde [Tue, 5 Mar 2013 16:24:28 +0000]
Change the rt link from one requiring a login to a publicly accessible one

Also switch to https:// whatever can be reasonably switched

11 years agoReorganize and freshen up the DocMap
Peter Rabbitson [Tue, 5 Mar 2013 05:22:24 +0000]
Reorganize and freshen up the DocMap

It accumulated lots of stuff that is confusing / not relevant for beginners

11 years agoMove DocMap link to top of DBIx::Class to prevent it being missed
Christian Walde [Mon, 4 Mar 2013 13:28:33 +0000]
Move DocMap link to top of DBIx::Class to prevent it being missed

Reorganize the section to be a bit more comprehensive

11 years agoRemove outdated (and kinda offensive) CONTRIBUTING text
Peter Rabbitson [Tue, 5 Mar 2013 03:47:07 +0000]
Remove outdated (and kinda offensive) CONTRIBUTING text

A replacement should come shortly, courtesy of Getty

11 years agoAnd more fulltest dep conflicts
Peter Rabbitson [Tue, 5 Mar 2013 05:52:21 +0000]
And more fulltest dep conflicts

11 years agoClarify wtf do we have a _bool
Peter Rabbitson [Tue, 5 Mar 2013 03:25:11 +0000]
Clarify wtf do we have a _bool

11 years agoRequire latest EU::MM at dist-building time to avoid $-escaping issues
Christian Walde [Fri, 1 Mar 2013 17:08:19 +0000]
Require latest EU::MM at dist-building time to avoid $-escaping issues

11 years agoDo not auto-install dist-building dependencies in author mode
Peter Rabbitson [Sat, 2 Mar 2013 06:16:46 +0000]
Do not auto-install dist-building dependencies in author mode

Instead only require them for actual make dist/distdir/upload runs

11 years agoSmoke all branches on travis except for blocked* and wip/*
Peter Rabbitson [Fri, 1 Mar 2013 16:02:03 +0000]
Smoke all branches on travis except for blocked* and wip/*

11 years agoAnother adjustment of travis depinstall order
Peter Rabbitson [Fri, 1 Mar 2013 15:41:20 +0000]
Another adjustment of travis depinstall order

11 years agoPunt TODO until the dateops work merges
Peter Rabbitson [Fri, 1 Mar 2013 09:05:38 +0000]
Punt TODO until the dateops work merges

11 years agoThis infrastructure was removed ages ago by 263e41be
Peter Rabbitson [Fri, 1 Mar 2013 08:46:54 +0000]
This infrastructure was removed ages ago by 263e41be

11 years agoRemove TODO that could never be made to work (revert c49fcf72)
Peter Rabbitson [Fri, 1 Mar 2013 08:42:15 +0000]
Remove TODO that could never be made to work (revert c49fcf72)

I do not know what groditi was thinking - the behavior codified makes 0 sense

11 years agoRelease v0.08209 v0.08209
Alexander Hartmaier [Fri, 1 Mar 2013 13:09:42 +0000]
Release v0.08209

11 years agoFulltests deps clarification
Peter Rabbitson [Thu, 28 Feb 2013 14:46:48 +0000]
Fulltests deps clarification

- CDBI::Plugin::DeepAbstractSearch already depends on CDBI
- Install DateTime earlier in the CLEANTEST=false cycle

11 years agoGuard against exceptions in _describe_connection
Peter Rabbitson [Thu, 28 Feb 2013 09:02:56 +0000]
Guard against exceptions in _describe_connection

Stuff like this happens otherwise:
http://lists.scsys.co.uk/pipermail/dbix-class/2013-January/011085.html

11 years agoWhitespace-check the travis scripts as well
Peter Rabbitson [Wed, 27 Feb 2013 12:32:00 +0000]
Whitespace-check the travis scripts as well

11 years agoShuffle travis CLEANTEST=false depchain again
Peter Rabbitson [Wed, 27 Feb 2013 10:33:13 +0000]
Shuffle travis CLEANTEST=false depchain again

11 years agoTest::Strict is smarter now
Peter Rabbitson [Wed, 27 Feb 2013 10:27:50 +0000]
Test::Strict is smarter now

11 years agoRegex /o is *EVIL* - no idea why I even thought of using that
Peter Rabbitson [Mon, 18 Feb 2013 07:37:54 +0000]
Regex /o is *EVIL* - no idea why I even thought of using that

11 years agoWarn on signs of Moose-borkage (in case it gets to be the first new())
Peter Rabbitson [Tue, 26 Feb 2013 08:08:44 +0000]
Warn on signs of Moose-borkage (in case it gets to be the first new())

11 years agoAdjust CLEANTEST=false depinstall a bit more
Peter Rabbitson [Sat, 23 Feb 2013 15:16:45 +0000]
Adjust CLEANTEST=false depinstall a bit more

11 years agoFix cookbook - missing cond in 'Equivalent SQL'
David Schmidt [Wed, 20 Feb 2013 13:46:08 +0000]
Fix cookbook - missing cond in 'Equivalent SQL'

11 years agoInstrument the lockfile creation failure
Peter Rabbitson [Sat, 23 Feb 2013 14:52:50 +0000]
Instrument the lockfile creation failure

Attempting to get to the bottom of http://www.cpantesters.org/cpan/report/27f16417-89ea-1014-a33e-b361b1e9163f

11 years agoFix regression breaking search on prefetched rel (broken by 5e2a0518)
Peter Rabbitson [Sat, 23 Feb 2013 14:17:47 +0000]
Fix regression breaking search on prefetched rel (broken by 5e2a0518)

Boy 0.08205 was a bad release, so much crap went in undetected by
any of our tests :( Maybe it's time for Devel::Cover...?

11 years agoUncomment disabled test (not sure why it was)
Peter Rabbitson [Sat, 23 Feb 2013 14:13:32 +0000]
Uncomment disabled test (not sure why it was)

11 years agoRelease v0.08208 v0.08208
Peter Rabbitson [Wed, 20 Feb 2013 09:58:31 +0000]
Release v0.08208

11 years agoAdd optdep on CPAN::Uploader to get an effortless `make upload`
Peter Rabbitson [Wed, 20 Feb 2013 09:57:03 +0000]
Add optdep on CPAN::Uploader to get an effortless `make upload`

11 years agoEven more distbuilding checks
Peter Rabbitson [Wed, 20 Feb 2013 09:35:00 +0000]
Even more distbuilding checks

Frew's environment (and *only* his environment) keeps producing weirdly
broken dists. Add an extra check for this until we figure out how exactly
his environment is broken.

Extra check tested on cygwin and strawberry for good measure.

11 years agoNew Test::Strict no longer detects Moose::Role (RT#83433) - workaround
Peter Rabbitson [Mon, 18 Feb 2013 20:22:26 +0000]
New Test::Strict no longer detects Moose::Role (RT#83433) - workaround

11 years agoPrevent SQL::Translator::Producer::YAML from seeing our potential $dbh
Peter Rabbitson [Sat, 16 Feb 2013 15:27:23 +0000]
Prevent SQL::Translator::Producer::YAML from seeing our potential $dbh

The failure mode here is extremely convoluted, full of unimaginable fail
and makes baby jesus cry :(

The long story: there are two ways to supply a $schema to the SQLT producer:
via an argument to translate() (sane) or at the time of translator instance
creation (less sane). In the second case this becomes a problem because some
serializing producers (e.g. SQLT::Producer::YAML) take the *entire*
SQLT instance and dump it to YAML. This includes the arguments which include
our schema with its storage and potentially its $dbh. This causes the
weird warnings described in e.g. RT#75394, because YAML creates a dead
DBI object upon de-serialization of said arguments. What's even more sad is
that while the YAML Producer dumps the entire SQLT instance, the YAML Parser
simply takes the ->{schema} part of this structure and throws everything
else away.

Of course we can not just fix the ::Producer - folks may very well be relying
on the structure it spits out (nobody knows if the *only* consumer of the
Producer::YAML output is in fact Parser::YAML). Really the only thing we can
know (well not know, but reasonably assume) is that there is no way that any
user relies on the accessing the storage passed in with a schema instance to
be parsed.

So what we do is the least invasive thing of all - at translate() time we
check the state of the passed in $schema and if it does have a storage
instance we simply detach it (by cloning the $schema instance) and as a
result everything remains happy.

11 years agoDeprecate the insane forest of SQLT::Parser::DBIC arguments
Peter Rabbitson [Sat, 16 Feb 2013 15:12:50 +0000]
Deprecate the insane forest of SQLT::Parser::DBIC arguments

It seems like things have been just piled up with no plan nor reason. Bring in
the broom - converge on an argument name that actuall makes sense - dbic_schema

11 years agoReadjust the parallel no-test dependency install order
Peter Rabbitson [Sat, 16 Feb 2013 16:44:54 +0000]
Readjust the parallel no-test dependency install order

Better utilize the massive amount of CPUs we have available

11 years agoIt appears that travis drastically increased the amount of available CPUs
Peter Rabbitson [Sat, 16 Feb 2013 16:05:12 +0000]
It appears that travis drastically increased the amount of available CPUs

Well, this is awesome - we just happen to be equipped to take advantage
of this ;)

Remove the branch-name limitations - now a smoke takes fraction of the time
it used to, no point to limit what we smoke anymore.

At the same time reduce the amount of threads building the perls - older
binaries do not build very well on -j32. This is a temporary thing - the
perl-building will soon be exported away anyway.

11 years agoMore (temporary) kwalitee fixups
Peter Rabbitson [Fri, 15 Feb 2013 08:48:50 +0000]
More (temporary) kwalitee fixups

11 years agoMoar kwalitee - we do have pod(coverage) tests
Peter Rabbitson [Thu, 14 Feb 2013 04:41:20 +0000]
Moar kwalitee - we do have pod(coverage) tests

11 years agoAdd strict/warnings test, adjust all offenders (wow, that was a lot)
Peter Rabbitson [Wed, 13 Feb 2013 22:20:29 +0000]
Add strict/warnings test, adjust all offenders (wow, that was a lot)

Should shut kwalitee up: http://cpants.cpanauthors.org/dist/DBIx-Class

11 years agoStop shipping world writeable files in our tarball
Peter Rabbitson [Wed, 13 Feb 2013 18:39:57 +0000]
Stop shipping world writeable files in our tarball

The chain of failures would go as follows: when we prepare the tarball
we briefly copy all generated POD to our root dir so that the
manifest/distdir_copy process can pick it up. Then before the distdir is
ready we run a cleanup using ExtUtils::Install::uninstall. However
everything in the ditdir is hardlinked to our root dir, including the
files we "uninstall". EU::I::uninstall has a weird dance deep in its
source[1] where it explicitly does chmod(0666) on the file it is about
to delete (why?!). Thus we end up with world-writables in our distdir,
since the hardlinked inode still retains the result of that last chmod.

Switch to a manual cleanup, and leave EU::I alone.

[1] https://metacpan.org/source/YVES/ExtUtils-Install-1.54/lib/ExtUtils/Install.pm#L274

11 years agoFix duplicated columns for count()
André Walker [Wed, 13 Feb 2013 15:47:17 +0000]
Fix duplicated columns for count()

When a same aggregate function was used more than once in a 'having'
clause, count() added that function more than once to 'select'.

11 years agorelease v0.08206 v0.08206
Alexander Hartmaier [Mon, 11 Feb 2013 17:59:09 +0000]
release v0.08206

11 years agoTry Schwern's latest Test::Builder offering on a stock perl and a threaded blead
Peter Rabbitson [Thu, 7 Feb 2013 05:21:22 +0000]
Try Schwern's latest Test::Builder offering on a stock perl and a threaded blead

11 years agoReorganize travis stuff a little - no functional changes
Peter Rabbitson [Thu, 7 Feb 2013 05:10:43 +0000]
Reorganize travis stuff a little - no functional changes

11 years agoTry to config Fibrebird twice - it does seem to help >.<
Peter Rabbitson [Thu, 7 Feb 2013 04:06:24 +0000]
Try to config Fibrebird twice - it does seem to help >.<

Read changeset under -w

11 years agoTemporary workaround for Path::Class not being installable (RT#83143)
Peter Rabbitson [Thu, 7 Feb 2013 04:04:37 +0000]
Temporary workaround for Path::Class not being installable (RT#83143)

11 years agoChangelogging for 728f32b5 and e705f529
Peter Rabbitson [Fri, 1 Feb 2013 06:55:04 +0000]
Changelogging for 728f32b5 and e705f529

11 years agoRevert parts of 6864429a which utterly broke dbh_do() retries
Peter Rabbitson [Fri, 1 Feb 2013 06:50:15 +0000]
Revert parts of 6864429a which utterly broke dbh_do() retries

Was never noticed because of undertesting, now should behave correctly

11 years agoClarify travis timings
Peter Rabbitson [Fri, 1 Feb 2013 04:34:01 +0000]
Clarify travis timings

11 years agoNew travis build infrastructure is 'set -e' sensitive
Peter Rabbitson [Fri, 1 Feb 2013 04:28:03 +0000]
New travis build infrastructure is 'set -e' sensitive

11 years agoPrevent spurious unclean git repo state on ddl regeneration
Peter Rabbitson [Tue, 29 Jan 2013 21:52:45 +0000]
Prevent spurious unclean git repo state on ddl regeneration

11 years agoExtra sanity check of a fresh DBI handle
Peter Rabbitson [Tue, 29 Jan 2013 10:57:49 +0000]
Extra sanity check of a fresh DBI handle

11 years agoMake `perl Makefile.PL` runs more user friendly - better diagnostics
Peter Rabbitson [Fri, 25 Jan 2013 13:14:31 +0000]
Make `perl Makefile.PL` runs more user friendly - better diagnostics

11 years agoStop `perl Makefile.PL` from recursing into distdirs if present
Peter Rabbitson [Fri, 25 Jan 2013 12:25:52 +0000]
Stop `perl Makefile.PL` from recursing into distdirs if present

11 years agoMore .mailmap fixes
Peter Rabbitson [Thu, 20 Dec 2012 15:11:09 +0000]
More .mailmap fixes

11 years agoGeneral cleanup of error messages - quote identifiers/names where sensible
Peter Rabbitson [Thu, 1 Sep 2011 10:13:36 +0000]
General cleanup of error messages - quote identifiers/names where sensible

No functional changes

11 years agoRemove TODO labels from blocks not using todo_skip() - no test changes
Peter Rabbitson [Wed, 26 Dec 2012 10:31:00 +0000]
Remove TODO labels from blocks not using todo_skip() - no test changes

11 years agoRevert 344f761c - this was a stupid idea
Peter Rabbitson [Fri, 25 Jan 2013 02:26:06 +0000]
Revert 344f761c - this was a stupid idea

Way too many failures, maked CPANTesters output unusable.
Extracted and submitted as DBI RT#82942 instead

11 years ago::Storage::BlockRunner now has minimum POD, tell CPAN to noindex
Peter Rabbitson [Wed, 23 Jan 2013 12:31:50 +0000]
::Storage::BlockRunner now has minimum POD, tell CPAN to noindex

It is not ready for prime time yet

11 years agoOnly allow known globals in SQL::Translator leak allowance
Dagfinn Ilmari Mannsåker [Wed, 23 Jan 2013 12:07:33 +0000]
Only allow known globals in SQL::Translator leak allowance

11 years agorelease v0.08205 v0.08205
Arthur Axel 'fREW' Schmidt [Wed, 23 Jan 2013 01:02:54 +0000]
release v0.08205

11 years agoEnsure xt/whitespace.t executes standalone
Peter Rabbitson [Tue, 22 Jan 2013 21:04:23 +0000]
Ensure xt/whitespace.t executes standalone

This way it will not pick up anything temporary a test may have left
around, and won't complain about the whitespace contents.

11 years agoClarifying that the "around" method modifier can come from Moose
Jason McIntosh [Tue, 22 Jan 2013 03:17:47 +0000]
Clarifying that the "around" method modifier can come from Moose

Also adding a trailing semicolon to the "around" example. This way, it
better agrees with the information in Manual::FAQ.

11 years agoDo not tax travis with full pull request smoking
Peter Rabbitson [Tue, 22 Jan 2013 01:35:06 +0000]
Do not tax travis with full pull request smoking

11 years agoSome cleanups around loading/use of DBIx::Class::Exception (no func. changes)
Peter Rabbitson [Sun, 20 Jan 2013 18:23:48 +0000]
Some cleanups around loading/use of DBIx::Class::Exception (no func. changes)

11 years agoRevert workarounds for $@ broken during 5.13.x - mainly 1f870d5a
Peter Rabbitson [Sun, 20 Jan 2013 18:09:46 +0000]
Revert workarounds for $@ broken during 5.13.x - mainly 1f870d5a

Luckily reason prevailed and $@ was left alone during DESTROY time,
the complexity (mnost of it compiled away) is no longer needed

More historic info can be found here: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits/DBIx-Class-Historic.git;a=blob_plain;f=useful_guard_objects.html;h=4678884

11 years agoFurther reshuffle logic in _rs_update_delete - no functional changes
Peter Rabbitson [Fri, 11 Jan 2013 17:58:42 +0000]
Further reshuffle logic in _rs_update_delete - no functional changes

review with -w, lots of reindentation

11 years agoFix self-referential resultset update/delete on MySQL (aggravated by 31073ac7)
Peter Rabbitson [Wed, 21 Nov 2012 11:38:43 +0000]
Fix self-referential resultset update/delete on MySQL (aggravated by 31073ac7)

MySQL is unable to figure out it needs a temp-table when it is trying
to update a table with a condition it derived from that table. So what
we do here is give it a helpful nudge by rewriting any "offending"
subquery to a double subquery post-sql-generation.

Performance seems to be about the same for moderately large sets. If it
becomes a problem later we can always revisit and add the ability to
induce "row-by-row" update/deletion instead.

The implementation sucks, but is rather concise and most importantly
contained to the MySQL codepath only - it does not affect the rest of
the code flow in any way.

11 years agoFix proper handling of composite resultset heads (e.g. as_subselect_rs)
Peter Rabbitson [Mon, 19 Nov 2012 09:11:11 +0000]
Fix proper handling of composite resultset heads (e.g. as_subselect_rs)

Solves http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010650.html

11 years agoMove the *preliminary* multicol IN support to the sqlmaker
Peter Rabbitson [Fri, 11 Jan 2013 18:00:20 +0000]
Move the *preliminary* multicol IN support to the sqlmaker

It really does not belong in ResultSet.pm, but we do not have an API
either. Take a first stab at a sketch, DQ will need to wrangle it to
completion.

11 years agoFlip quoting in all of t/71mysql.t (no test changes)
Peter Rabbitson [Thu, 10 Jan 2013 21:35:51 +0000]
Flip quoting in all of t/71mysql.t (no test changes)

11 years agoSimplify dbh_do invocation, and only alias @_ when needed
Peter Rabbitson [Mon, 7 Jan 2013 18:45:05 +0000]
Simplify dbh_do invocation, and only alias @_ when needed

11 years agoScope::Upper somehow confuses pseudofork on older perls - investigation pending
Peter Rabbitson [Mon, 7 Jan 2013 18:43:40 +0000]
Scope::Upper somehow confuses pseudofork on older perls - investigation pending

View the patch with -w, lots of reindentation

11 years agoReign in (a little bit) the sprawling CRLF insanity on Win32
Peter Rabbitson [Sat, 12 Jan 2013 17:35:36 +0000]
Reign in (a little bit) the sprawling CRLF insanity on Win32

In the process join the notabs/eol tests into one file, and tighten
the WS checks even more

11 years agoEnsure the testddl is regenerated at Makefile and distdir times
Peter Rabbitson [Thu, 10 Jan 2013 18:32:19 +0000]
Ensure the testddl is regenerated at Makefile and distdir times

This will stop things constantly getting out of sync

11 years agoRegenerate SQLite testschema ddl with explicit quoting and generate FKs
Peter Rabbitson [Thu, 10 Jan 2013 18:08:31 +0000]
Regenerate SQLite testschema ddl with explicit quoting and generate FKs

We *do not* yet turn on FK checking in sqlite - many tests will need tweaking

11 years agoSQLT got a lot better lately - bump min version
Peter Rabbitson [Thu, 10 Jan 2013 17:15:52 +0000]
SQLT got a lot better lately - bump min version

Remove a large number of workarounds in the process

11 years agoRemove SQLA namespace pollution fixer - this is no longer the case since 1.73
Peter Rabbitson [Mon, 7 Jan 2013 21:50:23 +0000]
Remove SQLA namespace pollution fixer - this is no longer the case since 1.73

11 years agodeployment_statements() is not storage-dependent - only sqlt_type() is
Peter Rabbitson [Thu, 10 Jan 2013 14:03:05 +0000]
deployment_statements() is not storage-dependent - only sqlt_type() is

This fixes maint/gen_schema erroring out after 75d3bdb243

11 years agoReduce amount of calls to $rsrc->columns_info where possible
Peter Rabbitson [Mon, 7 Jan 2013 13:14:34 +0000]
Reduce amount of calls to $rsrc->columns_info where possible

11 years ago_resolve_bindattrs already expects colinfo - just pass it in where we forgot
Peter Rabbitson [Mon, 7 Jan 2013 13:09:29 +0000]
_resolve_bindattrs already expects colinfo - just pass it in where we forgot

11 years agoFix some pessimizations spotted here and there (no functional changes)
Peter Rabbitson [Thu, 13 Dec 2012 06:40:13 +0000]
Fix some pessimizations spotted here and there (no functional changes)

Mainly remove a number of unused @_ unpackings, and remove the hideous
_resolved_attrs_copy pessimizer

11 years agoRemove apparent pessimization introduced in 6a588797
Peter Rabbitson [Thu, 10 Jan 2013 13:13:21 +0000]
Remove apparent pessimization introduced in 6a588797

There is no conceivable reason why the attrs need to be recalculated on cursor
reset. All tests seem to pass as well. Removing it as the calculation is quite
expensive - if problems arise bisection will hopefully lead us here

11 years agoOptimize populate(), especially bind handling in complex populate cases
Peter Rabbitson [Sun, 23 Dec 2012 11:45:16 +0000]
Optimize populate(), especially bind handling in complex populate cases

Instead of recalculating the data slice positions on every loop, we
do it only once during the "proto bind" generation. This is because
even though all bind values can and will change (even ones supplied
via \[ ... ]), their number will always remain constant.

11 years agoSimplify/cleanup parsing of search() arguments
Peter Rabbitson [Fri, 21 Dec 2012 11:41:54 +0000]
Simplify/cleanup parsing of search() arguments