Karen Etheridge [Wed, 8 Oct 2014 19:42:49 +0000]
cross-reference alias with current_source_alias
Karen Etheridge [Mon, 28 Jul 2014 19:13:30 +0000]
show more ways to include literal bind values
Karen Etheridge [Mon, 28 Jul 2014 19:08:11 +0000]
use standard '' quoting for string literals
Karen Etheridge [Mon, 28 Jul 2014 19:02:23 +0000]
document including literal SQL and values in a resultset with "columns"
Karen Etheridge [Tue, 27 May 2014 23:09:20 +0000]
spelling fix
Dagfinn Ilmari Mannsåker [Mon, 7 Apr 2014 12:29:29 +0000]
Add Changes entry for empty related cache population
With a more user-oriented description than the commit message,
i.e. explaining the symptom fixed, rather than the underlying change.
Dagfinn Ilmari Mannsåker [Fri, 28 Mar 2014 16:48:17 +0000]
Populate caches for related result sets even if they're empty
Peter Rabbitson [Wed, 26 Mar 2014 07:11:43 +0000]
Add progress meter to travis builds
Naveed Massjouni [Tue, 11 Mar 2014 01:43:08 +0000]
fixed example in the DBIx::Class::Storage::DBI::Replicated synopsis
The example in the synopsis does not work. It should be
{ balancer_type => '::Random' } instead of { balancer => '::Random' }
Peter Rabbitson [Tue, 4 Mar 2014 08:39:49 +0000]
Fix pesky on_connect_* race condition abraxxa++ ilmari++
A race condition existed between storage accessor setters and the
determine_driver routines, triggering a connection before the set-cycle
is finished
Olaf Alders [Thu, 13 Feb 2014 21:47:22 +0000]
Fixes Pod typo.
Sean Zellmer [Thu, 20 Feb 2014 21:54:33 +0000]
Removed useless line of code in many_to_many
Alexandr Ciornii [Wed, 5 Mar 2014 20:48:55 +0000]
typos
Peter Rabbitson [Wed, 12 Feb 2014 14:48:42 +0000]
Shuffle prefetch torture test (no func. changes)
Peter Rabbitson [Mon, 10 Feb 2014 12:29:45 +0000]
PATH may be unset entirely
Tested with
~$ bash -c 'perl=$(which perl); unset PATH; $perl t/54taint.t'
Peter Rabbitson [Mon, 10 Feb 2014 08:48:11 +0000]
Fix travis prereq extractor (not sure how this ever worked...)
Peter Rabbitson [Mon, 10 Feb 2014 07:58:39 +0000]
Remove vestigial unused @INC munge found after
a8de639b
Peter Rabbitson [Mon, 10 Feb 2014 07:18:46 +0000]
Harden t/54taint.t against possible future changes in -T
Peter Rabbitson [Sat, 8 Feb 2014 09:48:12 +0000]
Make sure the taint test does some DB-level ops
Graham Knop [Sat, 8 Feb 2014 09:34:52 +0000]
Really fix @INC munging of the taint test
Now runs even with a plain `perl t/54taint.t`
Peter Rabbitson [Fri, 7 Feb 2014 04:39:41 +0000]
Apparently this is more stable historically... boggle
Peter Rabbitson [Tue, 4 Feb 2014 07:25:24 +0000]
Duh, this will always be true
Peter Rabbitson [Fri, 31 Jan 2014 06:11:44 +0000]
Shipping the CI stuff to CPAN makes no sense
Peter Rabbitson [Fri, 31 Jan 2014 05:49:31 +0000]
Release v0.08270
Peter Rabbitson [Fri, 31 Jan 2014 04:29:02 +0000]
RT#87124 fixed, workaround no longer necessary
Peter Rabbitson [Thu, 30 Jan 2014 05:04:05 +0000]
Add Firebird over ODBC TravisCI testing
Peter Rabbitson [Fri, 31 Jan 2014 03:38:14 +0000]
Give Firebird (and Interbase) a common sqlt_type
Even though the parser/producer pair do not yet exist in SQLT, we also use this
value as the basis for the lockfile on parallel tests, hence it is important
Peter Rabbitson [Thu, 30 Jan 2014 12:00:41 +0000]
Fix datetimes in ODBC/Firebird (merge identical code left after
a870aa85e)
Peter Rabbitson [Wed, 29 Jan 2014 10:27:59 +0000]
Rudimentary DBI/DBD MDV
Peter Rabbitson [Wed, 29 Jan 2014 13:43:55 +0000]
Clarify parallel_installdeps design comment
Peter Rabbitson [Wed, 29 Jan 2014 13:25:12 +0000]
The trace formatter seems to register intermittent leaks - skip on 5.18 for now
Peter Rabbitson [Wed, 29 Jan 2014 12:47:08 +0000]
Fix undefined order sensitive test (no idea how it went undetected)
Peter Rabbitson [Wed, 29 Jan 2014 10:39:06 +0000]
Ints bound as DBI::SQL_BIGINT on SQLite < 1.37 do not work in functions
For all the meticulous testing of
04ab4eb1, 1363f0f5 and f3b1224b I
failed to notice that functions no longer work when they encounter
numbers bound as bigint (may as well have not bound them at all).
Happened due to shortsighted testing methodology as described in the
commit msg of
f3b1224b, a rudimentary MDV will be introduced in a later
commit to ensure this doesn't happen anymore.
Fix this by explicitly requirung DBD::SQLite 1.37 for bigint operations.
Examine patch under -w
Peter Rabbitson [Tue, 28 Jan 2014 18:49:22 +0000]
Release v0.08260
Peter Rabbitson [Tue, 28 Jan 2014 18:42:37 +0000]
We still intermittently grab a "leaked" SQLT quoter, skip explicitly
Will figure this out after 0.08260
Peter Rabbitson [Mon, 27 Jan 2014 17:54:30 +0000]
Factor out the symtable walker, no functional changes but much reshuffling
Peter Rabbitson [Sat, 25 Jan 2014 07:06:39 +0000]
One extra cleanup pass before asserting weakregistry is empty
Matt S Trout [Thu, 28 Nov 2013 20:24:40 +0000]
Make 54taint.t actually test the DBIx::Class in lib (originally
689e22d1)
Peter Rabbitson [Mon, 27 Jan 2014 11:50:49 +0000]
Skip annoyingly failing test on broken base.pm
Was broken in 5.19.7, fixed in 5.19.8
Peter Rabbitson [Sat, 25 Jan 2014 05:18:18 +0000]
Yet another attempt to solve the mystery-win32-failure cpantesters report
While
fa19e5d6 was a nice idea, its test was flawed. As seen in the fresh fail
http://www.cpantesters.org/cpan/report/
137dfaf3-7bbc-1014-aec2-3d202b825c07
the writability test passed with flying colors, but the lock didn't open right
after that. The only explanation at this point is that the FS underlying this
particular dir can not create filenames starting with a dot <facepalm />
Alternatively it may have to do with the umask(0) call, but this seems even
more insane.
Thus (as unlikely as it seems) the culprit seems to be the name. Hopefully
changing it will be the end of this and we will smoke happily ever after...
Peter Rabbitson [Sat, 25 Jan 2014 05:06:47 +0000]
Rewrite writiability test to be clearer and with less warnings
Peter Rabbitson [Sat, 25 Jan 2014 09:23:06 +0000]
Skip thread tests under Devel::Cover
Peter Rabbitson [Fri, 24 Jan 2014 07:14:37 +0000]
Counter the strictures bullshit with localised bullshit
Peter Rabbitson [Fri, 24 Jan 2014 05:26:43 +0000]
Augment the logic from
aca094b4d, add deprecation to settle the distinct drama
Details in attached IRC log
magnet#dbic-cabal_
20131108.log
====
[19:01:38] <mst> using aggregates and distinct seems like it should be an error
[19:02:12] <mst> since it makes no sense to ask for "GROUP BY everything we select" and then select aggregates AFAICS
[19:03:20] <mst> so, yes, what we did before was ... wtf
[19:04:44] <ribasushi> mst: the point is *sometimes* a select in a group-by may make sense is my gut feeling, I basically wanted to "send the nonsense" along, and have the rdbms be the judge
[19:05:52] <mst> well ... what we did before was definitely completely wrong
[19:06:09] <mst> what we're doing now ... I don't want to release it without thinking it through some more, but it's certainly less wrong
[19:07:40] <mst> but I mean ... I dunno, I think group_over_selection makes sense for subquery wrapping
[19:08:04] <mst> but in the case of 'distinct => 1' I think "can't do that with an aggregate in select, pass a real group by you fucking pansy" would be pretty good too
[19:08:14] <mst> since I'm really not convinced it ever can make sense
[19:08:27] <ribasushi> mst: and I am not convinced it never makes sense
[19:08:36] <ribasushi> mst: so bubbling it up doesn't seem like a loss
[19:09:09] <mst> hmmm
[19:09:44] <ribasushi> mst: also I do not want to *entirely* discourage mysql/sqlite-centric grouppage - if a person wants to do that, they should be able to
[19:09:56] <ribasushi> hence why the explicit \'' rule
[19:10:03] <ribasushi> (that is back from 2009-ish actually)
[19:10:05] <mst> actually, looking at this
[19:10:23] <mst> the sql looks like what the user asked for
[19:10:38] <ribasushi> how so?
[19:10:59] <ribasushi> distinct is "final selection grouper" not "first selection"
[19:11:00] <mst> well, they created a resultset of
[19:11:04] <ribasushi> i.e. it is inherently lazy
[19:11:29] <ribasushi> right, it does not take effect on the current selection, didn't from before I took over
[19:11:53] <mst> SELECT year, COUNT(me.cdid) AS cnt ....
[19:11:57] <mst> and then grabbed the 'cnt' column
[19:13:06] <mst> ribasushi: ResultSet originally (0.05000) did '$attrs->{group_by} ||= $attrs->{select} if delete $attrs->{distinct};' in new()
[19:13:15] <mst> so, yes, it takes effect on the current selection
[19:13:36] <mst> so sql is correct according to the original behaviour as implemented
[19:13:36] <ribasushi> mst: but it did this in *_resolve_attrs*
[19:13:55] <ribasushi> which is after the selection is modified by RSETColumn
[19:14:15] <ribasushi> or to put it diff. - RSetColumn does not do a subquery, just like a ->search doesn't
[19:14:30] <mst> it didn't originally, it did it immediately you supplied the distinct attribute to a search
[19:14:40] <mst> anything else is a bug; fix that and we don't need this crap
[19:14:52] <ribasushi> well - when I came around it was lazified via the late resolver
[19:15:08] <ribasushi> and I had bugs reported when that behavior changed later on when I was doin prefetches
[19:15:17] <ribasushi> so this is crap in production for years
[19:15:41] <ribasushi> mst: https://github.com/dbsrgits/dbix-class/blob/master/t/search/distinct.t behaviors on non-aggregates
[19:15:55] <ribasushi> it accreted stuff obviously, the ages of tests are different
[19:17:01] <ribasushi> mst: basically this boils to "is distinct => 1 lazy or eager" and I am afraid this ship sailed around 0.07
[19:17:17] <ribasushi> "fixing" it will serve nothing but bring breakage
[19:17:48] <mst> yeah, it looks like it got broken when _resolved_attrs was factored out of new()
[19:17:53] <ribasushi> nod
[19:18:28] <ribasushi> so - if we assume "distinct is lazy" - you see why I would go the way I did with the latest fix
[19:19:22] <mst> ribasushi: distinct is lazy works fine, you just have to disallow aggregates in the select list in that case
[19:19:30] <mst> and make them do an explicit group_by for that
[19:20:31] <ribasushi> mst: aggregates via the {} syntax have been supported correctly forever - that is distinct knows to ignore them
[19:20:45] <ribasushi> mst: this test is more or less "aggregate in literal" (due to being an alias)
[19:20:47] <mst> even as far as 08000 it was straight up
[19:20:51] <ribasushi> so I can't disallow it
[19:20:56] <ribasushi> because it is... a literal
[19:20:59] <mst> $attrs->{group_by} ||= $attrs->{select} if delete $attrs->{distinct};
[19:21:11] <mst> so if we started allowing them via the {} syntax that wasn't me
[19:21:17] <ribasushi> mst: I came around 0.08010 ;)
[19:22:01] <mst> ribasushi: $attrs->{group_by} ||= $attrs->{select} if delete $attrs->{distinct};
[19:22:07] <mst> ribasushi: in 08011 which is the first release you did
[19:22:34] <ribasushi> mst: it is very possibkle that I broke it when I wasn't knowing wtf is on
[19:22:46] <mst> I think you made lazy distinct work "better"
[19:22:51] <mst> when it shouldn't've been lazy
[19:22:59] <ribasushi> mst: in any case - it's old shit, so even if I am responsible it still boils to "people depend on that"
[19:23:13] <ribasushi> mst: nod, may very well be my rookie mistake ;)
[19:23:15] <mst> sure. at this point it's "I fucked it up, then you made it worse, we'll have to deprecate it"
[19:23:19] <mst> most likely
[19:23:34] <mst> and the only question is damage control so we don't break current usages while isolating the code
[19:24:48] <ribasushi> deprecating it - I wouldn't go that far, I use distinct a lot myself because it does the group construction for me without me thinking
[19:25:01] <ribasushi> juggling selection/ordering is hard enough ;)
Peter Rabbitson [Fri, 24 Jan 2014 04:55:24 +0000]
Check that the just-built-distdir is configure-able in usermode
Peter Rabbitson [Fri, 24 Jan 2014 04:44:49 +0000]
Shuffle author-side M::I stuff out of the way
Zero functional changes
Peter Rabbitson [Fri, 24 Jan 2014 04:38:23 +0000]
Logically separate statements mangled in
3054407e9
Peter Rabbitson [Fri, 24 Jan 2014 04:36:29 +0000]
Explicitly declare static config
Peter Rabbitson [Fri, 24 Jan 2014 04:30:48 +0000]
SQLite is not a build_requires dep anymore (trap-the-sigsegv days are gone)
Peter Rabbitson [Fri, 24 Jan 2014 04:27:21 +0000]
Remove silly double-entry from test_requires
Peter Rabbitson [Thu, 23 Jan 2014 15:37:01 +0000]
Adjust todo escape, use travis-provided 5.8 for one of the poisontests
Peter Rabbitson [Thu, 23 Jan 2014 14:52:21 +0000]
Clarify is_exception(undef) behavior missed in
841efcb3
Peter Rabbitson [Thu, 23 Jan 2014 13:34:23 +0000]
Have tests recover gracefully when File::Spec->tmpdir gives us lemons
Once and for all solves http://www.cpantesters.org/cpan/report/
36d4436d-7888-1014-a278-e5322b825c07
Peter Rabbitson [Thu, 23 Jan 2014 10:03:10 +0000]
Move hrefaddr to DBIC::_Util, give most functions a prototype
This way we can safely do e.g. ( hrefaddr $foo, $unrelated_bar )
Peter Rabbitson [Thu, 23 Jan 2014 10:05:30 +0000]
Improve error reporting when we encounter broken exception objects
Undo parts of
935ea660e (which inadevrtently broke 153a6b38), while
keeping the entire shebang running after issuing a stern warning.
Peter Rabbitson [Thu, 23 Jan 2014 09:35:42 +0000]
Work around older DBI (possibly other cases) of faulty tie()
View diff under -w, similar failcase: http://www.perlmonks.org/?node_id=568377
Peter Rabbitson [Wed, 22 Jan 2014 16:24:03 +0000]
GAH! DBD::SQLite's sqlite_db_filename() is relatively new, undo
9e75be92
On the bright side, re-trapping $db_file now *SEEMS TO WORK*. What the hell?
Ripping out the dogE-crap of
9e75be92, and trying to forget all of this ever
happened...
Peter Rabbitson [Wed, 22 Jan 2014 18:15:52 +0000]
Report correct mismatching inode in the deletion guard on fixed perls
For reference:
http://www.nntp.perl.org/group/perl.perl5.porters/2011/02/msg169414.html
Peter Rabbitson [Wed, 22 Jan 2014 18:24:53 +0000]
Scalar::Util 1.38 seems to be fixed, revert
647da28e
Peter Rabbitson [Wed, 22 Jan 2014 18:18:26 +0000]
Do not run the expensive test under PPerl/SppedyCGI
Peter Rabbitson [Wed, 22 Jan 2014 18:17:27 +0000]
Need some exceptions removed in
556c4fe6 when some optdeps are missing
Peter Rabbitson [Wed, 22 Jan 2014 12:00:47 +0000]
Massive incompatible change of ::BlockRunner internals
It was never documented as usable externally (though folks do use it, sigh)
This last set of changes settles the design for proper documentation and
opening up
Peter Rabbitson [Wed, 22 Jan 2014 09:50:23 +0000]
Fix long standing issue with resultset growth on repeated execution (GHPR#29)
The "save the SQLA argstack" dirty solution introduced in
975b573a actually
resulted in an infinitely growing nested data structure, containing the
history of *every* reinvocation of the resultset. Scale back the problematic
part, though this is still an interim workaround. A DQ-based stack should
make this much cleaner.
Peter Rabbitson [Mon, 20 Jan 2014 19:05:00 +0000]
Stop using precomputed SQLite testdb name, fix test-end bug in replicated.t
This was an... odd one. Originally the problem manifested as a classic
var-sub-sub closure problem, leading to $db_file being captured and tripping
a more involved testcase that is coming in a subsequent commit. However while
getting rid of the reference itself was easy, this led to the outer coderef
itself being "leaked out".
The reproducing oneliner is:
~$ perl -MScalar::Util=weaken -Mstrict -Mwarnings -e '
sub foo {
my $rv = sub { "wtf" }; return $rv;
}
my $should_be_gone;
{
$should_be_gone = foo();
weaken ($should_be_gone);
}
warn $should_be_gone; # why is this still defined@!%#$!$#
'
Various tools indicated that it is somehow attached to the PAD of the static
foo() sub, but I could not figure out *why* exactly this is happening, nor
how to properly list it: PadWalker's closed_over() shows nothing for foo()
Thus invoking doge on the whole shebang, and moving on. SUCH WTF, WOW!
Incientally changing things to use the current SQLite filename revealed
a bug in t/storage/replicated.t, which was never noticed as it only
resulted in annoying warnings under Win32 global destroy (test
teardown).
Peter Rabbitson [Mon, 26 Aug 2013 13:24:04 +0000]
Add extra operations to the heavy duty leaktrace scope
Fire all so-far-collected resultsets multiple times
Peter Rabbitson [Mon, 20 Jan 2014 13:12:23 +0000]
Do not track plain scalar refs on 5.17+ for the time being
Peter Rabbitson [Mon, 20 Jan 2014 10:50:25 +0000]
Smoke 5.16.2 (ensure we are not affected by Encode leak) and bump latest 5.18
Peter Rabbitson [Sun, 19 Jan 2014 17:08:09 +0000]
Stop circref TODO based on RT#82942 from failing after changes in
96577657
Peter Rabbitson [Wed, 15 Jan 2014 15:04:30 +0000]
Now that we have the tools leak-track much more stuff when XS is there
Peter Rabbitson [Wed, 15 Jan 2014 15:04:24 +0000]
Switch to a global symtable "classdata" visitor
This not only allows us to track anything global, not only CAG stuff
but also removes a bunch of workarounda from t/52leaks.t \o/
Peter Rabbitson [Wed, 15 Jan 2014 15:19:54 +0000]
Even saner diagnostics (view under diff -w)
Now that we no longer store signs of "ref X was here but GCed" there is no
point in "No leaks of X" pass()es either
Peter Rabbitson [Tue, 14 Jan 2014 15:19:26 +0000]
Stop various CLONE-registries from growing indefinitely
Peter Rabbitson [Sun, 29 Dec 2013 06:25:53 +0000]
Rewire the leaktracer to store all refs by address, not by name
Also add better diagnostics during failure
Peter Rabbitson [Sun, 12 Jan 2014 12:36:30 +0000]
Centralize handling of refcount in DBIC::_Util
Peter Rabbitson [Sun, 19 Jan 2014 21:59:23 +0000]
Switch the bleadcpan test to 5.8.7
Peter Rabbitson [Sun, 19 Jan 2014 22:47:28 +0000]
Allow devcpan tests to pass by not considering SQLA 1.99_xx
Peter Rabbitson [Sun, 19 Jan 2014 18:24:49 +0000]
Temporary CI workaround for RT#92226
Peter Rabbitson [Sun, 12 Jan 2014 12:34:42 +0000]
Unused import
Peter Rabbitson [Sun, 19 Jan 2014 11:39:28 +0000]
Fix ridiculous regex anchor mistake from
66137dffe
Peter Rabbitson [Mon, 13 Jan 2014 11:49:53 +0000]
SQLite changed their exception text again
Zefram [Sun, 12 Jan 2014 20:04:27 +0000]
Fix warning in t/54taint.t with explicitly unset PERL5LIB (RT#91972)
Peter Rabbitson [Mon, 6 Jan 2014 12:00:12 +0000]
Clarify that this is not a fix but a workaround for loud users
Peter Rabbitson [Mon, 6 Jan 2014 11:52:27 +0000]
Temporary todo list
Dagfinn Ilmari Mannsåker [Fri, 3 Jan 2014 21:18:06 +0000]
Add .mailmap entry for my work address
Dagfinn Ilmari Mannsåker [Fri, 3 Jan 2014 21:17:30 +0000]
Fix typo in Changes
Peter Rabbitson [Fri, 3 Jan 2014 09:37:03 +0000]
Full depchain test on plain blead
Peter Rabbitson [Fri, 3 Jan 2014 09:33:54 +0000]
Grumble - Module::Runtime is M::B-based, wtf Zefram
Peter Rabbitson [Fri, 3 Jan 2014 09:32:27 +0000]
Revert
8c11c33f - the AAAA record got axed
https://github.com/CPAN-API/metacpan-web/issues/1029
Karen Etheridge [Wed, 18 Dec 2013 23:52:30 +0000]
Extra (passing) test case generated while investigating the cause of RT#91375
David Schmidt [Mon, 23 Dec 2013 14:43:27 +0000]
Better explanation for optional fk values in rels
David Schmidt [Mon, 30 Dec 2013 09:32:32 +0000]
Fixed typos
Peter Rabbitson [Fri, 27 Dec 2013 05:53:06 +0000]
Extra poison - have our latest stable in PERL5LIB
Peter Rabbitson [Fri, 27 Dec 2013 05:28:04 +0000]
Better instrument memcached test against failures like
106c81a5
Peter Rabbitson [Fri, 27 Dec 2013 04:59:25 +0000]
Require latest SQLA (some deprecations, lots of parser fixes)
Peter Rabbitson [Thu, 19 Dec 2013 11:59:21 +0000]
Augment
287373c2 with a more pinpointed link
Matt S Trout [Sun, 17 Nov 2013 03:01:29 +0000]
fix test to use qw as (so far as I can see) originally intended
Karen Etheridge [Wed, 18 Dec 2013 20:41:27 +0000]
misspelling
Karen Etheridge [Wed, 18 Dec 2013 20:24:59 +0000]
add link explaining the format of the .mailmap file
Peter Rabbitson [Mon, 16 Dec 2013 08:50:12 +0000]
A git based install works in one step with cpanm
Peter Rabbitson [Mon, 16 Dec 2013 07:42:16 +0000]
Dancing around T::B 1.5 is becoming untenable, just limit it away
Also add an extra 5.12.1 clean devrel smoke