16 years agoMinor doc patch by Caelum
Peter Rabbitson [Thu, 20 Nov 2008 11:09:11 +0000]
Minor doc patch by Caelum

16 years agoCDBI-compat tests by Dave Horwoth:
Peter Rabbitson [Thu, 20 Nov 2008 11:01:14 +0000]
CDBI-compat tests by Dave Horwoth:

    OK. I've attached a patch to t/cdbi-t/15-accessor.t that does several
    things:

    (1) Fixes the way the arguments are built so the sheep argument is
    correct in the tests.

    (2) Adds explicit tests for the number of sheep so we can be sure which
    database record is actually returned.

    (3) Adds tests for find_or_create() with modified accessor names.

    (4) Fixes the test for search() to report all errors

    I still don't fully understand what's going on in the output below but I
    think they are genuine test failures. I'd appreciate it if somebody else
    could run the tests to make sure the results are not some artefact of my
    test environment. I also attached a copy of the modified test script so
    you don't even have to apply the patch first :)

    I don't know what the DestroyWarning at the end is all about.

16 years agoTrunk passes tests again - todoify everything multicreate related to branch it out...
Peter Rabbitson [Thu, 20 Nov 2008 10:25:32 +0000]
Trunk passes tests again - todoify everything multicreate related to branch it out, as the task turned out to be more complex (no indentation to aid future merging)

16 years agoExtend might_have test with ideas from zby
Peter Rabbitson [Mon, 17 Nov 2008 11:04:54 +0000]
Extend might_have test with ideas from zby

16 years agoFailing tests by zby, showing that recursing insert() gets in the way of some exotic...
Peter Rabbitson [Mon, 17 Nov 2008 03:01:39 +0000]
Failing tests by zby, showing that recursing insert() gets in the way of some exotic insert scenarious - waiting for mst to decide course of action

16 years agoSilence cdbi tests like everything else
Peter Rabbitson [Mon, 17 Nov 2008 02:48:57 +0000]
Silence cdbi tests like everything else

16 years agoTwo failing multicreate tests (the root cause of castaway's problem)
Peter Rabbitson [Mon, 17 Nov 2008 02:09:18 +0000]
Two failing multicreate tests (the root cause of castaway's problem)

16 years agoTwo more sets of might_have - has_many relationships for extra tests
Peter Rabbitson [Mon, 17 Nov 2008 01:59:53 +0000]
Two more sets of might_have - has_many relationships for extra tests

16 years agoOne more (passing) multicreate test and a bit of cleanup
Peter Rabbitson [Mon, 17 Nov 2008 01:00:28 +0000]
One more (passing) multicreate test and a bit of cleanup

16 years agorip away a horribly wrong create_via_update test (will pass when multicreate is merged)
Peter Rabbitson [Mon, 17 Nov 2008 00:33:51 +0000]
rip away a horribly wrong create_via_update test (will pass when multicreate is merged)

16 years agomight_have test for castaway to break
Peter Rabbitson [Sun, 16 Nov 2008 22:23:38 +0000]
might_have test for castaway to break

16 years agoAdd new test relationship - a track can have a relates single_cd
Peter Rabbitson [Sun, 16 Nov 2008 22:16:31 +0000]
Add new test relationship - a track can have a relates single_cd

16 years agoRevert castaway's test - mildly bogus
Peter Rabbitson [Sun, 16 Nov 2008 22:14:13 +0000]
Revert castaway's test - mildly bogus

16 years agoMerge 'resultsetcolumn_custom_columns' into 'trunk'
Norbert Buchmuller [Mon, 17 Nov 2008 02:11:42 +0000]
Merge 'resultsetcolumn_custom_columns' into 'trunk'

r5165@vger:  mendel | 2008-11-16 20:11:42 +0100
 * Merged in changes from 'resultsetcolumn_custom_columns' branch,

16 years agowhops
Peter Rabbitson [Sun, 16 Nov 2008 09:53:07 +0000]
whops

16 years agoAdded failing create-multi test
Jess Robinson [Sat, 15 Nov 2008 21:08:30 +0000]
Added failing create-multi test

16 years ago * Rewrote fetching the 'select' and 'as' values from the parent resultset to somethi...
Norbert Buchmuller [Sun, 16 Nov 2008 02:18:11 +0000]
 * Rewrote fetching the 'select' and 'as' values from the parent resultset to something that's easier to read for everyone.

16 years ago * Fixed a bug: did not create the underlying resultset if neither ->next or ->reset...
Norbert Buchmuller [Sat, 15 Nov 2008 03:48:51 +0000]
 * Fixed a bug: did not create the underlying resultset if neither ->next or ->reset is called before ->first was called.

16 years ago * Added ->first and ->reset implementation to ResultSetColumn.
Norbert Buchmuller [Sat, 15 Nov 2008 03:18:53 +0000]
 * Added ->first and ->reset implementation to ResultSetColumn.
 * A bit of refactoring/cleanup of ResultSetColumn.

16 years agowe use register_extra_source() now
Peter Rabbitson [Fri, 14 Nov 2008 17:44:25 +0000]
we use register_extra_source() now

16 years agoDocument the new from usage
Peter Rabbitson [Fri, 14 Nov 2008 09:46:00 +0000]
Document the new from usage

16 years agoresultset attribute from can now take a scalarref and use it verbatim
Peter Rabbitson [Thu, 13 Nov 2008 18:34:29 +0000]
resultset attribute from can now take a scalarref and use it verbatim

16 years agoresult_class goodies by Caelum:
Peter Rabbitson [Thu, 13 Nov 2008 07:34:26 +0000]
result_class goodies by Caelum:
- result_class can now be specified as a search attribute, attaching it to the returned resultset
- the specified class is now autoloaded via ensure_loaded()

16 years agofixed 73oracle.t, added charfield
Johannes Plunien [Wed, 12 Nov 2008 16:42:44 +0000]
fixed 73oracle.t, added charfield

16 years ago * Fixed test cases of ResultSetColumn vs. +select/+as (they used to unconditionally...
Norbert Buchmuller [Tue, 11 Nov 2008 08:29:09 +0000]
 * Fixed test cases of ResultSetColumn vs. +select/+as (they used to unconditionally pass).
 * Added a test case of ResultSetColumn for a non-existent column (note: a valid SQL fragment still can be passed instead of a column).
 * Added a test case of ResultSetColumn that tests overriding a column using select/as.
 * ResultSetColumn now respects select/as/+select/+as.
 * Added missing throw_exception() to ResultSetColumn.

16 years agoClarify attributes argument of find()
Peter Rabbitson [Mon, 10 Nov 2008 23:18:01 +0000]
Clarify attributes argument of find()

16 years agobelongs_to relationships are explicitly flagged by default, to aid the DBIC SQLT...
Peter Rabbitson [Mon, 10 Nov 2008 23:09:23 +0000]
belongs_to relationships are explicitly flagged by default, to aid the DBIC SQLT parser (by abraxxa)

16 years agoSwitch out one more reliance on connect_info
Peter Rabbitson [Mon, 10 Nov 2008 22:46:45 +0000]
Switch out one more reliance on connect_info

16 years agochanged the way we get the DSN for debugging in replication
John Napiorkowski [Mon, 10 Nov 2008 16:12:28 +0000]
changed the way we get the DSN for debugging in replication

16 years agoSwitch schema management version calls from VERSION() to schema_version()
Peter Rabbitson [Sun, 9 Nov 2008 20:19:39 +0000]
Switch schema management version calls from VERSION() to schema_version()

16 years agoDon't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which...
Peter Rabbitson [Sun, 9 Nov 2008 16:02:05 +0000]
Don't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which is stable no matter which connect_info() flavor is used)
todo: ping jnpiorkowski about Replicated::Pool and Replicated::Replicant - it blindly assumes that connect_info->[0] contains the dsn, which might not be the case. Even when using _dbi_connect_info, the first element might be a coderef

16 years agoFix detection of multiple rows being returned for single(): calling fetchrow_array...
Peter Rabbitson [Sun, 9 Nov 2008 15:35:30 +0000]
Fix detection of multiple rows being returned for single(): calling fetchrow_array in scalar context leads to indefined results (search.cpan.org/~timb/DBI/DBI.pm#fetchrow_array)

16 years agoSome testdb changes and alignment, preparing for test refactor branch
Peter Rabbitson [Sun, 9 Nov 2008 15:29:34 +0000]
Some testdb changes and alignment, preparing for test refactor branch

16 years agoSQLT behaves sanely in scalar context, no need for stupid version detections (ribasus...
Peter Rabbitson [Sun, 9 Nov 2008 15:27:40 +0000]
SQLT behaves sanely in scalar context, no need for stupid version detections (ribasushi--)

16 years agoMore TODO items
Peter Rabbitson [Sun, 9 Nov 2008 13:35:57 +0000]
More TODO items

16 years agoOne extra multicreate test and some cleanup
Peter Rabbitson [Fri, 7 Nov 2008 09:42:48 +0000]
One extra multicreate test and some cleanup

16 years agoFix loss of objects on multicreate over several 1:M relations
Peter Rabbitson [Fri, 7 Nov 2008 07:30:49 +0000]
Fix loss of objects on multicreate over several 1:M relations

16 years agoFinal insanification of the multicreate test
Peter Rabbitson [Fri, 7 Nov 2008 07:29:21 +0000]
Final insanification of the multicreate test

16 years agounhide SQL::Translator::Parser::DBIx::Class from pause indexer
Steffen Schwigon [Thu, 6 Nov 2008 21:59:42 +0000]
unhide SQL::Translator::Parser::DBIx::Class from pause indexer

16 years agopod documentation for SQL::Translator::Parser::DBIx::Class
Steffen Schwigon [Thu, 6 Nov 2008 20:23:22 +0000]
pod documentation for SQL::Translator::Parser::DBIx::Class

16 years agoA little indentation clean up
Michael G Schwern [Thu, 6 Nov 2008 12:44:36 +0000]
A little indentation clean up

Test the result of an eval directly.

discard the changes to $sandl to quiet an "object destroyed with changes"
warning.

16 years agomk_group_accessor() is sometimes called internally when inflating a column
Michael G Schwern [Thu, 6 Nov 2008 12:44:27 +0000]
mk_group_accessor() is sometimes called internally when inflating a column
and with an array ref field spec, but the accessor and column names are
the same.  Special case that to go through the usual accessor_name_for stuff.

16 years ago[rt.cpan.org 36863]
Michael G Schwern [Tue, 4 Nov 2008 18:26:41 +0000]
[rt.cpan.org 36863]
Fix mk_group_accessors() to handle [$field, $name].  It ignores
accessor/mutator_name_for() because if you pass in your own accessor
name you probably mean it.

16 years agoNormalize indentation
Michael G Schwern [Tue, 4 Nov 2008 18:26:29 +0000]
Normalize indentation

16 years agoAnd now really untabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:19 +0000]
And now really untabify

16 years agonormalize the indentation and detabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:09 +0000]
normalize the indentation and detabify

16 years agofixed 73oracle.t
Johannes Plunien [Tue, 4 Nov 2008 16:22:51 +0000]
fixed 73oracle.t

16 years agoTest prompted by discussion about tasty stuff
Peter Rabbitson [Sun, 2 Nov 2008 16:55:31 +0000]
Test prompted by discussion about tasty stuff

16 years agoBetter linking in Relatiomship POD
Peter Rabbitson [Sun, 2 Nov 2008 16:54:46 +0000]
Better linking in Relatiomship POD

16 years agoMore svn:ignore
Peter Rabbitson [Sun, 2 Nov 2008 13:32:26 +0000]
More svn:ignore

16 years agoClarify Relationship POD
Peter Rabbitson [Sun, 2 Nov 2008 13:30:49 +0000]
Clarify Relationship POD

16 years agorefactor of t/96multi_create.t:
Peter Rabbitson [Sun, 2 Nov 2008 12:28:02 +0000]
refactor of t/96multi_create.t:
- simplify test case submitted by wreis
- incorporate it into the large multicreate at the end
- eval{} independent sections of the test so more output can be gathered

16 years agoAugment commit r5037 - the column_info feature on SQLite is not buggy but partially...
Peter Rabbitson [Sat, 1 Nov 2008 20:58:07 +0000]
Augment commit r5037 - the column_info feature on SQLite is not buggy but partially unimplemented

16 years agorolling back my last change, waiting until new sqlt is on cpan
Johannes Plunien [Sun, 2 Nov 2008 01:59:49 +0000]
rolling back my last change, waiting until new sqlt is on cpan

16 years agofixed next warnings
Johannes Plunien [Sun, 2 Nov 2008 01:37:21 +0000]
fixed next warnings

16 years agoupdated Changes
Johannes Plunien [Sun, 2 Nov 2008 01:22:09 +0000]
updated Changes

16 years agosplit sql statements for deploy only if SQLT::Producer returned a scalar
Johannes Plunien [Sun, 2 Nov 2008 01:19:09 +0000]
split sql statements for deploy only if SQLT::Producer returned a scalar

16 years agoTODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite...
Peter Rabbitson [Sat, 1 Nov 2008 14:23:15 +0000]
TODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite versions

16 years agoadded failing test case for multi create
Wallace Reis [Sat, 1 Nov 2008 00:42:56 +0000]
added failing test case for multi create

16 years agoKill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected
Peter Rabbitson [Fri, 31 Oct 2008 23:36:02 +0000]
Kill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected

16 years ago68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
Peter Rabbitson [Fri, 31 Oct 2008 20:34:27 +0000]
68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
bumped up the version of DBD::SQLite required for testing

16 years agoAdjust MANIFEST.SKIP
Peter Rabbitson [Fri, 31 Oct 2008 11:22:38 +0000]
Adjust MANIFEST.SKIP

16 years agoCleanup TODO, delete implemented VERSIONING.SKETCH
Peter Rabbitson [Fri, 31 Oct 2008 11:21:41 +0000]
Cleanup TODO, delete implemented VERSIONING.SKETCH

16 years agoIt seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which...
Peter Rabbitson [Fri, 31 Oct 2008 00:26:58 +0000]
It seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which return unexpected column info - fixing. Should take care of:
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525124.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525137.html

16 years agoDev-Release 0.08099_05
Peter Rabbitson [Thu, 30 Oct 2008 21:30:47 +0000]
Dev-Release 0.08099_05

16 years agoFinal set of DBI docfixes
Peter Rabbitson [Thu, 30 Oct 2008 21:26:00 +0000]
Final set of DBI docfixes

16 years agoDocumentation fixups, still needs standardising though
Jess Robinson [Thu, 30 Oct 2008 21:10:05 +0000]
Documentation fixups, still needs standardising though

16 years agoFix some lapses in Storage::DBI pod
Peter Rabbitson [Thu, 30 Oct 2008 15:26:36 +0000]
Fix some lapses in Storage::DBI pod

16 years agoadd some things to castaway's rewrite
Peter Rabbitson [Thu, 30 Oct 2008 12:41:04 +0000]
add some things to castaway's rewrite

16 years agoAdd new TODO items
Peter Rabbitson [Thu, 30 Oct 2008 12:36:54 +0000]
Add new TODO items

16 years agoTest direct sql passed to ResultSetColumn
Peter Rabbitson [Thu, 30 Oct 2008 12:26:05 +0000]
Test direct sql passed to ResultSetColumn

16 years agoMassive cleanup of Storage::DBI::connect_info, based on patches from Oleg Kostyk
Peter Rabbitson [Thu, 30 Oct 2008 11:20:09 +0000]
Massive cleanup of Storage::DBI::connect_info, based on patches from Oleg Kostyk

16 years agoStandardising and improving Row's docs. Added cross linking etc.
Jess Robinson [Wed, 29 Oct 2008 21:09:49 +0000]
Standardising and improving Row's docs. Added cross linking etc.

16 years agoMinor chaining patch + test by Norbert Buchmuller (chaining needs a massive cleanup...
Peter Rabbitson [Wed, 29 Oct 2008 11:18:44 +0000]
Minor chaining patch + test by Norbert Buchmuller (chaining needs a massive cleanup, delayed until next release)

16 years agoYet more RH perf bug test tweaks
Nigel Metheringham [Tue, 28 Oct 2008 13:37:02 +0000]
Yet more RH perf bug test tweaks

16 years agoReworked RH perf test to be more targetted
Nigel Metheringham [Tue, 28 Oct 2008 13:07:44 +0000]
Reworked RH perf test to be more targetted

16 years agoFix an obscure bug in the DBI exception handler, clobbering the exception contents...
Peter Rabbitson [Tue, 28 Oct 2008 12:32:52 +0000]
Fix an obscure bug in the DBI exception handler, clobbering the exception contents when the same $dbh is used outside of dbic code

16 years agoSkip tests if DateTime is not installed.
Tom Hukins [Tue, 28 Oct 2008 11:11:20 +0000]
Skip tests if DateTime is not installed.

16 years agoMerge 'doc_mods' into 'trunk'
Nigel Metheringham [Tue, 28 Oct 2008 09:22:42 +0000]
Merge 'doc_mods' into 'trunk'

Merged in changes to StartupCheck, documentation and tests for Red Hat perl performance issues

16 years agoMerge 'doc_mods' into 'trunk'
Nigel Metheringham [Tue, 28 Oct 2008 09:21:33 +0000]
Merge 'doc_mods' into 'trunk'

Merged in documentation modifications for Intro and Example to use load_namespaces syntax

16 years agoMissing semicolon
Nigel Metheringham [Tue, 28 Oct 2008 09:08:29 +0000]
Missing semicolon

16 years agoMinor RH perf bug test tweaks including internal documentation
Nigel Metheringham [Tue, 28 Oct 2008 09:00:31 +0000]
Minor RH perf bug test tweaks including internal documentation

16 years agoMinor tweaks to RH perf issue stuff following suggestions from ribasushi>
Nigel Metheringham [Mon, 27 Oct 2008 21:55:55 +0000]
Minor tweaks to RH perf issue stuff following suggestions from ribasushi>

16 years agoReworked information on RH perl performance issues
Nigel Metheringham [Mon, 27 Oct 2008 21:42:51 +0000]
Reworked information on RH perl performance issues

16 years agodirty_column detection in set_column() should not depend on the (undocumented) return...
Peter Rabbitson [Mon, 27 Oct 2008 17:27:40 +0000]
dirty_column detection in set_column() should not depend on the (undocumented) return value of store_column()

16 years agoupdated last changes of InflateColumn::DateTime
Johannes Plunien [Sun, 26 Oct 2008 23:38:27 +0000]
updated last changes of InflateColumn::DateTime

16 years agoImprove IC::DT timezone checker POD, add note explaining code weirdness
Peter Rabbitson [Sun, 26 Oct 2008 17:32:11 +0000]
Improve IC::DT timezone checker POD, add note explaining code weirdness

16 years agotypo in pod
Johannes Plunien [Sun, 26 Oct 2008 21:32:29 +0000]
typo in pod

16 years agoreferencing DateTime/Floating_DateTimes
Johannes Plunien [Sun, 26 Oct 2008 21:31:17 +0000]
referencing DateTime/Floating_DateTimes

16 years agousing local on SIG handler
Johannes Plunien [Sun, 26 Oct 2008 21:24:18 +0000]
using local on SIG handler

16 years agofloating timezone warning
Johannes Plunien [Sun, 26 Oct 2008 20:57:28 +0000]
floating timezone warning

16 years agoReworked Manual::Intro to use load_namecpaces
Nigel Metheringham [Sun, 26 Oct 2008 12:47:10 +0000]
Reworked Manual::Intro to use load_namecpaces

16 years agoUpdated example to use load_namespace
Nigel Metheringham [Sun, 26 Oct 2008 12:13:17 +0000]
Updated example to use load_namespace

16 years agoModified example to use load_namespace with default naming rather than load_classes
Nigel Metheringham [Sun, 26 Oct 2008 11:59:35 +0000]
Modified example to use load_namespace with default naming rather than load_classes

16 years agorafl refactored last changes
Johannes Plunien [Sat, 25 Oct 2008 03:11:43 +0000]
rafl refactored last changes

16 years agoadded myself to CONTRIBUTORS
Johannes Plunien [Sat, 25 Oct 2008 02:39:36 +0000]
added myself to CONTRIBUTORS

16 years agopossible to explicitly skip inflation, again rafl++
Johannes Plunien [Sat, 25 Oct 2008 02:33:59 +0000]
possible to explicitly skip inflation, again rafl++

16 years agoadded new option to enforce Date or DateTime inflation, no matter what type the colum...
Johannes Plunien [Sat, 25 Oct 2008 02:05:00 +0000]
added new option to enforce Date or DateTime inflation, no matter what type the column is, rafl++ for having this idea

16 years agocomplete a test
Peter Rabbitson [Fri, 24 Oct 2008 14:32:17 +0000]
complete a test

16 years agoMassive multi-create testing, with two regression fixes:
Peter Rabbitson [Fri, 24 Oct 2008 13:29:08 +0000]
Massive multi-create testing, with two regression fixes:
- An uninserted row must be passed to find_or_create_related with all uninserted objects on which it depends. Since currently we store those in {_inflated_column} as opposed to {_relationship_data} as we should, a simple ->get_inflated_columns will suffice
- We must find_or_create related rows, as find_or_new might queue multiple identical objects for insertions, which will subsequently violate existing unique constraints