Fix t/54taint.t failures on perl-in-hell-in-space

Given its a core bug, and the test is not critical, just skip the whole thing

diff --git a/Changes b/Changes
index 0e8ea0a..8a3fa2e 100644 (file)
--- a/Changes
+++ b/Changes
@@ -13,6 +13,8 @@ Revision history for DBIx::Class
         - Fix hang in t/72pg.t when run against DBD::Pg 3.5.0. The ping()
           implementation changes due to RT#100648 made an alarm() based
           timeout lock-prone.
+        - Fix failures of t/54taint.t on Windows with spaces in the $^X
+          executable path (RT#101615)
 
     * Misc
         - Remove warning about potential side effects of RT#79576 (scheduled)

diff --git a/t/54taint.t b/t/54taint.t
index 7f0db9a..6b866e6 100644 (file)
--- a/t/54taint.t
+++ b/t/54taint.t
@@ -6,6 +6,11 @@ use Config;
 # doesn't work. We don't want to have the user deal with that.
 BEGIN { unless ($INC{'t/lib/DBICTest/WithTaint.pm'}) {
 
+  if ( $^O eq 'MSWin32' and $^X =~ /\x20/ ) {
+    print "1..0 # SKIP Running this test on Windows with spaces within the perl executable path (\$^X) is not possible due to https://rt.perl.org/Ticket/Display.html?id=123907\n";
+    exit 0;
+  }
+
   # it is possible the test itself is initially invoked in taint mode
   # and with relative paths *and* with a relative $^X and some other
   # craziness... in short: just be proactive