fix Win32 file use error in t/storage/reconnect.t

Even though the fake SQLite db file is chmod 0000, for some reason
SQLite still opens it on Win32 and holds it open; this prevents deleting
it and replacing it with the original db file so that the rest of the
tests can run.

TODO: followup with the DBD::SQLite folks.

Disconnect the $dbh on Win32 so the unlink can succeed, and remove the
following SKIP: block (for if db is "encrypted") which is no longer
necessary.

diff --git a/t/storage/reconnect.t b/t/storage/reconnect.t
index 8a33284..a4b7ad0 100644 (file)
--- a/t/storage/reconnect.t
+++ b/t/storage/reconnect.t
@@ -2,8 +2,9 @@ use strict;
 use warnings;
 
 use FindBin;
-use File::Copy;
+use File::Copy 'move';
 use Test::More;
+use Test::Exception;
 use lib qw(t/lib);
 use DBICTest;
 
@@ -37,7 +38,8 @@ cmp_ok(@art_two, '==', 3, "Three artists returned");
 ### Now, disconnect the dbh, and move the db file;
 # create a new one and chmod 000 to prevent SQLite from connecting.
 $schema->storage->_dbh->disconnect;
-move( $db_orig, $db_tmp );
+move( $db_orig, $db_tmp )
+  or die "failed to move $db_orig to $db_tmp: $!";
 open DBFILE, '>', $db_orig;
 print DBFILE 'THIS IS NOT A REAL DATABASE';
 close DBFILE;
@@ -47,28 +49,25 @@ chmod 0000, $db_orig;
 {
     # Catch the DBI connection error
     local $SIG{__WARN__} = sub {};
-    eval {
+    dies_ok {
         my @art_three = $schema->resultset("Artist")->search( {}, { order_by => 'name DESC' } );
-    };
-    ok( $@, 'The operation failed' );
+    } 'The operation failed';
 }
 
+# otherwise can't unlink the fake db file on these systems
+$schema->storage->_dbh->disconnect if $^O =~ /MSWin32|cygwin/i;
+
 ### Now, move the db file back to the correct name
-unlink($db_orig);
-move( $db_tmp, $db_orig );
-
-SKIP: {
-    skip "Cannot reconnect if original connection didn't fail", 2
-        if ( $@ =~ /encrypted or is not a database/ );
-
-    ### Try the operation again... this time, it should succeed
-    my @art_four;
-    eval {
-        @art_four = $schema->resultset("Artist")->search( {}, { order_by => 'name DESC' } );
-    };
-    ok( !$@, 'The operation succeeded' );
-    cmp_ok( @art_four, '==', 3, "Three artists returned" );
-}
+unlink($db_orig) or die "could not delete $db_orig: $!";
+move( $db_tmp, $db_orig )
+  or die "could not move $db_tmp to $db_orig: $!";
+
+### Try the operation again... this time, it should succeed
+my @art_four;
+lives_ok {
+    @art_four = $schema->resultset("Artist")->search( {}, { order_by => 'name DESC' } );
+} 'The operation succeeded';
+cmp_ok( @art_four, '==', 3, "Three artists returned" );
 
 # check that reconnection contexts are preserved in txn_do / dbh_do