Protect several resolve_relationship_condition() callsites
authorPeter Rabbitson <ribasushi@cpan.org>
Thu, 1 Sep 2016 18:22:55 +0000 (20:22 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Tue, 27 Sep 2016 09:54:44 +0000 (11:54 +0200)
commite5c6382908ee65577e53c0771629384d70959a3d
treec6b1d2c88e0879fbb11305ea31fa33634f960a31
parent1bd54f3d4bc8428d602d2e28cb410b303bb242b7
Protect several resolve_relationship_condition() callsites

Some external use of DBIx::Class::ParameterizedJoinHack revealed a couple
sites where the relationship resolution may unexpectedly, yet non-fatally
fail. This protects all the reasonable places (partially reverting b47fb9c0),
downgrading the exceptions to once-per-callsite warnings.

I did not have time to dig to find the underlying problem, there may very well
be a real bug lurking around :/

For reproduction of the (now) warnings: see https://github.com/ctrlo/lenio
lib/DBIx/Class/Relationship/Base.pm
lib/DBIx/Class/Relationship/ManyToMany.pm
lib/DBIx/Class/ResultSource/RowParser.pm