Another blast from the past - fix distinct/order behavior borked by d59eba65f
authorPeter Rabbitson <ribasushi@cpan.org>
Wed, 27 Mar 2013 11:42:15 +0000 (12:42 +0100)
committerPeter Rabbitson <ribasushi@cpan.org>
Wed, 17 Apr 2013 08:59:34 +0000 (10:59 +0200)
commit560978e22520434c67eebb2de72f0e571e47ee40
treeca688da8c92422a121c095ff66b79fac813eb7e0
parent90f10b5a4f971772f25d6304430124abfa4a890c
Another blast from the past - fix distinct/order behavior borked by d59eba65f

While the SQL we test for is valid syntax - the result it produces makes
zero sense for these resultset arguments. Reshuffle the distinct construction
and reuse the codepah for order_by rewrites.

This is a heavy change, but it is *extremely unlikely* anyone was relying on
the previous behavior - any aggregate value would have been wrong...
Changes
lib/DBIx/Class/ResultSet.pm
lib/DBIx/Class/Storage/DBI.pm
lib/DBIx/Class/Storage/DBIHacks.pm
t/prefetch/grouped.t