Merge 'sqla_1.50_compat' into 'trunk'

Merge 'sqla_1.50_compat' into 'trunk'

r5416@vger:  mendel | 2009-01-18 21:22:05 +0100
 * Merged in changes from the 'sqla_1.50_compat' branch:
   * Converted test cases to use SQL::Abstract::Test if available.
     * created DBIC::SqlMakerTest and DBIC::DebugObj helper modules
     * that way the number of extra parens does not matter
     * test cases still pass with SQLA 1.24, but also with 1.50RC
       * those tests that make no sense with older SQLA are skipped
     * Added dependency for Test::Deep (used when emulating SQL::Abstract::Test::eq_bind when SQLA is older than 1.50)
   * Removed a wrong TODO test: 95sql_maker_quote.t/"order_by with quoting needs fixing (ash/castaway)"
     * it never passed and never will (SQLA should not parse the strings in order_by)
     * asked by mst
   * Made a TODO test non-TODO: 95sql_maker_quote.t/"select attr with star needs fixing (mst/nate)"
     * this works with SQLA 1.50
   * Removed dead code from DBI::Class::Storage::DBI (sub _RowNumberOver).
     * neither DBIC, nor SQLA, nor SQLA::Limit uses this (in any version supported by DBIC)
   * Added test cases for every supported order_by syntax.
   * Made DBIC::SQL::Abstract pass on order_by hashref ({-desc => 'colname'}) to SQL::Abstract.
     * this is the blessed way of doing order by
     * new SQLA supports it
     * formerly DBIC considered this as an error
   * Documented using order_by hashref in DBIx::Class::ResultSet.
   * Added test cases to test if arrayref bind values in insert/update are passed through sql_maker intact.
   * Added test cases to test if arrayref bind values work with a PostgreSQL array type.
   * Added 'array_datatypes' parameter to the sql_maker constructor.
     * formerly SQLA considered these as literal SQL with bind values, now that is \['literal SQL', @bind]
       * the new syntax is consistent (works the same in insert/update and where conditions)
     * fortunately 'array_datatypes' was simply ignored by old SQLA (at least with current version..)
     * DBD::Pg can use arrayref bind values for PostgreSQL array types
   * Documented using PostgreSQL arrays (in Cookbook).
   * Fixed/improved a few skip and diag messages.

 r5092@vger (orig r5091):  norbi | 2008-11-10 21:28:36 +0100
  * Created branch for changes required to make DBIC work with SQL::Abstract 1.50.
 r5101@vger (orig r5094):  norbi | 2008-11-11 00:04:34 +0100
  r5094@vger:  mendel | 2008-11-10 23:59:32 +0100
   * Converted some of the test cases to use SQL::Abstract::Test.
   * Added the parens for the join condition (SQL::Abstract::Test can't cope with it, and, besides, they help readability there; plus this gives the same output that older SQLA generated).

 r5102@vger (orig r5095):  norbi | 2008-11-11 00:04:38 +0100
  r5095@vger:  mendel | 2008-11-11 00:00:18 +0100
   * Removed a wrong TODO test: "order_by with quoting needs fixing (ash/castaway)" (asked by mst).
   * Made a TODO test non-TODO: "select attr with star needs fixing (mst/nate)" (works with SQLA 1.50).

 r5103@vger (orig r5096):  norbi | 2008-11-11 00:04:43 +0100
  r5096@vger:  mendel | 2008-11-11 00:00:44 +0100
   * Removed dead code (sub _RowNumberOver).

 r5128@vger (orig r5114):  matthewt | 2008-11-12 17:43:54 +0100
  r25478@agaton (orig r5092):  ribasushi | 2008-11-10 22:46:45 +0000
  Switch out one more reliance on connect_info
  r25483@agaton (orig r5097):  ribasushi | 2008-11-10 23:09:23 +0000
  belongs_to relationships are explicitly flagged by default, to aid the DBIC SQLT parser (by abraxxa)
  r25484@agaton (orig r5098):  ribasushi | 2008-11-10 23:18:01 +0000
  Clarify attributes argument of find()
  r25499@agaton (orig r5113):  plu | 2008-11-12 16:42:44 +0000
  fixed 73oracle.t, added charfield

 r5131@vger (orig r5115):  norbi | 2008-11-13 00:18:05 +0100
  r5130@vger:  mendel | 2008-11-13 00:13:07 +0100
   * Made DBIC::SQL::Abstract pass on order_by hashref ({-desc => 'colname'}) to SQL::Abstract.

 r5133@vger (orig r5116):  norbi | 2008-11-13 00:23:03 +0100
  r5132@vger:  mendel | 2008-11-13 00:22:53 +0100
   * Bumped SQL::Abstract version dependency.

 r5178@vger (orig r5148):  norbi | 2008-11-16 22:29:42 +0100
  r5177@vger:  mendel | 2008-11-16 22:29:33 +0100
   * Added test cases to test if arrayref bind values in insert/update are passed through sql_maker intact.
   * Added 'array_datatypes' parameter to the sql_maker constructor.

 r5209@vger (orig r5172):  norbi | 2008-11-21 17:34:41 +0100
  r5204@vger:  mendel | 2008-11-21 17:11:16 +0100
   * Test cases for every supported order_by syntax.

 r5210@vger (orig r5173):  norbi | 2008-11-21 17:34:51 +0100
  r5205@vger:  mendel | 2008-11-21 17:23:05 +0100
   * Documented order_by => [ { -desc => 'col' } ] syntax.

 r5211@vger (orig r5174):  norbi | 2008-11-21 17:34:57 +0100
  r5206@vger:  mendel | 2008-11-21 17:27:42 +0100
   * Added a WHATSNEW.txt file that summarises the changes on this branch.

 r5212@vger (orig r5175):  norbi | 2008-11-21 17:35:06 +0100
  r5207@vger:  mendel | 2008-11-21 17:28:58 +0100
   * Updated svn:ignore.

 r5213@vger (orig r5176):  norbi | 2008-11-21 17:35:13 +0100
  r5208@vger:  mendel | 2008-11-21 17:34:29 +0100
   * Added tests for passing arrayrefs as bind values for PostgreSQL array values.

 r5243@vger (orig r5191):  norbi | 2008-11-25 02:10:43 +0100
  r5227@vger:  mendel | 2008-11-24 22:03:47 +0100
   * Made PostgreSQL array tests SKIP if SQLA version < 1.50.

 r5244@vger (orig r5192):  norbi | 2008-11-25 02:10:49 +0100
  r5228@vger:  mendel | 2008-11-24 22:13:10 +0100
   * Disabled stringification of arrayref bind values (used to pass values for PostgreSQL arrays).

 r5245@vger (orig r5193):  norbi | 2008-11-25 02:10:54 +0100
  r5229@vger:  mendel | 2008-11-24 22:23:16 +0100
   * Made some more tests SKIP if SQLA version < 1.50.

 r5246@vger (orig r5194):  norbi | 2008-11-25 02:10:59 +0100
  r5230@vger:  mendel | 2008-11-24 22:34:29 +0100
   * Added a test for arrayref bind values in search to match PostgreSQL array type values.

 r5247@vger (orig r5195):  norbi | 2008-11-25 02:11:07 +0100
  r5231@vger:  mendel | 2008-11-24 22:38:08 +0100
   * Fixed the test plan in 72pg.t.
   * Fixed SQLA version check in SKIP tests (it's 1.49 in current 1.50RC branch).

 r5248@vger (orig r5196):  norbi | 2008-11-25 02:11:13 +0100
  r5232@vger:  mendel | 2008-11-24 22:58:38 +0100
   * Documented using PostgreSQL arrays in Cookbook.

 r5249@vger (orig r5197):  norbi | 2008-11-25 02:11:22 +0100
  r5235@vger:  mendel | 2008-11-25 00:32:57 +0100
   * Wrapped SQL::Abstract::Test functionality in a new module (DBIC::SqlMakerTest).
   * Made a test SKIP that does not work with SQL::Abstract < 1.49 (used to be a TODO test).

 r5250@vger (orig r5198):  norbi | 2008-11-25 02:11:29 +0100
  r5236@vger:  mendel | 2008-11-25 00:34:15 +0100
   * Fixed the number of tests skipped in a SKIP block.

 r5251@vger (orig r5199):  norbi | 2008-11-25 02:11:36 +0100
  r5237@vger:  mendel | 2008-11-25 00:50:05 +0100
   * Renamed DBICTest::DBICDebugObj to DBIC::DebugObj.

 r5252@vger (orig r5200):  norbi | 2008-11-25 02:11:41 +0100
  r5238@vger:  mendel | 2008-11-25 00:52:01 +0100
   * Undid bumping of SQL::Abstract version dependency.

 r5253@vger (orig r5201):  norbi | 2008-11-25 02:11:46 +0100
  r5239@vger:  mendel | 2008-11-25 00:55:43 +0100
   * Fixed the order of args of skip().

 r5268@vger (orig r5209):  norbi | 2008-11-26 22:09:07 +0100
  r5267@vger:  mendel | 2008-11-26 22:07:01 +0100
   * Removed extra parens from the ON expression of JOIN (SQLA::Test now handles it properly - in SQLA branch '1.50_RC-extraparens' branch). That means that all the tests pass with SQLA 1.24 and SQLA 1.50RC.

 r5282@vger (orig r5216):  norbi | 2008-11-27 00:04:52 +0100
  r5281@vger:  mendel | 2008-11-27 00:04:40 +0100
   * Replaced eq_bind() implementation with the current copy from SQL::Abstract::Test.

 r5288@vger (orig r5219):  norbi | 2008-11-28 09:43:48 +0100
  r5287@vger:  mendel | 2008-11-28 09:43:36 +0100
   * Replaced eq_bind() implementation to use Test::Deep::eq_deeply().

 r5343@vger (orig r5262):  norbi | 2008-12-20 22:47:16 +0100
  r5341@vger:  mendel | 2008-12-20 22:33:26 +0100
   * Updated WHATSNEW.txt.

 r5345@vger (orig r5263):  norbi | 2008-12-20 23:13:55 +0100
  r5344@vger:  mendel | 2008-12-20 23:13:22 +0100
   * Removed hiding of packages under t/.

 r5347@vger (orig r5264):  norbi | 2008-12-20 23:43:41 +0100
  r5346@vger:  mendel | 2008-12-20 23:43:37 +0100
   * Removed hiding of packages under t/.

 r5349@vger (orig r5265):  norbi | 2008-12-20 23:44:47 +0100
  r5348@vger:  mendel | 2008-12-20 23:44:42 +0100
   * Removed an outdated comment.

 r5352@vger (orig r5267):  ribasushi | 2008-12-21 09:26:19 +0100
 Fix ordering of 'use lib' and 'use' in tests
 r5353@vger (orig r5268):  ribasushi | 2008-12-21 09:45:25 +0100
 whops
 r5356@vger (orig r5271):  ribasushi | 2008-12-21 12:25:37 +0100
 Remove some cruft
 r5415@vger (orig r5321):  norbi | 2009-01-18 21:15:24 +0100
  r5414@vger:  mendel | 2009-01-18 21:15:15 +0100
   * Removed temporary notes file (WHATSNEW.txt).