use strict;
use warnings;
+BEGIN {
+ require threads if $^O eq 'MSWin32'; # preload due to fork errors
+}
+
use Test::More;
use Test::Warn;
use Test::Exception;
year => 2006,
}) foreach (@cd_titles);
- return $artist->cds;
+ return $artist->cds->all;
};
# Test checking of parameters
die "$$ starts in txn!" if $s->storage->transaction_depth != 0;
$s->txn_do ( sub {
die "$$ not in txn!" if $s->storage->transaction_depth == 0;
- $s->storage->dbh->do('SELECT 1') }
+ $s->storage->dbh->do('SELECT 1') }
);
die "$$ did not finish txn!" if $s->storage->transaction_depth != 0;
},
$guard->commit
},
) {
- push @pids, fork();
+ my $pid = fork();
die "Unable to fork: $!\n"
- if ! defined $pids[-1];
+ if ! defined $pid;
- if ($pids[-1]) {
+ if ($pid) {
+ push @pids, $pid;
next;
}
my $guard = $schema->txn_scope_guard;
$schema->txn_do( sub { die } );
};
+ is( $schema->storage->transaction_depth, 0, 'Transaction successfully aborted' );
$schema->txn_do( sub {
ok ($schema->storage->_dbh->do ('SELECT 1'), "Query after exceptions ok ($_)");
});
}
- for my $pid ( $schema->txn_do ( sub { _forking_action ($schema) } ) ) {
- waitpid ($pid, 0);
- ok (! $?, "Child $pid exit ok (pass $pass)");
- isa_ok ($schema->resultset ('Artist')->find ({ name => "forking action $pid" }), 'DBIx::Class::Row');
- }
+ $schema->txn_do ( sub { _test_forking_action ($schema, $pass) } );
}
}
my $guard = $schema->txn_scope_guard;
$schema->txn_do( sub { die } );
};
+ is( $schema->storage->transaction_depth, 0, 'Transaction successfully aborted' );
$schema->txn_do( sub {
ok ($schema->storage->_dbh->do ('SELECT 1'), "Query after exceptions ok ($_)");
});
}
- my @pids;
my $guard = $schema->txn_scope_guard;
- _forking_action ($schema);
+ my @pids = _test_forking_action ($schema, $pass);
$guard->commit;
-
- for my $pid (@pids) {
- waitpid ($pid, 0);
- ok (! $?, "Child $pid exit ok (pass $pass)");
- isa_ok ($schema->resultset ('Artist')->find ({ name => "forking action $pid" }), 'DBIx::Class::Row');
- }
}
}
-sub _forking_action {
- my $schema = shift;
+sub _test_forking_action {
+ my ($schema, $pass) = @_;
my @pids;
- while (@pids < 5) {
- push @pids, fork();
+ SKIP: for my $count (1 .. 5) {
+
+ skip 'Weird DBI General Protection Faults, skip forking tests (RT#63104)', 5
+ if $^O eq 'MSWin32';
+
+ my $pid = fork();
die "Unable to fork: $!\n"
- if ! defined $pids[-1];
+ if ! defined $pid;
- if ($pids[-1]) {
+ if ($pid) {
+ push @pids, $pid;
next;
}
- if (@pids % 2) {
+ if ($count % 2) {
$schema->txn_do (sub {
my $depth = $schema->storage->transaction_depth;
die "$$(txn_do)unexpected txn depth $depth!" if $depth != 1;
exit 0;
}
- return @pids;
+ for my $pid (@pids) {
+ waitpid ($pid, 0);
+ ok (! $?, "Child $pid exit ok (pass $pass)");
+ }
+
+ # it is important to reap all children before checking the final db-state
+ # otherwise a deadlock may occur between the transactions running in the
+ # children and the query of the parent
+ for my $pid (@pids) {
+ isa_ok ($schema->resultset ('Artist')->find ({ name => "forking action $pid" }), 'DBIx::Class::Row');
+ }
}
my $fail_code = sub {
my $artist = $schema->resultset('Artist')->find(3);
# Force txn_rollback() to throw an exception
- no warnings 'redefine';
- no strict 'refs';
+ no warnings qw/once redefine/;
+
+ # this should logically work just fine - but it does not,
+ # only direct override of the existing method dtrt
+ #local *DBIx::Class::Storage::DBI::SQLite::txn_rollback = sub { die 'FAILED' };
- # die in rollback
- local *{"DBIx::Class::Storage::DBI::SQLite::txn_rollback"} = sub{
- my $storage = shift;
- die 'FAILED';
- };
+ local *DBIx::Class::Storage::DBI::txn_rollback = sub { die 'FAILED' };
+ Class::C3->reinitialize() if DBIx::Class::_ENV_::OLD_MRO;
throws_ok (
sub {
ok(!defined($cd), q{failed txn_do didn't add failed txn's cd});
}
+
# Grab a new schema to test txn before connect
+# also test nested txn exception
{
my $schema = DBICTest->init_schema(no_deploy => 1);
lives_ok (sub {
$schema->txn_begin();
}, 'Pre-connection nested transactions.');
- # although not connected DBI would still warn about rolling back at disconnect
- $schema->txn_rollback;
- $schema->txn_rollback;
+ throws_ok( sub { $schema->txn_rollback }, 'DBIx::Class::Storage::NESTED_ROLLBACK_EXCEPTION', 'got proper nested rollback exception' );
}
# make sure AutoCommit => 0 on external handles behaves correctly with scope_guard
warnings_are {
- my $factory = DBICTest->init_schema (AutoCommit => 0);
+ my $factory = DBICTest->init_schema;
cmp_ok ($factory->resultset('CD')->count, '>', 0, 'Something to delete');
my $dbh = $factory->storage->dbh;
+ $dbh->{AutoCommit} = 0;
ok (!$dbh->{AutoCommit}, 'AutoCommit is off on $dbh');
my $schema = DBICTest::Schema->connect (sub { $dbh });
# make sure AutoCommit => 0 on external handles behaves correctly with txn_do
warnings_are {
- my $factory = DBICTest->init_schema (AutoCommit => 0);
+ my $factory = DBICTest->init_schema;
cmp_ok ($factory->resultset('CD')->count, '>', 0, 'Something to delete');
my $dbh = $factory->storage->dbh;
+ $dbh->{AutoCommit} = 0;
ok (!$dbh->{AutoCommit}, 'AutoCommit is off on $dbh');
my $schema = DBICTest::Schema->connect (sub { $dbh });
-
lives_ok ( sub {
$schema->txn_do (sub { $schema->resultset ('CD')->delete });
}, 'No attempt to start a atransaction with txn_do');