Document software_limit and properly throw on related as_query calls

[dbsrgits/DBIx-Class.git] / t / sqlmaker / limit_dialects / basic.t

diff --git a/t/75limit.t b/t/sqlmaker/limit_dialects/basic.t
similarity index 88%
rename from t/75limit.t
rename to t/sqlmaker/limit_dialects/basic.t
index 61f5520..7098f1d 100644 (file)
--- a/t/75limit.t
+++ b/t/sqlmaker/limit_dialects/basic.t
@@ -2,6 +2,7 @@ use strict;
 use warnings;
 
 use Test::More;
+use Test::Exception;
 use lib qw(t/lib);
 use DBICTest;
 
@@ -46,6 +47,12 @@ is( $it->next, undef, "software next past end of resultset ok" );
 );
 is( $cds[0]->title, "Spoonful of bees", "software offset ok" );
 
+throws_ok {
+  $schema->resultset("CD")->search({}, {
+    rows => 2,
+    software_limit => 1,
+  })->as_query;
+} qr/Unable to generate limited query representation with 'software_limit' enabled/;
 
 @cds = $schema->resultset("CD")->search( {},
     {
@@ -54,9 +61,6 @@ is( $cds[0]->title, "Spoonful of bees", "software offset ok" );
 );
 is( $cds[0]->title, "Spoonful of bees", "offset with no limit" );
 
-
-# based on a failing criteria submitted by waswas
-# requires SQL::Abstract >= 1.20
 $it = $schema->resultset("CD")->search(
     { title => [
         -and =>