#
# As per https://metacpan.org/source/ADAMK/DBD-SQLite-1.37/lib/DBD/SQLite.pm#L921
# SQLite does *not* try to synchronize
+#
+# However DBD::SQLite 1.38_02 seems to fix this, with an accompanying test:
+# https://metacpan.org/source/ADAMK/DBD-SQLite-1.38_02/t/54_literal_txn.t
+
+my $lit_txn_todo = eval { DBD::SQLite->VERSION(1.38_02) }
+ ? undef
+ : "DBD::SQLite before 1.38_02 is retarded wrt detecting literal BEGIN/COMMIT statements"
+;
for my $prefix_comment (qw/Begin_only Commit_only Begin_and_Commit/) {
note "Testing with comment prefixes on $prefix_comment";
# perhaps when (if ever) DBD::SQLite gets fixed,
# we can do something extra here
local $SIG{__WARN__} = sub { warn @_ if $_[0] !~ /Internal transaction state .+? does not seem to match/ }
- unless $ENV{TEST_VERBOSE};
+ if ( $lit_txn_todo && !$ENV{TEST_VERBOSE} );
my ($c_begin, $c_commit) = map { $prefix_comment =~ $_ ? 1 : 0 } (qr/Begin/, qr/Commit/);
);
ok ($schema->storage->connected, 'Still connected');
{
- local $TODO = 'SQLite is retarded wrt detecting BEGIN' if $c_begin;
+ local $TODO = $lit_txn_todo if $c_begin;
ok (! $schema->storage->_dbh->{AutoCommit}, "DBD aware of txn begin with comments on $prefix_comment");
}
);
ok ($schema->storage->connected, 'Still connected');
{
- local $TODO = 'SQLite is retarded wrt detecting COMMIT' if $c_commit;
+ local $TODO = $lit_txn_todo if $c_commit and ! $c_begin;
ok ($schema->storage->_dbh->{AutoCommit}, "DBD aware txn ended with comments on $prefix_comment");
}
{
# this never worked in the 1st place
- local $TODO = 'SQLite is retarded wrt detecting COMMIT' if ! $c_begin and $c_commit;
+ local $TODO = $lit_txn_todo if ! $c_begin and $c_commit;
+ # odd argument passing, because such nested crefs leak on 5.8
lives_ok {
$schema->storage->txn_do (sub {
- ok ($ars->find({ name => $artist->name }), "Artist still where we left it after cycle with comments on $prefix_comment");
- });
+ ok ($_[0]->find({ name => $_[1] }), "Artist still where we left it after cycle with comments on $prefix_comment");
+ }, $ars, $artist->name );
} "Succesfull transaction with comments on $prefix_comment";
}
}
# make sure the side-effects of RT#67581 do not result in data loss
my $row;
warnings_exist { $row = $schema->resultset('Artist')->create ({ name => 'alpha rank', rank => 'abc' }) }
- [qr/Non-numeric value supplied for column 'rank' despite the numeric datatype/],
+ [qr/Non-integer value supplied for column 'rank' despite the integer datatype/],
'proper warning on string insertion into an numeric column'
;
$row->discard_changes;