use Test::More;
use Test::Exception;
use Test::Warn;
+use Time::HiRes 'time';
use Config;
use lib qw(t/lib);
use DBICTest;
+use DBIx::Class::_Util 'modver_gt_or_eq';
# savepoints test
{
'rollback from inner transaction';
}
+# check that we work somewhat OK with braindead SQLite transaction handling
+#
+# As per https://metacpan.org/source/ADAMK/DBD-SQLite-1.37/lib/DBD/SQLite.pm#L921
+# SQLite does *not* try to synchronize
+#
+# However DBD::SQLite 1.38_02 seems to fix this, with an accompanying test:
+# https://metacpan.org/source/ADAMK/DBD-SQLite-1.38_02/t/54_literal_txn.t
+
+my $lit_txn_todo = modver_gt_or_eq('DBD::SQLite', '1.38_02')
+ ? undef
+ : "DBD::SQLite before 1.38_02 is retarded wrt detecting literal BEGIN/COMMIT statements"
+;
+
+for my $prefix_comment (qw/Begin_only Commit_only Begin_and_Commit/) {
+ note "Testing with comment prefixes on $prefix_comment";
+
+ # FIXME warning won't help us for the time being
+ # perhaps when (if ever) DBD::SQLite gets fixed,
+ # we can do something extra here
+ local $SIG{__WARN__} = sub { warn @_ if $_[0] !~ /Internal transaction state .+? does not seem to match/ }
+ if ( $lit_txn_todo && !$ENV{TEST_VERBOSE} );
+
+ my ($c_begin, $c_commit) = map { $prefix_comment =~ $_ ? 1 : 0 } (qr/Begin/, qr/Commit/);
+
+ my $schema = DBICTest->init_schema( no_deploy => 1 );
+ my $ars = $schema->resultset('Artist');
+
+ ok (! $schema->storage->connected, 'No connection yet');
+
+ $schema->storage->dbh->do(<<'DDL');
+CREATE TABLE artist (
+ artistid INTEGER PRIMARY KEY NOT NULL,
+ name varchar(100),
+ rank integer DEFAULT 13,
+ charfield char(10) NULL
+);
+DDL
+
+ my $artist = $ars->create({ name => 'Artist_' . time() });
+ is ($ars->count, 1, 'Inserted artist ' . $artist->name);
+
+ ok ($schema->storage->connected, 'Connected');
+ ok ($schema->storage->_dbh->{AutoCommit}, 'DBD not in txn yet');
+
+ $schema->storage->dbh->do(join "\n",
+ $c_begin ? '-- comment' : (),
+ 'BEGIN TRANSACTION'
+ );
+ ok ($schema->storage->connected, 'Still connected');
+ {
+ local $TODO = $lit_txn_todo if $c_begin;
+ ok (! $schema->storage->_dbh->{AutoCommit}, "DBD aware of txn begin with comments on $prefix_comment");
+ }
+
+ $schema->storage->dbh->do(join "\n",
+ $c_commit ? '-- comment' : (),
+ 'COMMIT'
+ );
+ ok ($schema->storage->connected, 'Still connected');
+ {
+ local $TODO = $lit_txn_todo if $c_commit and ! $c_begin;
+ ok ($schema->storage->_dbh->{AutoCommit}, "DBD aware txn ended with comments on $prefix_comment");
+ }
+
+ is ($ars->count, 1, 'Inserted artists still there');
+
+ {
+ # this never worked in the 1st place
+ local $TODO = $lit_txn_todo if ! $c_begin and $c_commit;
+
+ # odd argument passing, because such nested crefs leak on 5.8
+ lives_ok {
+ $schema->storage->txn_do (sub {
+ ok ($_[0]->find({ name => $_[1] }), "Artist still where we left it after cycle with comments on $prefix_comment");
+ }, $ars, $artist->name );
+ } "Succesfull transaction with comments on $prefix_comment";
+ }
+}
+
+
my $schema = DBICTest->init_schema();
# make sure the side-effects of RT#67581 do not result in data loss
my $row;
warnings_exist { $row = $schema->resultset('Artist')->create ({ name => 'alpha rank', rank => 'abc' }) }
- [qr/Non-numeric value supplied for column 'rank' despite the numeric datatype/],
+ [qr/Non-integer value supplied for column 'rank' despite the integer datatype/],
'proper warning on string insertion into an numeric column'
;
$row->discard_changes;
# range is -(2**63) .. 2**63 - 1
SKIP: {
skip 'This perl does not seem to have 64bit int support - DBI roundtrip of large int will fail with DBD::SQLite < 1.37', 1
- if ($Config{ivsize} < 8 and ! eval { DBD::SQLite->VERSION(1.37); 1 });
+ if ($Config{ivsize} < 8 and ! modver_gt_or_eq('DBD::SQLite', '1.37') );
for my $bi (qw/
-9223372036854775808