more has_relationship_loaded tests + fix for the failing tests
[dbsrgits/DBIx-Class.git] / t / 746mssql.t
index f559945..57c44fb 100644 (file)
@@ -3,12 +3,17 @@ use warnings;
 
 use Test::More;
 use Test::Exception;
+use Try::Tiny;
+
+use DBIx::Class::Optional::Dependencies ();
+plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('test_rdbms_mssql_odbc')
+  unless DBIx::Class::Optional::Dependencies->req_ok_for ('test_rdbms_mssql_odbc');
+
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::SqlMakerTest;
-use Try::Tiny;
-
 use DBIx::Class::SQLMaker::LimitDialects;
+
 my $OFFSET = DBIx::Class::SQLMaker::LimitDialects->__offset_bindtype;
 my $TOTAL  = DBIx::Class::SQLMaker::LimitDialects->__total_bindtype;
 
@@ -39,10 +44,9 @@ my $schema = DBICTest::Schema->connect($dsn, $user, $pass);
 isa_ok( $schema->storage, 'DBIx::Class::Storage::DBI::ODBC::Microsoft_SQL_Server' );
 
 {
-  my $schema2 = $schema->connect ($schema->storage->connect_info);
+  my $schema2 = $schema->connect (@{$schema->storage->connect_info});
   ok (! $schema2->storage->connected, 'a re-connected cloned schema starts unconnected');
 }
-
 $schema->storage->_dbh->disconnect;
 
 lives_ok {
@@ -51,25 +55,35 @@ lives_ok {
 
 my %opts = (
   use_mars =>
-    { on_connect_call => 'use_mars' },
+    { opts => { on_connect_call => 'use_mars' } },
   use_dynamic_cursors =>
-    { on_connect_call => 'use_dynamic_cursors' },
+    { opts => { on_connect_call => 'use_dynamic_cursors' },
+      required => $schema->storage->_using_freetds ? 0 : 1,
+    },
   use_server_cursors =>
-    { on_connect_call => 'use_server_cursors' },
+    { opts => { on_connect_call => 'use_server_cursors' } },
   plain =>
-    {},
+    { opts => {}, required => 1 },
 );
 
 for my $opts_name (keys %opts) {
   SKIP: {
-    my $opts = $opts{$opts_name};
+    my $opts = $opts{$opts_name}{opts};
     $schema = DBICTest::Schema->connect($dsn, $user, $pass, $opts);
 
     try {
       $schema->storage->ensure_connected
     }
     catch {
-      skip "$opts_name not functional in this configuration: $_", 1;
+      if ($opts{$opts_name}{required}) {
+        die "on_connect_call option '$opts_name' is not functional: $_";
+      }
+      else {
+        skip
+          "on_connect_call option '$opts_name' not functional in this configuration: $_",
+          1
+        ;
+      }
     };
 
     $schema->storage->dbh_do (sub {
@@ -98,30 +112,40 @@ SQL
       skip 'not a multiple active statements configuration', 1
         if $opts_name eq 'plain';
 
-      my $artist_rs = $schema->resultset('Artist');
+      $schema->storage->ensure_connected;
 
-      $artist_rs->delete;
+      lives_ok {
 
-      $artist_rs->create({ name => "Artist$_" }) for (1..3);
+        no warnings 'redefine';
+        local *DBI::connect = sub { die "NO RECONNECTS!!!" };
 
-      my $forward  = $artist_rs->search({},
-        { order_by => { -asc  => 'artistid' } });
-      my $backward = $artist_rs->search({},
-        { order_by => { -desc => 'artistid' } });
+        my $artist_rs = $schema->resultset('Artist');
 
-      my @map = (
-        [qw/Artist1 Artist3/], [qw/Artist2 Artist2/], [qw/Artist3 Artist1/]
-      );
-      my @result;
+        $artist_rs->delete;
 
-      while (my $forward_row = $forward->next) {
-        my $backward_row = $backward->next;
-        push @result, [$forward_row->name, $backward_row->name];
-      }
+        $artist_rs->create({ name => "Artist$_" }) for (1..3);
 
-      is_deeply \@result, \@map, "multiple active statements in $opts_name";
+        my $forward  = $artist_rs->search({},
+          { order_by => { -asc  => 'artistid' } });
+        my $backward = $artist_rs->search({},
+          { order_by => { -desc => 'artistid' } });
 
-      $artist_rs->delete;
+        my @map = (
+          [qw/Artist1 Artist3/], [qw/Artist2 Artist2/], [qw/Artist3 Artist1/]
+        );
+        my @result;
+
+        while (my $forward_row = $forward->next) {
+          my $backward_row = $backward->next;
+          push @result, [$forward_row->name, $backward_row->name];
+        }
+
+        is_deeply \@result, \@map, "multiple active statements in $opts_name";
+
+        $artist_rs->delete;
+
+        is($artist_rs->count, 0, '$dbh still viable');
+      } "Multiple active statements survive $opts_name";
     }
 
 # Test populate
@@ -228,7 +252,7 @@ SQL
         my $test_type = "Dialect:$dialect Quoted:$quoted";
 
         # basic limit support
-        TODO: {
+        {
           my $art_rs = $schema->resultset ('Artist');
           $art_rs->delete;
           $art_rs->create({ name => 'Artist ' . $_ }) for (1..6);
@@ -267,35 +291,6 @@ SQL
           );
         }
 
-        {
-          my $book_owner_ids = $schema->resultset ('BooksInLibrary')->search ({}, {
-            rows => 6,
-            offset => 2,
-            join => 'owner',
-            distinct => 1,
-            order_by => 'owner.name',
-            unsafe_subselect_ok => 1
-          })->get_column ('owner');
-
-          my @ids = $book_owner_ids->all;
-
-          is (@ids, 6, 'Limit works');
-
-          my $book_owners = $schema->resultset ('Owners')->search ({
-            id => { -in => $book_owner_ids->as_query }
-          });
-
-          TODO: {
-            local $TODO = "Correlated limited IN subqueries will probably never preserve order";
-
-            is_deeply (
-              [ map { $_->id } ($book_owners->all) ],
-              [ $book_owner_ids->all ],
-              "$test_type: Sort is preserved across IN subqueries",
-            );
-          }
-        }
-
         # still even with lost order of IN, we should be getting correct
         # sets
         {
@@ -371,35 +366,89 @@ SQL
           },
           {
             prefetch => 'books',
-            order_by => { -asc => \['name + ?', [ test => 'xxx' ]] }, # test bindvar propagation
+            order_by => [ { -asc => \['name + ?', [ test => 'xxx' ]] }, 'me.id' ], # test bindvar propagation
             group_by => [ map { "me.$_" } $schema->source('Owners')->columns ], # the literal order_by requires an explicit group_by
             rows     => 3,  # 8 results total
             unsafe_subselect_ok => 1,
           },
         );
 
-        my ($sql, @bind) = @${$owners->page(3)->as_query};
-        is_same_bind (
-          \@bind,
+        is_same_sql_bind (
+          $owners->page(3)->as_query,
+          $dialect eq 'Top'
+            ? '(
+              SELECT TOP 2147483647 [me].[id], [me].[name],
+                                    [books].[id], [books].[source], [books].[owner], [books].[title], [books].[price]
+                FROM (
+                  SELECT TOP 2147483647 [me].[id], [me].[name]
+                    FROM (
+                      SELECT TOP 3 [me].[id], [me].[name], [ORDER__BY__001]
+                        FROM (
+                          SELECT TOP 9 [me].[id], [me].[name], name + ? AS [ORDER__BY__001]
+                            FROM [owners] [me]
+                            LEFT JOIN [books] [books]
+                              ON [books].[owner] = [me].[id]
+                          WHERE [books].[id] IS NOT NULL AND [me].[name] != ?
+                          GROUP BY [me].[id], [me].[name]
+                          ORDER BY name + ? ASC, [me].[id]
+                        ) [me]
+                      ORDER BY [ORDER__BY__001] DESC, [me].[id] DESC
+                    ) [me]
+                  ORDER BY [ORDER__BY__001] ASC, [me].[id]
+                ) [me]
+                LEFT JOIN [books] [books]
+                  ON [books].[owner] = [me].[id]
+              WHERE [books].[id] IS NOT NULL AND [me].[name] != ?
+              ORDER BY name + ? ASC, [me].[id]
+            )'
+            : '(
+              SELECT TOP 2147483647 [me].[id], [me].[name],
+                                    [books].[id], [books].[source], [books].[owner], [books].[title], [books].[price]
+                FROM (
+                  SELECT TOP 2147483647 [me].[id], [me].[name]
+                    FROM (
+                      SELECT [me].[id], [me].[name],
+                             ROW_NUMBER() OVER( ORDER BY [ORDER__BY__001] ASC, [me].[id] ) AS [rno__row__index]
+                        FROM (
+                          SELECT [me].[id], [me].[name], name + ? AS [ORDER__BY__001]
+                            FROM [owners] [me]
+                            LEFT JOIN [books] [books]
+                              ON [books].[owner] = [me].[id]
+                          WHERE [books].[id] IS NOT NULL AND [me].[name] != ?
+                          GROUP BY [me].[id], [me].[name]
+                        ) [me]
+                    ) [me]
+                  WHERE [rno__row__index] >= ? AND [rno__row__index] <= ?
+                ) [me]
+                LEFT JOIN [books] [books]
+                  ON [books].[owner] = [me].[id]
+              WHERE [books].[id] IS NOT NULL AND [me].[name] != ?
+              ORDER BY name + ? ASC, [me].[id]
+            )'
+          ,
           [
-            ($dialect eq 'Top' ? [ { dbic_colname => 'test' } => 'xxx' ] : ()), # the extra re-order bind
-            [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'me.name' }
-              => 'somebogusstring' ],
             [ { dbic_colname => 'test' }
               => 'xxx' ],
-            ($dialect ne 'Top' ? ( [ $OFFSET => 7 ], [ $TOTAL => 9 ] ) : ()), # parameterised RNO
+            [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'me.name' }
+              => 'somebogusstring' ],
+
+            ($dialect eq 'Top'
+              ? [ { dbic_colname => 'test' } => 'xxx' ]  # the extra re-order bind
+              : ([ $OFFSET => 7 ], [ $TOTAL => 9 ]) # parameterised RNO
+            ),
+
             [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'me.name' }
               => 'somebogusstring' ],
             [ { dbic_colname => 'test' }
               => 'xxx' ],
           ],
-        );
+        ) if $quoted;
 
         is ($owners->page(1)->all, 3, "$test_type: has_many prefetch returns correct number of rows");
         is ($owners->page(1)->count, 3, "$test_type: has-many prefetch returns correct count");
 
         is ($owners->page(3)->count, 2, "$test_type: has-many prefetch returns correct count");
-        TODO: {
+        {
           local $TODO = "Top-limit does not work when your limit ends up past the resultset"
             if $dialect eq 'Top';
           is ($owners->page(3)->all, 2, "$test_type: has_many prefetch returns correct number of rows");
@@ -417,14 +466,66 @@ SQL
             having => \['1 = ?', [ test => 1 ] ], #test having propagation
             prefetch => 'owner',
             rows     => 2,  # 3 results total
-            order_by => { -desc => 'me.owner' },
+            order_by => [{ -desc => 'me.owner' }, 'me.id'],
             unsafe_subselect_ok => 1,
           },
         );
 
-        ($sql, @bind) = @${$books->page(3)->as_query};
-        is_same_bind (
-          \@bind,
+        is_same_sql_bind (
+          $books->page(3)->as_query,
+          $dialect eq 'Top'
+            ? '(
+              SELECT TOP 2147483647 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price],
+                                    [owner].[id], [owner].[name]
+                FROM (
+                  SELECT TOP 2147483647 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                    FROM (
+                      SELECT TOP 2 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                        FROM (
+                          SELECT TOP 6 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                            FROM [books] [me]
+                            JOIN [owners] [owner]
+                              ON [owner].[id] = [me].[owner]
+                          WHERE ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ?
+                          GROUP BY [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                          HAVING 1 = ?
+                          ORDER BY [me].[owner] DESC, [me].[id]
+                        ) [me]
+                      ORDER BY [me].[owner] ASC, [me].[id] DESC
+                    ) [me]
+                  ORDER BY [me].[owner] DESC, [me].[id]
+                ) [me]
+                JOIN [owners] [owner]
+                  ON [owner].[id] = [me].[owner]
+              WHERE ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ?
+              ORDER BY [me].[owner] DESC, [me].[id]
+            )'
+            : '(
+              SELECT TOP 2147483647 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price],
+                                    [owner].[id], [owner].[name]
+                FROM (
+                  SELECT TOP 2147483647 [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                    FROM (
+                      SELECT [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price],
+                             ROW_NUMBER() OVER( ORDER BY [me].[owner] DESC, [me].[id] ) AS [rno__row__index]
+                        FROM (
+                          SELECT [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                            FROM [books] [me]
+                            JOIN [owners] [owner]
+                              ON [owner].[id] = [me].[owner]
+                          WHERE ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ?
+                          GROUP BY [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price]
+                          HAVING 1 = ?
+                        ) [me]
+                    ) [me]
+                  WHERE [rno__row__index] >= ? AND [rno__row__index] <= ?
+                ) [me]
+                JOIN [owners] [owner]
+                  ON [owner].[id] = [me].[owner]
+              WHERE ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ?
+              ORDER BY [me].[owner] DESC, [me].[id]
+            )'
+          ,
           [
             # inner
             [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'owner.name' }
@@ -436,8 +537,12 @@ SQL
             [ { dbic_colname => 'test' }
               => '1' ],
 
-            # rno(?)
-            $dialect ne 'Top' ? ( [ $OFFSET => 5 ], [ $TOTAL => 6 ] ) : (),
+            # top(?)
+            $dialect eq 'Top'
+              ? ()
+              : ( [ $OFFSET => 5 ], [ $TOTAL => 6 ] )
+            ,
+
             # outer
             [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'owner.name' }
               => 'wiggle' ],
@@ -446,13 +551,13 @@ SQL
             [ { sqlt_datatype => 'varchar', sqlt_size => 100, dbic_colname => 'source' }
               => 'Library' ],
           ],
-        );
+        ) if $quoted;
 
         is ($books->page(1)->all, 2, "$test_type: Prefetched grouped search returns correct number of rows");
         is ($books->page(1)->count, 2, "$test_type: Prefetched grouped search returns correct count");
 
         is ($books->page(2)->count, 1, "$test_type: Prefetched grouped search returns correct count");
-        TODO: {
+        {
           local $TODO = "Top-limit does not work when your limit ends up past the resultset"
             if $dialect eq 'Top';
           is ($books->page(2)->all, 1, "$test_type: Prefetched grouped search returns correct number of rows");
@@ -522,27 +627,41 @@ CREATE TABLE money_test (
 SQL
       });
 
-      my $rs = $schema->resultset('Money');
-      my $row;
+      {
+        my $freetds_and_dynamic_cursors = 1
+          if $opts_name eq 'use_dynamic_cursors' &&
+            $schema->storage->_using_freetds;
 
-      lives_ok {
-        $row = $rs->create({ amount => 100 });
-      } 'inserted a money value';
+        local $TODO =
+'these tests fail on freetds with dynamic cursors for some reason'
+          if $freetds_and_dynamic_cursors;
+        local $ENV{DBIC_NULLABLE_KEY_NOWARN} = 1
+          if $freetds_and_dynamic_cursors;
 
-      cmp_ok $rs->find($row->id)->amount, '==', 100, 'money value round-trip';
+        my $rs = $schema->resultset('Money');
+        my $row;
 
-      lives_ok {
-        $row->update({ amount => 200 });
-      } 'updated a money value';
+        lives_ok {
+          $row = $rs->create({ amount => 100 });
+        } 'inserted a money value';
 
-      cmp_ok $rs->find($row->id)->amount, '==', 200,
-        'updated money value round-trip';
+        cmp_ok ((try { $rs->find($row->id)->amount })||0, '==', 100,
+          'money value round-trip');
 
-      lives_ok {
-        $row->update({ amount => undef });
-      } 'updated a money value to NULL';
+        lives_ok {
+          $row->update({ amount => 200 });
+        } 'updated a money value';
 
-      is $rs->find($row->id)->amount, undef,'updated money value to NULL round-trip';
+        cmp_ok ((try { $rs->find($row->id)->amount })||0, '==', 200,
+          'updated money value round-trip');
+
+        lives_ok {
+          $row->update({ amount => undef });
+        } 'updated a money value to NULL';
+
+        is try { $rs->find($row->id)->amount }, undef,
+          'updated money value to NULL round-trip';
+      }
     }
   }
 }
@@ -555,5 +674,6 @@ END {
     eval { $dbh->do("DROP TABLE $_") }
       for qw/artist artist_guid money_test books owners/;
   }
+  undef $schema;
 }
 # vim:sw=2 sts=2