Some test fixes and TODOs for older Oracle versions

[dbsrgits/DBIx-Class.git] / t / 73oracle.t

diff --git a/t/73oracle.t b/t/73oracle.t
index 8bab7af..84847ae 100644 (file)
--- a/t/73oracle.t
+++ b/t/73oracle.t
@@ -73,10 +73,7 @@ my $v = do {
   sprintf('%d.%03d', $1, $2);
 };
 
-# while 8i (8.1) does not document support for ansi joins, and the the drivers do not use
-# them because performance sucks, there is strong evidence they are in fact supported
-# means we can test 'em :)
-my $test_server_supports_only_orajoins = $v < 8.001;
+my $test_server_supports_only_orajoins = $v < 9;
 
 # TODO find out which version supports the RETURNING syntax
 # 8i (8.1) has it and earlier docs are a 404 on oracle.com
@@ -89,8 +86,8 @@ is (
 );
 
 ##########
-# recyclebin sometimes comes in the way
-my $on_connect_sql = ["ALTER SESSION SET recyclebin = OFF"];
+# the recyclebin (new for 10g) sometimes comes in the way
+my $on_connect_sql = $v >= 10 ? ["ALTER SESSION SET recyclebin = OFF"] : [];
 
 # iterate all tests on following options
 my @tryopt = (