use strict;
use warnings;
+# Do the override as early as possible so that CORE::bless doesn't get compiled away
+# We will replace $bless_override only if we are in author mode
+my $bless_override;
+BEGIN {
+ $bless_override = sub {
+ CORE::bless( $_[0], (@_ > 1) ? $_[1] : caller() );
+ };
+ *CORE::GLOBAL::bless = sub { goto $bless_override };
+}
+
use Test::More;
-use Scalar::Util qw/refaddr reftype weaken/;
-use Carp qw/longmess/;
-use Try::Tiny;
use lib qw(t/lib);
use DBICTest::RunMode;
+BEGIN {
+ plan skip_all => "Your perl version $] appears to leak like a sieve - skipping test"
+ if DBICTest::RunMode->peepeeness;
+}
+
+use Scalar::Util qw/refaddr reftype weaken/;
+use Carp qw/longmess/;
+use Try::Tiny;
my $have_test_cycle;
BEGIN {
and import Test::Memory::Cycle;
}
-# preload stuff so that we don't trap globals
-use DBI;
-use Errno;
-use Class::Struct;
-use DBD::SQLite;
-use FileHandle;
-
# this is what holds all weakened refs to be checked for leakage
my $weak_registry = {};
# Skip the heavy-duty leak tracing when just doing an install
unless (DBICTest::RunMode->is_plain) {
+
+ # Some modules are known to install singletons on-load
+ # Load them before we swap out $bless_override
+ require DBI;
+ require DBD::SQLite;
+ require Errno;
+ require Class::Struct;
+ require FileHandle;
+ require Hash::Merge;
+
no warnings qw/redefine once/;
no strict qw/refs/;
- # override bless so that we can catch each and every object created
- *CORE::GLOBAL::bless = sub {
+ # redefine the bless override so that we can catch each and every object created
+ $bless_override = sub {
+
my $obj = CORE::bless(
$_[0], (@_ > 1) ? $_[1] : do {
my ($class, $fn, $line) = caller();
ok ($storage->connected, 'we are connected');
- my $row_obj = $rs->next;
+ my $row_obj = $rs->search({}, { rows => 1})->next; # so that commits/rollbacks work
ok ($row_obj, 'row from db');
+ # txn_do to invoke more codepaths
my ($mc_row_obj, $pager, $pager_explicit_count) = $schema->txn_do (sub {
my $artist = $rs->create ({
# based on 66 per 10 pages
is ($pager_explicit_count->last_page, 7, 'Correct last page');
+ # do some population (invokes some extra codepaths)
+ # also exercise the guard code and the manual txn control
+ {
+ my $guard = $schema->txn_scope_guard;
+ # populate with bindvars
+ $rs->populate([{ name => 'James Bound' }]);
+ $guard->commit;
+
+ $schema->txn_begin;
+ # populate mixed
+ $rs->populate([{ name => 'James Rebound', rank => \ '11' }]);
+ $schema->txn_commit;
+
+ $schema->txn_begin;
+ # and without bindvars
+ $rs->populate([{ name => \ '"James Unbound"' }]);
+ $schema->txn_rollback;
+ }
+
my $base_collection = {
schema => $schema,
storage => $storage,
resultset => $rs,
+
+ # twice so that we make sure only one H::M object spawned
+ chained_resultset => $rs->search_rs ({}, { '+columns' => [ 'foo' ] } ),
+ chained_resultset2 => $rs->search_rs ({}, { '+columns' => [ 'bar' ] } ),
+
row_object => $row_obj,
result_source => $rs->result_source,
memory_cycle_ok($weak_registry, 'No cycles in the weakened object collection')
if $have_test_cycle;
+# Naturally we have some exceptions
+my $cleared;
+for my $slot (keys %$weak_registry) {
+ if ($slot =~ /^\QTest::Builder/) {
+ # T::B 2.0 has result objects and other fancyness
+ delete $weak_registry->{$slot};
+ }
+ elsif ($slot =~ /^\QSQL::Translator/) {
+ # SQLT is a piece of shit, leaks all over
+ delete $weak_registry->{$slot};
+ }
+ elsif ($slot =~ /^\QHash::Merge/) {
+ # only clear one object of a specific behavior - more would indicate trouble
+ delete $weak_registry->{$slot}
+ unless $cleared->{hash_merge_singleton}{$weak_registry->{$slot}{weakref}{behavior}}++;
+ }
+ elsif ($slot =~ /^__TxnScopeGuard__FIXUP__/) {
+ die 'The $@ debacle should have been fixed by now!!!' if $] >= 5.013008;
+ delete $weak_registry->{$slot};
+ }
+}
+
+
# FIXME
# For reasons I can not yet fully understand the table() god-method (located in
# ::ResultSourceProxy::Table) attaches an actual source instance to each class
my $tb = Test::More->builder;
for my $slot (keys %$weak_registry) {
- # SQLT is a piece of shit, leaks all over
- next if $slot =~ /^SQL\:\:Translator/;
ok (! defined $weak_registry->{$slot}{weakref}, "No leaks of $slot") or do {
my $diag = '';