use warnings;
use Test::More;
use Test::Exception;
-use SQL::Abstract::Test import => ['is_same_sql_bind'];
+use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where)];
-use Data::Dumper;
use SQL::Abstract;
my @in_between_tests = (
bind => [],
test => '-between with literal sql with a literal (\"\'this\' AND \'that\'")',
},
+
+ # generate a set of invalid -between tests
+ ( map { {
+ where => { x => { -between => $_ } },
+ test => 'invalid -between args',
+ exception => qr|Operator 'BETWEEN' requires either an arrayref with two defined values or expressions, or a single literal scalarref/arrayref-ref|,
+ } } (
+ [ 1, 2, 3 ],
+ [ 1, undef, 3 ],
+ [ undef, 2, 3 ],
+ [ 1, 2, undef ],
+ [ 1, undef ],
+ [ undef, 2 ],
+ [ undef, undef ],
+ [ 1 ],
+ [ undef ],
+ [],
+ 1,
+ undef,
+ )),
{
where => {
- start0 => { -between => [ 1, 2 ] },
+ start0 => { -between => [ 1, { -upper => 2 } ] },
start1 => { -between => \["? AND ?", 1, 2] },
start2 => { -between => \"lower(x) AND upper(y)" },
start3 => { -between => [
] },
},
stmt => "WHERE (
- ( start0 BETWEEN ? AND ? )
+ ( start0 BETWEEN ? AND UPPER ? )
AND ( start1 BETWEEN ? AND ? )
AND ( start2 BETWEEN lower(x) AND upper(y) )
AND ( start3 BETWEEN lower(x) AND upper(?) )
bind => [1, 2, 1, 2, 'stuff'],
test => '-between POD test',
},
+ {
+ args => { bindtype => 'columns' },
+ where => {
+ start0 => { -between => [ 1, { -upper => 2 } ] },
+ start1 => { -between => \["? AND ?", [ start1 => 1], [start1 => 2] ] },
+ start2 => { -between => \"lower(x) AND upper(y)" },
+ start3 => { -between => [
+ \"lower(x)",
+ \["upper(?)", [ start3 => 'stuff'] ],
+ ] },
+ },
+ stmt => "WHERE (
+ ( start0 BETWEEN ? AND UPPER ? )
+ AND ( start1 BETWEEN ? AND ? )
+ AND ( start2 BETWEEN lower(x) AND upper(y) )
+ AND ( start3 BETWEEN lower(x) AND upper(?) )
+ )",
+ bind => [
+ [ start0 => 1 ],
+ [ start0 => 2 ],
+ [ start1 => 1 ],
+ [ start1 => 2 ],
+ [ start3 => 'stuff' ],
+ ],
+ test => '-between POD test',
+ },
{
parenthesis_significant => 1,
{
parenthesis_significant => 1,
where => { x => { -in => \'( 1,2,lower(y) )' } },
- stmt => "WHERE ( x IN (1, 2, lower(y) ) )",
+ stmt => "WHERE ( x IN ( 1,2,lower(y) ) )",
bind => [],
test => '-in with a literal scalarref',
},
{
parenthesis_significant => 1,
where => { x => { -in => \['( ( ?,?,lower(y) ) )', 1, 2] } },
- stmt => "WHERE ( x IN (?, ?, lower(y) ) )",
+ stmt => "WHERE ( x IN ( ?,?,lower(y) ) )", # note that outer parens are opened even though literal was requested (RIBASUSHI)
bind => [1, 2],
test => '-in with a literal arrayrefref',
},
{
parenthesis_significant => 1,
where => {
+ status => { -in => \"(SELECT status_codes\nFROM states)" },
+ },
+ # failed to open outer parens on a multi-line query in 1.61 (semifor)
+ stmt => " WHERE ( status IN ( SELECT status_codes FROM states )) ",
+ bind => [],
+ test => '-in multi-line subquery test',
+ },
+ {
+ parenthesis_significant => 1,
+ where => {
customer => { -in => \[
'SELECT cust_id FROM cust WHERE balance > ?',
2000,
bind => [2000],
test => '-in POD test',
},
+ {
+ where => { x => { -in => [ \['LOWER(?)', 'A' ], \'LOWER(b)', { -lower => 'c' } ] } },
+ stmt => " WHERE ( x IN ( LOWER(?), LOWER(b), LOWER ? ) )",
+ bind => [qw/A c/],
+ test => '-in with an array of function array refs with args',
+ },
+ {
+ exception => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { x => { -in => [ 1, undef ] } },
+ stmt => " WHERE ( x IN ( ? ) OR x IS NULL )",
+ bind => [ 1 ],
+ test => '-in with undef as an element',
+ },
+ {
+ exception => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { x => { -in => [ 1, undef, 2, 3, undef ] } },
+ stmt => " WHERE ( x IN ( ?, ?, ? ) OR x IS NULL )",
+ bind => [ 1, 2, 3 ],
+ test => '-in with multiple undef elements',
+ },
);
-plan tests => @in_between_tests*4;
-
for my $case (@in_between_tests) {
TODO: {
local $TODO = $case->{todo} if $case->{todo};
local $SQL::Abstract::Test::parenthesis_significant = $case->{parenthesis_significant};
- local $Data::Dumper::Terse = 1;
- lives_ok (sub {
+ my @w;
+ local $SIG{__WARN__} = sub { push @w, @_ };
- my @w;
- local $SIG{__WARN__} = sub { push @w, @_ };
- my $sql = SQL::Abstract->new ($case->{args} || {});
- lives_ok (sub {
- my ($stmt, @bind) = $sql->where($case->{where});
- is_same_sql_bind(
- $stmt,
- \@bind,
- $case->{stmt},
- $case->{bind},
- )
- || diag "Search term:\n" . Dumper $case->{where};
- });
- is (@w, 0, $case->{test} || 'No warnings within in-between tests')
- || diag join "\n", 'Emitted warnings:', @w;
- }, "$case->{test} doesn't die");
+ my $sql = SQL::Abstract->new ($case->{args} || {});
+
+ if ($case->{exception}) {
+ throws_ok { $sql->where($case->{where}) } $case->{exception};
+ }
+ else {
+ my ($stmt, @bind) = $sql->where($case->{where});
+ is_same_sql_bind(
+ $stmt,
+ \@bind,
+ $case->{stmt},
+ $case->{bind},
+ ) || diag_where ( $case->{where} );
+ }
+
+ is (@w, 0, $case->{test} || 'No warnings within in-between tests')
+ || diag join "\n", 'Emitted warnings:', @w;
}
}
+
+done_testing;